From cb057c2e6bf23b43df49282c0db26b663e4535f7 Mon Sep 17 00:00:00 2001 From: Chih-Hung Hsieh Date: Thu, 3 Aug 2017 15:48:25 -0700 Subject: Fix clang-tidy performance warnings in frameworks/native. * Use const reference parameter type to avoid unnecessary copy. * Use more efficient overloaded string methods. * Use const reference type for loop index variables to avoid unnecessary copy. Bug: 30407689 Bug: 30411878 Bug: 30413223 Test: build with WITH_TIDY=1 Change-Id: I75ed62e2cb9939878b8932ed512ceb7e241edd6f --- libs/gui/BufferQueueProducer.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'libs/gui/BufferQueueProducer.cpp') diff --git a/libs/gui/BufferQueueProducer.cpp b/libs/gui/BufferQueueProducer.cpp index 3424012acf..bcfa7bccd7 100644 --- a/libs/gui/BufferQueueProducer.cpp +++ b/libs/gui/BufferQueueProducer.cpp @@ -764,7 +764,7 @@ status_t BufferQueueProducer::queueBuffer(int slot, input.deflate(&requestedPresentTimestamp, &isAutoTimestamp, &dataSpace, &crop, &scalingMode, &transform, &acquireFence, &stickyTransform, &getFrameTimestamps); - Region surfaceDamage = input.getSurfaceDamage(); + const Region& surfaceDamage = input.getSurfaceDamage(); if (acquireFence == NULL) { BQ_LOGE("queueBuffer: fence is NULL"); -- cgit v1.2.3-59-g8ed1b