From caf14b26de53bf39ec2e16d2440dec3a6e32efd1 Mon Sep 17 00:00:00 2001 From: Steven Moreland Date: Mon, 27 Sep 2021 18:18:35 -0700 Subject: libbinder: RPC - better error for malformed parcel Was making it harder to debug an issue with binder_bpBinderFuzz. Bug: 200368820 Test: binder_bpBinderFuzz Change-Id: I915c04db1b00ed12385e2f6821320166c41febfa --- libs/binder/RpcState.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'libs/binder/RpcState.cpp') diff --git a/libs/binder/RpcState.cpp b/libs/binder/RpcState.cpp index df935fe9e3..1e86104392 100644 --- a/libs/binder/RpcState.cpp +++ b/libs/binder/RpcState.cpp @@ -427,12 +427,16 @@ status_t RpcState::transact(const sp& connection, const sp& binder, uint32_t code, const Parcel& data, const sp& session, Parcel* reply, uint32_t flags) { if (!data.isForRpc()) { - ALOGE("Refusing to send RPC with parcel not crafted for RPC"); + ALOGE("Refusing to send RPC with parcel not crafted for RPC call on binder %p code " + "%" PRIu32, + binder.get(), code); return BAD_TYPE; } if (data.objectsCount() != 0) { - ALOGE("Parcel at %p has attached objects but is being used in an RPC call", &data); + ALOGE("Parcel at %p has attached objects but is being used in an RPC call on binder %p " + "code %" PRIu32, + &data, binder.get(), code); return BAD_TYPE; } -- cgit v1.2.3-59-g8ed1b