From 1042306ba3bdaf4fbca2e84bf81f5cbbf2bcab3d Mon Sep 17 00:00:00 2001 From: Yifan Hong Date: Fri, 8 Oct 2021 16:26:32 -0700 Subject: binder: RpcSession::*MaxThreads -> *MaxIncomingThreads We'll add a separate number for outgoing threads Bug: 194225767 Test: pass Change-Id: I7bf178c098adc6359582792a2f1ca1248a336b9f --- libs/binder/RpcSession.cpp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) (limited to 'libs/binder/RpcSession.cpp') diff --git a/libs/binder/RpcSession.cpp b/libs/binder/RpcSession.cpp index 37f6c7ff45..486b67b62c 100644 --- a/libs/binder/RpcSession.cpp +++ b/libs/binder/RpcSession.cpp @@ -76,18 +76,18 @@ sp RpcSession::make(std::unique_ptr rpcTrans return sp::make(std::move(ctx)); } -void RpcSession::setMaxThreads(size_t threads) { +void RpcSession::setMaxIncomingThreads(size_t threads) { std::lock_guard _l(mMutex); LOG_ALWAYS_FATAL_IF(!mConnections.mOutgoing.empty() || !mConnections.mIncoming.empty(), - "Must set max threads before setting up connections, but has %zu client(s) " - "and %zu server(s)", + "Must set max incoming threads before setting up connections, but has %zu " + "client(s) and %zu server(s)", mConnections.mOutgoing.size(), mConnections.mIncoming.size()); - mMaxThreads = threads; + mMaxIncomingThreads = threads; } -size_t RpcSession::getMaxThreads() { +size_t RpcSession::getMaxIncomingThreads() { std::lock_guard _l(mMutex); - return mMaxThreads; + return mMaxIncomingThreads; } bool RpcSession::setProtocolVersion(uint32_t version) { @@ -484,7 +484,7 @@ status_t RpcSession::setupClient(const std::function RpcSession::assignIncomingConnectionToThisThread( std::unique_ptr rpcTransport) { std::lock_guard _l(mMutex); - if (mConnections.mIncoming.size() >= mMaxThreads) { + if (mConnections.mIncoming.size() >= mMaxIncomingThreads) { ALOGE("Cannot add thread to session with %zu threads (max is set to %zu)", - mConnections.mIncoming.size(), mMaxThreads); + mConnections.mIncoming.size(), mMaxIncomingThreads); return nullptr; } -- cgit v1.2.3-59-g8ed1b