From b86c866234b679fbeac4eec9a1d5e4418cac1997 Mon Sep 17 00:00:00 2001 From: Jiyong Park Date: Mon, 29 Oct 2018 23:01:57 +0900 Subject: Suppress lint warnings on google-default-arguments The lint rule google-default-arguments ensures that virtual or override methods do not have default arguments, because different default values across the hierarchy chain (e.g. Base::foo(int a=0) v.s. Derived::foo(int a=10)) can cause confusions. However, since the uses of the default arguments in libbinder don't lead to such problem, suppress the warnings. Test: WITH_TIDY=true WITH_TIDY_CHECKS=google-default-arguments m libbinder does not show any warning about google-default-arguments Change-Id: I90f6d05a9dc3232d0c63563df18a582432b83574 --- libs/binder/IPermissionController.cpp | 1 + 1 file changed, 1 insertion(+) (limited to 'libs/binder/IPermissionController.cpp') diff --git a/libs/binder/IPermissionController.cpp b/libs/binder/IPermissionController.cpp index 89ebc6c1aa..6b99150edf 100644 --- a/libs/binder/IPermissionController.cpp +++ b/libs/binder/IPermissionController.cpp @@ -109,6 +109,7 @@ IMPLEMENT_META_INTERFACE(PermissionController, "android.os.IPermissionController // ---------------------------------------------------------------------- +// NOLINTNEXTLINE(google-default-arguments) status_t BnPermissionController::onTransact( uint32_t code, const Parcel& data, Parcel* reply, uint32_t flags) { -- cgit v1.2.3-59-g8ed1b