From 6511af57870adc67363664edd10fc35cf9f01128 Mon Sep 17 00:00:00 2001 From: Steven Moreland Date: Thu, 26 Sep 2019 16:05:45 -0700 Subject: Remove extraneous semicolon. Bug: N/A Test: build w/o -Wno-c++98-compat-extra-semi Change-Id: I632d6df9a03485e547a6e7f14df0f1c068066c1e --- libs/binder/IAppOpsCallback.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'libs/binder/IAppOpsCallback.cpp') diff --git a/libs/binder/IAppOpsCallback.cpp b/libs/binder/IAppOpsCallback.cpp index 4c151e7a65..0ce1dd59cf 100644 --- a/libs/binder/IAppOpsCallback.cpp +++ b/libs/binder/IAppOpsCallback.cpp @@ -66,4 +66,4 @@ status_t BnAppOpsCallback::onTransact( } } -}; // namespace android +} // namespace android -- cgit v1.2.3-59-g8ed1b From fe76013f339325b68f00f3ce4491cf0f1ef3f7e7 Mon Sep 17 00:00:00 2001 From: Alex Buynytskyy Date: Fri, 3 Apr 2020 00:38:46 -0700 Subject: Making native transactions one-way as well. Fixing crash in native callback after changing permissions. Bug: b/152633648 Test: adb shell appops set 1000 GET_USAGE_STATS deny Change-Id: Ifbc2d2d982d2dd9b0b9c0ed109f827de9bed2768 --- libs/binder/IAppOpsCallback.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'libs/binder/IAppOpsCallback.cpp') diff --git a/libs/binder/IAppOpsCallback.cpp b/libs/binder/IAppOpsCallback.cpp index 0ce1dd59cf..b9eb281870 100644 --- a/libs/binder/IAppOpsCallback.cpp +++ b/libs/binder/IAppOpsCallback.cpp @@ -39,7 +39,7 @@ public: data.writeInterfaceToken(IAppOpsCallback::getInterfaceDescriptor()); data.writeInt32(op); data.writeString16(packageName); - remote()->transact(OP_CHANGED_TRANSACTION, data, &reply); + remote()->transact(OP_CHANGED_TRANSACTION, data, &reply, IBinder::FLAG_ONEWAY); } }; @@ -58,7 +58,6 @@ status_t BnAppOpsCallback::onTransact( String16 packageName; (void)data.readString16(&packageName); opChanged(op, packageName); - reply->writeNoException(); return NO_ERROR; } break; default: -- cgit v1.2.3-59-g8ed1b