From b109db34556dce51cd1802e20d65a032f439555a Mon Sep 17 00:00:00 2001
From: Parth Sane <parthsane@google.com>
Date: Thu, 5 Dec 2024 19:43:40 +0000
Subject: Libbinder cache: ensure binder thread count is checked when removing
 static list

Test: atest binderCacheUnitTest
Flag: RELEASE_LIBBINDER_REMOVE_CACHE_STATIC_LIST
Bug: 333854840
Change-Id: I5cec4f596887125ca2f8ca0f7c6388e58e97150a
---
 libs/binder/BackendUnifiedServiceManager.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 'libs/binder/BackendUnifiedServiceManager.cpp')

diff --git a/libs/binder/BackendUnifiedServiceManager.cpp b/libs/binder/BackendUnifiedServiceManager.cpp
index 03d687a9cc..34d5a09948 100644
--- a/libs/binder/BackendUnifiedServiceManager.cpp
+++ b/libs/binder/BackendUnifiedServiceManager.cpp
@@ -132,6 +132,7 @@ bool BinderCacheWithInvalidation::isClientSideCachingEnabled(const std::string&
               serviceName.c_str());
         return false;
     }
+    if (kRemoveStaticList) return true;
     for (const char* name : kStaticCachableList) {
         if (name == serviceName) {
             return true;
@@ -175,7 +176,7 @@ Status BackendUnifiedServiceManager::updateCache(const std::string& serviceName,
                                       "isBinderAlive_false");
     }
     // If we reach here with kRemoveStaticList=true then we know service isn't lazy
-    else if (kRemoveStaticList || mCacheForGetService->isClientSideCachingEnabled(serviceName)) {
+    else if (mCacheForGetService->isClientSideCachingEnabled(serviceName)) {
         binder::ScopedTrace aidlTrace(ATRACE_TAG_AIDL,
                                       "BinderCacheWithInvalidation::updateCache successful");
         return mCacheForGetService->setItem(serviceName, binder);
-- 
cgit v1.2.3-59-g8ed1b