From f4aae9ee08c2df54cff7820958552f6974ebd8b2 Mon Sep 17 00:00:00 2001 From: Samiul Islam Date: Fri, 18 Feb 2022 16:28:46 +0000 Subject: Stop creating sdk data directories due to boot time regression For some reason, there is 180% increase in boot time due to creating of sdk data directories. Locally, I noticed that it takes ~2500ms to prepare data. If we stop preparing sdk data directories with this cl, that time drops to ~1200ms. Will revert this CL once we fix the root cause of the regression. Bug: 220095381 Test: manual Ignore-AOSP-First: Feature is being developed in internal branch Change-Id: I3b74e34344ceb161d584c98bcb816d3dff3fd392 Merged-In: I3b74e34344ceb161d584c98bcb816d3dff3fd392 (cherry picked from commit 7f732f19ed990b37e74b590b550771c1c9a2a37e) --- cmds/installd/InstalldNativeService.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'cmds/installd/InstalldNativeService.cpp') diff --git a/cmds/installd/InstalldNativeService.cpp b/cmds/installd/InstalldNativeService.cpp index 7c219449d3..dd7c3d3524 100644 --- a/cmds/installd/InstalldNativeService.cpp +++ b/cmds/installd/InstalldNativeService.cpp @@ -722,7 +722,9 @@ binder::Status InstalldNativeService::createAppDataLocked( } } - { + // TODO(b/220095381): Due to boot time regression, we have omitted call to + // createAppDirectoryForSupplementalData from here temporarily (unless it's for testing) + if (uuid_ != nullptr && strcmp(uuid_, "TEST") == 0) { auto status = createAppDirectoryForSupplementalData(uuid, packageName, userId, appId, previousAppId, seInfo, flags); if (!status.isOk()) { -- cgit v1.2.3-59-g8ed1b