From af5e968482824e5b106f32d6460616880e2da181 Mon Sep 17 00:00:00 2001 From: Shikha Malhotra Date: Fri, 1 Apr 2022 18:13:32 +0000 Subject: Check for IOCTL feature changed to not set inheritence Inheritence flags should only be set on directories and not files, setting inheritence flags on files fails and leads to not using project ids. Also refined the tests to make sure that project ids are indeed used. Bug: b/215154615 Test: atest installd/StorageHostTest Test: atest installd/installd_service_test.cpp Change-Id: I6a2e310dc459f30fb967f25fe9162fc6ecdc54bc Merged-In: Ia5baf127af5a078592d8b2db4b2f3d8c048a8692 --- cmds/installd/InstalldNativeService.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'cmds/installd/InstalldNativeService.cpp') diff --git a/cmds/installd/InstalldNativeService.cpp b/cmds/installd/InstalldNativeService.cpp index b2a6ccff79..c95ee4109d 100644 --- a/cmds/installd/InstalldNativeService.cpp +++ b/cmds/installd/InstalldNativeService.cpp @@ -3391,7 +3391,7 @@ bool check_if_ioctl_feature_is_supported() { auto temp_path = StringPrintf("%smisc/installd/ioctl_check", android_data_dir.c_str()); if (access(temp_path.c_str(), F_OK) != 0) { open(temp_path.c_str(), O_CREAT | O_TRUNC | O_RDWR | O_CLOEXEC, 0644); - result = set_quota_project_id(temp_path, 0, true) == 0; + result = set_quota_project_id(temp_path, 0, false) == 0; // delete the temp file // remove the external file remove(temp_path.c_str()); -- cgit v1.2.3-59-g8ed1b