From 323343aa0ed4bb57df078af366efea3bc62165da Mon Sep 17 00:00:00 2001 From: Kansho Nishida Date: Mon, 24 Jun 2019 22:03:07 +0900 Subject: dumpstate: close socket after accepting Close socket just after accept(), to make sure that connect() by client will get error when the socket is used by the other services. Bug: 135575100 Test: execute bugreport in parallel Change-Id: I4e8a46e41519fa97cf41dde8955cf37361c6fa99 Signed-off-by: Kansho Nishida --- cmds/dumpstate/utils.cpp | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'cmds/dumpstate/utils.cpp') diff --git a/cmds/dumpstate/utils.cpp b/cmds/dumpstate/utils.cpp index 0bb80dcfba..4cbf5776d3 100644 --- a/cmds/dumpstate/utils.cpp +++ b/cmds/dumpstate/utils.cpp @@ -733,6 +733,11 @@ int open_socket(const char *service) { struct sockaddr addr; socklen_t alen = sizeof(addr); int fd = accept(s, &addr, &alen); + + // Close socket just after accept(), to make sure that connect() by client will get error + // when the socket is used by the other services. + close(s); + if (fd < 0) { MYLOGE("accept(control socket): %s\n", strerror(errno)); return -1; -- cgit v1.2.3-59-g8ed1b