From 6921f80f26cb779d2982d2e37e14aeadbc8230b7 Mon Sep 17 00:00:00 2001 From: Vishnu Nair Date: Wed, 22 Nov 2017 09:17:23 -0800 Subject: Support dumpsys timeouts in milliseconds - add new dumpsys argument to specify timeouts in milliseconds - use milliseconds to define timeouts in dumpstate - minor dumpsys output format changes: "SERVICE '' DUMP TIMEOUT (1s) EXPIRED" -> "SERVICE '' DUMP TIMEOUT (1000ms) EXPIRED" Bug: 27429130 Test: mmm -j32 frameworks/native/cmds/dumpsys && \ mmm -j32 frameworks/native/cmds/dumpstate && \ adb sync data && adb shell /data/nativetest/dumpsys_test/dumpsys_test && \ adb shell /data/nativetest64/dumpsys_test/dumpsys_test && \ adb shell /data/nativetest/dumpstate_test/dumpstate_test && \ adb shell /data/nativetest64/dumpstate_test/dumpstate_test && \ printf "\n\n#### ALL TESTS PASSED ####\n" Change-Id: Ibc96ad030bb2c6d880b8201c9b6241fce20b284f Change-Id: I6ef2ff19787f2b6d940d56e453a1a7462a8c854a --- cmds/dumpstate/utils.cpp | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'cmds/dumpstate/utils.cpp') diff --git a/cmds/dumpstate/utils.cpp b/cmds/dumpstate/utils.cpp index 6ff0dae01c..ac48041f6d 100644 --- a/cmds/dumpstate/utils.cpp +++ b/cmds/dumpstate/utils.cpp @@ -215,10 +215,10 @@ int32_t Progress::Get() const { return progress_; } -bool Progress::Inc(int32_t delta) { +bool Progress::Inc(int32_t delta_sec) { bool changed = false; - if (delta >= 0) { - progress_ += delta; + if (delta_sec >= 0) { + progress_ += delta_sec; if (progress_ > max_) { int32_t old_max = max_; max_ = floor((float)progress_ * growth_factor_); @@ -723,9 +723,9 @@ int Dumpstate::RunCommand(const std::string& title, const std::vector& dumpsys_args, - const CommandOptions& options, long dumpsysTimeout) { - long timeout = dumpsysTimeout > 0 ? dumpsysTimeout : options.Timeout(); - std::vector dumpsys = {"/system/bin/dumpsys", "-t", std::to_string(timeout)}; + const CommandOptions& options, long dumpsysTimeoutMs) { + long timeout_ms = dumpsysTimeoutMs > 0 ? dumpsysTimeoutMs : options.TimeoutInMs(); + std::vector dumpsys = {"/system/bin/dumpsys", "-T", std::to_string(timeout_ms)}; dumpsys.insert(dumpsys.end(), dumpsys_args.begin(), dumpsys_args.end()); RunCommand(title, dumpsys, options); } @@ -1165,14 +1165,14 @@ void dump_route_tables() { } // TODO: make this function thread safe if sections are generated in parallel. -void Dumpstate::UpdateProgress(int32_t delta) { +void Dumpstate::UpdateProgress(int32_t delta_sec) { if (progress_ == nullptr) { MYLOGE("UpdateProgress: progress_ not set\n"); return; } // Always update progess so stats can be tuned... - bool max_changed = progress_->Inc(delta); + bool max_changed = progress_->Inc(delta_sec); // ...but only notifiy listeners when necessary. if (!update_progress_) return; -- cgit v1.2.3-59-g8ed1b