From e225b28df5f4215d923a94f6ec4277651666d46b Mon Sep 17 00:00:00 2001 From: John Reck Date: Fri, 24 Mar 2023 16:15:17 -0400 Subject: Validate STRIDE Bug: 261856851 Test: build & boot cf Change-Id: I8a43d4eb3cb9d9bd6899e104ab443418587e6b98 --- libs/ui/Gralloc5.cpp | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/libs/ui/Gralloc5.cpp b/libs/ui/Gralloc5.cpp index 514b45f0a5..21068394d2 100644 --- a/libs/ui/Gralloc5.cpp +++ b/libs/ui/Gralloc5.cpp @@ -352,14 +352,12 @@ status_t Gralloc5Mapper::validateBufferSize(buffer_handle_t bufferHandle, uint32 } } { - (void)stride; - // TODO(b/261856851): Add StandardMetadataType::STRIDE && enable this - // auto value = getStandardMetadata(mMapper, - // bufferHandle); if (static_cast(usage) != value) { - // ALOGW("Layer count didn't match, expected %" PRIu64 " got %" PRId64, usage, - // static_cast(value.value_or(BufferUsage::CPU_READ_NEVER))); - // return BAD_VALUE; - // } + auto value = getStandardMetadata(mMapper, bufferHandle); + if (stride != value) { + ALOGW("Stride didn't match, expected %" PRIu32 " got %" PRId32, stride, + value.value_or(-1)); + return BAD_VALUE; + } } return OK; } -- cgit v1.2.3-59-g8ed1b