From e754bff9d773a912a6485fae30f16f686dfb169e Mon Sep 17 00:00:00 2001 From: Vaibhav Devmurari Date: Thu, 23 Jan 2025 17:32:41 +0000 Subject: Flag cleanup: enable_input_filter_rust_impl Bug: 294546335 Test: manual Flag: EXEMPT cleanup Change-Id: I9dafa7965f11663f9df4ffb8f636571582c942e3 --- libs/input/input_flags.aconfig | 7 ------- services/inputflinger/InputManager.cpp | 18 ++++++------------ 2 files changed, 6 insertions(+), 19 deletions(-) diff --git a/libs/input/input_flags.aconfig b/libs/input/input_flags.aconfig index f17575d60b..72a6fdf1bb 100644 --- a/libs/input/input_flags.aconfig +++ b/libs/input/input_flags.aconfig @@ -78,13 +78,6 @@ flag { bug: "301216095" } -flag { - name: "enable_input_filter_rust_impl" - namespace: "input" - description: "Enable input filter rust implementation" - bug: "294546335" -} - flag { name: "override_key_behavior_permission_apis" is_exported: true diff --git a/services/inputflinger/InputManager.cpp b/services/inputflinger/InputManager.cpp index b155122749..7d62ed9461 100644 --- a/services/inputflinger/InputManager.cpp +++ b/services/inputflinger/InputManager.cpp @@ -41,8 +41,6 @@ namespace { const bool ENABLE_INPUT_DEVICE_USAGE_METRICS = sysprop::InputProperties::enable_input_device_usage_metrics().value_or(true); -const bool ENABLE_INPUT_FILTER_RUST = input_flags::enable_input_filter_rust_impl(); - int32_t exceptionCodeFromStatusT(status_t status) { switch (status) { case OK: @@ -134,12 +132,10 @@ InputManager::InputManager(const sp& readerPolicy, mTracingStages.emplace_back( std::make_unique("InputDispatcher", *mDispatcher)); - if (ENABLE_INPUT_FILTER_RUST) { - mInputFilter = std::make_unique(*mTracingStages.back(), *mInputFlingerRust, - inputFilterPolicy); - mTracingStages.emplace_back( - std::make_unique("InputFilter", *mInputFilter)); - } + mInputFilter = std::make_unique(*mTracingStages.back(), *mInputFlingerRust, + inputFilterPolicy); + mTracingStages.emplace_back( + std::make_unique("InputFilter", *mInputFilter)); if (ENABLE_INPUT_DEVICE_USAGE_METRICS) { mCollector = std::make_unique(*mTracingStages.back()); @@ -250,10 +246,8 @@ void InputManager::dump(std::string& dump) { mCollector->dump(dump); dump += '\n'; } - if (ENABLE_INPUT_FILTER_RUST) { - mInputFilter->dump(dump); - dump += '\n'; - } + mInputFilter->dump(dump); + dump += '\n'; mDispatcher->dump(dump); dump += '\n'; } -- cgit v1.2.3-59-g8ed1b