From 330571240ff3d44fdbecbe513309d73ba82404e6 Mon Sep 17 00:00:00 2001 From: Vishnu Nair Date: Fri, 8 Nov 2024 04:29:07 +0000 Subject: Remove dead code from LayerFE Flag: EXEMPT flag removal Bug: 351894825 Test: presubmit Change-Id: I11312e555afac83d11da0a90816abbf666e1766b --- .../CompositionEngine/include/compositionengine/LayerFE.h | 3 --- .../CompositionEngine/include/compositionengine/mock/LayerFE.h | 3 --- services/surfaceflinger/LayerFE.cpp | 6 ------ services/surfaceflinger/LayerFE.h | 3 --- 4 files changed, 15 deletions(-) diff --git a/services/surfaceflinger/CompositionEngine/include/compositionengine/LayerFE.h b/services/surfaceflinger/CompositionEngine/include/compositionengine/LayerFE.h index 4e080b356b..a5e9dded8b 100644 --- a/services/surfaceflinger/CompositionEngine/include/compositionengine/LayerFE.h +++ b/services/surfaceflinger/CompositionEngine/include/compositionengine/LayerFE.h @@ -148,9 +148,6 @@ public: virtual std::optional prepareClientComposition( ClientCompositionTargetSettings&) const = 0; - // Called after the layer is displayed to update the presentation fence - virtual void onLayerDisplayed(ftl::SharedFuture, ui::LayerStack layerStack) = 0; - // Initializes a promise for a buffer release fence and provides the future for that // fence. This should only be called when a promise has not yet been created, or // after the previous promise has already been fulfilled. Attempting to call this diff --git a/services/surfaceflinger/CompositionEngine/include/compositionengine/mock/LayerFE.h b/services/surfaceflinger/CompositionEngine/include/compositionengine/mock/LayerFE.h index 05a5d3838c..c7ff704491 100644 --- a/services/surfaceflinger/CompositionEngine/include/compositionengine/mock/LayerFE.h +++ b/services/surfaceflinger/CompositionEngine/include/compositionengine/mock/LayerFE.h @@ -50,9 +50,6 @@ public: std::optional( compositionengine::LayerFE::ClientCompositionTargetSettings&)); - MOCK_METHOD(void, onLayerDisplayed, (ftl::SharedFuture, ui::LayerStack), - (override)); - MOCK_METHOD0(createReleaseFenceFuture, ftl::Future()); MOCK_METHOD1(setReleaseFence, void(const FenceResult&)); MOCK_METHOD0(getReleaseFencePromiseStatus, LayerFE::ReleaseFencePromiseStatus()); diff --git a/services/surfaceflinger/LayerFE.cpp b/services/surfaceflinger/LayerFE.cpp index a346981ae6..231b40b0ac 100644 --- a/services/surfaceflinger/LayerFE.cpp +++ b/services/surfaceflinger/LayerFE.cpp @@ -27,7 +27,6 @@ #include "LayerFE.h" #include "SurfaceFlinger.h" #include "ui/FenceResult.h" -#include "ui/LayerStack.h" namespace android { @@ -343,11 +342,6 @@ void LayerFE::prepareShadowClientComposition(LayerFE::LayerSettings& caster, caster.shadow = state; } -void LayerFE::onLayerDisplayed(ftl::SharedFuture futureFenceResult, - ui::LayerStack layerStack) { - mCompositionResult.releaseFences.emplace_back(std::move(futureFenceResult), layerStack); -} - CompositionResult&& LayerFE::stealCompositionResult() { return std::move(mCompositionResult); } diff --git a/services/surfaceflinger/LayerFE.h b/services/surfaceflinger/LayerFE.h index 658f949640..5081e102b8 100644 --- a/services/surfaceflinger/LayerFE.h +++ b/services/surfaceflinger/LayerFE.h @@ -22,14 +22,12 @@ #include "compositionengine/LayerFE.h" #include "compositionengine/LayerFECompositionState.h" #include "renderengine/LayerSettings.h" -#include "ui/LayerStack.h" #include namespace android { struct CompositionResult { - std::vector, ui::LayerStack>> releaseFences; sp lastClientCompositionFence = nullptr; }; @@ -41,7 +39,6 @@ public: // compositionengine::LayerFE overrides const compositionengine::LayerFECompositionState* getCompositionState() const override; bool onPreComposition(bool updatingOutputGeometryThisFrame) override; - void onLayerDisplayed(ftl::SharedFuture, ui::LayerStack) override; const char* getDebugName() const override; int32_t getSequence() const override; bool hasRoundedCorners() const override; -- cgit v1.2.3-59-g8ed1b