From dbf6dd5a3b59da9127eeb68cb74369d5f31bd18b Mon Sep 17 00:00:00 2001 From: Steven Moreland Date: Tue, 19 Nov 2019 16:03:30 -0800 Subject: libbinder_ndk: clearer error on host misconfigured libbinder_ndk uses defaults libbinder_ndk_host_user in order to work on host w/o bionic. Currently, if you try to use libbinder_ndk on host without libbinder_ndk, you'll get many errors like "use of undeclared identifier". Now the first error will be: In file included from frameworks/native/libs/binder/ndk/include_ndk/android/binder_auto_utils.h:29: frameworks/native/libs/binder/ndk/include_ndk/android/binder_ibinder.h:39:2: error: Android builds must be compiled against a specific API. If this is an android platform host build, you must use libbinder_ndk_host_user. #error Android builds must be compiled against a specific API. If this is an \ Bug: N/A Test: above Change-Id: I99de02858137ed3af149694fb7224fdf88c0df26 --- libs/binder/ndk/include_ndk/android/binder_ibinder.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/libs/binder/ndk/include_ndk/android/binder_ibinder.h b/libs/binder/ndk/include_ndk/android/binder_ibinder.h index 4d5c044232..4560f222cb 100644 --- a/libs/binder/ndk/include_ndk/android/binder_ibinder.h +++ b/libs/binder/ndk/include_ndk/android/binder_ibinder.h @@ -34,6 +34,12 @@ #include __BEGIN_DECLS + +#ifndef __ANDROID_API__ +#error Android builds must be compiled against a specific API. If this is an \ + android platform host build, you must use libbinder_ndk_host_user. +#endif + #if __ANDROID_API__ >= 29 // Also see TF_* in kernel's binder.h -- cgit v1.2.3-59-g8ed1b