From 0711f3dc6b73bea26b5dbad01f208e639f4ddc79 Mon Sep 17 00:00:00 2001 From: Pawan Wagh Date: Tue, 12 Sep 2023 18:11:35 +0000 Subject: Update fuzzService to call most common transactions easily Changing transaction code path in fuzzService so that most commonly used transact code in AIDL services can be reached and coverage can be improved. Test: atest fuzz_service_test Bug: 300115015 Change-Id: Ifaef7566491e6369e21f2ca3a7724a73f9bbf002 --- libs/binder/tests/parcel_fuzzer/libbinder_driver.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libs/binder/tests/parcel_fuzzer/libbinder_driver.cpp b/libs/binder/tests/parcel_fuzzer/libbinder_driver.cpp index 93ac1162ed..38e6f32cb9 100644 --- a/libs/binder/tests/parcel_fuzzer/libbinder_driver.cpp +++ b/libs/binder/tests/parcel_fuzzer/libbinder_driver.cpp @@ -61,11 +61,11 @@ void fuzzService(const std::vector>& binders, FuzzedDataProvider&& p while (provider.remaining_bytes() > 0) { // Most of the AIDL services will have small set of transaction codes. // TODO(b/295942369) : Add remaining transact codes from IBinder.h - uint32_t code = provider.ConsumeBool() - ? provider.ConsumeIntegral() - : provider.PickValueInArray( - {provider.ConsumeIntegralInRange(0, 100), - IBinder::DUMP_TRANSACTION, IBinder::PING_TRANSACTION, + uint32_t code = provider.ConsumeBool() ? provider.ConsumeIntegral() + : provider.ConsumeBool() + ? provider.ConsumeIntegralInRange(0, 100) + : provider.PickValueInArray( + {IBinder::DUMP_TRANSACTION, IBinder::PING_TRANSACTION, IBinder::SHELL_COMMAND_TRANSACTION, IBinder::INTERFACE_TRANSACTION, IBinder::SYSPROPS_TRANSACTION, IBinder::EXTENSION_TRANSACTION, IBinder::TWEET_TRANSACTION, IBinder::LIKE_TRANSACTION}); -- cgit v1.2.3-59-g8ed1b