From c6d1ada96ded44df58332e775f38ef943f4e06dc Mon Sep 17 00:00:00 2001 From: Ted Bauer Date: Thu, 16 Jan 2025 09:10:23 -0800 Subject: Remove device-side printflags from dumpstate To report device flag values, we are using aflags list, which shows up in the bugreport under ACONFIG FLAGS DUMP. Remove to avoid redundant information. Change-Id: Ie7d1676f60cbbbf4d190c0e46da0649da35d943b Test: m Bug: 388777619 --- cmds/dumpstate/dumpstate.cpp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/cmds/dumpstate/dumpstate.cpp b/cmds/dumpstate/dumpstate.cpp index c24bee12be..ab0274a15f 100644 --- a/cmds/dumpstate/dumpstate.cpp +++ b/cmds/dumpstate/dumpstate.cpp @@ -194,7 +194,6 @@ void add_mountinfo(); #define CGROUPFS_DIR "/sys/fs/cgroup" #define SDK_EXT_INFO "/apex/com.android.sdkext/bin/derive_sdk" #define DROPBOX_DIR "/data/system/dropbox" -#define PRINT_FLAGS "/system/bin/printflags" #define UWB_LOG_DIR "/data/misc/apexdata/com.android.uwb/log" // TODO(narayan): Since this information has to be kept in sync @@ -1816,12 +1815,8 @@ Dumpstate::RunStatus Dumpstate::dumpstate() { DumpFile("PRODUCT BUILD-TIME RELEASE FLAGS", "/product/etc/build_flags.json"); DumpFile("VENDOR BUILD-TIME RELEASE FLAGS", "/vendor/etc/build_flags.json"); - RunCommand("ACONFIG FLAGS", {PRINT_FLAGS}, - CommandOptions::WithTimeout(10).Always().DropRoot().Build()); RunCommand("ACONFIG FLAGS DUMP", {AFLAGS, "list"}, CommandOptions::WithTimeout(10).Always().AsRootIfAvailable().Build()); - RunCommand("WHICH ACONFIG FLAG STORAGE", {AFLAGS, "which-backing"}, - CommandOptions::WithTimeout(10).Always().AsRootIfAvailable().Build()); RunCommand("STORAGED IO INFO", {"storaged", "-u", "-p"}); -- cgit v1.2.3-59-g8ed1b