From 9f2d531265bfe48ca034cc8c7b203b1ea0e2f99b Mon Sep 17 00:00:00 2001 From: Chih-Hung Hsieh Date: Tue, 11 Dec 2018 15:34:17 -0800 Subject: Fix cert-dcl16-c clang-tidy warnings. Bug: 120614316 Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,cert-dcl16-c Change-Id: I4c2208ae23bfaf3950b4f7146fc2349f70c5bd1f --- cmds/dumpsys/dumpsys.cpp | 2 +- libs/binder/tests/binderValueTypeTest.cpp | 4 ++-- libs/vr/libpdx_default_transport/pdx_benchmarks.cpp | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cmds/dumpsys/dumpsys.cpp b/cmds/dumpsys/dumpsys.cpp index 5412d4df7b..8fbea8a163 100644 --- a/cmds/dumpsys/dumpsys.cpp +++ b/cmds/dumpsys/dumpsys.cpp @@ -389,7 +389,7 @@ status_t Dumpsys::writeDump(int fd, const String16& serviceName, std::chrono::mi auto time_left_ms = [end]() { auto now = std::chrono::steady_clock::now(); auto diff = std::chrono::duration_cast(end - now); - return std::max(diff.count(), 0ll); + return std::max(diff.count(), 0LL); }; int rc = TEMP_FAILURE_RETRY(poll(&pfd, 1, time_left_ms())); diff --git a/libs/binder/tests/binderValueTypeTest.cpp b/libs/binder/tests/binderValueTypeTest.cpp index 15949d48c0..f8922b0784 100644 --- a/libs/binder/tests/binderValueTypeTest.cpp +++ b/libs/binder/tests/binderValueTypeTest.cpp @@ -75,13 +75,13 @@ using ::std::vector; VALUE_TYPE_TEST(bool, Boolean, true) VALUE_TYPE_TEST(int32_t, Int, 31337) -VALUE_TYPE_TEST(int64_t, Long, 13370133701337l) +VALUE_TYPE_TEST(int64_t, Long, 13370133701337L) VALUE_TYPE_TEST(double, Double, 3.14159265358979323846) VALUE_TYPE_TEST(String16, String, String16("Lovely")) VALUE_TYPE_VECTOR_TEST(bool, Boolean, true) VALUE_TYPE_VECTOR_TEST(int32_t, Int, 31337) -VALUE_TYPE_VECTOR_TEST(int64_t, Long, 13370133701337l) +VALUE_TYPE_VECTOR_TEST(int64_t, Long, 13370133701337L) VALUE_TYPE_VECTOR_TEST(double, Double, 3.14159265358979323846) VALUE_TYPE_VECTOR_TEST(String16, String, String16("Lovely")) diff --git a/libs/vr/libpdx_default_transport/pdx_benchmarks.cpp b/libs/vr/libpdx_default_transport/pdx_benchmarks.cpp index fa0adf0182..f72dabc658 100644 --- a/libs/vr/libpdx_default_transport/pdx_benchmarks.cpp +++ b/libs/vr/libpdx_default_transport/pdx_benchmarks.cpp @@ -66,7 +66,7 @@ void SetThreadName(const std::string& name) { prctl(PR_SET_NAME, reinterpret_cast(name.c_str()), 0, 0, 0); } -constexpr uint64_t kNanosPerSecond = 1000000000llu; +constexpr uint64_t kNanosPerSecond = 1000000000LLU; uint64_t GetClockNs() { timespec t; -- cgit v1.2.3-59-g8ed1b