From f43b02c408d0b6afb958c9d426480dd1b615820b Mon Sep 17 00:00:00 2001 From: Chih-Hung Hsieh Date: Thu, 20 Dec 2018 15:45:56 -0800 Subject: Fix/suppress google-explicit-constructor warnings * Add explicit to conversion constructors/operators Bug: 28341362 Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,google-explicit-constructor Change-Id: Iac8f3aa14cd04861f6bcbab56b0dfc28c9a89e53 --- include/input/Input.h | 2 +- include/input/KeyCharacterMap.h | 2 +- libs/input/tests/TestHelpers.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/input/Input.h b/include/input/Input.h index cfcafabebf..756b337bc8 100644 --- a/include/input/Input.h +++ b/include/input/Input.h @@ -661,7 +661,7 @@ private: */ class PooledInputEventFactory : public InputEventFactoryInterface { public: - PooledInputEventFactory(size_t maxPoolSize = 20); + explicit PooledInputEventFactory(size_t maxPoolSize = 20); virtual ~PooledInputEventFactory(); virtual KeyEvent* createKeyEvent(); diff --git a/include/input/KeyCharacterMap.h b/include/input/KeyCharacterMap.h index 33d2757ec8..5e542b87ec 100644 --- a/include/input/KeyCharacterMap.h +++ b/include/input/KeyCharacterMap.h @@ -196,7 +196,7 @@ private: }; struct Property { - inline Property(int32_t property = 0, int32_t metaState = 0) : + inline explicit Property(int32_t property = 0, int32_t metaState = 0) : property(property), metaState(metaState) { } int32_t property; diff --git a/libs/input/tests/TestHelpers.h b/libs/input/tests/TestHelpers.h index fe87bb95a5..343d81f917 100644 --- a/libs/input/tests/TestHelpers.h +++ b/libs/input/tests/TestHelpers.h @@ -62,7 +62,7 @@ class DelayedTask : public Thread { int mDelayMillis; public: - DelayedTask(int delayMillis) : mDelayMillis(delayMillis) { } + explicit DelayedTask(int delayMillis) : mDelayMillis(delayMillis) { } protected: virtual ~DelayedTask() { } -- cgit v1.2.3-59-g8ed1b