From 6d81393c13ba5bf816fe0ed7c39b51c9af3cb6be Mon Sep 17 00:00:00 2001 From: Steven Moreland Date: Mon, 30 Sep 2019 15:31:35 -0700 Subject: libbinder fuzzer: read flattenable Bug: 131861045 Test: binder_parcel_fuzzer (for a few minutes) Change-Id: Ic5657e0e0a4da7ab9cf6080a1912941c15c59a5c --- libs/binder/fuzzer/binder.cpp | 37 +++++++++++++++++++++++++++++++++++-- 1 file changed, 35 insertions(+), 2 deletions(-) diff --git a/libs/binder/fuzzer/binder.cpp b/libs/binder/fuzzer/binder.cpp index 1aabfe6907..f678f4c912 100644 --- a/libs/binder/fuzzer/binder.cpp +++ b/libs/binder/fuzzer/binder.cpp @@ -37,6 +37,29 @@ private: int64_t mExampleUsedData = 0; }; +struct ExampleFlattenable : public android::Flattenable { +public: + size_t getFlattenedSize() const { return sizeof(mValue); } + size_t getFdCount() const { return 0; } + status_t flatten(void*& /*buffer*/, size_t& /*size*/, int*& /*fds*/, size_t& /*count*/) const { + FUZZ_LOG() << "should not reach"; + abort(); + } + status_t unflatten(void const*& buffer, size_t& size, int const*& /*fds*/, size_t& /*count*/) { + if (size < sizeof(mValue)) { + return android::NO_MEMORY; + } + android::FlattenableUtils::read(buffer, size, mValue); + return android::OK; + } +private: + int32_t mValue = 0xFEEDBEEF; +}; + +struct ExampleLightFlattenable : public android::LightFlattenablePod { + int32_t mValue = 0; +}; + #define PARCEL_READ_WITH_STATUS(T, FUN) \ [] (const ::android::Parcel& p, uint8_t /*data*/) {\ FUZZ_LOG() << "about to read " #T " using " #FUN " with status";\ @@ -173,8 +196,18 @@ std::vector> BINDER_PARCEL_READ_FUNCTIONS { // PARCEL_READ_WITH_STATUS(std::unique_ptr>>, readUtf8VectorFromUtf16Vector), // PARCEL_READ_WITH_STATUS(std::vector, readUtf8VectorFromUtf16Vector), - // TODO: read(Flattenable) - // TODO: read(LightFlattenable) + [] (const android::Parcel& p, uint8_t /*len*/) { + FUZZ_LOG() << "about to read flattenable"; + ExampleFlattenable f; + status_t status = p.read(f); + FUZZ_LOG() << "read flattenable: " << status; + }, + [] (const android::Parcel& p, uint8_t /*len*/) { + FUZZ_LOG() << "about to read lite flattenable"; + ExampleLightFlattenable f; + status_t status = p.read(f); + FUZZ_LOG() << "read lite flattenable: " << status; + }, // TODO(b/131868573): can force read of arbitrarily sized vector // TODO: resizeOutVector -- cgit v1.2.3-59-g8ed1b