From 789fe9183633ea97dad3c7ae28c6dbe052311edc Mon Sep 17 00:00:00 2001 From: Zim Date: Fri, 1 Dec 2023 15:35:06 +0000 Subject: Remove unnecessary atrace event We have some evidence to show that the atrace_call in addEntry is causing trace fd contention which affects binder calls like createSurface(). Remove this atrace event as its cost doesn't outweigh its value. Bug: 314305938 Test: Manual Change-Id: I3d86b788656bf9dd5bc62cd78a3afbdeefd9dbff --- services/surfaceflinger/Tracing/TransactionTracing.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/services/surfaceflinger/Tracing/TransactionTracing.cpp b/services/surfaceflinger/Tracing/TransactionTracing.cpp index 9d6d87eded..ce8119eecd 100644 --- a/services/surfaceflinger/Tracing/TransactionTracing.cpp +++ b/services/surfaceflinger/Tracing/TransactionTracing.cpp @@ -16,12 +16,10 @@ #undef LOG_TAG #define LOG_TAG "TransactionTracing" -#define ATRACE_TAG ATRACE_TAG_GRAPHICS #include #include #include -#include #include "Client.h" #include "FrontEnd/LayerCreationArgs.h" @@ -230,7 +228,6 @@ void TransactionTracing::loop() { void TransactionTracing::addEntry(const std::vector& committedUpdates, const std::vector& destroyedLayers) { - ATRACE_CALL(); std::scoped_lock lock(mTraceLock); std::vector removedEntries; perfetto::protos::TransactionTraceEntry entryProto; -- cgit v1.2.3-59-g8ed1b