From 3891cbe7d54d090994616dd238249d38d7a26eb2 Mon Sep 17 00:00:00 2001 From: Ady Abraham Date: Mon, 29 Mar 2021 11:29:31 -0700 Subject: SF: unsupported getLayerGenericMetadataKeys is not an error On devices with composer < 2.4 getLayerGenericMetadataKeys is not supported, and there should not be an error logged on boot. Test: boot Bug: 181269159 Change-Id: I82d9575b8a20dcb05596e2a6df4e1a9d101a6503 --- services/surfaceflinger/DisplayHardware/HWComposer.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/services/surfaceflinger/DisplayHardware/HWComposer.cpp b/services/surfaceflinger/DisplayHardware/HWComposer.cpp index ccfaa76374..fe957c0e43 100644 --- a/services/surfaceflinger/DisplayHardware/HWComposer.cpp +++ b/services/surfaceflinger/DisplayHardware/HWComposer.cpp @@ -964,8 +964,10 @@ void HWComposer::loadLayerMetadataSupport() { std::vector supportedMetadataKeyInfo; const auto error = mComposer->getLayerGenericMetadataKeys(&supportedMetadataKeyInfo); if (error != hardware::graphics::composer::V2_4::Error::NONE) { - ALOGE("%s: %s failed: %s (%d)", __FUNCTION__, "getLayerGenericMetadataKeys", - toString(error).c_str(), static_cast(error)); + if (error != hardware::graphics::composer::V2_4::Error::UNSUPPORTED) { + ALOGE("%s: %s failed: %s (%d)", __FUNCTION__, "getLayerGenericMetadataKeys", + toString(error).c_str(), static_cast(error)); + } return; } -- cgit v1.2.3-59-g8ed1b