diff options
130 files changed, 3027 insertions, 1460 deletions
diff --git a/cmds/dumpstate/dumpstate.cpp b/cmds/dumpstate/dumpstate.cpp index 2cea28d7ac..5dad511eb5 100644 --- a/cmds/dumpstate/dumpstate.cpp +++ b/cmds/dumpstate/dumpstate.cpp @@ -1148,6 +1148,13 @@ static void dumpstate() { RunDumpsys("APP PROVIDERS", {"activity", "provider", "all"}); + printf("========================================================\n"); + printf("== Dropbox crashes\n"); + printf("========================================================\n"); + + RunDumpsys("DROPBOX SYSTEM SERVER CRASHES", {"dropbox", "-p", "system_server_crash"}); + RunDumpsys("DROPBOX SYSTEM APP CRASHES", {"dropbox", "-p", "system_app_crash"}); + // DumpModemLogs adds the modem logs if available to the bugreport. // Do this at the end to allow for sufficient time for the modem logs to be // collected. diff --git a/cmds/installd/InstalldNativeService.cpp b/cmds/installd/InstalldNativeService.cpp index c604ca0336..20b960d218 100644 --- a/cmds/installd/InstalldNativeService.cpp +++ b/cmds/installd/InstalldNativeService.cpp @@ -88,6 +88,7 @@ static constexpr int FLAG_USE_QUOTA = 1 << 12; static constexpr int FLAG_FREE_CACHE_V2 = 1 << 13; static constexpr int FLAG_FREE_CACHE_V2_DEFY_QUOTA = 1 << 14; static constexpr int FLAG_FREE_CACHE_NOOP = 1 << 15; +static constexpr int FLAG_FORCE = 1 << 16; namespace { @@ -600,6 +601,113 @@ binder::Status InstalldNativeService::destroyAppData(const std::unique_ptr<std:: return res; } +static gid_t get_cache_gid(uid_t uid) { + int32_t gid = multiuser_get_cache_gid(multiuser_get_user_id(uid), multiuser_get_app_id(uid)); + return (gid != -1) ? gid : uid; +} + +binder::Status InstalldNativeService::fixupAppData(const std::unique_ptr<std::string>& uuid, + int32_t flags) { + ENFORCE_UID(AID_SYSTEM); + CHECK_ARGUMENT_UUID(uuid); + std::lock_guard<std::recursive_mutex> lock(mLock); + + const char* uuid_ = uuid ? uuid->c_str() : nullptr; + for (auto user : get_known_users(uuid_)) { + ATRACE_BEGIN("fixup user"); + FTS* fts; + FTSENT* p; + char *argv[] = { + (char*) create_data_user_ce_path(uuid_, user).c_str(), + (char*) create_data_user_de_path(uuid_, user).c_str(), + nullptr + }; + if (!(fts = fts_open(argv, FTS_PHYSICAL | FTS_NOCHDIR | FTS_XDEV, NULL))) { + return error("Failed to fts_open"); + } + while ((p = fts_read(fts)) != nullptr) { + if (p->fts_info == FTS_D && p->fts_level == 1) { + // Track down inodes of cache directories + uint64_t raw = 0; + ino_t inode_cache = 0; + ino_t inode_code_cache = 0; + if (getxattr(p->fts_path, kXattrInodeCache, &raw, sizeof(raw)) == sizeof(raw)) { + inode_cache = raw; + } + if (getxattr(p->fts_path, kXattrInodeCodeCache, &raw, sizeof(raw)) == sizeof(raw)) { + inode_code_cache = raw; + } + + // Figure out expected GID of each child + FTSENT* child = fts_children(fts, 0); + while (child != nullptr) { + if ((child->fts_statp->st_ino == inode_cache) + || (child->fts_statp->st_ino == inode_code_cache) + || !strcmp(child->fts_name, "cache") + || !strcmp(child->fts_name, "code_cache")) { + child->fts_number = get_cache_gid(p->fts_statp->st_uid); + } else { + child->fts_number = p->fts_statp->st_uid; + } + child = child->fts_link; + } + } else if (p->fts_level >= 2) { + if (p->fts_level > 2) { + // Inherit GID from parent once we're deeper into tree + p->fts_number = p->fts_parent->fts_number; + } + + uid_t uid = p->fts_parent->fts_statp->st_uid; + gid_t cache_gid = get_cache_gid(uid); + gid_t expected = p->fts_number; + gid_t actual = p->fts_statp->st_gid; + if (actual == expected) { +#if FIXUP_DEBUG + LOG(DEBUG) << "Ignoring " << p->fts_path << " with expected GID " << expected; +#endif + if (!(flags & FLAG_FORCE)) { + fts_set(fts, p, FTS_SKIP); + } + } else if ((actual == uid) || (actual == cache_gid)) { + // Only consider fixing up when current GID belongs to app + if (p->fts_info != FTS_D) { + LOG(INFO) << "Fixing " << p->fts_path << " with unexpected GID " << actual + << " instead of " << expected; + } + switch (p->fts_info) { + case FTS_DP: + // If we're moving towards cache GID, we need to set S_ISGID + if (expected == cache_gid) { + if (chmod(p->fts_path, 02771) != 0) { + PLOG(WARNING) << "Failed to chmod " << p->fts_path; + } + } + // Intentional fall through to also set GID + case FTS_F: + if (chown(p->fts_path, -1, expected) != 0) { + PLOG(WARNING) << "Failed to chown " << p->fts_path; + } + break; + case FTS_SL: + case FTS_SLNONE: + if (lchown(p->fts_path, -1, expected) != 0) { + PLOG(WARNING) << "Failed to chown " << p->fts_path; + } + break; + } + } else { + // Ignore all other GID transitions, since they're kinda shady + LOG(WARNING) << "Ignoring " << p->fts_path << " with unexpected GID " << actual + << " instead of " << expected; + } + } + } + fts_close(fts); + ATRACE_END(); + } + return ok(); +} + binder::Status InstalldNativeService::moveCompleteApp(const std::unique_ptr<std::string>& fromUuid, const std::unique_ptr<std::string>& toUuid, const std::string& packageName, const std::string& dataAppName, int32_t appId, const std::string& seInfo, diff --git a/cmds/installd/InstalldNativeService.h b/cmds/installd/InstalldNativeService.h index 7ad86878ca..f5b7142a12 100644 --- a/cmds/installd/InstalldNativeService.h +++ b/cmds/installd/InstalldNativeService.h @@ -58,6 +58,8 @@ public: binder::Status destroyAppData(const std::unique_ptr<std::string>& uuid, const std::string& packageName, int32_t userId, int32_t flags, int64_t ceDataInode); + binder::Status fixupAppData(const std::unique_ptr<std::string>& uuid, int32_t flags); + binder::Status getAppSize(const std::unique_ptr<std::string>& uuid, const std::vector<std::string>& packageNames, int32_t userId, int32_t flags, int32_t appId, const std::vector<int64_t>& ceDataInodes, diff --git a/cmds/installd/binder/android/os/IInstalld.aidl b/cmds/installd/binder/android/os/IInstalld.aidl index 4195a0128c..03ff96e866 100644 --- a/cmds/installd/binder/android/os/IInstalld.aidl +++ b/cmds/installd/binder/android/os/IInstalld.aidl @@ -32,6 +32,8 @@ interface IInstalld { void destroyAppData(@nullable @utf8InCpp String uuid, @utf8InCpp String packageName, int userId, int flags, long ceDataInode); + void fixupAppData(@nullable @utf8InCpp String uuid, int flags); + long[] getAppSize(@nullable @utf8InCpp String uuid, in @utf8InCpp String[] packageNames, int userId, int flags, int appId, in long[] ceDataInodes, in @utf8InCpp String[] codePaths); diff --git a/cmds/installd/tests/Android.bp b/cmds/installd/tests/Android.bp index b5b080d263..630c1f3652 100644 --- a/cmds/installd/tests/Android.bp +++ b/cmds/installd/tests/Android.bp @@ -33,3 +33,22 @@ cc_test { "libdiskusage", ], } + +cc_test { + name: "installd_service_test", + clang: true, + srcs: ["installd_service_test.cpp"], + shared_libs: [ + "libbase", + "libbinder", + "libcutils", + "liblog", + "liblogwrap", + "libselinux", + "libutils", + ], + static_libs: [ + "libinstalld", + "libdiskusage", + ], +} diff --git a/cmds/installd/tests/installd_service_test.cpp b/cmds/installd/tests/installd_service_test.cpp new file mode 100644 index 0000000000..4a1f333bae --- /dev/null +++ b/cmds/installd/tests/installd_service_test.cpp @@ -0,0 +1,155 @@ +/* + * Copyright (C) 2017 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include <stdlib.h> +#include <string.h> +#include <sys/statvfs.h> +#include <sys/xattr.h> + +#include <android-base/logging.h> +#include <android-base/stringprintf.h> +#include <cutils/properties.h> +#include <gtest/gtest.h> + +#include "InstalldNativeService.h" +#include "globals.h" +#include "utils.h" + +using android::base::StringPrintf; + +namespace android { +namespace installd { + +constexpr const char* kTestUuid = "TEST"; + +static constexpr int FLAG_FORCE = 1 << 16; + +int get_property(const char *key, char *value, const char *default_value) { + return property_get(key, value, default_value); +} + +bool calculate_oat_file_path(char path[PKG_PATH_MAX] ATTRIBUTE_UNUSED, + const char *oat_dir ATTRIBUTE_UNUSED, + const char *apk_path ATTRIBUTE_UNUSED, + const char *instruction_set ATTRIBUTE_UNUSED) { + return false; +} + +bool calculate_odex_file_path(char path[PKG_PATH_MAX] ATTRIBUTE_UNUSED, + const char *apk_path ATTRIBUTE_UNUSED, + const char *instruction_set ATTRIBUTE_UNUSED) { + return false; +} + +bool create_cache_path(char path[PKG_PATH_MAX] ATTRIBUTE_UNUSED, + const char *src ATTRIBUTE_UNUSED, + const char *instruction_set ATTRIBUTE_UNUSED) { + return false; +} + +static void mkdir(const char* path, uid_t owner, gid_t group, mode_t mode) { + const char* fullPath = StringPrintf("/data/local/tmp/user/0/%s", path).c_str(); + ::mkdir(fullPath, mode); + ::chown(fullPath, owner, group); + ::chmod(fullPath, mode); +} + +static void touch(const char* path, uid_t owner, gid_t group, mode_t mode) { + int fd = ::open(StringPrintf("/data/local/tmp/user/0/%s", path).c_str(), + O_RDWR | O_CREAT, mode); + ::fchown(fd, owner, group); + ::fchmod(fd, mode); + ::close(fd); +} + +static int stat_gid(const char* path) { + struct stat buf; + ::stat(StringPrintf("/data/local/tmp/user/0/%s", path).c_str(), &buf); + return buf.st_gid; +} + +static int stat_mode(const char* path) { + struct stat buf; + ::stat(StringPrintf("/data/local/tmp/user/0/%s", path).c_str(), &buf); + return buf.st_mode & (S_IRWXU | S_IRWXG | S_IRWXO | S_ISGID); +} + +class ServiceTest : public testing::Test { +protected: + InstalldNativeService* service; + std::unique_ptr<std::string> testUuid; + + virtual void SetUp() { + setenv("ANDROID_LOG_TAGS", "*:v", 1); + android::base::InitLogging(nullptr); + + service = new InstalldNativeService(); + testUuid = std::make_unique<std::string>(); + *testUuid = std::string(kTestUuid); + system("mkdir -p /data/local/tmp/user/0"); + } + + virtual void TearDown() { + delete service; + system("rm -rf /data/local/tmp/user"); + } +}; + +TEST_F(ServiceTest, FixupAppData_Upgrade) { + LOG(INFO) << "FixupAppData_Upgrade"; + + mkdir("com.example", 10000, 10000, 0700); + mkdir("com.example/normal", 10000, 10000, 0700); + mkdir("com.example/cache", 10000, 10000, 0700); + touch("com.example/cache/file", 10000, 10000, 0700); + + service->fixupAppData(testUuid, 0); + + EXPECT_EQ(10000, stat_gid("com.example/normal")); + EXPECT_EQ(20000, stat_gid("com.example/cache")); + EXPECT_EQ(20000, stat_gid("com.example/cache/file")); + + EXPECT_EQ(0700, stat_mode("com.example/normal")); + EXPECT_EQ(02771, stat_mode("com.example/cache")); + EXPECT_EQ(0700, stat_mode("com.example/cache/file")); +} + +TEST_F(ServiceTest, FixupAppData_Moved) { + LOG(INFO) << "FixupAppData_Moved"; + + mkdir("com.example", 10000, 10000, 0700); + mkdir("com.example/foo", 10000, 10000, 0700); + touch("com.example/foo/file", 10000, 20000, 0700); + mkdir("com.example/bar", 10000, 20000, 0700); + touch("com.example/bar/file", 10000, 20000, 0700); + + service->fixupAppData(testUuid, 0); + + EXPECT_EQ(10000, stat_gid("com.example/foo")); + EXPECT_EQ(20000, stat_gid("com.example/foo/file")); + EXPECT_EQ(10000, stat_gid("com.example/bar")); + EXPECT_EQ(10000, stat_gid("com.example/bar/file")); + + service->fixupAppData(testUuid, FLAG_FORCE); + + EXPECT_EQ(10000, stat_gid("com.example/foo")); + EXPECT_EQ(10000, stat_gid("com.example/foo/file")); + EXPECT_EQ(10000, stat_gid("com.example/bar")); + EXPECT_EQ(10000, stat_gid("com.example/bar/file")); +} + +} // namespace installd +} // namespace android diff --git a/cmds/installd/utils.cpp b/cmds/installd/utils.cpp index 24c0b45f45..c7920821c6 100644 --- a/cmds/installd/utils.cpp +++ b/cmds/installd/utils.cpp @@ -1047,18 +1047,18 @@ int prepare_app_cache_dir(const std::string& parent, const char* name, mode_t ta while ((p = fts_read(fts)) != NULL) { switch (p->fts_info) { case FTS_DP: - if (chmod(p->fts_accpath, target_mode) != 0) { + if (chmod(p->fts_path, target_mode) != 0) { PLOG(WARNING) << "Failed to chmod " << p->fts_path; } // Intentional fall through to also set GID case FTS_F: - if (chown(p->fts_accpath, -1, gid) != 0) { + if (chown(p->fts_path, -1, gid) != 0) { PLOG(WARNING) << "Failed to chown " << p->fts_path; } break; case FTS_SL: case FTS_SLNONE: - if (lchown(p->fts_accpath, -1, gid) != 0) { + if (lchown(p->fts_path, -1, gid) != 0) { PLOG(WARNING) << "Failed to chown " << p->fts_path; } break; diff --git a/cmds/installd/utils.h b/cmds/installd/utils.h index 7ebfea213c..dd94da9e31 100644 --- a/cmds/installd/utils.h +++ b/cmds/installd/utils.h @@ -31,6 +31,7 @@ #include <installd_constants.h> #define MEASURE_DEBUG 0 +#define FIXUP_DEBUG 0 namespace android { namespace installd { diff --git a/cmds/servicemanager/Android.bp b/cmds/servicemanager/Android.bp index 5431233b27..68d39dbb52 100644 --- a/cmds/servicemanager/Android.bp +++ b/cmds/servicemanager/Android.bp @@ -43,6 +43,9 @@ cc_binary { "service_manager.c", "binder.c", ], + cflags: [ + "-DVENDORSERVICEMANAGER=1", + ], shared_libs: ["libcutils", "libselinux"], init_rc: ["vndservicemanager.rc"], } diff --git a/cmds/servicemanager/service_manager.c b/cmds/servicemanager/service_manager.c index 5d44e87245..45bb1d05e8 100644 --- a/cmds/servicemanager/service_manager.c +++ b/cmds/servicemanager/service_manager.c @@ -17,13 +17,12 @@ #include "binder.h" -#if 0 -#define ALOGI(x...) fprintf(stderr, "svcmgr: " x) -#define ALOGE(x...) fprintf(stderr, "svcmgr: " x) +#ifdef VENDORSERVICEMANAGER +#define LOG_TAG "VendorServiceManager" #else #define LOG_TAG "ServiceManager" -#include <log/log.h> #endif +#include <log/log.h> struct audit_data { pid_t pid; @@ -374,7 +373,14 @@ int main(int argc, char** argv) bs = binder_open(driver, 128*1024); if (!bs) { +#ifdef VENDORSERVICEMANAGER + ALOGW("failed to open binder driver %s\n", driver); + while (true) { + sleep(UINT_MAX); + } +#else ALOGE("failed to open binder driver %s\n", driver); +#endif return -1; } @@ -388,7 +394,11 @@ int main(int argc, char** argv) cb.func_log = selinux_log_callback; selinux_set_callback(SELINUX_CB_LOG, cb); +#ifdef VENDORSERVICEMANAGER + sehandle = selinux_android_vendor_service_context_handle(); +#else sehandle = selinux_android_service_context_handle(); +#endif selinux_status_open(true); if (sehandle == NULL) { diff --git a/cmds/servicemanager/servicemanager.rc b/cmds/servicemanager/servicemanager.rc index aee7bd825e..aec211abac 100644 --- a/cmds/servicemanager/servicemanager.rc +++ b/cmds/servicemanager/servicemanager.rc @@ -1,5 +1,5 @@ service servicemanager /system/bin/servicemanager - class core + class core animation user system group system readproc critical @@ -12,4 +12,3 @@ service servicemanager /system/bin/servicemanager onrestart restart drm onrestart restart cameraserver writepid /dev/cpuset/system-background/tasks - diff --git a/include/android/native_window_jni.h b/include/android/native_window_jni.h index 1ec2a67c3d..23b39aa41f 100644 --- a/include/android/native_window_jni.h +++ b/include/android/native_window_jni.h @@ -54,6 +54,17 @@ ANativeWindow* ANativeWindow_fromSurface(JNIEnv* env, jobject surface); ANativeWindow* ANativeWindow_fromSurfaceTexture(JNIEnv* env, jobject surfaceTexture); #endif +#if __ANDROID_API__ >= 26 +/** + * Return a Java Surface object derived from the ANativeWindow, for interacting + * with it through Java code. The returned Java object acquires a reference on + * the ANativeWindow; maintains it through general Java object's life cycle; + * and will automatically release the reference when the Java object gets garbage + * collected. + */ +jobject ANativeWindow_toSurface(JNIEnv* env, ANativeWindow* window); +#endif + #ifdef __cplusplus }; #endif diff --git a/include/gui/GLConsumer.h b/include/gui/GLConsumer.h index 51d76665eb..2cf6162fd8 100644 --- a/include/gui/GLConsumer.h +++ b/include/gui/GLConsumer.h @@ -23,6 +23,7 @@ #include <gui/BufferQueueDefs.h> #include <gui/ConsumerBase.h> +#include <ui/FenceTime.h> #include <ui/GraphicBuffer.h> #include <utils/String8.h> diff --git a/include/gui/IConsumerListener.h b/include/gui/IConsumerListener.h index a3c7d6496d..c0828820e3 100644 --- a/include/gui/IConsumerListener.h +++ b/include/gui/IConsumerListener.h @@ -14,103 +14,84 @@ * limitations under the License. */ -#ifndef ANDROID_GUI_ICONSUMERLISTENER_H -#define ANDROID_GUI_ICONSUMERLISTENER_H +#pragma once -#include <stdint.h> -#include <sys/types.h> +#include <binder/IInterface.h> +#include <binder/SafeInterface.h> #include <utils/Errors.h> #include <utils/RefBase.h> -#include <binder/IInterface.h> - -#include <gui/FrameTimestamps.h> +#include <cstdint> namespace android { -// ---------------------------------------------------------------------------- class BufferItem; +class FrameEventHistoryDelta; +struct NewFrameEventsEntry; -// ConsumerListener is the interface through which the BufferQueue notifies -// the consumer of events that the consumer may wish to react to. Because -// the consumer will generally have a mutex that is locked during calls from -// the consumer to the BufferQueue, these calls from the BufferQueue to the +// ConsumerListener is the interface through which the BufferQueue notifies the consumer of events +// that the consumer may wish to react to. Because the consumer will generally have a mutex that is +// locked during calls from the consumer to the BufferQueue, these calls from the BufferQueue to the // consumer *MUST* be called only when the BufferQueue mutex is NOT locked. class ConsumerListener : public virtual RefBase { public: - ConsumerListener() { } + ConsumerListener() {} virtual ~ConsumerListener(); // onDisconnect is called when a producer disconnects from the BufferQueue. virtual void onDisconnect() {} /* Asynchronous */ - // onFrameAvailable is called from queueBuffer each time an additional - // frame becomes available for consumption. This means that frames that - // are queued while in asynchronous mode only trigger the callback if no - // previous frames are pending. Frames queued while in synchronous mode - // always trigger the callback. The item passed to the callback will contain - // all of the information about the queued frame except for its - // GraphicBuffer pointer, which will always be null (except if the consumer - // is SurfaceFlinger). + // onFrameAvailable is called from queueBuffer each time an additional frame becomes available + // for consumption. This means that frames that are queued while in asynchronous mode only + // trigger the callback if no previous frames are pending. Frames queued while in synchronous + // mode always trigger the callback. The item passed to the callback will contain all of the + // information about the queued frame except for its GraphicBuffer pointer, which will always be + // null (except if the consumer is SurfaceFlinger). // - // This is called without any lock held and can be called concurrently - // by multiple threads. + // This is called without any lock held and can be called concurrently by multiple threads. virtual void onFrameAvailable(const BufferItem& item) = 0; /* Asynchronous */ - // onFrameReplaced is called from queueBuffer if the frame being queued is - // replacing an existing slot in the queue. Any call to queueBuffer that - // doesn't call onFrameAvailable will call this callback instead. The item - // passed to the callback will contain all of the information about the - // queued frame except for its GraphicBuffer pointer, which will always be - // null. + // onFrameReplaced is called from queueBuffer if the frame being queued is replacing an existing + // slot in the queue. Any call to queueBuffer that doesn't call onFrameAvailable will call this + // callback instead. The item passed to the callback will contain all of the information about + // the queued frame except for its GraphicBuffer pointer, which will always be null. // - // This is called without any lock held and can be called concurrently - // by multiple threads. + // This is called without any lock held and can be called concurrently by multiple threads. virtual void onFrameReplaced(const BufferItem& /* item */) {} /* Asynchronous */ - // onBuffersReleased is called to notify the buffer consumer that the - // BufferQueue has released its references to one or more GraphicBuffers - // contained in its slots. The buffer consumer should then call - // BufferQueue::getReleasedBuffers to retrieve the list of buffers + // onBuffersReleased is called to notify the buffer consumer that the BufferQueue has released + // its references to one or more GraphicBuffers contained in its slots. The buffer consumer + // should then call BufferQueue::getReleasedBuffers to retrieve the list of buffers. // - // This is called without any lock held and can be called concurrently - // by multiple threads. + // This is called without any lock held and can be called concurrently by multiple threads. virtual void onBuffersReleased() = 0; /* Asynchronous */ - // onSidebandStreamChanged is called to notify the buffer consumer that the - // BufferQueue's sideband buffer stream has changed. This is called when a - // stream is first attached and when it is either detached or replaced by a - // different stream. + // onSidebandStreamChanged is called to notify the buffer consumer that the BufferQueue's + // sideband buffer stream has changed. This is called when a stream is first attached and when + // it is either detached or replaced by a different stream. virtual void onSidebandStreamChanged() = 0; /* Asynchronous */ - // Notifies the consumer of any new producer-side timestamps and - // returns the combined frame history that hasn't already been retrieved. - virtual void addAndGetFrameTimestamps( - const NewFrameEventsEntry* /*newTimestamps*/, - FrameEventHistoryDelta* /*outDelta*/) {} + // Notifies the consumer of any new producer-side timestamps and returns the combined frame + // history that hasn't already been retrieved. + // + // WARNING: This method can only be called when the BufferQueue is in the consumer's process. + virtual void addAndGetFrameTimestamps(const NewFrameEventsEntry* /*newTimestamps*/, + FrameEventHistoryDelta* /*outDelta*/) {} }; - -class IConsumerListener : public ConsumerListener, public IInterface -{ +class IConsumerListener : public ConsumerListener, public IInterface { public: DECLARE_META_INTERFACE(ConsumerListener) }; -// ---------------------------------------------------------------------------- - -class BnConsumerListener : public BnInterface<IConsumerListener> -{ +class BnConsumerListener : public SafeBnInterface<IConsumerListener> { public: - virtual status_t onTransact( uint32_t code, - const Parcel& data, - Parcel* reply, - uint32_t flags = 0); -}; + BnConsumerListener() : SafeBnInterface<IConsumerListener>("BnConsumerListener") {} -// ---------------------------------------------------------------------------- -}; // namespace android + status_t onTransact(uint32_t code, const Parcel& data, Parcel* reply, + uint32_t flags = 0) override; +}; -#endif // ANDROID_GUI_ICONSUMERLISTENER_H +} // namespace android diff --git a/include/gui/ISurfaceComposerClient.h b/include/gui/ISurfaceComposerClient.h index a680bc67c4..2c613ea8c5 100644 --- a/include/gui/ISurfaceComposerClient.h +++ b/include/gui/ISurfaceComposerClient.h @@ -29,14 +29,6 @@ class ISurfaceComposerClient : public IInterface { public: DECLARE_META_INTERFACE(SurfaceComposerClient) - enum class Tag : uint32_t { - CreateSurface = IBinder::FIRST_CALL_TRANSACTION, - DestroySurface, - ClearLayerFrameStats, - GetLayerFrameStats, - Last, - }; - // flags for createSurface() enum { // (keep in sync with Surface.java) eHidden = 0x00000004, diff --git a/include/gui/Surface.h b/include/gui/Surface.h index 62f6cadece..88ef010368 100644 --- a/include/gui/Surface.h +++ b/include/gui/Surface.h @@ -257,10 +257,25 @@ public: virtual int query(int what, int* value) const; virtual int connect(int api, const sp<IProducerListener>& listener); + + // When reportBufferRemoval is true, clients must call getAndFlushRemovedBuffers to fetch + // GraphicBuffers removed from this surface after a dequeueBuffer, detachNextBuffer or + // attachBuffer call. This allows clients with their own buffer caches to free up buffers no + // longer in use by this surface. + virtual int connect( + int api, const sp<IProducerListener>& listener, + bool reportBufferRemoval); virtual int detachNextBuffer(sp<GraphicBuffer>* outBuffer, sp<Fence>* outFence); virtual int attachBuffer(ANativeWindowBuffer*); + // When client connects to Surface with reportBufferRemoval set to true, any buffers removed + // from this Surface will be collected and returned here. Once this method returns, these + // buffers will no longer be referenced by this Surface unless they are attached to this + // Surface later. The list of removed buffers will only be stored until the next dequeueBuffer, + // detachNextBuffer, or attachBuffer call. + status_t getAndFlushRemovedBuffers(std::vector<sp<GraphicBuffer>>* out); + protected: enum { NUM_BUFFER_SLOTS = BufferQueueDefs::NUM_BUFFER_SLOTS }; enum { DEFAULT_FORMAT = PIXEL_FORMAT_RGBA_8888 }; @@ -414,6 +429,9 @@ protected: // A cached copy of the FrameEventHistory maintained by the consumer. bool mEnableFrameTimestamps = false; std::unique_ptr<ProducerFrameEventHistory> mFrameEventHistory; + + bool mReportRemovedBuffers = false; + std::vector<sp<GraphicBuffer>> mRemovedBuffers; }; } // namespace android diff --git a/include/ui/GraphicBuffer.h b/include/ui/GraphicBuffer.h index 040d1e7bac..af1d8be8b3 100644 --- a/include/ui/GraphicBuffer.h +++ b/include/ui/GraphicBuffer.h @@ -72,30 +72,69 @@ public: USAGE_CURSOR = GRALLOC_USAGE_CURSOR, }; - GraphicBuffer(); + static sp<GraphicBuffer> from(ANativeWindowBuffer *); - // creates w * h buffer - GraphicBuffer(uint32_t inWidth, uint32_t inHeight, PixelFormat inFormat, - uint32_t inUsage, std::string requestorName = "<Unknown>"); - // creates w * h buffer with a layer count using gralloc1 + // Create a GraphicBuffer to be unflatten'ed into or be reallocated. + GraphicBuffer(); + + // Create a GraphicBuffer by allocating and managing a buffer internally. + // This function is privileged. See reallocate for details. GraphicBuffer(uint32_t inWidth, uint32_t inHeight, PixelFormat inFormat, uint32_t inLayerCount, uint64_t inProducerUsage, uint64_t inConsumerUsage, std::string requestorName = "<Unknown>"); - // create a buffer from an existing handle + // Create a GraphicBuffer from an existing handle. + enum HandleWrapMethod : uint8_t { + // Wrap and use the handle directly. It assumes the handle has been + // registered and never fails. The handle must have a longer lifetime + // than this wrapping GraphicBuffer. + // + // This can be used when, for example, you want to wrap a handle that + // is already managed by another GraphicBuffer. + WRAP_HANDLE, + + // Take ownership of the handle and use it directly. It assumes the + // handle has been registered and never fails. + // + // This can be used to manage an already registered handle with + // GraphicBuffer. + TAKE_HANDLE, + + // Take onwership of an unregistered handle and use it directly. It + // can fail when the buffer does not register. There is no ownership + // transfer on failures. + // + // This can be used to, for example, create a GraphicBuffer from a + // handle returned by Parcel::readNativeHandle. + TAKE_UNREGISTERED_HANDLE, + + // Make a clone of the handle and use the cloned handle. It can fail + // when cloning fails or when the buffer does not register. There is + // never ownership transfer. + // + // This can be used to create a GraphicBuffer from a handle that + // cannot be used directly, such as one from hidl_handle. + CLONE_HANDLE, + }; + GraphicBuffer(const native_handle_t* handle, HandleWrapMethod method, + uint32_t width, uint32_t height, + PixelFormat format, uint32_t layerCount, + uint64_t producerUsage, uint64_t consumerUsage, uint32_t stride); + + // These functions are deprecated because they do not distinguish producer + // and consumer usages. + GraphicBuffer(const native_handle_t* handle, HandleWrapMethod method, + uint32_t width, uint32_t height, + PixelFormat format, uint32_t layerCount, + uint32_t usage, uint32_t stride) + : GraphicBuffer(handle, method, width, height, format, layerCount, + usage, usage, stride) {} GraphicBuffer(uint32_t inWidth, uint32_t inHeight, PixelFormat inFormat, uint32_t inLayerCount, uint32_t inUsage, uint32_t inStride, native_handle_t* inHandle, bool keepOwnership); - - // create a buffer from an existing handle using gralloc1 GraphicBuffer(uint32_t inWidth, uint32_t inHeight, PixelFormat inFormat, - uint32_t inLayerCount, uint32_t inProducerUsage, - uint32_t inConsumerUsage, uint32_t inStride, - native_handle_t* inHandle, bool keepOwnership); - - // create a buffer from an existing ANativeWindowBuffer - GraphicBuffer(ANativeWindowBuffer* buffer, bool keepOwnership); + uint32_t inUsage, std::string requestorName = "<Unknown>"); // return status status_t initCheck() const; @@ -114,6 +153,9 @@ public: mGenerationNumber = generation; } + // This function is privileged. It requires access to the allocator + // device or service, which usually involves adding suitable selinux + // rules. status_t reallocate(uint32_t inWidth, uint32_t inHeight, PixelFormat inFormat, uint32_t inLayerCount, uint32_t inUsage); @@ -175,19 +217,21 @@ private: GraphicBuffer& operator = (const GraphicBuffer& rhs); const GraphicBuffer& operator = (const GraphicBuffer& rhs) const; - status_t initSize(uint32_t inWidth, uint32_t inHeight, PixelFormat inFormat, - uint32_t inLayerCount, uint64_t inProducerUsage, - uint64_t inConsumerUsage, std::string requestorName); + status_t initWithSize(uint32_t inWidth, uint32_t inHeight, + PixelFormat inFormat, uint32_t inLayerCount, + uint64_t inProducerUsage, uint64_t inConsumerUsage, + std::string requestorName); + + status_t initWithHandle(const native_handle_t* handle, + HandleWrapMethod method, uint32_t width, uint32_t height, + PixelFormat format, uint32_t layerCount, + uint64_t producerUsage, uint64_t consumerUsage, uint32_t stride); void free_handle(); GraphicBufferMapper& mBufferMapper; ssize_t mInitCheck; - // If we're wrapping another buffer then this reference will make sure it - // doesn't get freed. - sp<ANativeWindowBuffer> mWrappedBuffer; - uint64_t mId; // Stores the generation number of this buffer. If this number does not diff --git a/libs/binder/include/binder/SafeInterface.h b/libs/binder/include/binder/SafeInterface.h index 0e723c59ee..44c1352984 100644 --- a/libs/binder/include/binder/SafeInterface.h +++ b/libs/binder/include/binder/SafeInterface.h @@ -45,6 +45,16 @@ public: return callParcel("writeBool", [&]() { return parcel->writeBool(b); }); } template <typename T> + typename std::enable_if<std::is_base_of<Flattenable<T>, T>::value, status_t>::type read( + const Parcel& parcel, T* t) const { + return callParcel("read(Flattenable)", [&]() { return parcel.read(*t); }); + } + template <typename T> + typename std::enable_if<std::is_base_of<Flattenable<T>, T>::value, status_t>::type write( + Parcel* parcel, const T& t) const { + return callParcel("write(Flattenable)", [&]() { return parcel->write(t); }); + } + template <typename T> typename std::enable_if<std::is_base_of<LightFlattenable<T>, T>::value, status_t>::type read( const Parcel& parcel, T* t) const { return callParcel("read(LightFlattenable)", [&]() { return parcel.read(*t); }); diff --git a/libs/binder/tests/binderSafeInterfaceTest.cpp b/libs/binder/tests/binderSafeInterfaceTest.cpp index ac2f4d5a59..d1f63a728b 100644 --- a/libs/binder/tests/binderSafeInterfaceTest.cpp +++ b/libs/binder/tests/binderSafeInterfaceTest.cpp @@ -65,6 +65,25 @@ private: uint8_t mPadding[4] = {}; // Avoids a warning from -Wpadded }; +struct TestFlattenable : Flattenable<TestFlattenable> { + TestFlattenable() = default; + explicit TestFlattenable(int32_t v) : value(v) {} + + // Flattenable protocol + size_t getFlattenedSize() const { return sizeof(value); } + size_t getFdCount() const { return 0; } + status_t flatten(void*& buffer, size_t& size, int*& /*fds*/, size_t& /*count*/) const { + FlattenableUtils::write(buffer, size, value); + return NO_ERROR; + } + status_t unflatten(void const*& buffer, size_t& size, int const*& /*fds*/, size_t& /*count*/) { + FlattenableUtils::read(buffer, size, value); + return NO_ERROR; + } + + int32_t value = 0; +}; + struct TestLightFlattenable : LightFlattenablePod<TestLightFlattenable> { TestLightFlattenable() = default; explicit TestLightFlattenable(int32_t v) : value(v) {} @@ -142,6 +161,7 @@ public: SetDeathToken = IBinder::FIRST_CALL_TRANSACTION, ReturnsNoMemory, LogicalNot, + IncrementFlattenable, IncrementLightFlattenable, IncrementNoCopyNoMove, ToUpper, @@ -161,6 +181,7 @@ public: // These are ordered according to their corresponding methods in SafeInterface::ParcelHandler virtual status_t logicalNot(bool a, bool* notA) const = 0; + virtual status_t increment(const TestFlattenable& a, TestFlattenable* aPlusOne) const = 0; virtual status_t increment(const TestLightFlattenable& a, TestLightFlattenable* aPlusOne) const = 0; virtual status_t increment(const NoCopyNoMove& a, NoCopyNoMove* aPlusOne) const = 0; @@ -192,6 +213,12 @@ public: ALOG(LOG_INFO, getLogTag(), "%s", __PRETTY_FUNCTION__); return callRemote<decltype(&ISafeInterfaceTest::logicalNot)>(Tag::LogicalNot, a, notA); } + status_t increment(const TestFlattenable& a, TestFlattenable* aPlusOne) const override { + using Signature = + status_t (ISafeInterfaceTest::*)(const TestFlattenable&, TestFlattenable*) const; + ALOG(LOG_INFO, getLogTag(), "%s", __PRETTY_FUNCTION__); + return callRemote<Signature>(Tag::IncrementFlattenable, a, aPlusOne); + } status_t increment(const TestLightFlattenable& a, TestLightFlattenable* aPlusOne) const override { using Signature = status_t (ISafeInterfaceTest::*)(const TestLightFlattenable&, @@ -263,6 +290,11 @@ public: *notA = !a; return NO_ERROR; } + status_t increment(const TestFlattenable& a, TestFlattenable* aPlusOne) const override { + ALOG(LOG_INFO, getLogTag(), "%s", __PRETTY_FUNCTION__); + aPlusOne->value = a.value + 1; + return NO_ERROR; + } status_t increment(const TestLightFlattenable& a, TestLightFlattenable* aPlusOne) const override { ALOG(LOG_INFO, getLogTag(), "%s", __PRETTY_FUNCTION__); @@ -317,6 +349,11 @@ public: case ISafeInterfaceTest::Tag::LogicalNot: { return callLocal(data, reply, &ISafeInterfaceTest::logicalNot); } + case ISafeInterfaceTest::Tag::IncrementFlattenable: { + using Signature = status_t (ISafeInterfaceTest::*)(const TestFlattenable& a, + TestFlattenable* aPlusOne) const; + return callLocal<Signature>(data, reply, &ISafeInterfaceTest::increment); + } case ISafeInterfaceTest::Tag::IncrementLightFlattenable: { using Signature = status_t (ISafeInterfaceTest::*)(const TestLightFlattenable& a, @@ -428,6 +465,14 @@ TEST_F(SafeInterfaceTest, TestLogicalNot) { ASSERT_EQ(!b, notB); } +TEST_F(SafeInterfaceTest, TestIncrementFlattenable) { + const TestFlattenable a{1}; + TestFlattenable aPlusOne{0}; + status_t result = mSafeInterfaceTest->increment(a, &aPlusOne); + ASSERT_EQ(NO_ERROR, result); + ASSERT_EQ(a.value + 1, aPlusOne.value); +} + TEST_F(SafeInterfaceTest, TestIncrementLightFlattenable) { const TestLightFlattenable a{1}; TestLightFlattenable aPlusOne{0}; diff --git a/libs/gui/Android.bp b/libs/gui/Android.bp index 5fc6abe5b1..28c2a482c3 100644 --- a/libs/gui/Android.bp +++ b/libs/gui/Android.bp @@ -117,6 +117,7 @@ cc_library_shared { "android.hidl.token@1.0-utils", "android.hardware.graphics.bufferqueue@1.0", "android.hardware.configstore@1.0", + "android.hardware.configstore-utils", ], export_shared_lib_headers: [ @@ -125,8 +126,6 @@ cc_library_shared { "android.hidl.token@1.0-utils", "android.hardware.graphics.bufferqueue@1.0", ], - - header_libs: ["android.hardware.configstore-utils"], } subdirs = ["tests"] diff --git a/libs/gui/BufferQueueProducer.cpp b/libs/gui/BufferQueueProducer.cpp index 27ced6180b..aef231a252 100644 --- a/libs/gui/BufferQueueProducer.cpp +++ b/libs/gui/BufferQueueProducer.cpp @@ -951,7 +951,11 @@ status_t BufferQueueProducer::queueBuffer(int slot, // Call back without the main BufferQueue lock held, but with the callback // lock held so we can ensure that callbacks occur in order - { + + int connectedApi; + sp<Fence> lastQueuedFence; + + { // scope for the lock Mutex::Autolock lock(mCallbackMutex); while (callbackTicket != mCurrentCallbackTicket) { mCallbackCondition.wait(mCallbackMutex); @@ -963,20 +967,24 @@ status_t BufferQueueProducer::queueBuffer(int slot, frameReplacedListener->onFrameReplaced(item); } + connectedApi = mCore->mConnectedApi; + lastQueuedFence = std::move(mLastQueueBufferFence); + + mLastQueueBufferFence = std::move(acquireFence); + mLastQueuedCrop = item.mCrop; + mLastQueuedTransform = item.mTransform; + ++mCurrentCallbackTicket; mCallbackCondition.broadcast(); } // Wait without lock held - if (mCore->mConnectedApi == NATIVE_WINDOW_API_EGL) { + if (connectedApi == NATIVE_WINDOW_API_EGL) { // Waiting here allows for two full buffers to be queued but not a // third. In the event that frames take varying time, this makes a // small trade-off in favor of latency rather than throughput. - mLastQueueBufferFence->waitForever("Throttling EGL Production"); + lastQueuedFence->waitForever("Throttling EGL Production"); } - mLastQueueBufferFence = std::move(acquireFence); - mLastQueuedCrop = item.mCrop; - mLastQueuedTransform = item.mTransform; // Update and get FrameEventHistory. nsecs_t postedTime = systemTime(SYSTEM_TIME_MONOTONIC); diff --git a/libs/gui/IConsumerListener.cpp b/libs/gui/IConsumerListener.cpp index 8cadc4de1b..85ac304ab8 100644 --- a/libs/gui/IConsumerListener.cpp +++ b/libs/gui/IConsumerListener.cpp @@ -14,98 +14,86 @@ * limitations under the License. */ -#include <stdint.h> -#include <sys/types.h> - -#include <binder/IInterface.h> -#include <binder/Parcel.h> - #include <gui/IConsumerListener.h> + #include <gui/BufferItem.h> -// --------------------------------------------------------------------------- namespace android { -// --------------------------------------------------------------------------- -enum { +namespace { // Anonymous + +enum class Tag : uint32_t { ON_DISCONNECT = IBinder::FIRST_CALL_TRANSACTION, ON_FRAME_AVAILABLE, - ON_BUFFER_RELEASED, + ON_FRAME_REPLACED, + ON_BUFFERS_RELEASED, ON_SIDEBAND_STREAM_CHANGED, - GET_FRAME_TIMESTAMPS + LAST = ON_SIDEBAND_STREAM_CHANGED, }; -class BpConsumerListener : public BpInterface<IConsumerListener> -{ +} // Anonymous namespace + +class BpConsumerListener : public SafeBpInterface<IConsumerListener> { public: explicit BpConsumerListener(const sp<IBinder>& impl) - : BpInterface<IConsumerListener>(impl) { + : SafeBpInterface<IConsumerListener>(impl, "BpConsumerListener") {} + + ~BpConsumerListener() override; + + void onDisconnect() override { + callRemoteAsync<decltype(&IConsumerListener::onDisconnect)>(Tag::ON_DISCONNECT); } - virtual ~BpConsumerListener(); + void onFrameAvailable(const BufferItem& item) override { + callRemoteAsync<decltype(&IConsumerListener::onFrameAvailable)>(Tag::ON_FRAME_AVAILABLE, + item); + } - virtual void onDisconnect() { - Parcel data, reply; - data.writeInterfaceToken(IConsumerListener::getInterfaceDescriptor()); - remote()->transact(ON_DISCONNECT, data, &reply, IBinder::FLAG_ONEWAY); + void onFrameReplaced(const BufferItem& item) override { + callRemoteAsync<decltype(&IConsumerListener::onFrameReplaced)>(Tag::ON_FRAME_REPLACED, + item); } - virtual void onFrameAvailable(const BufferItem& item) { - Parcel data, reply; - data.writeInterfaceToken(IConsumerListener::getInterfaceDescriptor()); - data.write(item); - remote()->transact(ON_FRAME_AVAILABLE, data, &reply, IBinder::FLAG_ONEWAY); + void onBuffersReleased() override { + callRemoteAsync<decltype(&IConsumerListener::onBuffersReleased)>(Tag::ON_BUFFERS_RELEASED); } - virtual void onBuffersReleased() { - Parcel data, reply; - data.writeInterfaceToken(IConsumerListener::getInterfaceDescriptor()); - remote()->transact(ON_BUFFER_RELEASED, data, &reply, IBinder::FLAG_ONEWAY); + void onSidebandStreamChanged() override { + callRemoteAsync<decltype(&IConsumerListener::onSidebandStreamChanged)>( + Tag::ON_SIDEBAND_STREAM_CHANGED); } - virtual void onSidebandStreamChanged() { - Parcel data, reply; - data.writeInterfaceToken(IConsumerListener::getInterfaceDescriptor()); - remote()->transact(ON_SIDEBAND_STREAM_CHANGED, data, &reply, IBinder::FLAG_ONEWAY); + void addAndGetFrameTimestamps(const NewFrameEventsEntry* /*newTimestamps*/, + FrameEventHistoryDelta* /*outDelta*/) override { + LOG_ALWAYS_FATAL("IConsumerListener::addAndGetFrameTimestamps cannot be proxied"); } }; -// Out-of-line virtual method definition to trigger vtable emission in this -// translation unit (see clang warning -Wweak-vtables) -BpConsumerListener::~BpConsumerListener() {} +// Out-of-line virtual method definitions to trigger vtable emission in this translation unit (see +// clang warning -Wweak-vtables) +BpConsumerListener::~BpConsumerListener() = default; +ConsumerListener::~ConsumerListener() = default; IMPLEMENT_META_INTERFACE(ConsumerListener, "android.gui.IConsumerListener"); -// ---------------------------------------------------------------------- - -status_t BnConsumerListener::onTransact( - uint32_t code, const Parcel& data, Parcel* reply, uint32_t flags) -{ - switch(code) { - case ON_DISCONNECT: { - CHECK_INTERFACE(IConsumerListener, data, reply); - onDisconnect(); - return NO_ERROR; } - case ON_FRAME_AVAILABLE: { - CHECK_INTERFACE(IConsumerListener, data, reply); - BufferItem item; - data.read(item); - onFrameAvailable(item); - return NO_ERROR; } - case ON_BUFFER_RELEASED: { - CHECK_INTERFACE(IConsumerListener, data, reply); - onBuffersReleased(); - return NO_ERROR; } - case ON_SIDEBAND_STREAM_CHANGED: { - CHECK_INTERFACE(IConsumerListener, data, reply); - onSidebandStreamChanged(); - return NO_ERROR; } +status_t BnConsumerListener::onTransact(uint32_t code, const Parcel& data, Parcel* reply, + uint32_t flags) { + if (code < IBinder::FIRST_CALL_TRANSACTION || code > static_cast<uint32_t>(Tag::LAST)) { + return BBinder::onTransact(code, data, reply, flags); + } + auto tag = static_cast<Tag>(code); + switch (tag) { + case Tag::ON_DISCONNECT: + return callLocalAsync(data, reply, &IConsumerListener::onDisconnect); + case Tag::ON_FRAME_AVAILABLE: + return callLocalAsync(data, reply, &IConsumerListener::onFrameAvailable); + case Tag::ON_FRAME_REPLACED: + return callLocalAsync(data, reply, &IConsumerListener::onFrameReplaced); + case Tag::ON_BUFFERS_RELEASED: + return callLocalAsync(data, reply, &IConsumerListener::onBuffersReleased); + case Tag::ON_SIDEBAND_STREAM_CHANGED: + return callLocalAsync(data, reply, &IConsumerListener::onSidebandStreamChanged); } - return BBinder::onTransact(code, data, reply, flags); } -ConsumerListener::~ConsumerListener() = default; - -// --------------------------------------------------------------------------- -}; // namespace android -// --------------------------------------------------------------------------- +} // namespace android diff --git a/libs/gui/ISurfaceComposerClient.cpp b/libs/gui/ISurfaceComposerClient.cpp index 2d2146b356..679f44b57b 100644 --- a/libs/gui/ISurfaceComposerClient.cpp +++ b/libs/gui/ISurfaceComposerClient.cpp @@ -17,24 +17,28 @@ // tag as surfaceflinger #define LOG_TAG "SurfaceFlinger" -#include <stdint.h> -#include <stdio.h> -#include <sys/types.h> +#include <gui/ISurfaceComposerClient.h> + +#include <gui/IGraphicBufferProducer.h> -#include <binder/IPCThreadState.h> -#include <binder/IServiceManager.h> -#include <binder/Parcel.h> #include <binder/SafeInterface.h> #include <ui/FrameStats.h> -#include <ui/Point.h> -#include <ui/Rect.h> - -#include <gui/IGraphicBufferProducer.h> -#include <gui/ISurfaceComposerClient.h> namespace android { +namespace { // Anonymous + +enum class Tag : uint32_t { + CREATE_SURFACE = IBinder::FIRST_CALL_TRANSACTION, + DESTROY_SURFACE, + CLEAR_LAYER_FRAME_STATS, + GET_LAYER_FRAME_STATS, + LAST = GET_LAYER_FRAME_STATS, +}; + +} // Anonymous namespace + class BpSurfaceComposerClient : public SafeBpInterface<ISurfaceComposerClient> { public: explicit BpSurfaceComposerClient(const sp<IBinder>& impl) @@ -46,7 +50,7 @@ public: uint32_t flags, const sp<IBinder>& parent, uint32_t windowType, uint32_t ownerUid, sp<IBinder>* handle, sp<IGraphicBufferProducer>* gbp) override { - return callRemote<decltype(&ISurfaceComposerClient::createSurface)>(Tag::CreateSurface, + return callRemote<decltype(&ISurfaceComposerClient::createSurface)>(Tag::CREATE_SURFACE, name, width, height, format, flags, parent, windowType, ownerUid, @@ -54,18 +58,19 @@ public: } status_t destroySurface(const sp<IBinder>& handle) override { - return callRemote<decltype(&ISurfaceComposerClient::destroySurface)>(Tag::DestroySurface, + return callRemote<decltype(&ISurfaceComposerClient::destroySurface)>(Tag::DESTROY_SURFACE, handle); } status_t clearLayerFrameStats(const sp<IBinder>& handle) const override { return callRemote<decltype( - &ISurfaceComposerClient::clearLayerFrameStats)>(Tag::ClearLayerFrameStats, handle); + &ISurfaceComposerClient::clearLayerFrameStats)>(Tag::CLEAR_LAYER_FRAME_STATS, + handle); } status_t getLayerFrameStats(const sp<IBinder>& handle, FrameStats* outStats) const override { return callRemote<decltype( - &ISurfaceComposerClient::getLayerFrameStats)>(Tag::GetLayerFrameStats, handle, + &ISurfaceComposerClient::getLayerFrameStats)>(Tag::GET_LAYER_FRAME_STATS, handle, outStats); } }; @@ -80,26 +85,19 @@ IMPLEMENT_META_INTERFACE(SurfaceComposerClient, "android.ui.ISurfaceComposerClie status_t BnSurfaceComposerClient::onTransact(uint32_t code, const Parcel& data, Parcel* reply, uint32_t flags) { - if (code < IBinder::FIRST_CALL_TRANSACTION || code >= static_cast<uint32_t>(Tag::Last)) { + if (code < IBinder::FIRST_CALL_TRANSACTION || code > static_cast<uint32_t>(Tag::LAST)) { return BBinder::onTransact(code, data, reply, flags); } auto tag = static_cast<Tag>(code); switch (tag) { - case Tag::CreateSurface: { + case Tag::CREATE_SURFACE: return callLocal(data, reply, &ISurfaceComposerClient::createSurface); - } - case Tag::DestroySurface: { + case Tag::DESTROY_SURFACE: return callLocal(data, reply, &ISurfaceComposerClient::destroySurface); - } - case Tag::ClearLayerFrameStats: { + case Tag::CLEAR_LAYER_FRAME_STATS: return callLocal(data, reply, &ISurfaceComposerClient::clearLayerFrameStats); - } - case Tag::GetLayerFrameStats: { + case Tag::GET_LAYER_FRAME_STATS: return callLocal(data, reply, &ISurfaceComposerClient::getLayerFrameStats); - } - case Tag::Last: - // Should not be possible because of the check at the beginning of the method - return BBinder::onTransact(code, data, reply, flags); } } diff --git a/libs/gui/Surface.cpp b/libs/gui/Surface.cpp index 06fc31d16c..1149b8980b 100644 --- a/libs/gui/Surface.cpp +++ b/libs/gui/Surface.cpp @@ -505,7 +505,11 @@ int Surface::dequeueBuffer(android_native_buffer_t** buffer, int* fenceFd) { mFrameEventHistory->applyDelta(frameTimestamps); } - if ((result & IGraphicBufferProducer::BUFFER_NEEDS_REALLOCATION) || gbuf == 0) { + if ((result & IGraphicBufferProducer::BUFFER_NEEDS_REALLOCATION) || gbuf == nullptr) { + if (mReportRemovedBuffers && (gbuf != nullptr)) { + mRemovedBuffers.clear(); + mRemovedBuffers.push_back(gbuf); + } result = mGraphicBufferProducer->requestBuffer(buf, &gbuf); if (result != NO_ERROR) { ALOGE("dequeueBuffer: IGraphicBufferProducer::requestBuffer failed: %d", result); @@ -1075,10 +1079,16 @@ int Surface::connect(int api) { } int Surface::connect(int api, const sp<IProducerListener>& listener) { + return connect(api, listener, false); +} + +int Surface::connect( + int api, const sp<IProducerListener>& listener, bool reportBufferRemoval) { ATRACE_CALL(); ALOGV("Surface::connect"); Mutex::Autolock lock(mMutex); IGraphicBufferProducer::QueueBufferOutput output; + mReportRemovedBuffers = reportBufferRemoval; int err = mGraphicBufferProducer->connect(listener, api, mProducerControlledByApp, &output); if (err == NO_ERROR) { mDefaultWidth = output.width; @@ -1109,6 +1119,7 @@ int Surface::disconnect(int api, IGraphicBufferProducer::DisconnectMode mode) { ATRACE_CALL(); ALOGV("Surface::disconnect"); Mutex::Autolock lock(mMutex); + mRemovedBuffers.clear(); mSharedBufferSlot = BufferItem::INVALID_BUFFER_SLOT; mSharedBufferHasBeenQueued = false; freeAllBuffers(); @@ -1156,9 +1167,16 @@ int Surface::detachNextBuffer(sp<GraphicBuffer>* outBuffer, *outFence = Fence::NO_FENCE; } + if (mReportRemovedBuffers) { + mRemovedBuffers.clear(); + } + for (int i = 0; i < NUM_BUFFER_SLOTS; i++) { if (mSlots[i].buffer != NULL && mSlots[i].buffer->handle == buffer->handle) { + if (mReportRemovedBuffers) { + mRemovedBuffers.push_back(mSlots[i].buffer); + } mSlots[i].buffer = NULL; } } @@ -1184,6 +1202,10 @@ int Surface::attachBuffer(ANativeWindowBuffer* buffer) graphicBuffer->mGenerationNumber = priorGeneration; return result; } + if (mReportRemovedBuffers && (mSlots[attachedSlot].buffer != nullptr)) { + mRemovedBuffers.clear(); + mRemovedBuffers.push_back(mSlots[attachedSlot].buffer); + } mSlots[attachedSlot].buffer = graphicBuffer; return NO_ERROR; @@ -1617,4 +1639,16 @@ status_t Surface::getUniqueId(uint64_t* outId) const { return mGraphicBufferProducer->getUniqueId(outId); } +status_t Surface::getAndFlushRemovedBuffers(std::vector<sp<GraphicBuffer>>* out) { + if (out == nullptr) { + ALOGE("%s: out must not be null!", __FUNCTION__); + return BAD_VALUE; + } + + Mutex::Autolock lock(mMutex); + *out = mRemovedBuffers; + mRemovedBuffers.clear(); + return OK; +} + }; // namespace android diff --git a/libs/gui/tests/Android.bp b/libs/gui/tests/Android.bp index 3a99147a7a..192bfc8fac 100644 --- a/libs/gui/tests/Android.bp +++ b/libs/gui/tests/Android.bp @@ -27,6 +27,8 @@ cc_test { ], shared_libs: [ + "android.hardware.configstore@1.0", + "android.hardware.configstore-utils", "liblog", "libEGL", "libGLESv1_CM", @@ -34,6 +36,8 @@ cc_test { "libbinder", "libcutils", "libgui", + "libhidlbase", + "libhidltransport", "libui", "libutils", "libnativewindow" diff --git a/libs/gui/tests/CpuConsumer_test.cpp b/libs/gui/tests/CpuConsumer_test.cpp index 9c2e838b09..5848c74b8c 100644 --- a/libs/gui/tests/CpuConsumer_test.cpp +++ b/libs/gui/tests/CpuConsumer_test.cpp @@ -490,7 +490,7 @@ void produceOneFrame(const sp<ANativeWindow>& anw, ASSERT_TRUE(anb != NULL); - sp<GraphicBuffer> buf(new GraphicBuffer(anb, false)); + sp<GraphicBuffer> buf(GraphicBuffer::from(anb)); *stride = buf->getStride(); uint8_t* img = NULL; diff --git a/libs/gui/tests/FillBuffer.cpp b/libs/gui/tests/FillBuffer.cpp index 079962c8b9..ccd674fcb8 100644 --- a/libs/gui/tests/FillBuffer.cpp +++ b/libs/gui/tests/FillBuffer.cpp @@ -95,7 +95,7 @@ void produceOneRGBA8Frame(const sp<ANativeWindow>& anw) { &anb)); ASSERT_TRUE(anb != NULL); - sp<GraphicBuffer> buf(new GraphicBuffer(anb, false)); + sp<GraphicBuffer> buf(GraphicBuffer::from(anb)); uint8_t* img = NULL; ASSERT_EQ(NO_ERROR, buf->lock(GRALLOC_USAGE_SW_WRITE_OFTEN, diff --git a/libs/gui/tests/SurfaceTextureFBO_test.cpp b/libs/gui/tests/SurfaceTextureFBO_test.cpp index 0606839506..0134273a07 100644 --- a/libs/gui/tests/SurfaceTextureFBO_test.cpp +++ b/libs/gui/tests/SurfaceTextureFBO_test.cpp @@ -41,7 +41,7 @@ TEST_F(SurfaceTextureFBOTest, BlitFromCpuFilledBufferToFbo) { &anb)); ASSERT_TRUE(anb != NULL); - sp<GraphicBuffer> buf(new GraphicBuffer(anb, false)); + sp<GraphicBuffer> buf(GraphicBuffer::from(anb)); // Fill the buffer with green uint8_t* img = NULL; @@ -65,7 +65,7 @@ TEST_F(SurfaceTextureFBOTest, BlitFromCpuFilledBufferToFbo) { &anb)); ASSERT_TRUE(anb != NULL); - buf = new GraphicBuffer(anb, false); + buf = GraphicBuffer::from(anb); // Fill the buffer with red ASSERT_EQ(NO_ERROR, buf->lock(GRALLOC_USAGE_SW_WRITE_OFTEN, diff --git a/libs/gui/tests/SurfaceTextureGL_test.cpp b/libs/gui/tests/SurfaceTextureGL_test.cpp index 308bd7d69c..c6745d034d 100644 --- a/libs/gui/tests/SurfaceTextureGL_test.cpp +++ b/libs/gui/tests/SurfaceTextureGL_test.cpp @@ -42,7 +42,7 @@ TEST_F(SurfaceTextureGLTest, TexturingFromCpuFilledYV12BufferNpot) { &anb)); ASSERT_TRUE(anb != NULL); - sp<GraphicBuffer> buf(new GraphicBuffer(anb, false)); + sp<GraphicBuffer> buf(GraphicBuffer::from(anb)); // Fill the buffer with the a checkerboard pattern uint8_t* img = NULL; @@ -92,7 +92,7 @@ TEST_F(SurfaceTextureGLTest, TexturingFromCpuFilledYV12BufferPow2) { &anb)); ASSERT_TRUE(anb != NULL); - sp<GraphicBuffer> buf(new GraphicBuffer(anb, false)); + sp<GraphicBuffer> buf(GraphicBuffer::from(anb)); // Fill the buffer with the a checkerboard pattern uint8_t* img = NULL; @@ -157,7 +157,7 @@ TEST_F(SurfaceTextureGLTest, TexturingFromCpuFilledYV12BufferWithCrop) { &anb)); ASSERT_TRUE(anb != NULL); - sp<GraphicBuffer> buf(new GraphicBuffer(anb, false)); + sp<GraphicBuffer> buf(GraphicBuffer::from(anb)); uint8_t* img = NULL; buf->lock(GRALLOC_USAGE_SW_WRITE_OFTEN, (void**)(&img)); @@ -238,7 +238,7 @@ TEST_F(SurfaceTextureGLTest, TexturingFromCpuFilledYV12BuffersRepeatedly) { return false; } - sp<GraphicBuffer> buf(new GraphicBuffer(anb, false)); + sp<GraphicBuffer> buf(GraphicBuffer::from(anb)); const int yuvTexOffsetY = 0; int stride = buf->getStride(); diff --git a/libs/gui/tests/Surface_test.cpp b/libs/gui/tests/Surface_test.cpp index 3932b92674..ce114864aa 100644 --- a/libs/gui/tests/Surface_test.cpp +++ b/libs/gui/tests/Surface_test.cpp @@ -18,7 +18,9 @@ #include <gtest/gtest.h> +#include <android/hardware/configstore/1.0/ISurfaceFlingerConfigs.h> #include <binder/ProcessState.h> +#include <configstore/Utils.h> #include <cutils/properties.h> #include <gui/BufferItemConsumer.h> #include <gui/IDisplayEventConnection.h> @@ -35,6 +37,12 @@ namespace android { using namespace std::chrono_literals; +// retrieve wide-color and hdr settings from configstore +using namespace android::hardware::configstore; +using namespace android::hardware::configstore::V1_0; + +static bool hasWideColorDisplay = + getBool<ISurfaceFlingerConfigs, &ISurfaceFlingerConfigs::hasWideColorDisplay>(false); class FakeSurfaceComposer; class FakeProducerFrameEventHistory; @@ -271,17 +279,19 @@ TEST_F(SurfaceTest, GetWideColorSupport) { bool supported; surface->getWideColorSupport(&supported); - // TODO(courtneygo): How can we know what device we are on to - // verify that this is correct? - char product[PROPERTY_VALUE_MAX] = "0"; - property_get("ro.build.product", product, "0"); - std::cerr << "[ ] product = " << product << std::endl; - - if (strcmp("marlin", product) == 0 || strcmp("sailfish", product) == 0) { - ASSERT_EQ(true, supported); - } else { - ASSERT_EQ(false, supported); - } + // NOTE: This test assumes that device that supports + // wide-color (as indicated by BoardConfig) must also + // have a wide-color primary display. + // That assumption allows this test to cover devices + // that advertised a wide-color color mode without + // actually supporting wide-color to pass this test + // as well as the case of a device that does support + // wide-color (via BoardConfig) and has a wide-color + // primary display. + // NOT covered at this time is a device that supports + // wide color in the BoardConfig but does not support + // a wide-color color mode on the primary display. + ASSERT_EQ(hasWideColorDisplay, supported); } TEST_F(SurfaceTest, DynamicSetBufferCount) { diff --git a/libs/nativewindow/AHardwareBuffer.cpp b/libs/nativewindow/AHardwareBuffer.cpp index 1ed150b37b..a38b4dc61b 100644 --- a/libs/nativewindow/AHardwareBuffer.cpp +++ b/libs/nativewindow/AHardwareBuffer.cpp @@ -28,6 +28,7 @@ #include <ui/GraphicBuffer.h> #include <system/graphics.h> #include <hardware/gralloc1.h> +#include <grallocusage/GrallocUsageConversion.h> #include <private/android/AHardwareBufferHelpers.h> @@ -100,8 +101,12 @@ void AHardwareBuffer_describe(const AHardwareBuffer* buffer, outDesc->width = gbuffer->getWidth(); outDesc->height = gbuffer->getHeight(); outDesc->layers = gbuffer->getLayerCount(); + + uint64_t producerUsage = 0; + uint64_t consumerUsage = 0; + android_convertGralloc0To1Usage(gbuffer->getUsage(), &producerUsage, &consumerUsage); AHardwareBuffer_convertFromGrallocUsageBits(&outDesc->usage0, &outDesc->usage1, - gbuffer->getUsage(), gbuffer->getUsage()); + producerUsage, consumerUsage); outDesc->format = AHardwareBuffer_convertFromPixelFormat( static_cast<uint32_t>(gbuffer->getPixelFormat())); } diff --git a/libs/nativewindow/ANativeWindow.cpp b/libs/nativewindow/ANativeWindow.cpp index c0c4ac0f04..6c67cf8dc6 100644 --- a/libs/nativewindow/ANativeWindow.cpp +++ b/libs/nativewindow/ANativeWindow.cpp @@ -25,6 +25,8 @@ #include <private/android/AHardwareBufferHelpers.h> +#include <ui/GraphicBuffer.h> + using namespace android; static int32_t query(ANativeWindow* window, int what) { @@ -105,6 +107,10 @@ int32_t ANativeWindow_setBuffersTransform(ANativeWindow* window, int32_t transfo * vndk-stable **************************************************************************************************/ +AHardwareBuffer* ANativeWindowBuffer_getHardwareBuffer(ANativeWindowBuffer* anwb) { + return AHardwareBuffer_from_GraphicBuffer(static_cast<GraphicBuffer*>(anwb)); +} + int ANativeWindow_OemStorageSet(ANativeWindow* window, uint32_t slot, intptr_t value) { if (slot < 4) { window->oem[slot] = value; diff --git a/libs/nativewindow/include/vndk/window.h b/libs/nativewindow/include/vndk/window.h index 310e1e52a1..067046b8d3 100644 --- a/libs/nativewindow/include/vndk/window.h +++ b/libs/nativewindow/include/vndk/window.h @@ -99,8 +99,12 @@ typedef struct ANativeWindowBuffer typedef struct ANativeWindowBuffer ANativeWindowBuffer; -/*****************************************************************************/ +/* + * Convert this ANativeWindowBuffer into a AHardwareBuffer + */ +AHardwareBuffer* ANativeWindowBuffer_getHardwareBuffer(ANativeWindowBuffer* anwb); +/*****************************************************************************/ /* * Stores a value into one of the 4 available slots diff --git a/libs/sensor/include/sensor/SensorEventQueue.h b/libs/sensor/include/sensor/SensorEventQueue.h index a03c7eeea3..baed2ee20d 100644 --- a/libs/sensor/include/sensor/SensorEventQueue.h +++ b/libs/sensor/include/sensor/SensorEventQueue.h @@ -83,7 +83,7 @@ public: status_t disableSensor(Sensor const* sensor) const; status_t setEventRate(Sensor const* sensor, nsecs_t ns) const; - // these are here only to support SensorManager.java + // these are here only to support SensorManager.java and HIDL Frameworks SensorManager. status_t enableSensor(int32_t handle, int32_t samplingPeriodUs, int64_t maxBatchReportLatencyUs, int reservedFlags) const; status_t disableSensor(int32_t handle) const; diff --git a/libs/ui/GraphicBuffer.cpp b/libs/ui/GraphicBuffer.cpp index 6e8473018a..d21758d41e 100644 --- a/libs/ui/GraphicBuffer.cpp +++ b/libs/ui/GraphicBuffer.cpp @@ -39,6 +39,10 @@ static uint64_t getUniqueId() { return id; } +sp<GraphicBuffer> GraphicBuffer::from(ANativeWindowBuffer* anwb) { + return static_cast<GraphicBuffer *>(anwb); +} + GraphicBuffer::GraphicBuffer() : BASE(), mOwner(ownData), mBufferMapper(GraphicBufferMapper::get()), mInitCheck(NO_ERROR), mId(getUniqueId()), mGenerationNumber(0) @@ -52,86 +56,42 @@ GraphicBuffer::GraphicBuffer() handle = NULL; } +// deprecated GraphicBuffer::GraphicBuffer(uint32_t inWidth, uint32_t inHeight, PixelFormat inFormat, uint32_t inUsage, std::string requestorName) - : BASE(), mOwner(ownData), mBufferMapper(GraphicBufferMapper::get()), - mInitCheck(NO_ERROR), mId(getUniqueId()), mGenerationNumber(0) + : GraphicBuffer(inWidth, inHeight, inFormat, 1, inUsage, inUsage, + requestorName) { - width = - height = - stride = - format = - usage = 0; - layerCount = 0; - handle = NULL; - mInitCheck = initSize(inWidth, inHeight, inFormat, 1, inUsage, inUsage, - std::move(requestorName)); } GraphicBuffer::GraphicBuffer(uint32_t inWidth, uint32_t inHeight, PixelFormat inFormat, uint32_t inLayerCount, uint64_t producerUsage, uint64_t consumerUsage, std::string requestorName) - : BASE(), mOwner(ownData), mBufferMapper(GraphicBufferMapper::get()), - mInitCheck(NO_ERROR), mId(getUniqueId()), mGenerationNumber(0) + : GraphicBuffer() { - width = - height = - stride = - format = - usage = 0; - layerCount = 0; - handle = NULL; - mInitCheck = initSize(inWidth, inHeight, inFormat, inLayerCount, + mInitCheck = initWithSize(inWidth, inHeight, inFormat, inLayerCount, producerUsage, consumerUsage, std::move(requestorName)); } +// deprecated GraphicBuffer::GraphicBuffer(uint32_t inWidth, uint32_t inHeight, PixelFormat inFormat, uint32_t inLayerCount, uint32_t inUsage, uint32_t inStride, native_handle_t* inHandle, bool keepOwnership) - : BASE(), mOwner(keepOwnership ? ownHandle : ownNone), - mBufferMapper(GraphicBufferMapper::get()), - mInitCheck(NO_ERROR), mId(getUniqueId()), mGenerationNumber(0) + : GraphicBuffer(inHandle, keepOwnership ? TAKE_HANDLE : WRAP_HANDLE, + inWidth, inHeight, inFormat, inLayerCount, inUsage, inUsage, + inStride) { - width = static_cast<int>(inWidth); - height = static_cast<int>(inHeight); - stride = static_cast<int>(inStride); - format = inFormat; - layerCount = inLayerCount; - usage = static_cast<int>(inUsage); - handle = inHandle; } -GraphicBuffer::GraphicBuffer(uint32_t inWidth, uint32_t inHeight, - PixelFormat inFormat, uint32_t inLayerCount, uint32_t inProducerUsage, - uint32_t inConsumerUsage, uint32_t inStride, - native_handle_t* inHandle, bool keepOwnership) - : BASE(), mOwner(keepOwnership ? ownHandle : ownNone), - mBufferMapper(GraphicBufferMapper::get()), - mInitCheck(NO_ERROR), mId(getUniqueId()), mGenerationNumber(0) +GraphicBuffer::GraphicBuffer(const native_handle_t* handle, + HandleWrapMethod method, uint32_t width, uint32_t height, + PixelFormat format, uint32_t layerCount, + uint64_t producerUsage, uint64_t consumerUsage, + uint32_t stride) + : GraphicBuffer() { - width = static_cast<int>(inWidth); - height = static_cast<int>(inHeight); - stride = static_cast<int>(inStride); - format = inFormat; - layerCount = inLayerCount; - usage = android_convertGralloc1To0Usage(inProducerUsage, inConsumerUsage); - handle = inHandle; -} - - -GraphicBuffer::GraphicBuffer(ANativeWindowBuffer* buffer, bool keepOwnership) - : BASE(), mOwner(keepOwnership ? ownHandle : ownNone), - mBufferMapper(GraphicBufferMapper::get()), - mInitCheck(NO_ERROR), mWrappedBuffer(buffer), mId(getUniqueId()), - mGenerationNumber(0) -{ - width = buffer->width; - height = buffer->height; - stride = buffer->stride; - format = buffer->format; - layerCount = buffer->layerCount; - usage = buffer->usage; - handle = buffer->handle; + mInitCheck = initWithHandle(handle, method, width, height, format, + layerCount, producerUsage, consumerUsage, stride); } GraphicBuffer::~GraphicBuffer() @@ -154,7 +114,6 @@ void GraphicBuffer::free_handle() allocator.free(handle); } handle = NULL; - mWrappedBuffer = 0; } status_t GraphicBuffer::initCheck() const { @@ -192,8 +151,8 @@ status_t GraphicBuffer::reallocate(uint32_t inWidth, uint32_t inHeight, allocator.free(handle); handle = 0; } - return initSize(inWidth, inHeight, inFormat, inLayerCount, inUsage, inUsage, - "[Reallocation]"); + return initWithSize(inWidth, inHeight, inFormat, inLayerCount, + inUsage, inUsage, "[Reallocation]"); } bool GraphicBuffer::needsReallocation(uint32_t inWidth, uint32_t inHeight, @@ -207,7 +166,7 @@ bool GraphicBuffer::needsReallocation(uint32_t inWidth, uint32_t inHeight, return false; } -status_t GraphicBuffer::initSize(uint32_t inWidth, uint32_t inHeight, +status_t GraphicBuffer::initWithSize(uint32_t inWidth, uint32_t inHeight, PixelFormat inFormat, uint32_t inLayerCount, uint64_t inProducerUsage, uint64_t inConsumerUsage, std::string requestorName) { @@ -227,6 +186,54 @@ status_t GraphicBuffer::initSize(uint32_t inWidth, uint32_t inHeight, return err; } +status_t GraphicBuffer::initWithHandle(const native_handle_t* handle, + HandleWrapMethod method, uint32_t width, uint32_t height, + PixelFormat format, uint32_t layerCount, + uint64_t producerUsage, uint64_t consumerUsage, + uint32_t stride) +{ + native_handle_t* clone = nullptr; + + if (method == CLONE_HANDLE) { + clone = native_handle_clone(handle); + if (!clone) { + return NO_MEMORY; + } + + handle = clone; + method = TAKE_UNREGISTERED_HANDLE; + } + + ANativeWindowBuffer::width = static_cast<int>(width); + ANativeWindowBuffer::height = static_cast<int>(height); + ANativeWindowBuffer::stride = static_cast<int>(stride); + ANativeWindowBuffer::format = format; + ANativeWindowBuffer::usage = + android_convertGralloc1To0Usage(producerUsage, consumerUsage); + + ANativeWindowBuffer::layerCount = layerCount; + ANativeWindowBuffer::handle = handle; + + mOwner = (method == WRAP_HANDLE) ? ownNone : ownHandle; + + if (method == TAKE_UNREGISTERED_HANDLE) { + status_t err = mBufferMapper.registerBuffer(this); + if (err != NO_ERROR) { + // clean up cloned handle + if (clone) { + native_handle_close(clone); + native_handle_delete(clone); + } + + initWithHandle(nullptr, WRAP_HANDLE, 0, 0, 0, 0, 0, 0, 0); + + return err; + } + } + + return NO_ERROR; +} + status_t GraphicBuffer::lock(uint32_t inUsage, void** vaddr) { const Rect lockBounds(width, height); diff --git a/libs/vr/libbufferhub/ion_buffer.cpp b/libs/vr/libbufferhub/ion_buffer.cpp index 3fb3f3c6ff..e5a56c1a4b 100644 --- a/libs/vr/libbufferhub/ion_buffer.cpp +++ b/libs/vr/libbufferhub/ion_buffer.cpp @@ -1,5 +1,4 @@ #include <private/dvr/ion_buffer.h> -#include <ui/GraphicBufferMapper.h> #include <log/log.h> #define ATRACE_TAG ATRACE_TAG_GRAPHICS @@ -70,10 +69,9 @@ int IonBuffer::Alloc(int width, int height, int format, int usage) { ALOGD_IF(TRACE, "IonBuffer::Alloc: width=%d height=%d format=%d usage=%d", width, height, format, usage); - GraphicBufferMapper& mapper = GraphicBufferMapper::get(); buffer_ = new GraphicBuffer(width, height, format, usage); - if (mapper.registerBuffer(buffer_.get()) != OK) { - ALOGE("IonBuffer::Aloc: Failed to register buffer"); + if (buffer_->initCheck() != OK) { + ALOGE("IonBuffer::Aloc: Failed to allocate buffer"); } return 0; } @@ -96,11 +94,10 @@ int IonBuffer::Import(buffer_handle_t handle, int width, int height, int stride, "usage=%d", handle, width, height, stride, format, usage); FreeHandle(); - GraphicBufferMapper& mapper = GraphicBufferMapper::get(); - buffer_ = new GraphicBuffer(width, height, format, 1, usage, - stride, (native_handle_t*)handle, true); - if (mapper.registerBuffer(buffer_.get()) != OK) { - ALOGE("IonBuffer::Import: Failed to register cloned buffer"); + buffer_ = new GraphicBuffer(handle, GraphicBuffer::TAKE_UNREGISTERED_HANDLE, + width, height, format, 1, usage, stride); + if (buffer_->initCheck() != OK) { + ALOGE("IonBuffer::Import: Failed to import buffer"); return -EINVAL; } return 0; diff --git a/libs/vr/libbufferhubqueue/buffer_hub_queue_core.cpp b/libs/vr/libbufferhubqueue/buffer_hub_queue_core.cpp index a108042d01..a826a6958d 100644 --- a/libs/vr/libbufferhubqueue/buffer_hub_queue_core.cpp +++ b/libs/vr/libbufferhubqueue/buffer_hub_queue_core.cpp @@ -50,27 +50,7 @@ status_t BufferHubQueueCore::AllocateBuffer(uint32_t width, uint32_t height, LOG_ALWAYS_FATAL_IF(buffer_producer == nullptr, "Failed to get buffer producer at slot: %zu", slot); - // Allocating a new buffer, |buffers_[slot]| should be in initial state. - LOG_ALWAYS_FATAL_IF(buffers_[slot].mGraphicBuffer != nullptr, - "AllocateBuffer: slot %zu is not empty.", slot); - - // Create new GraphicBuffer based on the newly created |buffer_producer|. Here - // we have to cast |buffer_handle_t| to |native_handle_t|, it's OK because - // internally, GraphicBuffer is still an |ANativeWindowBuffer| and |handle| - // is still type of |buffer_handle_t| and bears const property. - sp<GraphicBuffer> graphic_buffer(new GraphicBuffer( - buffer_producer->width(), buffer_producer->height(), - buffer_producer->format(), - 1, /* layer count */ - buffer_producer->usage(), - buffer_producer->stride(), - const_cast<native_handle_t*>(buffer_producer->buffer()->handle()), - false)); - - LOG_ALWAYS_FATAL_IF(NO_ERROR != graphic_buffer->initCheck(), - "Failed to init GraphicBuffer."); buffers_[slot].mBufferProducer = buffer_producer; - buffers_[slot].mGraphicBuffer = graphic_buffer; return NO_ERROR; } diff --git a/libs/vr/libbufferhubqueue/buffer_hub_queue_producer.cpp b/libs/vr/libbufferhubqueue/buffer_hub_queue_producer.cpp index ddf7fd2330..3fe76426fd 100644 --- a/libs/vr/libbufferhubqueue/buffer_hub_queue_producer.cpp +++ b/libs/vr/libbufferhubqueue/buffer_hub_queue_producer.cpp @@ -8,7 +8,7 @@ namespace dvr { BufferHubQueueProducer::BufferHubQueueProducer( const std::shared_ptr<BufferHubQueueCore>& core) - : core_(core), req_buffer_count_(kInvalidBufferCount) {} + : core_(core) {} status_t BufferHubQueueProducer::requestBuffer(int slot, sp<GraphicBuffer>* buf) { @@ -16,18 +16,48 @@ status_t BufferHubQueueProducer::requestBuffer(int slot, std::unique_lock<std::mutex> lock(core_->mutex_); - if (slot < 0 || slot >= req_buffer_count_) { + if (core_->connected_api_ == BufferHubQueueCore::kNoConnectedApi) { + ALOGE("requestBuffer: BufferHubQueueProducer has no connected producer"); + return NO_INIT; + } + + if (slot < 0 || slot >= max_buffer_count_) { ALOGE("requestBuffer: slot index %d out of range [0, %d)", slot, - req_buffer_count_); + max_buffer_count_); return BAD_VALUE; } else if (!core_->buffers_[slot].mBufferState.isDequeued()) { ALOGE("requestBuffer: slot %d is not owned by the producer (state = %s)", slot, core_->buffers_[slot].mBufferState.string()); return BAD_VALUE; + } else if (core_->buffers_[slot].mGraphicBuffer != nullptr) { + ALOGE("requestBuffer: slot %d is not empty.", slot); + return BAD_VALUE; + } else if (core_->buffers_[slot].mBufferProducer == nullptr) { + ALOGE("requestBuffer: slot %d is not dequeued.", slot); + return BAD_VALUE; } + const auto& buffer_producer = core_->buffers_[slot].mBufferProducer; + + // Create new GraphicBuffer based on the newly created |buffer_producer|. Here + // we have to cast |buffer_handle_t| to |native_handle_t|, it's OK because + // internally, GraphicBuffer is still an |ANativeWindowBuffer| and |handle| + // is still type of |buffer_handle_t| and bears const property. + sp<GraphicBuffer> graphic_buffer(new GraphicBuffer( + buffer_producer->width(), buffer_producer->height(), + buffer_producer->format(), + 1, /* layer count */ + buffer_producer->usage(), + buffer_producer->stride(), + const_cast<native_handle_t*>(buffer_producer->buffer()->handle()), + false)); + + LOG_ALWAYS_FATAL_IF(NO_ERROR != graphic_buffer->initCheck(), + "Failed to init GraphicBuffer."); + core_->buffers_[slot].mGraphicBuffer = graphic_buffer; core_->buffers_[slot].mRequestBufferCalled = true; - *buf = core_->buffers_[slot].mGraphicBuffer; + + *buf = graphic_buffer; return NO_ERROR; } @@ -46,30 +76,68 @@ status_t BufferHubQueueProducer::setMaxDequeuedBufferCount( return BAD_VALUE; } - req_buffer_count_ = max_dequeued_buffers; + // The new dequeued_buffers count should not be violated by the number + // of currently dequeued buffers. + int dequeued_count = 0; + for (const auto& buf : core_->buffers_) { + if (buf.mBufferState.isDequeued()) { + dequeued_count++; + } + } + if (dequeued_count > max_dequeued_buffers) { + ALOGE( + "setMaxDequeuedBufferCount: the requested dequeued_buffers" + "count (%d) exceeds the current dequeued buffer count (%d)", + max_dequeued_buffers, dequeued_count); + return BAD_VALUE; + } + + max_dequeued_buffer_count_ = max_dequeued_buffers; return NO_ERROR; } -status_t BufferHubQueueProducer::setAsyncMode(bool /* async */) { - ALOGE("BufferHubQueueProducer::setAsyncMode not implemented."); - return INVALID_OPERATION; +status_t BufferHubQueueProducer::setAsyncMode(bool async) { + if (async) { + // TODO(b/36724099) BufferHubQueue's consumer end always acquires the buffer + // automatically and behaves differently from IGraphicBufferConsumer. Thus, + // android::BufferQueue's async mode (a.k.a. allocating an additional buffer + // to prevent dequeueBuffer from being blocking) technically does not apply + // here. + // + // In Daydream, non-blocking producer side dequeue is guaranteed by careful + // buffer consumer implementations. In another word, BufferHubQueue based + // dequeueBuffer should never block whether setAsyncMode(true) is set or + // not. + // + // See: IGraphicBufferProducer::setAsyncMode and + // BufferQueueProducer::setAsyncMode for more about original implementation. + ALOGW( + "BufferHubQueueProducer::setAsyncMode: BufferHubQueue should always be " + "asynchronous. This call makes no effact."); + return NO_ERROR; + } + return NO_ERROR; } -status_t BufferHubQueueProducer::dequeueBuffer(int* out_slot, - sp<Fence>* out_fence, - uint32_t width, uint32_t height, - PixelFormat format, - uint32_t usage, - FrameEventHistoryDelta* /* outTimestamps */) { +status_t BufferHubQueueProducer::dequeueBuffer( + int* out_slot, sp<Fence>* out_fence, uint32_t width, uint32_t height, + PixelFormat format, uint32_t usage, + FrameEventHistoryDelta* /* out_timestamps */) { ALOGD_IF(TRACE, "dequeueBuffer: w=%u, h=%u, format=%d, usage=%u", width, height, format, usage); status_t ret; std::unique_lock<std::mutex> lock(core_->mutex_); - if (static_cast<int32_t>(core_->producer_->capacity()) < req_buffer_count_) { + if (core_->connected_api_ == BufferHubQueueCore::kNoConnectedApi) { + ALOGE("dequeueBuffer: BufferQueue has no connected producer"); + return NO_INIT; + } + + if (static_cast<int32_t>(core_->producer_->capacity()) < + max_dequeued_buffer_count_) { // Lazy allocation. When the capacity of |core_->producer_| has not reach - // |req_buffer_count_|, allocate new buffer. + // |max_dequeued_buffer_count_|, allocate new buffer. // TODO(jwcai) To save memory, the really reasonable thing to do is to go // over existing slots and find first existing one to dequeue. ret = core_->AllocateBuffer(width, height, format, usage, 1); @@ -126,8 +194,8 @@ status_t BufferHubQueueProducer::dequeueBuffer(int* out_slot, // BufferHubQueue). // TODO(jwcai) Clean this up, make mBufferState compatible with BufferHub's // model. - LOG_ALWAYS_FATAL_IF(!core_->buffers_[slot].mBufferState.isFree() && - !core_->buffers_[slot].mBufferState.isQueued(), + LOG_ALWAYS_FATAL_IF((!core_->buffers_[slot].mBufferState.isFree() && + !core_->buffers_[slot].mBufferState.isQueued()), "dequeueBuffer: slot %zu is not free or queued.", slot); core_->buffers_[slot].mBufferState.freeQueued(); @@ -170,22 +238,39 @@ status_t BufferHubQueueProducer::attachBuffer( status_t BufferHubQueueProducer::queueBuffer(int slot, const QueueBufferInput& input, - QueueBufferOutput* /* output */) { + QueueBufferOutput* output) { ALOGD_IF(TRACE, "queueBuffer: slot %d", slot); + if (output == nullptr) { + return BAD_VALUE; + } + int64_t timestamp; + int scaling_mode; sp<Fence> fence; + Rect crop(Rect::EMPTY_RECT); // TODO(jwcai) The following attributes are ignored. bool is_auto_timestamp; android_dataspace data_space; - Rect crop(Rect::EMPTY_RECT); - int scaling_mode; uint32_t transform; input.deflate(×tamp, &is_auto_timestamp, &data_space, &crop, &scaling_mode, &transform, &fence); + // Check input scaling mode is valid. + switch (scaling_mode) { + case NATIVE_WINDOW_SCALING_MODE_FREEZE: + case NATIVE_WINDOW_SCALING_MODE_SCALE_TO_WINDOW: + case NATIVE_WINDOW_SCALING_MODE_SCALE_CROP: + case NATIVE_WINDOW_SCALING_MODE_NO_SCALE_CROP: + break; + default: + ALOGE("queueBuffer: unknown scaling mode %d", scaling_mode); + return BAD_VALUE; + } + + // Check input fence is valid. if (fence == nullptr) { ALOGE("queueBuffer: fence is NULL"); return BAD_VALUE; @@ -194,25 +279,61 @@ status_t BufferHubQueueProducer::queueBuffer(int slot, status_t ret; std::unique_lock<std::mutex> lock(core_->mutex_); - if (slot < 0 || slot >= req_buffer_count_) { + if (core_->connected_api_ == BufferHubQueueCore::kNoConnectedApi) { + ALOGE("queueBuffer: BufferQueue has no connected producer"); + return NO_INIT; + } + + if (slot < 0 || slot >= max_buffer_count_) { ALOGE("queueBuffer: slot index %d out of range [0, %d)", slot, - req_buffer_count_); + max_buffer_count_); return BAD_VALUE; } else if (!core_->buffers_[slot].mBufferState.isDequeued()) { ALOGE("queueBuffer: slot %d is not owned by the producer (state = %s)", slot, core_->buffers_[slot].mBufferState.string()); return BAD_VALUE; + } else if ((!core_->buffers_[slot].mRequestBufferCalled || + core_->buffers_[slot].mGraphicBuffer == nullptr)) { + ALOGE( + "queueBuffer: slot %d is not requested (mRequestBufferCalled=%d, " + "mGraphicBuffer=%p)", + slot, core_->buffers_[slot].mRequestBufferCalled, + core_->buffers_[slot].mGraphicBuffer.get()); + return BAD_VALUE; } // Post the buffer producer with timestamp in the metadata. - auto buffer_producer = core_->buffers_[slot].mBufferProducer; + const auto& buffer_producer = core_->buffers_[slot].mBufferProducer; + + // Check input crop is not out of boundary of current buffer. + Rect buffer_rect(buffer_producer->width(), buffer_producer->height()); + Rect cropped_rect(Rect::EMPTY_RECT); + crop.intersect(buffer_rect, &cropped_rect); + if (cropped_rect != crop) { + ALOGE("queueBuffer: slot %d has out-of-boundary crop.", slot); + return BAD_VALUE; + } + LocalHandle fence_fd(fence->isValid() ? fence->dup() : -1); BufferHubQueueCore::BufferMetadata meta_data = {.timestamp = timestamp}; buffer_producer->Post(fence_fd, &meta_data, sizeof(meta_data)); core_->buffers_[slot].mBufferState.queue(); - // TODO(jwcai) check how to fill in output properly. + output->width = buffer_producer->width(); + output->height = buffer_producer->height(); + output->transformHint = 0; // default value, we don't use it yet. + + // |numPendingBuffers| counts of the number of buffers that has been enqueued + // by the producer but not yet acquired by the consumer. Due to the nature + // of BufferHubQueue design, this is hard to trace from the producer's client + // side, but it's safe to assume it's zero. + output->numPendingBuffers = 0; + + // Note that we are not setting nextFrameNumber here as it seems to be only + // used by surface flinger. See more at b/22802885, ag/791760. + output->nextFrameNumber = 0; + return NO_ERROR; } @@ -222,15 +343,20 @@ status_t BufferHubQueueProducer::cancelBuffer(int slot, std::unique_lock<std::mutex> lock(core_->mutex_); - if (slot < 0 || slot >= req_buffer_count_) { + if (core_->connected_api_ == BufferHubQueueCore::kNoConnectedApi) { + ALOGE("cancelBuffer: BufferQueue has no connected producer"); + return NO_INIT; + } + + if (slot < 0 || slot >= max_buffer_count_) { ALOGE("cancelBuffer: slot index %d out of range [0, %d)", slot, - req_buffer_count_); + max_buffer_count_); return BAD_VALUE; } else if (!core_->buffers_[slot].mBufferState.isDequeued()) { ALOGE("cancelBuffer: slot %d is not owned by the producer (state = %s)", slot, core_->buffers_[slot].mBufferState.string()); return BAD_VALUE; - } else if (fence == NULL) { + } else if (fence == nullptr) { ALOGE("cancelBuffer: fence is NULL"); return BAD_VALUE; } @@ -249,7 +375,7 @@ status_t BufferHubQueueProducer::query(int what, int* out_value) { std::unique_lock<std::mutex> lock(core_->mutex_); - if (out_value == NULL) { + if (out_value == nullptr) { ALOGE("query: out_value was NULL"); return BAD_VALUE; } @@ -262,15 +388,30 @@ status_t BufferHubQueueProducer::query(int what, int* out_value) { case NATIVE_WINDOW_BUFFER_AGE: value = 0; break; - // The following queries are currently considered as unsupported. - // TODO(jwcai) Need to carefully check the whether they should be - // supported after all. case NATIVE_WINDOW_WIDTH: + value = core_->producer_->default_width(); + break; case NATIVE_WINDOW_HEIGHT: + value = core_->producer_->default_height(); + break; case NATIVE_WINDOW_FORMAT: - case NATIVE_WINDOW_STICKY_TRANSFORM: + value = core_->producer_->default_format(); + break; case NATIVE_WINDOW_CONSUMER_RUNNING_BEHIND: + // BufferHubQueue is always operating in async mode, thus semantically + // consumer can never be running behind. See BufferQueueCore.cpp core + // for more information about the original meaning of this flag. + value = 0; + break; case NATIVE_WINDOW_CONSUMER_USAGE_BITS: + // TODO(jwcai) This is currently not implement as we don't need + // IGraphicBufferConsumer parity. + value = 0; + break; + // The following queries are currently considered as unsupported. + // TODO(jwcai) Need to carefully check the whether they should be + // supported after all. + case NATIVE_WINDOW_STICKY_TRANSFORM: case NATIVE_WINDOW_DEFAULT_DATASPACE: default: return BAD_VALUE; @@ -282,24 +423,58 @@ status_t BufferHubQueueProducer::query(int what, int* out_value) { } status_t BufferHubQueueProducer::connect( - const sp<IProducerListener>& /* listener */, int /* api */, - bool /* producer_controlled_by_app */, QueueBufferOutput* /* output */) { + const sp<IProducerListener>& /* listener */, int api, + bool /* producer_controlled_by_app */, QueueBufferOutput* output) { // Consumer interaction are actually handled by buffer hub, and we need - // to maintain consumer operations here. Hence |connect| is a NO-OP. + // to maintain consumer operations here. We only need to perform basic input + // parameter checks here. ALOGD_IF(TRACE, __FUNCTION__); + + if (output == nullptr) { + return BAD_VALUE; + } + + std::unique_lock<std::mutex> lock(core_->mutex_); + + if (core_->connected_api_ != BufferHubQueueCore::kNoConnectedApi) { + return BAD_VALUE; + } + + switch (api) { + case NATIVE_WINDOW_API_EGL: + case NATIVE_WINDOW_API_CPU: + case NATIVE_WINDOW_API_MEDIA: + case NATIVE_WINDOW_API_CAMERA: + core_->connected_api_ = api; + // TODO(jwcai) Fill output. + break; + default: + ALOGE("BufferHubQueueProducer::connect: unknow API %d", api); + return BAD_VALUE; + } + return NO_ERROR; } -status_t BufferHubQueueProducer::disconnect(int /* api */, DisconnectMode /* mode */) { +status_t BufferHubQueueProducer::disconnect(int api, DisconnectMode mode) { // Consumer interaction are actually handled by buffer hub, and we need - // to maintain consumer operations here. Hence |disconnect| is a NO-OP. + // to maintain consumer operations here. We only need to perform basic input + // parameter checks here. ALOGD_IF(TRACE, __FUNCTION__); + + std::unique_lock<std::mutex> lock(core_->mutex_); + + if (api != core_->connected_api_) { + return BAD_VALUE; + } + + core_->connected_api_ = BufferHubQueueCore::kNoConnectedApi; return NO_ERROR; } status_t BufferHubQueueProducer::setSidebandStream( const sp<NativeHandle>& stream) { - if (stream != NULL) { + if (stream != nullptr) { // TODO(jwcai) Investigate how is is used, maybe use BufferHubBuffer's // metadata. ALOGE("SidebandStream is not currently supported."); @@ -314,7 +489,7 @@ void BufferHubQueueProducer::allocateBuffers(uint32_t /* width */, uint32_t /* usage */) { // TODO(jwcai) |allocateBuffers| aims to preallocate up to the maximum number // of buffers permitted by the current BufferQueue configuration (aka - // |req_buffer_count_|). + // |max_buffer_count_|). ALOGE("BufferHubQueueProducer::allocateBuffers not implemented."); } @@ -343,6 +518,7 @@ String8 BufferHubQueueProducer::getConsumerName() const { status_t BufferHubQueueProducer::setSharedBufferMode( bool /* shared_buffer_mode */) { ALOGE("BufferHubQueueProducer::setSharedBufferMode not implemented."); + // TODO(b/36373181) Front buffer mode for buffer hub queue as ANativeWindow. return INVALID_OPERATION; } diff --git a/libs/vr/libbufferhubqueue/include/private/dvr/buffer_hub_queue_client.h b/libs/vr/libbufferhubqueue/include/private/dvr/buffer_hub_queue_client.h index f786356cce..a020dca7f9 100644 --- a/libs/vr/libbufferhubqueue/include/private/dvr/buffer_hub_queue_client.h +++ b/libs/vr/libbufferhubqueue/include/private/dvr/buffer_hub_queue_client.h @@ -32,6 +32,15 @@ class BufferHubQueue : public pdx::Client { // a new consumer queue client or nullptr on failure. std::unique_ptr<ConsumerQueue> CreateConsumerQueue(); + // Return the default buffer width of this buffer queue. + size_t default_width() const { return default_width_; } + + // Return the default buffer height of this buffer queue. + size_t default_height() const { return default_height_; } + + // Return the default buffer format of this buffer queue. + int32_t default_format() const { return default_format_; } + // Return the number of buffers avaiable for dequeue. size_t count() const { return available_buffers_.GetSize(); } @@ -169,6 +178,18 @@ class BufferHubQueue : public pdx::Client { void operator=(BufferInfo&) = delete; }; + // Default buffer width that can be set to override the buffer width when a + // width and height of 0 are specified in AllocateBuffer. + size_t default_width_{1}; + + // Default buffer height that can be set to override the buffer height when a + // width and height of 0 are specified in AllocateBuffer. + size_t default_height_{1}; + + // Default buffer format that can be set to override the buffer format when it + // isn't specified in AllocateBuffer. + int32_t default_format_{PIXEL_FORMAT_RGBA_8888}; + // Buffer queue: // |buffers_| tracks all |BufferHubBuffer|s created by this |BufferHubQueue|. std::vector<std::shared_ptr<BufferHubBuffer>> buffers_; diff --git a/libs/vr/libbufferhubqueue/include/private/dvr/buffer_hub_queue_core.h b/libs/vr/libbufferhubqueue/include/private/dvr/buffer_hub_queue_core.h index ba0c0c5f2e..e353187701 100644 --- a/libs/vr/libbufferhubqueue/include/private/dvr/buffer_hub_queue_core.h +++ b/libs/vr/libbufferhubqueue/include/private/dvr/buffer_hub_queue_core.h @@ -17,6 +17,8 @@ class BufferHubQueueCore { friend class BufferHubQueueProducer; public: + static constexpr int kNoConnectedApi = -1; + // Create a BufferHubQueueCore instance by creating a new producer queue. static std::shared_ptr<BufferHubQueueCore> Create(); @@ -87,6 +89,9 @@ class BufferHubQueueCore { // Mutex for thread safety. std::mutex mutex_; + // Connect client API, should be one of the NATIVE_WINDOW_API_* flags. + int connected_api_{kNoConnectedApi}; + // |buffers_| stores the buffers that have been dequeued from // |dvr::BufferHubQueue|, It is initialized to invalid buffers, and gets // filled in with the result of |Dequeue|. diff --git a/libs/vr/libbufferhubqueue/include/private/dvr/buffer_hub_queue_producer.h b/libs/vr/libbufferhubqueue/include/private/dvr/buffer_hub_queue_producer.h index 5b1a7e0c76..43e5ce30b8 100644 --- a/libs/vr/libbufferhubqueue/include/private/dvr/buffer_hub_queue_producer.h +++ b/libs/vr/libbufferhubqueue/include/private/dvr/buffer_hub_queue_producer.h @@ -103,13 +103,15 @@ class BufferHubQueueProducer : public IGraphicBufferProducer { private: using LocalHandle = pdx::LocalHandle; - static constexpr int kInvalidBufferCount = -1; - // |core_| holds the actually buffer slots. std::shared_ptr<BufferHubQueueCore> core_; - // |req_buffer_count_| sets the capacity of the underlying buffer queue. - int32_t req_buffer_count_; + // |max_buffer_count_| sets the capacity of the underlying buffer queue. + int32_t max_buffer_count_{BufferHubQueue::kMaxQueueCapacity}; + + // |max_dequeued_buffer_count_| set the maximum number of buffers that can + // be dequeued at the same momment. + int32_t max_dequeued_buffer_count_{1}; }; } // namespace dvr diff --git a/libs/vr/libbufferhubqueue/tests/buffer_hub_queue_producer-test.cpp b/libs/vr/libbufferhubqueue/tests/buffer_hub_queue_producer-test.cpp index 5bb121aeb9..64034e8800 100644 --- a/libs/vr/libbufferhubqueue/tests/buffer_hub_queue_producer-test.cpp +++ b/libs/vr/libbufferhubqueue/tests/buffer_hub_queue_producer-test.cpp @@ -1,7 +1,9 @@ #include <private/dvr/buffer_hub_queue_producer.h> #include <base/logging.h> +#include <gui/IProducerListener.h> #include <gui/Surface.h> + #include <gtest/gtest.h> namespace android { @@ -9,12 +11,500 @@ namespace dvr { namespace { -class BufferHubQueueProducerTest : public ::testing::Test {}; +// Default dimensions before setDefaultBufferSize is called by the consumer. +constexpr uint32_t kDefaultWidth = 1; +constexpr uint32_t kDefaultHeight = 1; + +// Default format before setDefaultBufferFormat is called by the consumer. +constexpr PixelFormat kDefaultFormat = HAL_PIXEL_FORMAT_RGBA_8888; +constexpr int kDefaultConsumerUsageBits = 0; + +// Default transform hint before setTransformHint is called by the consumer. +constexpr uint32_t kDefaultTransformHint = 0; + +constexpr int kTestApi = NATIVE_WINDOW_API_CPU; +constexpr int kTestApiOther = NATIVE_WINDOW_API_EGL; +constexpr int kTestApiInvalid = 0xDEADBEEF; +constexpr int kTestProducerUsageBits = 0; +constexpr bool kTestControlledByApp = true; + +// Builder pattern to slightly vary *almost* correct input +// -- avoids copying and pasting +struct QueueBufferInputBuilder { + IGraphicBufferProducer::QueueBufferInput build() { + return IGraphicBufferProducer::QueueBufferInput( + mTimestamp, mIsAutoTimestamp, mDataSpace, mCrop, mScalingMode, + mTransform, mFence); + } + + QueueBufferInputBuilder& setTimestamp(int64_t timestamp) { + this->mTimestamp = timestamp; + return *this; + } + + QueueBufferInputBuilder& setIsAutoTimestamp(bool isAutoTimestamp) { + this->mIsAutoTimestamp = isAutoTimestamp; + return *this; + } + + QueueBufferInputBuilder& setDataSpace(android_dataspace dataSpace) { + this->mDataSpace = dataSpace; + return *this; + } + + QueueBufferInputBuilder& setCrop(Rect crop) { + this->mCrop = crop; + return *this; + } + + QueueBufferInputBuilder& setScalingMode(int scalingMode) { + this->mScalingMode = scalingMode; + return *this; + } + + QueueBufferInputBuilder& setTransform(uint32_t transform) { + this->mTransform = transform; + return *this; + } + + QueueBufferInputBuilder& setFence(sp<Fence> fence) { + this->mFence = fence; + return *this; + } + + private: + int64_t mTimestamp{1384888611}; + bool mIsAutoTimestamp{false}; + android_dataspace mDataSpace{HAL_DATASPACE_UNKNOWN}; + Rect mCrop{Rect(kDefaultWidth, kDefaultHeight)}; + int mScalingMode{0}; + uint32_t mTransform{0}; + sp<Fence> mFence{Fence::NO_FENCE}; +}; + +// This is a test that covers our implementation of bufferhubqueue-based +// IGraphicBufferProducer. +class BufferHubQueueProducerTest : public ::testing::Test { + protected: + virtual void SetUp() { + const ::testing::TestInfo* const testInfo = + ::testing::UnitTest::GetInstance()->current_test_info(); + ALOGD_IF(TRACE, "Begin test: %s.%s", testInfo->test_case_name(), + testInfo->name()); + + auto core = BufferHubQueueCore::Create(); + mProducer = new BufferHubQueueProducer(core); + ASSERT_TRUE(mProducer != nullptr); + mSurface = new Surface(mProducer, true); + ASSERT_TRUE(mSurface != nullptr); + } + + // Connect to a producer in a 'correct' fashion. + void ConnectProducer() { + IGraphicBufferProducer::QueueBufferOutput output; + // Can connect the first time. + ASSERT_EQ(NO_ERROR, mProducer->connect(kDummyListener, kTestApi, + kTestControlledByApp, &output)); + } + + // Dequeue a buffer in a 'correct' fashion. + // Precondition: Producer is connected. + void DequeueBuffer(int* outSlot) { + sp<Fence> fence; + ASSERT_NO_FATAL_FAILURE(DequeueBuffer(outSlot, &fence)); + } + + void DequeueBuffer(int* outSlot, sp<Fence>* outFence) { + ASSERT_NE(nullptr, outSlot); + ASSERT_NE(nullptr, outFence); + + int ret = mProducer->dequeueBuffer(outSlot, outFence, kDefaultWidth, + kDefaultHeight, kDefaultFormat, + kTestProducerUsageBits, nullptr); + // BUFFER_NEEDS_REALLOCATION can be either on or off. + ASSERT_EQ(0, ~IGraphicBufferProducer::BUFFER_NEEDS_REALLOCATION & ret); + + // Slot number should be in boundary. + ASSERT_LE(0, *outSlot); + ASSERT_GT(BufferQueueDefs::NUM_BUFFER_SLOTS, *outSlot); + } + + // Create a generic "valid" input for queueBuffer + // -- uses the default buffer format, width, etc. + static IGraphicBufferProducer::QueueBufferInput CreateBufferInput() { + return QueueBufferInputBuilder().build(); + } + + const sp<IProducerListener> kDummyListener{new DummyProducerListener}; + + sp<BufferHubQueueProducer> mProducer; + sp<Surface> mSurface; +}; + +TEST_F(BufferHubQueueProducerTest, ConnectFirst_ReturnsError) { + IGraphicBufferProducer::QueueBufferOutput output; + + // NULL output returns BAD_VALUE + EXPECT_EQ(BAD_VALUE, mProducer->connect(kDummyListener, kTestApi, + kTestControlledByApp, nullptr)); + + // Invalid API returns bad value + EXPECT_EQ(BAD_VALUE, mProducer->connect(kDummyListener, kTestApiInvalid, + kTestControlledByApp, &output)); +} + +TEST_F(BufferHubQueueProducerTest, ConnectAgain_ReturnsError) { + ASSERT_NO_FATAL_FAILURE(ConnectProducer()); + + // Can't connect when there is already a producer connected. + IGraphicBufferProducer::QueueBufferOutput output; + EXPECT_EQ(BAD_VALUE, mProducer->connect(kDummyListener, kTestApi, + kTestControlledByApp, &output)); +} + +TEST_F(BufferHubQueueProducerTest, Disconnect_Succeeds) { + ASSERT_NO_FATAL_FAILURE(ConnectProducer()); + + ASSERT_EQ(NO_ERROR, mProducer->disconnect(kTestApi)); +} + +TEST_F(BufferHubQueueProducerTest, Disconnect_ReturnsError) { + ASSERT_NO_FATAL_FAILURE(ConnectProducer()); + + // Must disconnect with same API number + EXPECT_EQ(BAD_VALUE, mProducer->disconnect(kTestApiOther)); + // API must not be out of range + EXPECT_EQ(BAD_VALUE, mProducer->disconnect(kTestApiInvalid)); +} + +TEST_F(BufferHubQueueProducerTest, Query_Succeeds) { + ASSERT_NO_FATAL_FAILURE(ConnectProducer()); + + int32_t value = -1; + EXPECT_EQ(NO_ERROR, mProducer->query(NATIVE_WINDOW_WIDTH, &value)); + EXPECT_EQ(kDefaultWidth, static_cast<uint32_t>(value)); + + EXPECT_EQ(NO_ERROR, mProducer->query(NATIVE_WINDOW_HEIGHT, &value)); + EXPECT_EQ(kDefaultHeight, static_cast<uint32_t>(value)); + + EXPECT_EQ(NO_ERROR, mProducer->query(NATIVE_WINDOW_FORMAT, &value)); + EXPECT_EQ(kDefaultFormat, value); + + EXPECT_EQ(NO_ERROR, + mProducer->query(NATIVE_WINDOW_MIN_UNDEQUEUED_BUFFERS, &value)); + EXPECT_LE(0, value); + EXPECT_GE(BufferQueueDefs::NUM_BUFFER_SLOTS, static_cast<size_t>(value)); + + EXPECT_EQ(NO_ERROR, + mProducer->query(NATIVE_WINDOW_CONSUMER_RUNNING_BEHIND, &value)); + EXPECT_FALSE(value); // Can't run behind when we haven't touched the queue + + EXPECT_EQ(NO_ERROR, + mProducer->query(NATIVE_WINDOW_CONSUMER_USAGE_BITS, &value)); + EXPECT_EQ(kDefaultConsumerUsageBits, value); +} + +TEST_F(BufferHubQueueProducerTest, Query_ReturnsError) { + ASSERT_NO_FATAL_FAILURE(ConnectProducer()); + + // One past the end of the last 'query' enum value. Update this if we add more + // enums. + const int NATIVE_WINDOW_QUERY_LAST_OFF_BY_ONE = NATIVE_WINDOW_BUFFER_AGE + 1; + + int value; + // What was out of range + EXPECT_EQ(BAD_VALUE, mProducer->query(/*what*/ -1, &value)); + EXPECT_EQ(BAD_VALUE, mProducer->query(/*what*/ 0xDEADBEEF, &value)); + EXPECT_EQ(BAD_VALUE, + mProducer->query(NATIVE_WINDOW_QUERY_LAST_OFF_BY_ONE, &value)); + + // Some enums from window.h are 'invalid' + EXPECT_EQ(BAD_VALUE, + mProducer->query(NATIVE_WINDOW_QUEUES_TO_WINDOW_COMPOSER, &value)); + EXPECT_EQ(BAD_VALUE, mProducer->query(NATIVE_WINDOW_CONCRETE_TYPE, &value)); + EXPECT_EQ(BAD_VALUE, mProducer->query(NATIVE_WINDOW_DEFAULT_WIDTH, &value)); + EXPECT_EQ(BAD_VALUE, mProducer->query(NATIVE_WINDOW_DEFAULT_HEIGHT, &value)); + EXPECT_EQ(BAD_VALUE, mProducer->query(NATIVE_WINDOW_TRANSFORM_HINT, &value)); + + // Value was NULL + EXPECT_EQ(BAD_VALUE, mProducer->query(NATIVE_WINDOW_FORMAT, /*value*/ NULL)); +} + +TEST_F(BufferHubQueueProducerTest, Queue_Succeeds) { + int slot = -1; + + ASSERT_NO_FATAL_FAILURE(ConnectProducer()); + ASSERT_NO_FATAL_FAILURE(DequeueBuffer(&slot)); + + // Request the buffer (pre-requisite for queueing) + sp<GraphicBuffer> buffer; + ASSERT_EQ(NO_ERROR, mProducer->requestBuffer(slot, &buffer)); + + // A generic "valid" input + IGraphicBufferProducer::QueueBufferInput input = CreateBufferInput(); + IGraphicBufferProducer::QueueBufferOutput output; + + // Queue the buffer back into the BQ + ASSERT_EQ(NO_ERROR, mProducer->queueBuffer(slot, input, &output)); + + EXPECT_EQ(kDefaultWidth, output.width); + EXPECT_EQ(kDefaultHeight, output.height); + EXPECT_EQ(kDefaultTransformHint, output.transformHint); + + // BufferHubQueue delivers buffers to consumer immediately. + EXPECT_EQ(0u, output.numPendingBuffers); + + // Note that BufferHubQueue doesn't support nextFrameNumber as it seems to + // be a SurfaceFlinger specific optimization. + EXPECT_EQ(0u, output.nextFrameNumber); + + // Buffer was not in the dequeued state + EXPECT_EQ(BAD_VALUE, mProducer->queueBuffer(slot, input, &output)); +} + +// Test invalid slot number +TEST_F(BufferHubQueueProducerTest, QueueInvalidSlot_ReturnsError) { + ASSERT_NO_FATAL_FAILURE(ConnectProducer()); + + // A generic "valid" input + IGraphicBufferProducer::QueueBufferInput input = CreateBufferInput(); + IGraphicBufferProducer::QueueBufferOutput output; + + EXPECT_EQ(BAD_VALUE, mProducer->queueBuffer(/*slot*/ -1, input, &output)); + EXPECT_EQ(BAD_VALUE, + mProducer->queueBuffer(/*slot*/ 0xDEADBEEF, input, &output)); + EXPECT_EQ(BAD_VALUE, mProducer->queueBuffer(BufferQueueDefs::NUM_BUFFER_SLOTS, + input, &output)); +} + +// Slot was not in the dequeued state (all slots start out in Free state) +TEST_F(BufferHubQueueProducerTest, QueueNotDequeued_ReturnsError) { + ASSERT_NO_FATAL_FAILURE(ConnectProducer()); + + IGraphicBufferProducer::QueueBufferInput input = CreateBufferInput(); + IGraphicBufferProducer::QueueBufferOutput output; + + EXPECT_EQ(BAD_VALUE, mProducer->queueBuffer(/*slot*/ 0, input, &output)); +} + +// Slot was enqueued without requesting a buffer +TEST_F(BufferHubQueueProducerTest, QueueNotRequested_ReturnsError) { + int slot = -1; + + ASSERT_NO_FATAL_FAILURE(ConnectProducer()); + ASSERT_NO_FATAL_FAILURE(DequeueBuffer(&slot)); + + IGraphicBufferProducer::QueueBufferInput input = CreateBufferInput(); + IGraphicBufferProducer::QueueBufferOutput output; + + EXPECT_EQ(BAD_VALUE, mProducer->queueBuffer(slot, input, &output)); +} + +// Test when fence was NULL +TEST_F(BufferHubQueueProducerTest, QueueNoFence_ReturnsError) { + int slot = -1; + + ASSERT_NO_FATAL_FAILURE(ConnectProducer()); + ASSERT_NO_FATAL_FAILURE(DequeueBuffer(&slot)); + + sp<GraphicBuffer> buffer; + ASSERT_EQ(NO_ERROR, mProducer->requestBuffer(slot, &buffer)); + + sp<Fence> nullFence = NULL; + + IGraphicBufferProducer::QueueBufferInput input = + QueueBufferInputBuilder().setFence(nullFence).build(); + IGraphicBufferProducer::QueueBufferOutput output; + + EXPECT_EQ(BAD_VALUE, mProducer->queueBuffer(slot, input, &output)); +} + +// Test scaling mode was invalid +TEST_F(BufferHubQueueProducerTest, QueueTestInvalidScalingMode_ReturnsError) { + int slot = -1; + + ASSERT_NO_FATAL_FAILURE(ConnectProducer()); + ASSERT_NO_FATAL_FAILURE(DequeueBuffer(&slot)); + + sp<GraphicBuffer> buffer; + ASSERT_EQ(NO_ERROR, mProducer->requestBuffer(slot, &buffer)); + + IGraphicBufferProducer::QueueBufferInput input = + QueueBufferInputBuilder().setScalingMode(-1).build(); + IGraphicBufferProducer::QueueBufferOutput output; + + EXPECT_EQ(BAD_VALUE, mProducer->queueBuffer(slot, input, &output)); + + input = QueueBufferInputBuilder().setScalingMode(0xDEADBEEF).build(); + + EXPECT_EQ(BAD_VALUE, mProducer->queueBuffer(slot, input, &output)); +} + +// Test crop rect is out of bounds of the buffer dimensions +TEST_F(BufferHubQueueProducerTest, QueueCropOutOfBounds_ReturnsError) { + int slot = -1; + + ASSERT_NO_FATAL_FAILURE(ConnectProducer()); + ASSERT_NO_FATAL_FAILURE(DequeueBuffer(&slot)); + + sp<GraphicBuffer> buffer; + ASSERT_EQ(NO_ERROR, mProducer->requestBuffer(slot, &buffer)); + + IGraphicBufferProducer::QueueBufferInput input = + QueueBufferInputBuilder() + .setCrop(Rect(kDefaultWidth + 1, kDefaultHeight + 1)) + .build(); + IGraphicBufferProducer::QueueBufferOutput output; + + EXPECT_EQ(BAD_VALUE, mProducer->queueBuffer(slot, input, &output)); +} + +TEST_F(BufferHubQueueProducerTest, CancelBuffer_Succeeds) { + int slot = -1; + sp<Fence> fence; + + ASSERT_NO_FATAL_FAILURE(ConnectProducer()); + ASSERT_NO_FATAL_FAILURE(DequeueBuffer(&slot, &fence)); + + // Should be able to cancel buffer after a dequeue. + EXPECT_EQ(NO_ERROR, mProducer->cancelBuffer(slot, fence)); +} + +TEST_F(BufferHubQueueProducerTest, SetMaxDequeuedBufferCount_Succeeds) { + return; + ASSERT_NO_FATAL_FAILURE(ConnectProducer()); + + int minUndequeuedBuffers; + ASSERT_EQ(NO_ERROR, mProducer->query(NATIVE_WINDOW_MIN_UNDEQUEUED_BUFFERS, + &minUndequeuedBuffers)); + + const int minBuffers = 1; + const int maxBuffers = + BufferQueueDefs::NUM_BUFFER_SLOTS - minUndequeuedBuffers; + + ASSERT_EQ(NO_ERROR, mProducer->setAsyncMode(false)) + << "async mode: " << false; + ASSERT_EQ(NO_ERROR, mProducer->setMaxDequeuedBufferCount(minBuffers)) + << "bufferCount: " << minBuffers; + + // Should now be able to dequeue up to minBuffers times + // Should now be able to dequeue up to maxBuffers times + int slot = -1; + for (int i = 0; i < minBuffers; ++i) { + ASSERT_NO_FATAL_FAILURE(DequeueBuffer(&slot)); + } + + ASSERT_EQ(NO_ERROR, mProducer->setMaxDequeuedBufferCount(maxBuffers)); + + // queue the first buffer to enable max dequeued buffer count checking + IGraphicBufferProducer::QueueBufferInput input = CreateBufferInput(); + IGraphicBufferProducer::QueueBufferOutput output; + sp<GraphicBuffer> buffer; + ASSERT_EQ(NO_ERROR, mProducer->requestBuffer(slot, &buffer)); + ASSERT_EQ(NO_ERROR, mProducer->queueBuffer(slot, input, &output)); + + sp<Fence> fence; + for (int i = 0; i < maxBuffers; ++i) { + ASSERT_NO_FATAL_FAILURE(DequeueBuffer(&slot, &fence)); + } + + // Cancel a buffer, so we can decrease the buffer count + ASSERT_EQ(NO_ERROR, mProducer->cancelBuffer(slot, fence)); + + // Should now be able to decrease the max dequeued count by 1 + ASSERT_EQ(NO_ERROR, mProducer->setMaxDequeuedBufferCount(maxBuffers - 1)); +} + +TEST_F(BufferHubQueueProducerTest, SetMaxDequeuedBufferCount_Fails) { + ASSERT_NO_FATAL_FAILURE(ConnectProducer()); + + int minUndequeuedBuffers; + ASSERT_EQ(NO_ERROR, mProducer->query(NATIVE_WINDOW_MIN_UNDEQUEUED_BUFFERS, + &minUndequeuedBuffers)); + + const int minBuffers = 1; + const int maxBuffers = + BufferQueueDefs::NUM_BUFFER_SLOTS - minUndequeuedBuffers; + + ASSERT_EQ(NO_ERROR, mProducer->setAsyncMode(false)) + << "async mode: " << false; + // Buffer count was out of range + EXPECT_EQ(BAD_VALUE, mProducer->setMaxDequeuedBufferCount(0)) + << "bufferCount: " << 0; + EXPECT_EQ(BAD_VALUE, mProducer->setMaxDequeuedBufferCount(maxBuffers + 1)) + << "bufferCount: " << maxBuffers + 1; + + // Set max dequeue count to 2 + ASSERT_EQ(NO_ERROR, mProducer->setMaxDequeuedBufferCount(2)); + // Dequeue 2 buffers + int slot = -1; + sp<Fence> fence; + for (int i = 0; i < 2; i++) { + ASSERT_EQ(OK, ~IGraphicBufferProducer::BUFFER_NEEDS_REALLOCATION & + (mProducer->dequeueBuffer( + &slot, &fence, kDefaultWidth, kDefaultHeight, + kDefaultFormat, kTestProducerUsageBits, nullptr))) + << "slot: " << slot; + } + + // Client has too many buffers dequeued + EXPECT_EQ(BAD_VALUE, mProducer->setMaxDequeuedBufferCount(1)) + << "bufferCount: " << minBuffers; +} + +TEST_F(BufferHubQueueProducerTest, + DisconnectedProducerReturnsError_dequeueBuffer) { + int slot = -1; + sp<Fence> fence; + + ASSERT_EQ(NO_INIT, mProducer->dequeueBuffer(&slot, &fence, kDefaultWidth, + kDefaultHeight, kDefaultFormat, + kTestProducerUsageBits, nullptr)); +} + +TEST_F(BufferHubQueueProducerTest, + DisconnectedProducerReturnsError_requestBuffer) { + int slot = -1; + sp<GraphicBuffer> buffer; + + ASSERT_NO_FATAL_FAILURE(ConnectProducer()); + ASSERT_NO_FATAL_FAILURE(DequeueBuffer(&slot)); + + // Shouldn't be able to request buffer after disconnect. + ASSERT_EQ(NO_ERROR, mProducer->disconnect(kTestApi)); + ASSERT_EQ(NO_INIT, mProducer->requestBuffer(slot, &buffer)); +} + +TEST_F(BufferHubQueueProducerTest, + DisconnectedProducerReturnsError_queueBuffer) { + int slot = -1; + sp<GraphicBuffer> buffer; + + ASSERT_NO_FATAL_FAILURE(ConnectProducer()); + ASSERT_NO_FATAL_FAILURE(DequeueBuffer(&slot)); + ASSERT_EQ(NO_ERROR, mProducer->requestBuffer(slot, &buffer)); + + // A generic "valid" input + IGraphicBufferProducer::QueueBufferInput input = CreateBufferInput(); + IGraphicBufferProducer::QueueBufferOutput output; + + // Shouldn't be able to queue buffer after disconnect. + ASSERT_EQ(NO_ERROR, mProducer->disconnect(kTestApi)); + ASSERT_EQ(NO_INIT, mProducer->queueBuffer(slot, input, &output)); +} + +TEST_F(BufferHubQueueProducerTest, + DisconnectedProducerReturnsError_cancelBuffer) { + int slot = -1; + sp<GraphicBuffer> buffer; + + ASSERT_NO_FATAL_FAILURE(ConnectProducer()); + ASSERT_NO_FATAL_FAILURE(DequeueBuffer(&slot)); + ASSERT_EQ(NO_ERROR, mProducer->requestBuffer(slot, &buffer)); -TEST_F(BufferHubQueueProducerTest, TempTestBufferHubQueueProducer) { - auto core = BufferHubQueueCore::Create(); - sp<BufferHubQueueProducer> producer = new BufferHubQueueProducer(core); - sp<Surface> surface = new Surface(producer, true); + // Shouldn't be able to cancel buffer after disconnect. + ASSERT_EQ(NO_ERROR, mProducer->disconnect(kTestApi)); + ASSERT_EQ(NO_INIT, mProducer->cancelBuffer(slot, Fence::NO_FENCE)); } } // namespace diff --git a/libs/vr/libdvr/Android.mk b/libs/vr/libdvr/Android.mk index 5449cb5866..3c6934bdcc 100644 --- a/libs/vr/libdvr/Android.mk +++ b/libs/vr/libdvr/Android.mk @@ -33,6 +33,7 @@ LOCAL_SRC_FILES := \ dvr_api.cpp \ dvr_buffer.cpp \ dvr_buffer_queue.cpp \ + dvr_hardware_composer_client.cpp \ dvr_surface.cpp \ vsync_client_api.cpp \ @@ -42,12 +43,15 @@ LOCAL_STATIC_LIBRARIES := \ libdisplay \ libvrsensor \ libvirtualtouchpadclient \ + libvr_hwc-impl \ + libvr_hwc-binder \ LOCAL_SHARED_LIBRARIES := \ android.hardware.graphics.bufferqueue@1.0 \ android.hidl.token@1.0-utils \ libandroid_runtime \ libbase \ + libnativewindow \ include $(BUILD_STATIC_LIBRARY) diff --git a/libs/vr/libdvr/dvr_api.cpp b/libs/vr/libdvr/dvr_api.cpp index f464411fce..f786c29e1d 100644 --- a/libs/vr/libdvr/dvr_api.cpp +++ b/libs/vr/libdvr/dvr_api.cpp @@ -11,6 +11,7 @@ // Headers not yet moved into libdvr. // TODO(jwcai) Move these once their callers are moved into Google3. +#include <dvr/dvr_hardware_composer_client.h> #include <dvr/pose_client.h> #include <dvr/virtual_touchpad_client.h> @@ -100,6 +101,26 @@ DVR_EXPORT int dvrGetApi(void* api, size_t struct_size, int version) { dvr_api->virtual_touchpad_touch = dvrVirtualTouchpadTouch; dvr_api->virtual_touchpad_button_state = dvrVirtualTouchpadButtonState; + // dvr_hardware_composer_client.h + dvr_api->hwc_client_create = dvrHwcClientCreate; + dvr_api->hwc_client_destroy = dvrHwcClientDestroy; + dvr_api->hwc_frame_destroy = dvrHwcFrameDestroy; + dvr_api->hwc_frame_get_display_id = dvrHwcFrameGetDisplayId; + dvr_api->hwc_frame_get_display_width = dvrHwcFrameGetDisplayWidth; + dvr_api->hwc_frame_get_display_height = dvrHwcFrameGetDisplayHeight; + dvr_api->hwc_frame_get_layer_count = dvrHwcFrameGetLayerCount; + dvr_api->hwc_frame_get_layer_id = dvrHwcFrameGetLayerId; + dvr_api->hwc_frame_get_layer_buffer = dvrHwcFrameGetLayerBuffer; + dvr_api->hwc_frame_get_layer_fence = dvrHwcFrameGetLayerFence; + dvr_api->hwc_frame_get_layer_display_frame = + dvrHwcFrameGetLayerDisplayFrame; + dvr_api->hwc_frame_get_layer_crop = dvrHwcFrameGetLayerCrop; + dvr_api->hwc_frame_get_layer_blend_mode = dvrHwcFrameGetLayerBlendMode; + dvr_api->hwc_frame_get_layer_alpha = dvrHwcFrameGetLayerAlpha; + dvr_api->hwc_frame_get_layer_type = dvrHwcFrameGetLayerType; + dvr_api->hwc_frame_get_layer_application_id = + dvrHwcFrameGetLayerApplicationId; + return 0; } return -EINVAL; diff --git a/services/vr/hardware_composer/dvr_hardware_composer_client.cpp b/libs/vr/libdvr/dvr_hardware_composer_client.cpp index 39fa9fc305..e5665e152f 100644 --- a/services/vr/hardware_composer/dvr_hardware_composer_client.cpp +++ b/libs/vr/libdvr/dvr_hardware_composer_client.cpp @@ -1,7 +1,8 @@ -#include "private/android/dvr_hardware_composer_client.h" +#include "include/dvr/dvr_hardware_composer_client.h" #include <android/dvr/IVrComposer.h> #include <android/dvr/BnVrComposerCallback.h> +#include <android/hardware_buffer.h> #include <binder/IServiceManager.h> #include <private/android/AHardwareBufferHelpers.h> @@ -15,7 +16,8 @@ namespace { class HwcCallback : public android::dvr::BnVrComposerCallback { public: - explicit HwcCallback(DvrHwcOnFrameCallback callback); + explicit HwcCallback(DvrHwcOnFrameCallback callback, + void* client_state); ~HwcCallback() override; std::unique_ptr<DvrHwcFrame> DequeueFrame(); @@ -27,13 +29,14 @@ class HwcCallback : public android::dvr::BnVrComposerCallback { android::dvr::ParcelableUniqueFd* fence) override; DvrHwcOnFrameCallback callback_; + void* client_state_; HwcCallback(const HwcCallback&) = delete; void operator=(const HwcCallback&) = delete; }; -HwcCallback::HwcCallback(DvrHwcOnFrameCallback callback) - : callback_(callback) {} +HwcCallback::HwcCallback(DvrHwcOnFrameCallback callback, void* client_state) + : callback_(callback), client_state_(client_state) {} HwcCallback::~HwcCallback() {} @@ -43,7 +46,8 @@ android::binder::Status HwcCallback::onNewFrame( std::unique_ptr<DvrHwcFrame> dvr_frame(new DvrHwcFrame()); dvr_frame->frame = frame.frame(); - fence->set_fence(android::base::unique_fd(callback_(dvr_frame.release()))); + fence->set_fence(android::base::unique_fd(callback_(client_state_, + dvr_frame.release()))); return android::binder::Status::ok(); } @@ -54,7 +58,7 @@ struct DvrHwcClient { android::sp<HwcCallback> callback; }; -DvrHwcClient* dvrHwcCreateClient(DvrHwcOnFrameCallback callback) { +DvrHwcClient* dvrHwcClientCreate(DvrHwcOnFrameCallback callback, void* data) { std::unique_ptr<DvrHwcClient> client(new DvrHwcClient()); android::sp<android::IServiceManager> sm(android::defaultServiceManager()); @@ -63,7 +67,7 @@ DvrHwcClient* dvrHwcCreateClient(DvrHwcOnFrameCallback callback) { if (!client->composer.get()) return nullptr; - client->callback = new HwcCallback(callback); + client->callback = new HwcCallback(callback, data); android::binder::Status status = client->composer->registerObserver( client->callback); if (!status.isOk()) @@ -72,6 +76,10 @@ DvrHwcClient* dvrHwcCreateClient(DvrHwcOnFrameCallback callback) { return client.release(); } +void dvrHwcClientDestroy(DvrHwcClient* client) { + delete client; +} + void dvrHwcFrameDestroy(DvrHwcFrame* frame) { delete frame; } @@ -80,6 +88,18 @@ Display dvrHwcFrameGetDisplayId(DvrHwcFrame* frame) { return frame->frame.display_id; } +int32_t dvrHwcFrameGetDisplayWidth(DvrHwcFrame* frame) { + return frame->frame.display_width; +} + +int32_t dvrHwcFrameGetDisplayHeight(DvrHwcFrame* frame) { + return frame->frame.display_height; +} + +bool dvrHwcFrameGetDisplayRemoved(DvrHwcFrame* frame) { + return frame->frame.removed; +} + size_t dvrHwcFrameGetLayerCount(DvrHwcFrame* frame) { return frame->frame.layers.size(); } diff --git a/libs/vr/libdvr/include/dvr/dvr_api.h b/libs/vr/libdvr/include/dvr/dvr_api.h index d840b6c8c9..053382f28c 100644 --- a/libs/vr/libdvr/include/dvr/dvr_api.h +++ b/libs/vr/libdvr/include/dvr/dvr_api.h @@ -5,6 +5,7 @@ #include <stddef.h> #include <stdint.h> +#include <dvr/dvr_hardware_composer_defs.h> #include <jni.h> #ifdef __cplusplus @@ -144,6 +145,37 @@ typedef int (*DvrVirtualTouchpadTouchPtr)(DvrVirtualTouchpad* client, typedef int (*DvrVirtualTouchpadButtonStatePtr)(DvrVirtualTouchpad* client, int touchpad, int buttons); +// dvr_hardware_composer_client.h +typedef struct DvrHwcClient DvrHwcClient; +typedef struct DvrHwcFrame DvrHwcFrame; +typedef int(*DvrHwcOnFrameCallback)(void* client_state, DvrHwcFrame* frame); +typedef DvrHwcClient* (*DvrHwcClientCreatePtr)(DvrHwcOnFrameCallback callback, + void* client_state); +typedef void (*DvrHwcClientDestroyPtr)(DvrHwcClient* client); +typedef void (*DvrHwcFrameDestroyPtr)(DvrHwcFrame* frame); +typedef Display (*DvrHwcFrameGetDisplayIdPtr)(DvrHwcFrame* frame); +typedef int32_t (*DvrHwcFrameGetDisplayWidthPtr)(DvrHwcFrame* frame); +typedef int32_t (*DvrHwcFrameGetDisplayHeightPtr)(DvrHwcFrame* frame); +typedef bool (*DvrHwcFrameGetDisplayRemovedPtr)(DvrHwcFrame* frame); +typedef size_t (*DvrHwcFrameGetLayerCountPtr)(DvrHwcFrame* frame); +typedef Layer (*DvrHwcFrameGetLayerIdPtr)(DvrHwcFrame* frame, size_t layer_index); +typedef AHardwareBuffer* (*DvrHwcFrameGetLayerBufferPtr)(DvrHwcFrame* frame, + size_t layer_index); +typedef int (*DvrHwcFrameGetLayerFencePtr)(DvrHwcFrame* frame, + size_t layer_index); +typedef Recti (*DvrHwcFrameGetLayerDisplayFramePtr)(DvrHwcFrame* frame, + size_t layer_index); +typedef Rectf (*DvrHwcFrameGetLayerCropPtr)(DvrHwcFrame* frame, + size_t layer_index); +typedef BlendMode (*DvrHwcFrameGetLayerBlendModePtr)(DvrHwcFrame* frame, + size_t layer_index); +typedef float (*DvrHwcFrameGetLayerAlphaPtr)(DvrHwcFrame* frame, + size_t layer_index); +typedef uint32_t (*DvrHwcFrameGetLayerTypePtr)(DvrHwcFrame* frame, + size_t layer_index); +typedef uint32_t (*DvrHwcFrameGetLayerApplicationIdPtr)(DvrHwcFrame* frame, + size_t layer_index); + struct DvrApi_v1 { // Display manager client DvrDisplayManagerClientCreatePtr display_manager_client_create; @@ -220,6 +252,25 @@ struct DvrApi_v1 { DvrVirtualTouchpadDetachPtr virtual_touchpad_detach; DvrVirtualTouchpadTouchPtr virtual_touchpad_touch; DvrVirtualTouchpadButtonStatePtr virtual_touchpad_button_state; + + // VR HWComposer client + DvrHwcClientCreatePtr hwc_client_create; + DvrHwcClientDestroyPtr hwc_client_destroy; + DvrHwcFrameDestroyPtr hwc_frame_destroy; + DvrHwcFrameGetDisplayIdPtr hwc_frame_get_display_id; + DvrHwcFrameGetDisplayWidthPtr hwc_frame_get_display_width; + DvrHwcFrameGetDisplayHeightPtr hwc_frame_get_display_height; + DvrHwcFrameGetDisplayRemovedPtr hwc_frame_get_display_removed; + DvrHwcFrameGetLayerCountPtr hwc_frame_get_layer_count; + DvrHwcFrameGetLayerIdPtr hwc_frame_get_layer_id; + DvrHwcFrameGetLayerBufferPtr hwc_frame_get_layer_buffer; + DvrHwcFrameGetLayerFencePtr hwc_frame_get_layer_fence; + DvrHwcFrameGetLayerDisplayFramePtr hwc_frame_get_layer_display_frame; + DvrHwcFrameGetLayerCropPtr hwc_frame_get_layer_crop; + DvrHwcFrameGetLayerBlendModePtr hwc_frame_get_layer_blend_mode; + DvrHwcFrameGetLayerAlphaPtr hwc_frame_get_layer_alpha; + DvrHwcFrameGetLayerTypePtr hwc_frame_get_layer_type; + DvrHwcFrameGetLayerApplicationIdPtr hwc_frame_get_layer_application_id; }; int dvrGetApi(void* api, size_t struct_size, int version); diff --git a/services/vr/hardware_composer/private/android/dvr_hardware_composer_client.h b/libs/vr/libdvr/include/dvr/dvr_hardware_composer_client.h index 063c16d484..692864da4c 100644 --- a/services/vr/hardware_composer/private/android/dvr_hardware_composer_client.h +++ b/libs/vr/libdvr/include/dvr/dvr_hardware_composer_client.h @@ -1,29 +1,45 @@ -#ifndef VR_HARDWARE_COMPOSER_PRIVATE_ANDROID_DVR_HARDWARE_COMPOSER_CLIENT_H -#define VR_HARDWARE_COMPOSER_PRIVATE_ANDROID_DVR_HARDWARE_COMPOSER_CLIENT_H +#ifndef ANDROID_DVR_HARDWARE_COMPOSER_CLIENT_H +#define ANDROID_DVR_HARDWARE_COMPOSER_CLIENT_H -#include <android/dvr_hardware_composer_defs.h> -#include <android/hardware_buffer.h> +#include <dvr/dvr_hardware_composer_defs.h> +#include <stdbool.h> #ifdef __cplusplus extern "C" { #endif +typedef struct AHardwareBuffer AHardwareBuffer; typedef struct DvrHwcClient DvrHwcClient; typedef struct DvrHwcFrame DvrHwcFrame; // Called when a new frame has arrived. // +// @param client_state Pointer to client state passed in |dvrHwcCreateClient()|. // @param frame New frame. Owned by the client. // @return fence FD for the release of the last frame. -typedef int(*DvrHwcOnFrameCallback)(DvrHwcFrame* frame); +typedef int(*DvrHwcOnFrameCallback)(void* client_state, DvrHwcFrame* frame); -DvrHwcClient* dvrHwcCreateClient(DvrHwcOnFrameCallback callback); +// @param callback Called when a new frame is available. +// @param client_state Pointer to client state passed back in the callback. +DvrHwcClient* dvrHwcClientCreate(DvrHwcOnFrameCallback callback, + void* client_state); + +void dvrHwcClientDestroy(DvrHwcClient* client); // Called to free the frame information. void dvrHwcFrameDestroy(DvrHwcFrame* frame); Display dvrHwcFrameGetDisplayId(DvrHwcFrame* frame); +int32_t dvrHwcFrameGetDisplayWidth(DvrHwcFrame* frame); + +int32_t dvrHwcFrameGetDisplayHeight(DvrHwcFrame* frame); + +// @return True if the display has been removed. In this case the current frame +// does not contain any valid layers to display. It is a signal to clean up any +// display related state. +bool dvrHwcFrameGetDisplayRemoved(DvrHwcFrame* frame); + // @return Number of layers in the frame. size_t dvrHwcFrameGetLayerCount(DvrHwcFrame* frame); @@ -59,4 +75,4 @@ uint32_t dvrHwcFrameGetLayerApplicationId(DvrHwcFrame* frame, } // extern "C" #endif -#endif // VR_HARDWARE_COMPOSER_PRIVATE_ANDROID_DVR_HARDWARE_COMPOSER_CLIENT_H +#endif // ANDROID_DVR_HARDWARE_COMPOSER_CLIENT_H diff --git a/services/vr/hardware_composer/private/android/dvr_hardware_composer_defs.h b/libs/vr/libdvr/include/dvr/dvr_hardware_composer_defs.h index 3186f821a6..546ed7b040 100644 --- a/services/vr/hardware_composer/private/android/dvr_hardware_composer_defs.h +++ b/libs/vr/libdvr/include/dvr/dvr_hardware_composer_defs.h @@ -1,5 +1,5 @@ -#ifndef VR_HARDWARE_COMPOSER_PRIVATE_ANDROID_VR_HARDWARE_COMPOSER_DEFS_H -#define VR_HARDWARE_COMPOSER_PRIVATE_ANDROID_VR_HARDWARE_COMPOSER_DEFS_H +#ifndef ANDROID_VR_HARDWARE_COMPOSER_DEFS_H +#define ANDROID_VR_HARDWARE_COMPOSER_DEFS_H #include <inttypes.h> @@ -47,4 +47,4 @@ struct Rectf { } // extern "C" #endif -#endif // VR_HARDWARE_COMPOSER_PRIVATE_ANDROID_DVR_HARDWARE_COMPOSER_DEFS_H +#endif // ANDROID_DVR_HARDWARE_COMPOSER_DEFS_H diff --git a/libs/vr/libpdx/client.cpp b/libs/vr/libpdx/client.cpp index c31862896a..bfa2d879b5 100644 --- a/libs/vr/libpdx/client.cpp +++ b/libs/vr/libpdx/client.cpp @@ -4,7 +4,6 @@ #include <log/log.h> #include <pdx/trace.h> -#include "errno_guard.h" namespace android { namespace pdx { @@ -84,7 +83,6 @@ int Client::error() const { return error_; } Status<void> Client::SendImpulse(int opcode) { PDX_TRACE_NAME("Client::SendImpulse"); - ErrnoGuard errno_guard; auto status = CheckReconnect(); if (!status) @@ -98,7 +96,6 @@ Status<void> Client::SendImpulse(int opcode) { Status<void> Client::SendImpulse(int opcode, const void* buffer, size_t length) { PDX_TRACE_NAME("Client::SendImpulse"); - ErrnoGuard errno_guard; auto status = CheckReconnect(); if (!status) @@ -110,7 +107,6 @@ Status<void> Client::SendImpulse(int opcode, const void* buffer, } void Client::Close(int error) { - ErrnoGuard errno_guard; channel_.reset(); // Normalize error codes to negative integer space. error_ = error <= 0 ? error : -error; @@ -228,37 +224,38 @@ void Transaction::SendTransaction(int opcode, Status<LocalChannelHandle>* ret, CheckDisconnect(*ret); } -FileReference Transaction::PushFileHandle(const LocalHandle& handle) { - return client_.CheckReconnect() && EnsureStateAllocated() - ? client_.GetChannel()->PushFileHandle(state_, handle) - : -1; +Status<FileReference> Transaction::PushFileHandle(const LocalHandle& handle) { + if (client_.CheckReconnect() && EnsureStateAllocated()) + return client_.GetChannel()->PushFileHandle(state_, handle); + return ErrorStatus{ESHUTDOWN}; } -FileReference Transaction::PushFileHandle(const BorrowedHandle& handle) { - return client_.CheckReconnect() && EnsureStateAllocated() - ? client_.GetChannel()->PushFileHandle(state_, handle) - : -1; +Status<FileReference> Transaction::PushFileHandle( + const BorrowedHandle& handle) { + if (client_.CheckReconnect() && EnsureStateAllocated()) + return client_.GetChannel()->PushFileHandle(state_, handle); + return ErrorStatus{ESHUTDOWN}; } -FileReference Transaction::PushFileHandle(const RemoteHandle& handle) { +Status<FileReference> Transaction::PushFileHandle(const RemoteHandle& handle) { return handle.Get(); } -ChannelReference Transaction::PushChannelHandle( +Status<ChannelReference> Transaction::PushChannelHandle( const LocalChannelHandle& handle) { - return client_.CheckReconnect() && EnsureStateAllocated() - ? client_.GetChannel()->PushChannelHandle(state_, handle) - : -1; + if (client_.CheckReconnect() && EnsureStateAllocated()) + return client_.GetChannel()->PushChannelHandle(state_, handle); + return ErrorStatus{ESHUTDOWN}; } -ChannelReference Transaction::PushChannelHandle( +Status<ChannelReference> Transaction::PushChannelHandle( const BorrowedChannelHandle& handle) { - return client_.CheckReconnect() && EnsureStateAllocated() - ? client_.GetChannel()->PushChannelHandle(state_, handle) - : -1; + if (client_.CheckReconnect() && EnsureStateAllocated()) + return client_.GetChannel()->PushChannelHandle(state_, handle); + return ErrorStatus{ESHUTDOWN}; } -ChannelReference Transaction::PushChannelHandle( +Status<ChannelReference> Transaction::PushChannelHandle( const RemoteChannelHandle& handle) { return handle.value(); } diff --git a/libs/vr/libpdx/client_tests.cpp b/libs/vr/libpdx/client_tests.cpp index f1fb6d1143..99ccc698c4 100644 --- a/libs/vr/libpdx/client_tests.cpp +++ b/libs/vr/libpdx/client_tests.cpp @@ -518,28 +518,29 @@ TEST_F(ClientTransactionTest, PushHandle) { EXPECT_CALL(*mock_channel(), PushFileHandle(kTransactionState, A<const LocalHandle&>())) .WillOnce(Return(1)); - EXPECT_EQ(1, transaction_.PushFileHandle(LocalHandle{-1})); + EXPECT_EQ(1, transaction_.PushFileHandle(LocalHandle{-1}).get()); EXPECT_CALL(*mock_channel(), PushFileHandle(kTransactionState, A<const BorrowedHandle&>())) .WillOnce(Return(2)); - EXPECT_EQ(2, transaction_.PushFileHandle(BorrowedHandle{-1})); + EXPECT_EQ(2, transaction_.PushFileHandle(BorrowedHandle{-1}).get()); - EXPECT_EQ(3, transaction_.PushFileHandle(RemoteHandle{3})); + EXPECT_EQ(3, transaction_.PushFileHandle(RemoteHandle{3}).get()); EXPECT_CALL( *mock_channel(), PushChannelHandle(kTransactionState, A<const LocalChannelHandle&>())) .WillOnce(Return(11)); - EXPECT_EQ(11, transaction_.PushChannelHandle(LocalChannelHandle{nullptr, 1})); + EXPECT_EQ( + 11, transaction_.PushChannelHandle(LocalChannelHandle{nullptr, 1}).get()); EXPECT_CALL( *mock_channel(), PushChannelHandle(kTransactionState, A<const BorrowedChannelHandle&>())) .WillOnce(Return(12)); - EXPECT_EQ(12, transaction_.PushChannelHandle(BorrowedChannelHandle{2})); + EXPECT_EQ(12, transaction_.PushChannelHandle(BorrowedChannelHandle{2}).get()); - EXPECT_EQ(13, transaction_.PushChannelHandle(RemoteChannelHandle{13})); + EXPECT_EQ(13, transaction_.PushChannelHandle(RemoteChannelHandle{13}).get()); } TEST_F(ClientTransactionTest, GetHandle) { diff --git a/libs/vr/libpdx/errno_guard.h b/libs/vr/libpdx/errno_guard.h deleted file mode 100644 index fc7dfdf4fd..0000000000 --- a/libs/vr/libpdx/errno_guard.h +++ /dev/null @@ -1,34 +0,0 @@ -#ifndef ANDROID_PDX_ERRNO_GUARD_H_ -#define ANDROID_PDX_ERRNO_GUARD_H_ - -#include <errno.h> - -namespace android { -namespace pdx { - -// Automatically saves and restores the system errno for API implementations to -// prevent internal use errno from affecting API callers. -class ErrnoGuard { - public: - ErrnoGuard() : saved_errno_(errno) {} - ~ErrnoGuard() { errno = saved_errno_; } - - int saved_errno() const { return saved_errno_; } - - private: - int saved_errno_; - - ErrnoGuard(const ErrnoGuard&) = delete; - void operator=(const ErrnoGuard&) = delete; -}; - -// Checks |return_code| and returns either it or the negated system errno based -// on the return code value. -inline int ReturnCodeOrError(int return_code) { - return return_code < 0 ? -errno : return_code; -} - -} // namespace pdx -} // namespace android - -#endif // ANDROID_PDX_ERRNO_GUARD_H_ diff --git a/libs/vr/libpdx/private/pdx/client.h b/libs/vr/libpdx/private/pdx/client.h index a590087497..656de7e2ca 100644 --- a/libs/vr/libpdx/private/pdx/client.h +++ b/libs/vr/libpdx/private/pdx/client.h @@ -253,13 +253,14 @@ class Transaction final : public OutputResourceMapper, } // OutputResourceMapper - FileReference PushFileHandle(const LocalHandle& handle) override; - FileReference PushFileHandle(const BorrowedHandle& handle) override; - FileReference PushFileHandle(const RemoteHandle& handle) override; - ChannelReference PushChannelHandle(const LocalChannelHandle& handle) override; - ChannelReference PushChannelHandle( + Status<FileReference> PushFileHandle(const LocalHandle& handle) override; + Status<FileReference> PushFileHandle(const BorrowedHandle& handle) override; + Status<FileReference> PushFileHandle(const RemoteHandle& handle) override; + Status<ChannelReference> PushChannelHandle( + const LocalChannelHandle& handle) override; + Status<ChannelReference> PushChannelHandle( const BorrowedChannelHandle& handle) override; - ChannelReference PushChannelHandle( + Status<ChannelReference> PushChannelHandle( const RemoteChannelHandle& handle) override; // InputResourceMapper diff --git a/libs/vr/libpdx/private/pdx/message_writer.h b/libs/vr/libpdx/private/pdx/message_writer.h index 0cb6e4064f..4a101d6806 100644 --- a/libs/vr/libpdx/private/pdx/message_writer.h +++ b/libs/vr/libpdx/private/pdx/message_writer.h @@ -3,20 +3,22 @@ #include <pdx/channel_handle.h> #include <pdx/file_handle.h> +#include <pdx/status.h> namespace android { namespace pdx { class OutputResourceMapper { public: - virtual FileReference PushFileHandle(const LocalHandle& handle) = 0; - virtual FileReference PushFileHandle(const BorrowedHandle& handle) = 0; - virtual FileReference PushFileHandle(const RemoteHandle& handle) = 0; - virtual ChannelReference PushChannelHandle( + virtual Status<FileReference> PushFileHandle(const LocalHandle& handle) = 0; + virtual Status<FileReference> PushFileHandle( + const BorrowedHandle& handle) = 0; + virtual Status<FileReference> PushFileHandle(const RemoteHandle& handle) = 0; + virtual Status<ChannelReference> PushChannelHandle( const LocalChannelHandle& handle) = 0; - virtual ChannelReference PushChannelHandle( + virtual Status<ChannelReference> PushChannelHandle( const BorrowedChannelHandle& handle) = 0; - virtual ChannelReference PushChannelHandle( + virtual Status<ChannelReference> PushChannelHandle( const RemoteChannelHandle& handle) = 0; protected: diff --git a/libs/vr/libpdx/private/pdx/mock_message_writer.h b/libs/vr/libpdx/private/pdx/mock_message_writer.h index 3c513d7e5a..e06e5bbc2b 100644 --- a/libs/vr/libpdx/private/pdx/mock_message_writer.h +++ b/libs/vr/libpdx/private/pdx/mock_message_writer.h @@ -9,15 +9,18 @@ namespace pdx { class MockOutputResourceMapper : public OutputResourceMapper { public: - MOCK_METHOD1(PushFileHandle, FileReference(const LocalHandle& handle)); - MOCK_METHOD1(PushFileHandle, FileReference(const BorrowedHandle& handle)); - MOCK_METHOD1(PushFileHandle, FileReference(const RemoteHandle& handle)); + MOCK_METHOD1(PushFileHandle, + Status<FileReference>(const LocalHandle& handle)); + MOCK_METHOD1(PushFileHandle, + Status<FileReference>(const BorrowedHandle& handle)); + MOCK_METHOD1(PushFileHandle, + Status<FileReference>(const RemoteHandle& handle)); MOCK_METHOD1(PushChannelHandle, - ChannelReference(const LocalChannelHandle& handle)); + Status<ChannelReference>(const LocalChannelHandle& handle)); MOCK_METHOD1(PushChannelHandle, - ChannelReference(const BorrowedChannelHandle& handle)); + Status<ChannelReference>(const BorrowedChannelHandle& handle)); MOCK_METHOD1(PushChannelHandle, - ChannelReference(const RemoteChannelHandle& handle)); + Status<ChannelReference>(const RemoteChannelHandle& handle)); }; class MockMessageWriter : public MessageWriter { diff --git a/libs/vr/libpdx/private/pdx/mock_service_endpoint.h b/libs/vr/libpdx/private/pdx/mock_service_endpoint.h index ead74d561f..e741d4a46b 100644 --- a/libs/vr/libpdx/private/pdx/mock_service_endpoint.h +++ b/libs/vr/libpdx/private/pdx/mock_service_endpoint.h @@ -10,46 +10,54 @@ namespace pdx { class MockEndpoint : public Endpoint { public: MOCK_CONST_METHOD0(GetIpcTag, uint32_t()); - MOCK_METHOD1(SetService, int(Service* service)); - MOCK_METHOD2(SetChannel, int(int channel_id, Channel* channel)); - MOCK_METHOD1(CloseChannel, int(int channel_id)); + MOCK_METHOD1(SetService, Status<void>(Service* service)); + MOCK_METHOD2(SetChannel, Status<void>(int channel_id, Channel* channel)); + MOCK_METHOD1(CloseChannel, Status<void>(int channel_id)); MOCK_METHOD3(ModifyChannelEvents, - int(int channel_id, int clear_mask, int set_mask)); + Status<void>(int channel_id, int clear_mask, int set_mask)); MOCK_METHOD4(PushChannel, Status<RemoteChannelHandle>(Message* message, int flags, Channel* channel, int* channel_id)); MOCK_METHOD3(CheckChannel, Status<int>(const Message* message, ChannelReference ref, Channel** channel)); - MOCK_METHOD1(DefaultHandleMessage, int(const MessageInfo& info)); - MOCK_METHOD1(MessageReceive, int(Message* message)); - MOCK_METHOD2(MessageReply, int(Message* message, int return_code)); - MOCK_METHOD2(MessageReplyFd, int(Message* message, unsigned int push_fd)); + MOCK_METHOD1(MessageReceive, Status<void>(Message* message)); + MOCK_METHOD2(MessageReply, Status<void>(Message* message, int return_code)); + MOCK_METHOD2(MessageReplyFd, + Status<void>(Message* message, unsigned int push_fd)); MOCK_METHOD2(MessageReplyChannelHandle, - int(Message* message, const LocalChannelHandle& handle)); + Status<void>(Message* message, + const LocalChannelHandle& handle)); MOCK_METHOD2(MessageReplyChannelHandle, - int(Message* message, const BorrowedChannelHandle& handle)); + Status<void>(Message* message, + const BorrowedChannelHandle& handle)); MOCK_METHOD2(MessageReplyChannelHandle, - int(Message* message, const RemoteChannelHandle& handle)); - MOCK_METHOD3(ReadMessageData, ssize_t(Message* message, const iovec* vector, - size_t vector_length)); - MOCK_METHOD3(WriteMessageData, ssize_t(Message* message, const iovec* vector, - size_t vector_length)); + Status<void>(Message* message, + const RemoteChannelHandle& handle)); + MOCK_METHOD3(ReadMessageData, + Status<size_t>(Message* message, const iovec* vector, + size_t vector_length)); + MOCK_METHOD3(WriteMessageData, + Status<size_t>(Message* message, const iovec* vector, + size_t vector_length)); MOCK_METHOD2(PushFileHandle, - FileReference(Message* message, const LocalHandle& handle)); + Status<FileReference>(Message* message, + const LocalHandle& handle)); MOCK_METHOD2(PushFileHandle, - FileReference(Message* message, const BorrowedHandle& handle)); + Status<FileReference>(Message* message, + const BorrowedHandle& handle)); MOCK_METHOD2(PushFileHandle, - FileReference(Message* message, const RemoteHandle& handle)); + Status<FileReference>(Message* message, + const RemoteHandle& handle)); MOCK_METHOD2(PushChannelHandle, - ChannelReference(Message* message, - const LocalChannelHandle& handle)); + Status<ChannelReference>(Message* message, + const LocalChannelHandle& handle)); MOCK_METHOD2(PushChannelHandle, - ChannelReference(Message* message, - const BorrowedChannelHandle& handle)); + Status<ChannelReference>(Message* message, + const BorrowedChannelHandle& handle)); MOCK_METHOD2(PushChannelHandle, - ChannelReference(Message* message, - const RemoteChannelHandle& handle)); + Status<ChannelReference>(Message* message, + const RemoteChannelHandle& handle)); MOCK_CONST_METHOD2(GetFileHandle, LocalHandle(Message* message, FileReference ref)); MOCK_CONST_METHOD2(GetChannelHandle, @@ -57,7 +65,7 @@ class MockEndpoint : public Endpoint { ChannelReference ref)); MOCK_METHOD0(AllocateMessageState, void*()); MOCK_METHOD1(FreeMessageState, void(void* state)); - MOCK_METHOD0(Cancel, int()); + MOCK_METHOD0(Cancel, Status<void>()); }; } // namespace pdx diff --git a/libs/vr/libpdx/private/pdx/rpc/remote_method.h b/libs/vr/libpdx/private/pdx/rpc/remote_method.h index 3eca9e5f10..505c63b1bf 100644 --- a/libs/vr/libpdx/private/pdx/rpc/remote_method.h +++ b/libs/vr/libpdx/private/pdx/rpc/remote_method.h @@ -121,9 +121,9 @@ class UnpackArguments<Class, Return(Args...)> { // either during dispatch of the remote method handler or at a later time if the // message is moved for delayed response. inline void RemoteMethodError(Message& message, int error_code) { - const int ret = message.ReplyError(error_code); - ALOGE_IF(ret < 0, "RemoteMethodError: Failed to reply to message: %s", - strerror(-ret)); + const auto status = message.ReplyError(error_code); + ALOGE_IF(!status, "RemoteMethodError: Failed to reply to message: %s", + status.GetErrorMessage().c_str()); } // Returns a value from a remote method to the client. The usual method to @@ -135,9 +135,9 @@ inline void RemoteMethodError(Message& message, int error_code) { template <typename RemoteMethodType, typename Return> EnableIfDirectReturn<typename RemoteMethodType::Return> RemoteMethodReturn( Message& message, const Return& return_value) { - const int ret = message.Reply(return_value); - ALOGE_IF(ret < 0, "RemoteMethodReturn: Failed to reply to message: %s", - strerror(-ret)); + const auto status = message.Reply(return_value); + ALOGE_IF(!status, "RemoteMethodReturn: Failed to reply to message: %s", + status.GetErrorMessage().c_str()); } // Overload for non-direct return types. @@ -148,14 +148,10 @@ EnableIfNotDirectReturn<typename RemoteMethodType::Return> RemoteMethodReturn( rpc::ServicePayload<ReplyBuffer> payload(message); MakeArgumentEncoder<Signature>(&payload).EncodeReturn(return_value); - int ret; - auto size = message.Write(payload.Data(), payload.Size()); - if (size < static_cast<decltype(size)>(payload.Size())) - ret = message.ReplyError(EIO); - else - ret = message.Reply(0); - ALOGE_IF(ret < 0, "RemoteMethodReturn: Failed to reply to message: %s", - strerror(-ret)); + auto ret = message.WriteAll(payload.Data(), payload.Size()); + auto status = message.Reply(ret); + ALOGE_IF(!status, "RemoteMethodReturn: Failed to reply to message: %s", + status.GetErrorMessage().c_str()); } // Overload for Status<void> return types. @@ -189,13 +185,13 @@ void DispatchRemoteMethod(Class& instance, rpc::ServicePayload<ReceiveBuffer> payload(message); payload.Resize(max_capacity); - auto size = message.Read(payload.Data(), payload.Size()); - if (size < 0) { - RemoteMethodError(message, -size); + Status<size_t> read_status = message.Read(payload.Data(), payload.Size()); + if (!read_status) { + RemoteMethodError(message, read_status.error()); return; } - payload.Resize(size); + payload.Resize(read_status.get()); ErrorType error; auto decoder = MakeArgumentDecoder<Signature>(&payload); @@ -225,13 +221,13 @@ void DispatchRemoteMethod(Class& instance, rpc::ServicePayload<ReceiveBuffer> payload(message); payload.Resize(max_capacity); - auto size = message.Read(payload.Data(), payload.Size()); - if (size < 0) { - RemoteMethodError(message, -size); + Status<size_t> read_status = message.Read(payload.Data(), payload.Size()); + if (!read_status) { + RemoteMethodError(message, read_status.error()); return; } - payload.Resize(size); + payload.Resize(read_status.get()); ErrorType error; auto decoder = MakeArgumentDecoder<Signature>(&payload); @@ -265,13 +261,13 @@ void DispatchRemoteMethod(Class& instance, rpc::ServicePayload<ReceiveBuffer> payload(message); payload.Resize(max_capacity); - auto size = message.Read(payload.Data(), payload.Size()); - if (size < 0) { - RemoteMethodError(message, -size); + Status<size_t> read_status = message.Read(payload.Data(), payload.Size()); + if (!read_status) { + RemoteMethodError(message, read_status.error()); return; } - payload.Resize(size); + payload.Resize(read_status.get()); ErrorType error; auto decoder = MakeArgumentDecoder<Signature>(&payload); diff --git a/libs/vr/libpdx/private/pdx/rpc/serialization.h b/libs/vr/libpdx/private/pdx/rpc/serialization.h index fccd028336..9a012ede7d 100644 --- a/libs/vr/libpdx/private/pdx/rpc/serialization.h +++ b/libs/vr/libpdx/private/pdx/rpc/serialization.h @@ -905,8 +905,9 @@ template <FileHandleMode Mode> inline void SerializeObject(const FileHandle<Mode>& fd, MessageWriter* writer, void*& buffer) { SerializeType(fd, buffer); - const FileReference value = + const Status<FileReference> status = writer->GetOutputResourceMapper()->PushFileHandle(fd); + FileReference value = status ? status.get() : -status.error(); SerializeRaw(value, buffer); } @@ -915,8 +916,9 @@ template <ChannelHandleMode Mode> inline void SerializeObject(const ChannelHandle<Mode>& handle, MessageWriter* writer, void*& buffer) { SerializeType(handle, buffer); - const ChannelReference value = + const Status<ChannelReference> status = writer->GetOutputResourceMapper()->PushChannelHandle(handle); + ChannelReference value = status ? status.get() : -status.error(); SerializeRaw(value, buffer); } diff --git a/libs/vr/libpdx/private/pdx/service.h b/libs/vr/libpdx/private/pdx/service.h index 175cedfb16..0d30614562 100644 --- a/libs/vr/libpdx/private/pdx/service.h +++ b/libs/vr/libpdx/private/pdx/service.h @@ -98,29 +98,62 @@ class Message : public OutputResourceMapper, public InputResourceMapper { /* * Read/write payload, in either single buffer or iovec form. */ - ssize_t ReadVector(const iovec* vector, size_t vector_length); - ssize_t Read(void* buffer, size_t length); - ssize_t WriteVector(const iovec* vector, size_t vector_length); - ssize_t Write(const void* buffer, size_t length); + Status<size_t> ReadVector(const iovec* vector, size_t vector_length); + Status<size_t> Read(void* buffer, size_t length); + Status<size_t> WriteVector(const iovec* vector, size_t vector_length); + Status<size_t> Write(const void* buffer, size_t length); template <size_t N> - inline ssize_t ReadVector(const iovec (&vector)[N]) { + inline Status<size_t> ReadVector(const iovec (&vector)[N]) { return ReadVector(vector, N); } template <size_t N> - inline ssize_t WriteVector(const iovec (&vector)[N]) { + inline Status<size_t> WriteVector(const iovec (&vector)[N]) { return WriteVector(vector, N); } + // Helper functions to read/write all requested bytes, and return EIO if not + // all were read/written. + Status<void> ReadVectorAll(const iovec* vector, size_t vector_length); + Status<void> WriteVectorAll(const iovec* vector, size_t vector_length); + + inline Status<void> ReadAll(void* buffer, size_t length) { + Status<size_t> status = Read(buffer, length); + if (status && status.get() < length) + status.SetError(EIO); + Status<void> ret; + ret.PropagateError(status); + return ret; + } + inline Status<void> WriteAll(const void* buffer, size_t length) { + Status<size_t> status = Write(buffer, length); + if (status && status.get() < length) + status.SetError(EIO); + Status<void> ret; + ret.PropagateError(status); + return ret; + } + + template <size_t N> + inline Status<void> ReadVectorAll(const iovec (&vector)[N]) { + return ReadVectorAll(vector, N); + } + + template <size_t N> + inline Status<void> WriteVectorAll(const iovec (&vector)[N]) { + return WriteVectorAll(vector, N); + } + // OutputResourceMapper - FileReference PushFileHandle(const LocalHandle& handle) override; - FileReference PushFileHandle(const BorrowedHandle& handle) override; - FileReference PushFileHandle(const RemoteHandle& handle) override; - ChannelReference PushChannelHandle(const LocalChannelHandle& handle) override; - ChannelReference PushChannelHandle( + Status<FileReference> PushFileHandle(const LocalHandle& handle) override; + Status<FileReference> PushFileHandle(const BorrowedHandle& handle) override; + Status<FileReference> PushFileHandle(const RemoteHandle& handle) override; + Status<ChannelReference> PushChannelHandle( + const LocalChannelHandle& handle) override; + Status<ChannelReference> PushChannelHandle( const BorrowedChannelHandle& handle) override; - ChannelReference PushChannelHandle( + Status<ChannelReference> PushChannelHandle( const RemoteChannelHandle& handle) override; // InputResourceMapper @@ -131,25 +164,29 @@ class Message : public OutputResourceMapper, public InputResourceMapper { /* * Various ways to reply to a message. */ - int Reply(int return_code); - int ReplyError(unsigned error); - int ReplyFileDescriptor(unsigned int fd); - int Reply(const LocalHandle& handle); - int Reply(const BorrowedHandle& handle); - int Reply(const RemoteHandle& handle); - int Reply(const LocalChannelHandle& handle); - int Reply(const BorrowedChannelHandle& handle); - int Reply(const RemoteChannelHandle& handle); + Status<void> Reply(int return_code); + Status<void> ReplyError(unsigned int error); + Status<void> ReplyFileDescriptor(unsigned int fd); + Status<void> Reply(const LocalHandle& handle); + Status<void> Reply(const BorrowedHandle& handle); + Status<void> Reply(const RemoteHandle& handle); + Status<void> Reply(const LocalChannelHandle& handle); + Status<void> Reply(const BorrowedChannelHandle& handle); + Status<void> Reply(const RemoteChannelHandle& handle); template <typename T> - inline int Reply(const Status<T>& status) { + inline Status<void> Reply(const Status<T>& status) { return status ? Reply(status.get()) : ReplyError(status.error()); } + inline Status<void> Reply(const Status<void>& status) { + return status ? Reply(0) : ReplyError(status.error()); + } + /* * Update the channel event bits with the given clear and set masks. */ - int ModifyChannelEvents(int clear_mask, int set_mask); + Status<void> ModifyChannelEvents(int clear_mask, int set_mask); /* * Create a new channel and push it as a file descriptor to the client. See @@ -264,7 +301,7 @@ class Message : public OutputResourceMapper, public InputResourceMapper { * these in multi-threaded services. */ std::shared_ptr<Channel> GetChannel() const; - void SetChannel(const std::shared_ptr<Channel>& channnel); + Status<void> SetChannel(const std::shared_ptr<Channel>& channnel); /* * Get the Channel object for the channel associated with this message, @@ -355,7 +392,8 @@ class Service : public std::enable_shared_from_this<Service> { * the Channel object until the channel is closed or another call replaces * the current value. */ - int SetChannel(int channel_id, const std::shared_ptr<Channel>& channel); + Status<void> SetChannel(int channel_id, + const std::shared_ptr<Channel>& channel); /* * Get the channel context for the given channel id. This method should be @@ -404,7 +442,7 @@ class Service : public std::enable_shared_from_this<Service> { * * OnChannelClosed is not called in response to this method call. */ - int CloseChannel(int channel_id); + Status<void> CloseChannel(int channel_id); /* * Update the event bits for the given channel (given by id), using the @@ -413,7 +451,8 @@ class Service : public std::enable_shared_from_this<Service> { * This is useful for asynchronously signaling events that clients may be * waiting for using select/poll/epoll. */ - int ModifyChannelEvents(int channel_id, int clear_mask, int set_mask); + Status<void> ModifyChannelEvents(int channel_id, int clear_mask, + int set_mask); /* * Create a new channel and push it as a file descriptor to the process @@ -478,7 +517,7 @@ class Service : public std::enable_shared_from_this<Service> { * The default implementation simply calls defaultHandleMessage(). * Subclasses should call the same for any unrecognized message opcodes. */ - virtual int HandleMessage(Message& message); + virtual Status<void> HandleMessage(Message& message); /* * Handle an asynchronous message. Subclasses override this to receive @@ -496,9 +535,9 @@ class Service : public std::enable_shared_from_this<Service> { * Provides default handling of CHANNEL_OPEN and CHANNEL_CLOSE, calling * OnChannelOpen() and OnChannelClose(), respectively. * - * For all other message opcodes, this method replies with -ENOTSUP. + * For all other message opcodes, this method replies with ENOTSUP. */ - int DefaultHandleMessage(Message& message); + Status<void> DefaultHandleMessage(Message& message); /* * Called when system properties have changed. Subclasses should implement @@ -515,7 +554,7 @@ class Service : public std::enable_shared_from_this<Service> { * Cancels the endpoint, unblocking any receiver threads waiting in * ReceiveAndDispatch(). */ - int Cancel(); + Status<void> Cancel(); /* * Iterator type for Channel map iterators. @@ -564,14 +603,14 @@ class Service : public std::enable_shared_from_this<Service> { * If the endpoint is in blocking mode this call blocks until a message is * received, a signal is delivered to this thread, or the service is canceled. * If the endpoint is in non-blocking mode and a message is not pending this - * call returns immediately with -ETIMEDOUT. + * call returns immediately with ETIMEDOUT. */ - int ReceiveAndDispatch(); + Status<void> ReceiveAndDispatch(); private: friend class Message; - bool HandleSystemMessage(Message& message); + Status<void> HandleSystemMessage(Message& message); Service(const Service&); void operator=(const Service&) = delete; @@ -639,28 +678,28 @@ class ServiceBase : public Service { #define REPLY_ERROR(message, error, error_label) \ do { \ - int __ret = message.ReplyError(error); \ - CHECK_ERROR(__ret < 0, error_label, \ + auto __status = message.ReplyError(error); \ + CHECK_ERROR(!__status, error_label, \ PDX_ERROR_PREFIX " Failed to reply to message because: %s\n", \ - strerror(-__ret)); \ + __status.GetErrorMessage().c_str()); \ goto error_label; \ } while (0) #define REPLY_ERROR_RETURN(message, error, ...) \ do { \ - int __ret = message.ReplyError(error); \ - ALOGE_IF(__ret < 0, \ + auto __status = message.ReplyError(error); \ + ALOGE_IF(!__status, \ PDX_ERROR_PREFIX " Failed to reply to message because: %s", \ - strerror(-__ret)); \ + __status.GetErrorMessage().c_str()); \ return __VA_ARGS__; \ } while (0) #define REPLY_MESSAGE(message, message_return_code, error_label) \ do { \ - int __ret = message.Reply(message_return_code); \ - CHECK_ERROR(__ret < 0, error_label, \ + auto __status = message.Reply(message_return_code); \ + CHECK_ERROR(!__status, error_label, \ PDX_ERROR_PREFIX " Failed to reply to message because: %s\n", \ - strerror(-__ret)); \ + __status.GetErrorMessage().c_str()); \ goto error_label; \ } while (0) @@ -669,10 +708,10 @@ class ServiceBase : public Service { #define REPLY_MESSAGE_RETURN(message, message_return_code, ...) \ do { \ - int __ret = message.Reply(message_return_code); \ - ALOGE_IF(__ret < 0, \ + auto __status = message.Reply(message_return_code); \ + ALOGE_IF(!__status, \ PDX_ERROR_PREFIX " Failed to reply to message because: %s", \ - strerror(-__ret)); \ + __status.GetErrorMessage().c_str()); \ return __VA_ARGS__; \ } while (0) @@ -681,19 +720,19 @@ class ServiceBase : public Service { #define REPLY_FD(message, push_fd, error_label) \ do { \ - int __ret = message.ReplyFileDescriptor(push_fd); \ - CHECK_ERROR(__ret < 0, error_label, \ + auto __status = message.ReplyFileDescriptor(push_fd); \ + CHECK_ERROR(!__status, error_label, \ PDX_ERROR_PREFIX " Failed to reply to message because: %s\n", \ - strerror(-__ret)); \ + __status.GetErrorMessage().c_str()); \ goto error_label; \ } while (0) #define REPLY_FD_RETURN(message, push_fd, ...) \ do { \ - int __ret = message.ReplyFileDescriptor(push_fd); \ - ALOGE_IF(__ret < 0, \ + auto __status = message.ReplyFileDescriptor(push_fd); \ + ALOGE_IF(__status < 0, \ PDX_ERROR_PREFIX " Failed to reply to message because: %s", \ - strerror(-__ret)); \ + __status.GetErrorMessage().c_str()); \ return __VA_ARGS__; \ } while (0) diff --git a/libs/vr/libpdx/private/pdx/service_endpoint.h b/libs/vr/libpdx/private/pdx/service_endpoint.h index 613be7c9fa..28bd6bc454 100644 --- a/libs/vr/libpdx/private/pdx/service_endpoint.h +++ b/libs/vr/libpdx/private/pdx/service_endpoint.h @@ -44,20 +44,20 @@ class Endpoint { // Associates a Service instance with an endpoint by setting the service // context pointer to the address of the Service. Only one Service may be // associated with a given endpoint. - virtual int SetService(Service* service) = 0; + virtual Status<void> SetService(Service* service) = 0; // Set the channel context for the given channel. - virtual int SetChannel(int channel_id, Channel* channel) = 0; + virtual Status<void> SetChannel(int channel_id, Channel* channel) = 0; // Close a channel, signaling the client file object and freeing the channel // id. Once closed, the client side of the channel always returns the error // ESHUTDOWN and signals the poll/epoll events POLLHUP and POLLFREE. - virtual int CloseChannel(int channel_id) = 0; + virtual Status<void> CloseChannel(int channel_id) = 0; // Update the event bits for the given channel (given by id), using the // given clear and set masks. - virtual int ModifyChannelEvents(int channel_id, int clear_mask, - int set_mask) = 0; + virtual Status<void> ModifyChannelEvents(int channel_id, int clear_mask, + int set_mask) = 0; // Create a new channel and push it as a file descriptor to the process // sending the |message|. |flags| may be set to O_NONBLOCK and/or @@ -77,54 +77,49 @@ class Endpoint { virtual Status<int> CheckChannel(const Message* message, ChannelReference ref, Channel** channel) = 0; - // The default message handler. It is important that all messages - // (eventually) get a reply. This method should be called for any unrecognized - // opcodes or otherwise unhandled messages to prevent erroneous requests from - // blocking indefinitely. - virtual int DefaultHandleMessage(const MessageInfo& info) = 0; - // Receives a message on the given endpoint file descriptor. - virtual int MessageReceive(Message* message) = 0; + virtual Status<void> MessageReceive(Message* message) = 0; // Replies to the message with a return code. - virtual int MessageReply(Message* message, int return_code) = 0; + virtual Status<void> MessageReply(Message* message, int return_code) = 0; // Replies to the message with a file descriptor. - virtual int MessageReplyFd(Message* message, unsigned int push_fd) = 0; + virtual Status<void> MessageReplyFd(Message* message, + unsigned int push_fd) = 0; // Replies to the message with a local channel handle. - virtual int MessageReplyChannelHandle(Message* message, - const LocalChannelHandle& handle) = 0; + virtual Status<void> MessageReplyChannelHandle( + Message* message, const LocalChannelHandle& handle) = 0; // Replies to the message with a borrowed local channel handle. - virtual int MessageReplyChannelHandle( + virtual Status<void> MessageReplyChannelHandle( Message* message, const BorrowedChannelHandle& handle) = 0; // Replies to the message with a remote channel handle. - virtual int MessageReplyChannelHandle(Message* message, - const RemoteChannelHandle& handle) = 0; + virtual Status<void> MessageReplyChannelHandle( + Message* message, const RemoteChannelHandle& handle) = 0; // Reads message data into an array of memory buffers. - virtual ssize_t ReadMessageData(Message* message, const iovec* vector, - size_t vector_length) = 0; + virtual Status<size_t> ReadMessageData(Message* message, const iovec* vector, + size_t vector_length) = 0; // Sends reply data for message. - virtual ssize_t WriteMessageData(Message* message, const iovec* vector, - size_t vector_length) = 0; + virtual Status<size_t> WriteMessageData(Message* message, const iovec* vector, + size_t vector_length) = 0; // Records a file descriptor into the message buffer and returns the remapped // reference to be sent to the remote process. - virtual FileReference PushFileHandle(Message* message, - const LocalHandle& handle) = 0; - virtual FileReference PushFileHandle(Message* message, - const BorrowedHandle& handle) = 0; - virtual FileReference PushFileHandle(Message* message, - const RemoteHandle& handle) = 0; - virtual ChannelReference PushChannelHandle( + virtual Status<FileReference> PushFileHandle(Message* message, + const LocalHandle& handle) = 0; + virtual Status<FileReference> PushFileHandle( + Message* message, const BorrowedHandle& handle) = 0; + virtual Status<FileReference> PushFileHandle(Message* message, + const RemoteHandle& handle) = 0; + virtual Status<ChannelReference> PushChannelHandle( Message* message, const LocalChannelHandle& handle) = 0; - virtual ChannelReference PushChannelHandle( + virtual Status<ChannelReference> PushChannelHandle( Message* message, const BorrowedChannelHandle& handle) = 0; - virtual ChannelReference PushChannelHandle( + virtual Status<ChannelReference> PushChannelHandle( Message* message, const RemoteChannelHandle& handle) = 0; // Obtains a file descriptor/channel handle from a message for the given @@ -140,7 +135,7 @@ class Endpoint { // Cancels the endpoint, unblocking any receiver threads waiting for a // message. - virtual int Cancel() = 0; + virtual Status<void> Cancel() = 0; }; } // namespace pdx diff --git a/libs/vr/libpdx/private/pdx/status.h b/libs/vr/libpdx/private/pdx/status.h index ca2832c2a5..067fe25e9c 100644 --- a/libs/vr/libpdx/private/pdx/status.h +++ b/libs/vr/libpdx/private/pdx/status.h @@ -103,6 +103,17 @@ class Status { // is not empty nor containing a valid value). int error() const { return std::max(error_, 0); } + // Returns the error code as ErrorStatus object. This is a helper method + // to aid in propagation of error codes between Status<T> of different types + // as in the following example: + // Status<int> foo() { + // Status<void> status = bar(); + // if(!status) + // return status.error_status(); + // return 12; + // } + inline ErrorStatus error_status() const { return ErrorStatus{error()}; } + // Returns the error message associated with error code stored in the object. // The message is the same as the string returned by strerror(status.error()). // Can be called only when an error is actually stored (that is, the object @@ -142,6 +153,7 @@ class Status<void> { bool empty() const { return false; } explicit operator bool() const { return ok(); } int error() const { return std::max(error_, 0); } + inline ErrorStatus error_status() const { return ErrorStatus{error()}; } std::string GetErrorMessage() const { std::string message; if (error_ > 0) diff --git a/libs/vr/libpdx/private/pdx/utility.h b/libs/vr/libpdx/private/pdx/utility.h index c8c717cb65..305c3b87a4 100644 --- a/libs/vr/libpdx/private/pdx/utility.h +++ b/libs/vr/libpdx/private/pdx/utility.h @@ -150,29 +150,29 @@ inline R GetNTuple(T value) { class NoOpOutputResourceMapper : public OutputResourceMapper { public: - FileReference PushFileHandle(const LocalHandle& handle) override { + Status<FileReference> PushFileHandle(const LocalHandle& handle) override { return handle.Get(); } - FileReference PushFileHandle(const BorrowedHandle& handle) override { + Status<FileReference> PushFileHandle(const BorrowedHandle& handle) override { return handle.Get(); } - FileReference PushFileHandle(const RemoteHandle& handle) override { + Status<FileReference> PushFileHandle(const RemoteHandle& handle) override { return handle.Get(); } - ChannelReference PushChannelHandle( + Status<ChannelReference> PushChannelHandle( const LocalChannelHandle& handle) override { return handle.value(); } - ChannelReference PushChannelHandle( + Status<ChannelReference> PushChannelHandle( const BorrowedChannelHandle& handle) override { return handle.value(); } - ChannelReference PushChannelHandle( + Status<ChannelReference> PushChannelHandle( const RemoteChannelHandle& handle) override { return handle.value(); } @@ -278,7 +278,7 @@ class Payload : public MessageWriter, OutputResourceMapper* GetOutputResourceMapper() override { return this; } // OutputResourceMapper - FileReference PushFileHandle(const LocalHandle& handle) override { + Status<FileReference> PushFileHandle(const LocalHandle& handle) override { if (handle) { const int ref = file_handles_.size(); file_handles_.push_back(handle.Get()); @@ -288,7 +288,7 @@ class Payload : public MessageWriter, } } - FileReference PushFileHandle(const BorrowedHandle& handle) override { + Status<FileReference> PushFileHandle(const BorrowedHandle& handle) override { if (handle) { const int ref = file_handles_.size(); file_handles_.push_back(handle.Get()); @@ -298,11 +298,11 @@ class Payload : public MessageWriter, } } - FileReference PushFileHandle(const RemoteHandle& handle) override { + Status<FileReference> PushFileHandle(const RemoteHandle& handle) override { return handle.Get(); } - ChannelReference PushChannelHandle( + Status<ChannelReference> PushChannelHandle( const LocalChannelHandle& handle) override { if (handle) { const int ref = file_handles_.size(); @@ -313,7 +313,7 @@ class Payload : public MessageWriter, } } - ChannelReference PushChannelHandle( + Status<ChannelReference> PushChannelHandle( const BorrowedChannelHandle& handle) override { if (handle) { const int ref = file_handles_.size(); @@ -324,7 +324,7 @@ class Payload : public MessageWriter, } } - ChannelReference PushChannelHandle( + Status<ChannelReference> PushChannelHandle( const RemoteChannelHandle& handle) override { return handle.value(); } diff --git a/libs/vr/libpdx/service.cpp b/libs/vr/libpdx/service.cpp index daf9af89ed..fab4770b7f 100644 --- a/libs/vr/libpdx/service.cpp +++ b/libs/vr/libpdx/service.cpp @@ -9,7 +9,6 @@ #include <cstdint> #include <pdx/trace.h> -#include "errno_guard.h" #define TRACE 0 @@ -60,7 +59,7 @@ void Message::Destroy() { "ERROR: Service \"%s\" failed to reply to message: op=%d pid=%d " "cid=%d\n", svc->name_.c_str(), info_.op, info_.pid, info_.cid); - svc->endpoint()->DefaultHandleMessage(info_); + svc->DefaultHandleMessage(*this); } svc->endpoint()->FreeMessageState(state_); } @@ -77,112 +76,138 @@ const std::uint8_t* Message::ImpulseEnd() const { return ImpulseBegin() + (IsImpulse() ? GetSendLength() : 0); } -ssize_t Message::ReadVector(const struct iovec* vector, size_t vector_length) { +Status<size_t> Message::ReadVector(const struct iovec* vector, + size_t vector_length) { PDX_TRACE_NAME("Message::ReadVector"); if (auto svc = service_.lock()) { - ErrnoGuard errno_guard; - const ssize_t ret = + return svc->endpoint()->ReadMessageData(this, vector, vector_length); + } else { + return ErrorStatus{ESHUTDOWN}; + } +} + +Status<void> Message::ReadVectorAll(const struct iovec* vector, + size_t vector_length) { + PDX_TRACE_NAME("Message::ReadVectorAll"); + if (auto svc = service_.lock()) { + const auto status = svc->endpoint()->ReadMessageData(this, vector, vector_length); - return ReturnCodeOrError(ret); + if (!status) + return status.error_status(); + size_t size_to_read = 0; + for (size_t i = 0; i < vector_length; i++) + size_to_read += vector[i].iov_len; + if (status.get() < size_to_read) + return ErrorStatus{EIO}; + return {}; } else { - return -ESHUTDOWN; + return ErrorStatus{ESHUTDOWN}; } } -ssize_t Message::Read(void* buffer, size_t length) { +Status<size_t> Message::Read(void* buffer, size_t length) { PDX_TRACE_NAME("Message::Read"); if (auto svc = service_.lock()) { - ErrnoGuard errno_guard; const struct iovec vector = {buffer, length}; - const ssize_t ret = svc->endpoint()->ReadMessageData(this, &vector, 1); - return ReturnCodeOrError(ret); + return svc->endpoint()->ReadMessageData(this, &vector, 1); + } else { + return ErrorStatus{ESHUTDOWN}; + } +} + +Status<size_t> Message::WriteVector(const struct iovec* vector, + size_t vector_length) { + PDX_TRACE_NAME("Message::WriteVector"); + if (auto svc = service_.lock()) { + return svc->endpoint()->WriteMessageData(this, vector, vector_length); } else { - return -ESHUTDOWN; + return ErrorStatus{ESHUTDOWN}; } } -ssize_t Message::WriteVector(const struct iovec* vector, size_t vector_length) { +Status<void> Message::WriteVectorAll(const struct iovec* vector, + size_t vector_length) { PDX_TRACE_NAME("Message::WriteVector"); if (auto svc = service_.lock()) { - ErrnoGuard errno_guard; - const ssize_t ret = + const auto status = svc->endpoint()->WriteMessageData(this, vector, vector_length); - return ReturnCodeOrError(ret); + if (!status) + return status.error_status(); + size_t size_to_write = 0; + for (size_t i = 0; i < vector_length; i++) + size_to_write += vector[i].iov_len; + if (status.get() < size_to_write) + return ErrorStatus{EIO}; + return {}; } else { - return -ESHUTDOWN; + return ErrorStatus{ESHUTDOWN}; } } -ssize_t Message::Write(const void* buffer, size_t length) { +Status<size_t> Message::Write(const void* buffer, size_t length) { PDX_TRACE_NAME("Message::Write"); if (auto svc = service_.lock()) { - ErrnoGuard errno_guard; const struct iovec vector = {const_cast<void*>(buffer), length}; - const ssize_t ret = svc->endpoint()->WriteMessageData(this, &vector, 1); - return ReturnCodeOrError(ret); + return svc->endpoint()->WriteMessageData(this, &vector, 1); } else { - return -ESHUTDOWN; + return ErrorStatus{ESHUTDOWN}; } } -FileReference Message::PushFileHandle(const LocalHandle& handle) { +Status<FileReference> Message::PushFileHandle(const LocalHandle& handle) { PDX_TRACE_NAME("Message::PushFileHandle"); if (auto svc = service_.lock()) { - ErrnoGuard errno_guard; - return ReturnCodeOrError(svc->endpoint()->PushFileHandle(this, handle)); + return svc->endpoint()->PushFileHandle(this, handle); } else { - return -ESHUTDOWN; + return ErrorStatus{ESHUTDOWN}; } } -FileReference Message::PushFileHandle(const BorrowedHandle& handle) { +Status<FileReference> Message::PushFileHandle(const BorrowedHandle& handle) { PDX_TRACE_NAME("Message::PushFileHandle"); if (auto svc = service_.lock()) { - ErrnoGuard errno_guard; - return ReturnCodeOrError(svc->endpoint()->PushFileHandle(this, handle)); + return svc->endpoint()->PushFileHandle(this, handle); } else { - return -ESHUTDOWN; + return ErrorStatus{ESHUTDOWN}; } } -FileReference Message::PushFileHandle(const RemoteHandle& handle) { +Status<FileReference> Message::PushFileHandle(const RemoteHandle& handle) { PDX_TRACE_NAME("Message::PushFileHandle"); if (auto svc = service_.lock()) { - ErrnoGuard errno_guard; - return ReturnCodeOrError(svc->endpoint()->PushFileHandle(this, handle)); + return svc->endpoint()->PushFileHandle(this, handle); } else { - return -ESHUTDOWN; + return ErrorStatus{ESHUTDOWN}; } } -ChannelReference Message::PushChannelHandle(const LocalChannelHandle& handle) { +Status<ChannelReference> Message::PushChannelHandle( + const LocalChannelHandle& handle) { PDX_TRACE_NAME("Message::PushChannelHandle"); if (auto svc = service_.lock()) { - ErrnoGuard errno_guard; - return ReturnCodeOrError(svc->endpoint()->PushChannelHandle(this, handle)); + return svc->endpoint()->PushChannelHandle(this, handle); } else { - return -ESHUTDOWN; + return ErrorStatus{ESHUTDOWN}; } } -ChannelReference Message::PushChannelHandle( +Status<ChannelReference> Message::PushChannelHandle( const BorrowedChannelHandle& handle) { PDX_TRACE_NAME("Message::PushChannelHandle"); if (auto svc = service_.lock()) { - ErrnoGuard errno_guard; - return ReturnCodeOrError(svc->endpoint()->PushChannelHandle(this, handle)); + return svc->endpoint()->PushChannelHandle(this, handle); } else { - return -ESHUTDOWN; + return ErrorStatus{ESHUTDOWN}; } } -ChannelReference Message::PushChannelHandle(const RemoteChannelHandle& handle) { +Status<ChannelReference> Message::PushChannelHandle( + const RemoteChannelHandle& handle) { PDX_TRACE_NAME("Message::PushChannelHandle"); if (auto svc = service_.lock()) { - ErrnoGuard errno_guard; - return ReturnCodeOrError(svc->endpoint()->PushChannelHandle(this, handle)); + return svc->endpoint()->PushChannelHandle(this, handle); } else { - return -ESHUTDOWN; + return ErrorStatus{ESHUTDOWN}; } } @@ -193,7 +218,6 @@ bool Message::GetFileHandle(FileReference ref, LocalHandle* handle) { return false; if (ref >= 0) { - ErrnoGuard errno_guard; *handle = svc->endpoint()->GetFileHandle(this, ref); if (!handle->IsValid()) return false; @@ -211,7 +235,6 @@ bool Message::GetChannelHandle(ChannelReference ref, return false; if (ref >= 0) { - ErrnoGuard errno_guard; *handle = svc->endpoint()->GetChannelHandle(this, ref); if (!handle->valid()) return false; @@ -221,141 +244,137 @@ bool Message::GetChannelHandle(ChannelReference ref, return true; } -int Message::Reply(int return_code) { +Status<void> Message::Reply(int return_code) { PDX_TRACE_NAME("Message::Reply"); auto svc = service_.lock(); if (!replied_ && svc) { - ErrnoGuard errno_guard; - const int ret = svc->endpoint()->MessageReply(this, return_code); - replied_ = ret == 0; - return ReturnCodeOrError(ret); + const auto ret = svc->endpoint()->MessageReply(this, return_code); + replied_ = ret.ok(); + return ret; } else { - return -EINVAL; + return ErrorStatus{EINVAL}; } } -int Message::ReplyFileDescriptor(unsigned int fd) { +Status<void> Message::ReplyFileDescriptor(unsigned int fd) { PDX_TRACE_NAME("Message::ReplyFileDescriptor"); auto svc = service_.lock(); if (!replied_ && svc) { - ErrnoGuard errno_guard; - const int ret = svc->endpoint()->MessageReplyFd(this, fd); - replied_ = ret == 0; - return ReturnCodeOrError(ret); + const auto ret = svc->endpoint()->MessageReplyFd(this, fd); + replied_ = ret.ok(); + return ret; } else { - return -EINVAL; + return ErrorStatus{EINVAL}; } } -int Message::ReplyError(unsigned error) { +Status<void> Message::ReplyError(unsigned int error) { PDX_TRACE_NAME("Message::ReplyError"); auto svc = service_.lock(); if (!replied_ && svc) { - ErrnoGuard errno_guard; - const int ret = svc->endpoint()->MessageReply(this, -error); - replied_ = ret == 0; - return ReturnCodeOrError(ret); + const auto ret = + svc->endpoint()->MessageReply(this, -static_cast<int>(error)); + replied_ = ret.ok(); + return ret; } else { - return -EINVAL; + return ErrorStatus{EINVAL}; } } -int Message::Reply(const LocalHandle& handle) { +Status<void> Message::Reply(const LocalHandle& handle) { PDX_TRACE_NAME("Message::ReplyFileHandle"); auto svc = service_.lock(); if (!replied_ && svc) { - ErrnoGuard errno_guard; - int ret; + Status<void> ret; if (handle) ret = svc->endpoint()->MessageReplyFd(this, handle.Get()); else ret = svc->endpoint()->MessageReply(this, handle.Get()); - replied_ = ret == 0; - return ReturnCodeOrError(ret); + replied_ = ret.ok(); + return ret; } else { - return -EINVAL; + return ErrorStatus{EINVAL}; } } -int Message::Reply(const BorrowedHandle& handle) { +Status<void> Message::Reply(const BorrowedHandle& handle) { PDX_TRACE_NAME("Message::ReplyFileHandle"); auto svc = service_.lock(); if (!replied_ && svc) { - ErrnoGuard errno_guard; - int ret; + Status<void> ret; if (handle) ret = svc->endpoint()->MessageReplyFd(this, handle.Get()); else ret = svc->endpoint()->MessageReply(this, handle.Get()); - replied_ = ret == 0; - return ReturnCodeOrError(ret); + replied_ = ret.ok(); + return ret; } else { - return -EINVAL; + return ErrorStatus{EINVAL}; } } -int Message::Reply(const RemoteHandle& handle) { +Status<void> Message::Reply(const RemoteHandle& handle) { PDX_TRACE_NAME("Message::ReplyFileHandle"); auto svc = service_.lock(); if (!replied_ && svc) { - ErrnoGuard errno_guard; - const int ret = svc->endpoint()->MessageReply(this, handle.Get()); - replied_ = ret == 0; - return ReturnCodeOrError(ret); + Status<void> ret; + + if (handle) + ret = svc->endpoint()->MessageReply(this, handle.Get()); + else + ret = svc->endpoint()->MessageReply(this, handle.Get()); + + replied_ = ret.ok(); + return ret; } else { - return -EINVAL; + return ErrorStatus{EINVAL}; } } -int Message::Reply(const LocalChannelHandle& handle) { +Status<void> Message::Reply(const LocalChannelHandle& handle) { auto svc = service_.lock(); if (!replied_ && svc) { - ErrnoGuard errno_guard; - const int ret = svc->endpoint()->MessageReplyChannelHandle(this, handle); - replied_ = ret == 0; - return ReturnCodeOrError(ret); + const auto ret = svc->endpoint()->MessageReplyChannelHandle(this, handle); + replied_ = ret.ok(); + return ret; } else { - return -EINVAL; + return ErrorStatus{EINVAL}; } } -int Message::Reply(const BorrowedChannelHandle& handle) { +Status<void> Message::Reply(const BorrowedChannelHandle& handle) { auto svc = service_.lock(); if (!replied_ && svc) { - ErrnoGuard errno_guard; - const int ret = svc->endpoint()->MessageReplyChannelHandle(this, handle); - replied_ = ret == 0; - return ReturnCodeOrError(ret); + const auto ret = svc->endpoint()->MessageReplyChannelHandle(this, handle); + replied_ = ret.ok(); + return ret; } else { - return -EINVAL; + return ErrorStatus{EINVAL}; } } -int Message::Reply(const RemoteChannelHandle& handle) { +Status<void> Message::Reply(const RemoteChannelHandle& handle) { auto svc = service_.lock(); if (!replied_ && svc) { - ErrnoGuard errno_guard; - const int ret = svc->endpoint()->MessageReplyChannelHandle(this, handle); - replied_ = ret == 0; - return ReturnCodeOrError(ret); + const auto ret = svc->endpoint()->MessageReplyChannelHandle(this, handle); + replied_ = ret.ok(); + return ret; } else { - return -EINVAL; + return ErrorStatus{EINVAL}; } } -int Message::ModifyChannelEvents(int clear_mask, int set_mask) { +Status<void> Message::ModifyChannelEvents(int clear_mask, int set_mask) { PDX_TRACE_NAME("Message::ModifyChannelEvents"); if (auto svc = service_.lock()) { - ErrnoGuard errno_guard; - const int ret = - svc->endpoint()->ModifyChannelEvents(info_.cid, clear_mask, set_mask); - return ReturnCodeOrError(ret); + return svc->endpoint()->ModifyChannelEvents(info_.cid, clear_mask, + set_mask); } else { - return -ESHUTDOWN; + return ErrorStatus{ESHUTDOWN}; } } @@ -416,11 +435,12 @@ size_t Message::GetFileDescriptorCount() const { return info_.fd_count; } std::shared_ptr<Channel> Message::GetChannel() const { return channel_.lock(); } -void Message::SetChannel(const std::shared_ptr<Channel>& chan) { +Status<void> Message::SetChannel(const std::shared_ptr<Channel>& chan) { channel_ = chan; - + Status<void> status; if (auto svc = service_.lock()) - svc->SetChannel(info_.cid, chan); + status = svc->SetChannel(info_.cid, chan); + return status; } std::shared_ptr<Service> Message::GetService() const { return service_.lock(); } @@ -432,16 +452,16 @@ Service::Service(const std::string& name, std::unique_ptr<Endpoint> endpoint) if (!endpoint_) return; - const int ret = endpoint_->SetService(this); - ALOGE_IF(ret < 0, "Failed to set service context because: %s", - strerror(-ret)); + const auto status = endpoint_->SetService(this); + ALOGE_IF(!status, "Failed to set service context because: %s", + status.GetErrorMessage().c_str()); } Service::~Service() { if (endpoint_) { - const int ret = endpoint_->SetService(nullptr); - ALOGE_IF(ret < 0, "Failed to clear service context because: %s", - strerror(-ret)); + const auto status = endpoint_->SetService(nullptr); + ALOGE_IF(!status, "Failed to clear service context because: %s", + status.GetErrorMessage().c_str()); } } @@ -459,32 +479,28 @@ std::shared_ptr<Channel> Service::OnChannelOpen(Message& /*message*/) { void Service::OnChannelClose(Message& /*message*/, const std::shared_ptr<Channel>& /*channel*/) {} -int Service::SetChannel(int channel_id, - const std::shared_ptr<Channel>& channel) { +Status<void> Service::SetChannel(int channel_id, + const std::shared_ptr<Channel>& channel) { PDX_TRACE_NAME("Service::SetChannel"); - ErrnoGuard errno_guard; std::lock_guard<std::mutex> autolock(channels_mutex_); - const int ret = endpoint_->SetChannel(channel_id, channel.get()); - if (ret == -1) { + const auto status = endpoint_->SetChannel(channel_id, channel.get()); + if (!status) { ALOGE("%s::SetChannel: Failed to set channel context: %s\n", name_.c_str(), - strerror(errno)); + status.GetErrorMessage().c_str()); // It's possible someone mucked with things behind our back by calling the C // API directly. Since we know the channel id isn't valid, make sure we // don't have it in the channels map. - if (errno == ENOENT) + if (status.error() == ENOENT) + channels_.erase(channel_id); + } else { + if (channel != nullptr) + channels_[channel_id] = channel; + else channels_.erase(channel_id); - - return ReturnCodeOrError(ret); } - - if (channel != nullptr) - channels_[channel_id] = channel; - else - channels_.erase(channel_id); - - return ret; + return status; } std::shared_ptr<Channel> Service::GetChannel(int channel_id) const { @@ -498,21 +514,21 @@ std::shared_ptr<Channel> Service::GetChannel(int channel_id) const { return nullptr; } -int Service::CloseChannel(int channel_id) { +Status<void> Service::CloseChannel(int channel_id) { PDX_TRACE_NAME("Service::CloseChannel"); - ErrnoGuard errno_guard; std::lock_guard<std::mutex> autolock(channels_mutex_); - const int ret = endpoint_->CloseChannel(channel_id); + const auto status = endpoint_->CloseChannel(channel_id); // Always erase the map entry, in case someone mucked with things behind our // back using the C API directly. channels_.erase(channel_id); - return ReturnCodeOrError(ret); + return status; } -int Service::ModifyChannelEvents(int channel_id, int clear_mask, int set_mask) { +Status<void> Service::ModifyChannelEvents(int channel_id, int clear_mask, + int set_mask) { PDX_TRACE_NAME("Service::ModifyChannelEvents"); return endpoint_->ModifyChannelEvents(channel_id, clear_mask, set_mask); } @@ -521,7 +537,6 @@ Status<RemoteChannelHandle> Service::PushChannel( Message* message, int flags, const std::shared_ptr<Channel>& channel, int* channel_id) { PDX_TRACE_NAME("Service::PushChannel"); - ErrnoGuard errno_guard; std::lock_guard<std::mutex> autolock(channels_mutex_); @@ -542,7 +557,6 @@ Status<RemoteChannelHandle> Service::PushChannel( Status<int> Service::CheckChannel(const Message* message, ChannelReference ref, std::shared_ptr<Channel>* channel) const { PDX_TRACE_NAME("Service::CheckChannel"); - ErrnoGuard errno_guard; // Synchronization to maintain consistency between the kernel's channel // context pointer and the userspace channels_ map. Other threads may attempt @@ -565,13 +579,13 @@ Status<int> Service::CheckChannel(const Message* message, ChannelReference ref, std::string Service::DumpState(size_t /*max_length*/) { return ""; } -int Service::HandleMessage(Message& message) { +Status<void> Service::HandleMessage(Message& message) { return DefaultHandleMessage(message); } void Service::HandleImpulse(Message& /*impulse*/) {} -bool Service::HandleSystemMessage(Message& message) { +Status<void> Service::HandleSystemMessage(Message& message) { const MessageInfo& info = message.GetInfo(); switch (info.op) { @@ -579,8 +593,7 @@ bool Service::HandleSystemMessage(Message& message) { ALOGD("%s::OnChannelOpen: pid=%d cid=%d\n", name_.c_str(), info.pid, info.cid); message.SetChannel(OnChannelOpen(message)); - message.Reply(0); - return true; + return message.Reply(0); } case opcodes::CHANNEL_CLOSE: { @@ -588,8 +601,7 @@ bool Service::HandleSystemMessage(Message& message) { info.cid); OnChannelClose(message, Channel::GetFromMessageInfo(info)); message.SetChannel(nullptr); - message.Reply(0); - return true; + return message.Reply(0); } case opcodes::REPORT_SYSPROP_CHANGE: @@ -597,8 +609,7 @@ bool Service::HandleSystemMessage(Message& message) { info.pid, info.cid); OnSysPropChange(); android::report_sysprop_change(); - message.Reply(0); - return true; + return message.Reply(0); case opcodes::DUMP_STATE: { ALOGD("%s:DUMP_STATE: pid=%d cid=%d\n", name_.c_str(), info.pid, @@ -607,21 +618,20 @@ bool Service::HandleSystemMessage(Message& message) { const size_t response_size = response.size() < message.GetReceiveLength() ? response.size() : message.GetReceiveLength(); - const ssize_t bytes_written = + const Status<size_t> status = message.Write(response.data(), response_size); - if (bytes_written < static_cast<ssize_t>(response_size)) - message.ReplyError(EIO); + if (status && status.get() < response_size) + return message.ReplyError(EIO); else - message.Reply(bytes_written); - return true; + return message.Reply(status); } default: - return false; + return ErrorStatus{EOPNOTSUPP}; } } -int Service::DefaultHandleMessage(Message& message) { +Status<void> Service::DefaultHandleMessage(Message& message) { const MessageInfo& info = message.GetInfo(); ALOGD_IF(TRACE, "Service::DefaultHandleMessage: pid=%d cid=%d op=%d\n", @@ -632,23 +642,21 @@ int Service::DefaultHandleMessage(Message& message) { case opcodes::CHANNEL_CLOSE: case opcodes::REPORT_SYSPROP_CHANGE: case opcodes::DUMP_STATE: - HandleSystemMessage(message); - return 0; + return HandleSystemMessage(message); default: - return message.ReplyError(ENOTSUP); + return message.ReplyError(EOPNOTSUPP); } } void Service::OnSysPropChange() {} -int Service::ReceiveAndDispatch() { - ErrnoGuard errno_guard; +Status<void> Service::ReceiveAndDispatch() { Message message; - const int ret = endpoint_->MessageReceive(&message); - if (ret < 0) { - ALOGE("Failed to receive message: %s\n", strerror(errno)); - return ReturnCodeOrError(ret); + const auto status = endpoint_->MessageReceive(&message); + if (!status) { + ALOGE("Failed to receive message: %s\n", status.GetErrorMessage().c_str()); + return status; } std::shared_ptr<Service> service = message.GetService(); @@ -657,24 +665,20 @@ int Service::ReceiveAndDispatch() { ALOGE("Service::ReceiveAndDispatch: service context is NULL!!!\n"); // Don't block the sender indefinitely in this error case. endpoint_->MessageReply(&message, -EINVAL); - return -EINVAL; + return ErrorStatus{EINVAL}; } if (message.IsImpulse()) { service->HandleImpulse(message); - return 0; + return {}; } else if (service->HandleSystemMessage(message)) { - return 0; + return {}; } else { return service->HandleMessage(message); } } -int Service::Cancel() { - ErrnoGuard errno_guard; - const int ret = endpoint_->Cancel(); - return ReturnCodeOrError(ret); -} +Status<void> Service::Cancel() { return endpoint_->Cancel(); } } // namespace pdx } // namespace android diff --git a/libs/vr/libpdx/service_tests.cpp b/libs/vr/libpdx/service_tests.cpp index fc0c8dbbf9..c7412b7aae 100644 --- a/libs/vr/libpdx/service_tests.cpp +++ b/libs/vr/libpdx/service_tests.cpp @@ -30,7 +30,6 @@ using testing::Matcher; using testing::Ref; using testing::Return; using testing::SetArgPointee; -using testing::SetErrnoAndReturn; using testing::WithArg; using testing::WithoutArgs; using testing::_; @@ -91,7 +90,7 @@ class MockService : public Service { MOCK_METHOD1(OnChannelOpen, std::shared_ptr<Channel>(Message& message)); MOCK_METHOD2(OnChannelClose, void(Message& message, const std::shared_ptr<Channel>& channel)); - MOCK_METHOD1(HandleMessage, int(Message& message)); + MOCK_METHOD1(HandleMessage, Status<void>(Message& message)); MOCK_METHOD1(HandleImpulse, void(Message& impulse)); MOCK_METHOD0(OnSysPropChange, void()); MOCK_METHOD1(DumpState, std::string(size_t max_length)); @@ -101,7 +100,9 @@ class ServiceTest : public testing::Test { public: ServiceTest() { auto endpoint = std::make_unique<testing::StrictMock<MockEndpoint>>(); - EXPECT_CALL(*endpoint, SetService(_)).Times(2).WillRepeatedly(Return(0)); + EXPECT_CALL(*endpoint, SetService(_)) + .Times(2) + .WillRepeatedly(Return(Status<void>{})); service_ = std::make_shared<MockService>("MockSvc", std::move(endpoint)); } @@ -134,7 +135,8 @@ class ServiceTest : public testing::Test { } void ExpectDefaultHandleMessage() { - EXPECT_CALL(*endpoint(), DefaultHandleMessage(_)); + EXPECT_CALL(*endpoint(), MessageReply(_, -EOPNOTSUPP)) + .WillOnce(Return(Status<void>{})); } std::shared_ptr<MockService> service_; @@ -222,10 +224,11 @@ TEST_F(ServiceTest, HandleMessageChannelOpen) { auto channel = std::make_shared<Channel>(); EXPECT_CALL(*service_, OnChannelOpen(Ref(message))).WillOnce(Return(channel)); EXPECT_CALL(*endpoint(), SetChannel(kTestCid, channel.get())) - .WillOnce(Return(0)); - EXPECT_CALL(*endpoint(), MessageReply(&message, 0)).WillOnce(Return(0)); + .WillOnce(Return(Status<void>{})); + EXPECT_CALL(*endpoint(), MessageReply(&message, 0)) + .WillOnce(Return(Status<void>{})); - EXPECT_EQ(0, service_->Service::HandleMessage(message)); + EXPECT_TRUE(service_->Service::HandleMessage(message)); } TEST_F(ServiceTest, HandleMessageChannelClose) { @@ -237,10 +240,12 @@ TEST_F(ServiceTest, HandleMessageChannelClose) { Message message{info}; EXPECT_CALL(*service_, OnChannelClose(Ref(message), channel)); - EXPECT_CALL(*endpoint(), SetChannel(kTestCid, nullptr)).WillOnce(Return(0)); - EXPECT_CALL(*endpoint(), MessageReply(&message, 0)).WillOnce(Return(0)); + EXPECT_CALL(*endpoint(), SetChannel(kTestCid, nullptr)) + .WillOnce(Return(Status<void>{})); + EXPECT_CALL(*endpoint(), MessageReply(&message, 0)) + .WillOnce(Return(Status<void>{})); - EXPECT_EQ(0, service_->Service::HandleMessage(message)); + EXPECT_TRUE(service_->Service::HandleMessage(message)); } TEST_F(ServiceTest, HandleMessageOnSysPropChange) { @@ -250,9 +255,10 @@ TEST_F(ServiceTest, HandleMessageOnSysPropChange) { Message message{info}; EXPECT_CALL(*service_, OnSysPropChange()); - EXPECT_CALL(*endpoint(), MessageReply(&message, 0)).WillOnce(Return(0)); + EXPECT_CALL(*endpoint(), MessageReply(&message, 0)) + .WillOnce(Return(Status<void>{})); - EXPECT_EQ(0, service_->Service::HandleMessage(message)); + EXPECT_TRUE(service_->Service::HandleMessage(message)); } TEST_F(ServiceTest, HandleMessageOnDumpState) { @@ -270,9 +276,9 @@ TEST_F(ServiceTest, HandleMessageOnDumpState) { WriteMessageData(&message, IoVecDataMatcher(IoVecData{kReply}), 1)) .WillOnce(Return(kReply.size())); EXPECT_CALL(*endpoint(), MessageReply(&message, kReply.size())) - .WillOnce(Return(0)); + .WillOnce(Return(Status<void>{})); - EXPECT_EQ(0, service_->Service::HandleMessage(message)); + EXPECT_TRUE(service_->Service::HandleMessage(message)); } TEST_F(ServiceTest, HandleMessageOnDumpStateTooLarge) { @@ -291,9 +297,9 @@ TEST_F(ServiceTest, HandleMessageOnDumpStateTooLarge) { WriteMessageData(&message, IoVecDataMatcher(IoVecData{kActualReply}), 1)) .WillOnce(Return(kActualReply.size())); EXPECT_CALL(*endpoint(), MessageReply(&message, kActualReply.size())) - .WillOnce(Return(0)); + .WillOnce(Return(Status<void>{})); - EXPECT_EQ(0, service_->Service::HandleMessage(message)); + EXPECT_TRUE(service_->Service::HandleMessage(message)); } TEST_F(ServiceTest, HandleMessageOnDumpStateFail) { @@ -310,9 +316,10 @@ TEST_F(ServiceTest, HandleMessageOnDumpStateFail) { *endpoint(), WriteMessageData(&message, IoVecDataMatcher(IoVecData{kReply}), 1)) .WillOnce(Return(1)); - EXPECT_CALL(*endpoint(), MessageReply(&message, -EIO)).WillOnce(Return(0)); + EXPECT_CALL(*endpoint(), MessageReply(&message, -EIO)) + .WillOnce(Return(Status<void>{})); - EXPECT_EQ(0, service_->Service::HandleMessage(message)); + EXPECT_TRUE(service_->Service::HandleMessage(message)); } TEST_F(ServiceTest, HandleMessageCustom) { @@ -320,10 +327,10 @@ TEST_F(ServiceTest, HandleMessageCustom) { SetupMessageInfoAndDefaultExpectations(&info, kTestOp); Message message{info}; - EXPECT_CALL(*endpoint(), MessageReply(&message, -ENOTSUP)) - .WillOnce(Return(0)); + EXPECT_CALL(*endpoint(), MessageReply(&message, -EOPNOTSUPP)) + .WillOnce(Return(Status<void>{})); - EXPECT_EQ(0, service_->Service::HandleMessage(message)); + EXPECT_TRUE(service_->Service::HandleMessage(message)); } TEST_F(ServiceTest, ReplyMessageWithoutService) { @@ -337,7 +344,7 @@ TEST_F(ServiceTest, ReplyMessageWithoutService) { service_.reset(); EXPECT_TRUE(message.IsServiceExpired()); - EXPECT_EQ(-EINVAL, message.Reply(12)); + EXPECT_EQ(EINVAL, message.Reply(12).error()); } TEST_F(ServiceTest, ReceiveAndDispatchMessage) { @@ -345,33 +352,33 @@ TEST_F(ServiceTest, ReceiveAndDispatchMessage) { SetupMessageInfoAndDefaultExpectations(&info, kTestOp); ExpectDefaultHandleMessage(); - auto on_receive = [&info](Message* message) { + auto on_receive = [&info](Message* message) -> Status<void> { *message = Message{info}; - return 0; + return {}; }; EXPECT_CALL(*endpoint(), MessageReceive(_)).WillOnce(Invoke(on_receive)); - EXPECT_CALL(*service_, HandleMessage(_)).WillOnce(Return(0)); + EXPECT_CALL(*service_, HandleMessage(_)).WillOnce(Return(Status<void>{})); - EXPECT_EQ(0, service_->ReceiveAndDispatch()); + EXPECT_TRUE(service_->ReceiveAndDispatch()); } TEST_F(ServiceTest, ReceiveAndDispatchImpulse) { MessageInfo info; SetupMessageInfoAndDefaultExpectations(&info, kTestOp, true); - auto on_receive = [&info](Message* message) { + auto on_receive = [&info](Message* message) -> Status<void> { *message = Message{info}; - return 0; + return {}; }; EXPECT_CALL(*endpoint(), MessageReceive(_)).WillOnce(Invoke(on_receive)); EXPECT_CALL(*service_, HandleImpulse(_)); - EXPECT_EQ(0, service_->ReceiveAndDispatch()); + EXPECT_TRUE(service_->ReceiveAndDispatch()); } TEST_F(ServiceTest, Cancel) { - EXPECT_CALL(*endpoint(), Cancel()).WillOnce(Return(0)); - EXPECT_EQ(0, service_->Cancel()); + EXPECT_CALL(*endpoint(), Cancel()).WillOnce(Return(Status<void>{})); + EXPECT_TRUE(service_->Cancel()); } /////////////////////////////////////////////////////////////////////////////// @@ -380,85 +387,85 @@ TEST_F(ServiceTest, Cancel) { TEST_F(ServiceMessageTest, Reply) { EXPECT_CALL(*endpoint(), MessageReply(message_.get(), 12)) - .WillOnce(Return(0)); + .WillOnce(Return(Status<void>{})); EXPECT_FALSE(message_->replied()); - EXPECT_EQ(0, message_->Reply(12)); + EXPECT_TRUE(message_->Reply(12)); EXPECT_TRUE(message_->replied()); - EXPECT_EQ(-EINVAL, message_->Reply(12)); // Already replied. + EXPECT_EQ(EINVAL, message_->Reply(12).error()); // Already replied. } TEST_F(ServiceMessageTest, ReplyFail) { EXPECT_CALL(*endpoint(), MessageReply(message_.get(), 12)) - .WillOnce(SetErrnoAndReturn(EIO, -1)); - EXPECT_EQ(-EIO, message_->Reply(12)); + .WillOnce(Return(ErrorStatus{EIO})); + EXPECT_EQ(EIO, message_->Reply(12).error()); ExpectDefaultHandleMessage(); } TEST_F(ServiceMessageTest, ReplyError) { EXPECT_CALL(*endpoint(), MessageReply(message_.get(), -12)) - .WillOnce(Return(0)); - EXPECT_EQ(0, message_->ReplyError(12)); + .WillOnce(Return(Status<void>{})); + EXPECT_TRUE(message_->ReplyError(12)); } TEST_F(ServiceMessageTest, ReplyFileDescriptor) { EXPECT_CALL(*endpoint(), MessageReplyFd(message_.get(), 5)) - .WillOnce(Return(0)); - EXPECT_EQ(0, message_->ReplyFileDescriptor(5)); + .WillOnce(Return(Status<void>{})); + EXPECT_TRUE(message_->ReplyFileDescriptor(5)); } TEST_F(ServiceMessageTest, ReplyLocalFileHandle) { const int kFakeFd = 12345; LocalHandle handle{kFakeFd}; EXPECT_CALL(*endpoint(), MessageReplyFd(message_.get(), kFakeFd)) - .WillOnce(Return(0)); - EXPECT_EQ(0, message_->Reply(handle)); + .WillOnce(Return(Status<void>{})); + EXPECT_TRUE(message_->Reply(handle)); handle.Release(); // Make sure we do not close the fake file descriptor. } TEST_F(ServiceMessageTest, ReplyLocalFileHandleError) { LocalHandle handle{-EINVAL}; EXPECT_CALL(*endpoint(), MessageReply(message_.get(), -EINVAL)) - .WillOnce(Return(0)); - EXPECT_EQ(0, message_->Reply(handle)); + .WillOnce(Return(Status<void>{})); + EXPECT_TRUE(message_->Reply(handle)); } TEST_F(ServiceMessageTest, ReplyBorrowedFileHandle) { const int kFakeFd = 12345; BorrowedHandle handle{kFakeFd}; EXPECT_CALL(*endpoint(), MessageReplyFd(message_.get(), kFakeFd)) - .WillOnce(Return(0)); - EXPECT_EQ(0, message_->Reply(handle)); + .WillOnce(Return(Status<void>{})); + EXPECT_TRUE(message_->Reply(handle)); } TEST_F(ServiceMessageTest, ReplyBorrowedFileHandleError) { BorrowedHandle handle{-EACCES}; EXPECT_CALL(*endpoint(), MessageReply(message_.get(), -EACCES)) - .WillOnce(Return(0)); - EXPECT_EQ(0, message_->Reply(handle)); + .WillOnce(Return(Status<void>{})); + EXPECT_TRUE(message_->Reply(handle)); } TEST_F(ServiceMessageTest, ReplyRemoteFileHandle) { RemoteHandle handle{123}; EXPECT_CALL(*endpoint(), MessageReply(message_.get(), handle.Get())) - .WillOnce(Return(0)); - EXPECT_EQ(0, message_->Reply(handle)); + .WillOnce(Return(Status<void>{})); + EXPECT_TRUE(message_->Reply(handle)); } TEST_F(ServiceMessageTest, ReplyRemoteFileHandleError) { RemoteHandle handle{-EIO}; EXPECT_CALL(*endpoint(), MessageReply(message_.get(), -EIO)) - .WillOnce(Return(0)); - EXPECT_EQ(0, message_->Reply(handle)); + .WillOnce(Return(Status<void>{})); + EXPECT_TRUE(message_->Reply(handle)); } TEST_F(ServiceMessageTest, ReplyLocalChannelHandle) { LocalChannelHandle handle{nullptr, 12345}; EXPECT_CALL(*endpoint(), MessageReplyChannelHandle( message_.get(), A<const LocalChannelHandle&>())) - .WillOnce(Return(0)); - EXPECT_EQ(0, message_->Reply(handle)); + .WillOnce(Return(Status<void>{})); + EXPECT_TRUE(message_->Reply(handle)); } TEST_F(ServiceMessageTest, ReplyBorrowedChannelHandle) { @@ -466,30 +473,30 @@ TEST_F(ServiceMessageTest, ReplyBorrowedChannelHandle) { EXPECT_CALL(*endpoint(), MessageReplyChannelHandle(message_.get(), A<const BorrowedChannelHandle&>())) - .WillOnce(Return(0)); - EXPECT_EQ(0, message_->Reply(handle)); + .WillOnce(Return(Status<void>{})); + EXPECT_TRUE(message_->Reply(handle)); } TEST_F(ServiceMessageTest, ReplyRemoteChannelHandle) { RemoteChannelHandle handle{12345}; EXPECT_CALL(*endpoint(), MessageReplyChannelHandle( message_.get(), A<const RemoteChannelHandle&>())) - .WillOnce(Return(0)); - EXPECT_EQ(0, message_->Reply(handle)); + .WillOnce(Return(Status<void>{})); + EXPECT_TRUE(message_->Reply(handle)); } TEST_F(ServiceMessageTest, ReplyStatusInt) { Status<int> status{123}; EXPECT_CALL(*endpoint(), MessageReply(message_.get(), status.get())) - .WillOnce(Return(0)); - EXPECT_EQ(0, message_->Reply(status)); + .WillOnce(Return(Status<void>{})); + EXPECT_TRUE(message_->Reply(status)); } TEST_F(ServiceMessageTest, ReplyStatusError) { Status<int> status{ErrorStatus{EIO}}; EXPECT_CALL(*endpoint(), MessageReply(message_.get(), -status.error())) - .WillOnce(Return(0)); - EXPECT_EQ(0, message_->Reply(status)); + .WillOnce(Return(Status<void>{})); + EXPECT_TRUE(message_->Reply(status)); } TEST_F(ServiceMessageTest, Read) { @@ -500,9 +507,9 @@ TEST_F(ServiceMessageTest, Read) { *endpoint(), ReadMessageData(message_.get(), IoVecMatcher(kDataBuffer, kDataSize), 1)) .WillOnce(Return(50)) - .WillOnce(SetErrnoAndReturn(EACCES, -1)); - EXPECT_EQ(50, message_->Read(kDataBuffer, kDataSize)); - EXPECT_EQ(-EACCES, message_->Read(kDataBuffer, kDataSize)); + .WillOnce(Return(ErrorStatus{EACCES})); + EXPECT_EQ(50u, message_->Read(kDataBuffer, kDataSize).get()); + EXPECT_EQ(EACCES, message_->Read(kDataBuffer, kDataSize).error()); } TEST_F(ServiceMessageTest, ReadVector) { @@ -516,10 +523,10 @@ TEST_F(ServiceMessageTest, ReadVector) { IoVecMatcher(IoVecArray{std::begin(vec), std::end(vec)}), 2)) .WillOnce(Return(30)) .WillOnce(Return(15)) - .WillOnce(SetErrnoAndReturn(EBADF, -1)); - EXPECT_EQ(30, message_->ReadVector(vec, 2)); - EXPECT_EQ(15, message_->ReadVector(vec)); - EXPECT_EQ(-EBADF, message_->ReadVector(vec)); + .WillOnce(Return(ErrorStatus{EBADF})); + EXPECT_EQ(30u, message_->ReadVector(vec, 2).get()); + EXPECT_EQ(15u, message_->ReadVector(vec).get()); + EXPECT_EQ(EBADF, message_->ReadVector(vec).error()); } TEST_F(ServiceMessageTest, Write) { @@ -530,9 +537,9 @@ TEST_F(ServiceMessageTest, Write) { *endpoint(), WriteMessageData(message_.get(), IoVecMatcher(kDataBuffer, kDataSize), 1)) .WillOnce(Return(50)) - .WillOnce(SetErrnoAndReturn(EBADMSG, -1)); - EXPECT_EQ(50, message_->Write(kDataBuffer, kDataSize)); - EXPECT_EQ(-EBADMSG, message_->Write(kDataBuffer, kDataSize)); + .WillOnce(Return(ErrorStatus{EBADMSG})); + EXPECT_EQ(50u, message_->Write(kDataBuffer, kDataSize).get()); + EXPECT_EQ(EBADMSG, message_->Write(kDataBuffer, kDataSize).error()); } TEST_F(ServiceMessageTest, WriteVector) { @@ -546,10 +553,10 @@ TEST_F(ServiceMessageTest, WriteVector) { IoVecMatcher(IoVecArray{std::begin(vec), std::end(vec)}), 2)) .WillOnce(Return(30)) .WillOnce(Return(15)) - .WillOnce(SetErrnoAndReturn(EIO, -1)); - EXPECT_EQ(30, message_->WriteVector(vec, 2)); - EXPECT_EQ(15, message_->WriteVector(vec)); - EXPECT_EQ(-EIO, message_->WriteVector(vec, 2)); + .WillOnce(Return(ErrorStatus{EIO})); + EXPECT_EQ(30u, message_->WriteVector(vec, 2).get()); + EXPECT_EQ(15u, message_->WriteVector(vec).get()); + EXPECT_EQ(EIO, message_->WriteVector(vec, 2).error()); } TEST_F(ServiceMessageTest, PushLocalFileHandle) { @@ -560,9 +567,9 @@ TEST_F(ServiceMessageTest, PushLocalFileHandle) { PushFileHandle(message_.get(), Matcher<const LocalHandle&>( FileHandleMatcher(kFakeFd)))) .WillOnce(Return(12)) - .WillOnce(SetErrnoAndReturn(EIO, -1)); - EXPECT_EQ(12, message_->PushFileHandle(handle)); - EXPECT_EQ(-EIO, message_->PushFileHandle(handle)); + .WillOnce(Return(ErrorStatus{EIO})); + EXPECT_EQ(12, message_->PushFileHandle(handle).get()); + EXPECT_EQ(EIO, message_->PushFileHandle(handle).error()); handle.Release(); // Make sure we do not close the fake file descriptor. } @@ -574,9 +581,9 @@ TEST_F(ServiceMessageTest, PushBorrowedFileHandle) { PushFileHandle(message_.get(), Matcher<const BorrowedHandle&>( FileHandleMatcher(kFakeFd)))) .WillOnce(Return(13)) - .WillOnce(SetErrnoAndReturn(EACCES, -1)); - EXPECT_EQ(13, message_->PushFileHandle(handle)); - EXPECT_EQ(-EACCES, message_->PushFileHandle(handle)); + .WillOnce(Return(ErrorStatus{EACCES})); + EXPECT_EQ(13, message_->PushFileHandle(handle).get()); + EXPECT_EQ(EACCES, message_->PushFileHandle(handle).error()); } TEST_F(ServiceMessageTest, PushRemoteFileHandle) { @@ -587,9 +594,9 @@ TEST_F(ServiceMessageTest, PushRemoteFileHandle) { PushFileHandle(message_.get(), Matcher<const RemoteHandle&>( FileHandleMatcher(kFakeFd)))) .WillOnce(Return(kFakeFd)) - .WillOnce(SetErrnoAndReturn(EIO, -1)); - EXPECT_EQ(kFakeFd, message_->PushFileHandle(handle)); - EXPECT_EQ(-EIO, message_->PushFileHandle(handle)); + .WillOnce(Return(ErrorStatus{EIO})); + EXPECT_EQ(kFakeFd, message_->PushFileHandle(handle).get()); + EXPECT_EQ(EIO, message_->PushFileHandle(handle).error()); } TEST_F(ServiceMessageTest, PushLocalChannelHandle) { @@ -600,9 +607,9 @@ TEST_F(ServiceMessageTest, PushLocalChannelHandle) { Matcher<const LocalChannelHandle&>( ChannelHandleMatcher(kValue)))) .WillOnce(Return(7)) - .WillOnce(SetErrnoAndReturn(EIO, -1)); - EXPECT_EQ(7, message_->PushChannelHandle(handle)); - EXPECT_EQ(-EIO, message_->PushChannelHandle(handle)); + .WillOnce(Return(ErrorStatus{EIO})); + EXPECT_EQ(7, message_->PushChannelHandle(handle).get()); + EXPECT_EQ(EIO, message_->PushChannelHandle(handle).error()); } TEST_F(ServiceMessageTest, PushBorrowedChannelHandle) { @@ -614,9 +621,9 @@ TEST_F(ServiceMessageTest, PushBorrowedChannelHandle) { PushChannelHandle(message_.get(), Matcher<const BorrowedChannelHandle&>( ChannelHandleMatcher(kValue)))) .WillOnce(Return(8)) - .WillOnce(SetErrnoAndReturn(EIO, -1)); - EXPECT_EQ(8, message_->PushChannelHandle(handle)); - EXPECT_EQ(-EIO, message_->PushChannelHandle(handle)); + .WillOnce(Return(ErrorStatus{EIO})); + EXPECT_EQ(8, message_->PushChannelHandle(handle).get()); + EXPECT_EQ(EIO, message_->PushChannelHandle(handle).error()); } TEST_F(ServiceMessageTest, PushRemoteChannelHandle) { @@ -628,9 +635,9 @@ TEST_F(ServiceMessageTest, PushRemoteChannelHandle) { PushChannelHandle(message_.get(), Matcher<const RemoteChannelHandle&>( ChannelHandleMatcher(kValue)))) .WillOnce(Return(kValue)) - .WillOnce(SetErrnoAndReturn(EIO, -1)); - EXPECT_EQ(kValue, message_->PushChannelHandle(handle)); - EXPECT_EQ(-EIO, message_->PushChannelHandle(handle)); + .WillOnce(Return(ErrorStatus{EIO})); + EXPECT_EQ(kValue, message_->PushChannelHandle(handle).get()); + EXPECT_EQ(EIO, message_->PushChannelHandle(handle).error()); } TEST_F(ServiceMessageTest, GetFileHandle) { @@ -701,8 +708,8 @@ TEST_F(ServiceMessageTest, ModifyChannelEvents) { int kClearMask = 1; int kSetMask = 2; EXPECT_CALL(*endpoint(), ModifyChannelEvents(kTestCid, kClearMask, kSetMask)) - .WillOnce(Return(0)); - EXPECT_EQ(0, message_->ModifyChannelEvents(kClearMask, kSetMask)); + .WillOnce(Return(Status<void>{})); + EXPECT_TRUE(message_->ModifyChannelEvents(kClearMask, kSetMask)); } TEST_F(ServiceMessageTest, PushChannelSameService) { @@ -733,7 +740,9 @@ TEST_F(ServiceMessageTest, PushChannelFailure) { TEST_F(ServiceMessageTest, PushChannelDifferentService) { ExpectDefaultHandleMessage(); auto endpoint2 = std::make_unique<testing::StrictMock<MockEndpoint>>(); - EXPECT_CALL(*endpoint2, SetService(_)).Times(2).WillRepeatedly(Return(0)); + EXPECT_CALL(*endpoint2, SetService(_)) + .Times(2) + .WillRepeatedly(Return(Status<void>{})); auto service2 = std::make_shared<MockService>("MockSvc2", std::move(endpoint2)); @@ -779,7 +788,9 @@ TEST_F(ServiceMessageTest, CheckChannelFailure) { TEST_F(ServiceMessageTest, CheckChannelDifferentService) { ExpectDefaultHandleMessage(); auto endpoint2 = std::make_unique<testing::StrictMock<MockEndpoint>>(); - EXPECT_CALL(*endpoint2, SetService(_)).Times(2).WillRepeatedly(Return(0)); + EXPECT_CALL(*endpoint2, SetService(_)) + .Times(2) + .WillRepeatedly(Return(Status<void>{})); auto service2 = std::make_shared<MockService>("MockSvc2", std::move(endpoint2)); diff --git a/libs/vr/libpdx_default_transport/Android.bp b/libs/vr/libpdx_default_transport/Android.bp index 655adb8ddc..8cfa86fa44 100644 --- a/libs/vr/libpdx_default_transport/Android.bp +++ b/libs/vr/libpdx_default_transport/Android.bp @@ -57,6 +57,7 @@ cc_binary { "pdx_benchmarks.cpp", ], shared_libs: [ + "libbase", "libchrome", "libcutils", "liblog", diff --git a/libs/vr/libpdx_default_transport/pdx_benchmarks.cpp b/libs/vr/libpdx_default_transport/pdx_benchmarks.cpp index de0240189b..0b658fbc70 100644 --- a/libs/vr/libpdx_default_transport/pdx_benchmarks.cpp +++ b/libs/vr/libpdx_default_transport/pdx_benchmarks.cpp @@ -38,6 +38,7 @@ using android::pdx::Channel; using android::pdx::ClientBase; using android::pdx::Endpoint; +using android::pdx::ErrorStatus; using android::pdx::Message; using android::pdx::Service; using android::pdx::ServiceBase; @@ -246,7 +247,7 @@ class BenchmarkService : public ServiceBase<BenchmarkService> { << message.GetChannelId(); } - int HandleMessage(Message& message) override { + Status<void> HandleMessage(Message& message) override { ATRACE_NAME("BenchmarkService::HandleMessage"); switch (message.GetOp()) { @@ -254,30 +255,27 @@ class BenchmarkService : public ServiceBase<BenchmarkService> { VLOG(1) << "BenchmarkService::HandleMessage: op=nop"; { ATRACE_NAME("Reply"); - CHECK(message.Reply(0) == 0); + CHECK(message.Reply(0)); } - return 0; + return {}; case BenchmarkOps::Write: { VLOG(1) << "BenchmarkService::HandleMessage: op=write send_length=" << message.GetSendLength() << " receive_length=" << message.GetReceiveLength(); - const ssize_t expected_length = - static_cast<ssize_t>(message.GetSendLength()); - const ssize_t actual_length = - expected_length > 0 - ? message.Read(send_buffer.data(), message.GetSendLength()) - : 0; + Status<void> status; + if (message.GetSendLength()) + status = message.ReadAll(send_buffer.data(), message.GetSendLength()); { ATRACE_NAME("Reply"); - if (actual_length < expected_length) - CHECK(message.ReplyError(EIO) == 0); + if (!status) + CHECK(message.ReplyError(status.error())); else - CHECK(message.Reply(actual_length) == 0); + CHECK(message.Reply(message.GetSendLength())); } - return 0; + return {}; } case BenchmarkOps::Read: { @@ -285,22 +283,20 @@ class BenchmarkService : public ServiceBase<BenchmarkService> { << message.GetSendLength() << " receive_length=" << message.GetReceiveLength(); - const ssize_t expected_length = - static_cast<ssize_t>(message.GetReceiveLength()); - const ssize_t actual_length = - expected_length > 0 - ? message.Write(receive_buffer.data(), - message.GetReceiveLength()) - : 0; + Status<void> status; + if (message.GetReceiveLength()) { + status = message.WriteAll(receive_buffer.data(), + message.GetReceiveLength()); + } { ATRACE_NAME("Reply"); - if (actual_length < expected_length) - CHECK(message.ReplyError(EIO) == 0); + if (!status) + CHECK(message.ReplyError(status.error())); else - CHECK(message.Reply(actual_length) == 0); + CHECK(message.Reply(message.GetReceiveLength())); } - return 0; + return {}; } case BenchmarkOps::Echo: { @@ -308,31 +304,28 @@ class BenchmarkService : public ServiceBase<BenchmarkService> { << message.GetSendLength() << " receive_length=" << message.GetReceiveLength(); - const ssize_t expected_length = - static_cast<ssize_t>(message.GetSendLength()); - ssize_t actual_length = - expected_length > 0 - ? message.Read(send_buffer.data(), message.GetSendLength()) - : 0; + Status<void> status; + if (message.GetSendLength()) + status = message.ReadAll(send_buffer.data(), message.GetSendLength()); - if (actual_length < expected_length) { - CHECK(message.ReplyError(EIO) == 0); - return 0; + if (!status) { + CHECK(message.ReplyError(status.error())); + return {}; } - actual_length = - expected_length > 0 - ? message.Write(send_buffer.data(), message.GetSendLength()) - : 0; + if (message.GetSendLength()) { + status = + message.WriteAll(send_buffer.data(), message.GetSendLength()); + } { ATRACE_NAME("Reply"); - if (actual_length < expected_length) - CHECK(message.ReplyError(EIO) == 0); + if (!status) + CHECK(message.ReplyError(status.error())); else - CHECK(message.Reply(actual_length) == 0); + CHECK(message.Reply(message.GetSendLength())); } - return 0; + return {}; } case BenchmarkOps::Stats: { @@ -348,7 +341,7 @@ class BenchmarkService : public ServiceBase<BenchmarkService> { RemoteMethodReturn<BenchmarkRPC::Stats>( message, BenchmarkRPC::Stats::Return{receive_time_ns, GetClockNs(), sched_stats_}); - return 0; + return {}; } case BenchmarkOps::WriteVector: @@ -358,7 +351,7 @@ class BenchmarkService : public ServiceBase<BenchmarkService> { DispatchRemoteMethod<BenchmarkRPC::WriteVector>( *this, &BenchmarkService::OnWriteVector, message, kMaxMessageSize); - return 0; + return {}; case BenchmarkOps::EchoVector: VLOG(1) << "BenchmarkService::HandleMessage: op=echovec send_length=" @@ -367,11 +360,11 @@ class BenchmarkService : public ServiceBase<BenchmarkService> { DispatchRemoteMethod<BenchmarkRPC::EchoVector>( *this, &BenchmarkService::OnEchoVector, message, kMaxMessageSize); - return 0; + return {}; case BenchmarkOps::Quit: Cancel(); - return -ESHUTDOWN; + return ErrorStatus{ESHUTDOWN}; default: VLOG(1) << "BenchmarkService::HandleMessage: default case; op=" @@ -543,17 +536,17 @@ int ServiceCommand(const std::string& path) { const std::shared_ptr<BenchmarkService>& local_service) { SetThreadName("service" + std::to_string(service_id)); - // Read the inital schedstats for this thread from procfs. + // Read the initial schedstats for this thread from procfs. local_service->UpdateSchedStats(); ATRACE_NAME("BenchmarkService::Dispatch"); while (!done) { - const int ret = local_service->ReceiveAndDispatch(); - if (ret < 0) { - if (ret != -ESHUTDOWN) { + auto ret = local_service->ReceiveAndDispatch(); + if (!ret) { + if (ret.error() != ESHUTDOWN) { std::cerr << "Error while dispatching message on thread " << thread_id << " service " << service_id << ": " - << strerror(-ret) << std::endl; + << ret.GetErrorMessage() << std::endl; } else { std::cerr << "Quitting thread " << thread_id << " service " << service_id << std::endl; diff --git a/libs/vr/libpdx_uds/Android.bp b/libs/vr/libpdx_uds/Android.bp index 09eeaa04d0..a73ba34177 100644 --- a/libs/vr/libpdx_uds/Android.bp +++ b/libs/vr/libpdx_uds/Android.bp @@ -20,6 +20,8 @@ cc_library_static { "service_endpoint.cpp", ], static_libs: [ + "libcutils", + "libbase", "libpdx", ], } @@ -41,6 +43,8 @@ cc_test { "libpdx", ], shared_libs: [ + "libbase", + "libcutils", "liblog", "libutils", ], diff --git a/libs/vr/libpdx_uds/channel_event_set.cpp b/libs/vr/libpdx_uds/channel_event_set.cpp index f8baeabe88..ac4dea993b 100644 --- a/libs/vr/libpdx_uds/channel_event_set.cpp +++ b/libs/vr/libpdx_uds/channel_event_set.cpp @@ -12,7 +12,7 @@ ChannelEventSet::ChannelEventSet() { const int flags = EFD_CLOEXEC | EFD_NONBLOCK; LocalHandle epoll_fd, event_fd; - if (!SetupHandle(epoll_create(1), &epoll_fd, "epoll") || + if (!SetupHandle(epoll_create1(EPOLL_CLOEXEC), &epoll_fd, "epoll") || !SetupHandle(eventfd(0, flags), &event_fd, "event")) { return; } diff --git a/libs/vr/libpdx_uds/ipc_helper.cpp b/libs/vr/libpdx_uds/ipc_helper.cpp index ee7299e1a9..fe5c98631e 100644 --- a/libs/vr/libpdx_uds/ipc_helper.cpp +++ b/libs/vr/libpdx_uds/ipc_helper.cpp @@ -87,7 +87,7 @@ void* SendPayload::GetNextWriteBufferSection(size_t size) { OutputResourceMapper* SendPayload::GetOutputResourceMapper() { return this; } // OutputResourceMapper -FileReference SendPayload::PushFileHandle(const LocalHandle& handle) { +Status<FileReference> SendPayload::PushFileHandle(const LocalHandle& handle) { if (handle) { const int ref = file_handles_.size(); file_handles_.push_back(handle.Get()); @@ -97,7 +97,8 @@ FileReference SendPayload::PushFileHandle(const LocalHandle& handle) { } } -FileReference SendPayload::PushFileHandle(const BorrowedHandle& handle) { +Status<FileReference> SendPayload::PushFileHandle( + const BorrowedHandle& handle) { if (handle) { const int ref = file_handles_.size(); file_handles_.push_back(handle.Get()); @@ -107,21 +108,21 @@ FileReference SendPayload::PushFileHandle(const BorrowedHandle& handle) { } } -FileReference SendPayload::PushFileHandle(const RemoteHandle& handle) { +Status<FileReference> SendPayload::PushFileHandle(const RemoteHandle& handle) { return handle.Get(); } -ChannelReference SendPayload::PushChannelHandle( +Status<ChannelReference> SendPayload::PushChannelHandle( const LocalChannelHandle& /*handle*/) { - return -1; + return ErrorStatus{EOPNOTSUPP}; } -ChannelReference SendPayload::PushChannelHandle( +Status<ChannelReference> SendPayload::PushChannelHandle( const BorrowedChannelHandle& /*handle*/) { - return -1; + return ErrorStatus{EOPNOTSUPP}; } -ChannelReference SendPayload::PushChannelHandle( +Status<ChannelReference> SendPayload::PushChannelHandle( const RemoteChannelHandle& /*handle*/) { - return -1; + return ErrorStatus{EOPNOTSUPP}; } Status<void> ReceivePayload::Receive(int socket_fd) { diff --git a/libs/vr/libpdx_uds/private/uds/ipc_helper.h b/libs/vr/libpdx_uds/private/uds/ipc_helper.h index 00f3490fe7..80530bf2ff 100644 --- a/libs/vr/libpdx_uds/private/uds/ipc_helper.h +++ b/libs/vr/libpdx_uds/private/uds/ipc_helper.h @@ -33,13 +33,14 @@ class SendPayload : public MessageWriter, public OutputResourceMapper { OutputResourceMapper* GetOutputResourceMapper() override; // OutputResourceMapper - FileReference PushFileHandle(const LocalHandle& handle) override; - FileReference PushFileHandle(const BorrowedHandle& handle) override; - FileReference PushFileHandle(const RemoteHandle& handle) override; - ChannelReference PushChannelHandle(const LocalChannelHandle& handle) override; - ChannelReference PushChannelHandle( + Status<FileReference> PushFileHandle(const LocalHandle& handle) override; + Status<FileReference> PushFileHandle(const BorrowedHandle& handle) override; + Status<FileReference> PushFileHandle(const RemoteHandle& handle) override; + Status<ChannelReference> PushChannelHandle( + const LocalChannelHandle& handle) override; + Status<ChannelReference> PushChannelHandle( const BorrowedChannelHandle& handle) override; - ChannelReference PushChannelHandle( + Status<ChannelReference> PushChannelHandle( const RemoteChannelHandle& handle) override; private: diff --git a/libs/vr/libpdx_uds/private/uds/service_endpoint.h b/libs/vr/libpdx_uds/private/uds/service_endpoint.h index 3ec851909b..2b24f62b84 100644 --- a/libs/vr/libpdx_uds/private/uds/service_endpoint.h +++ b/libs/vr/libpdx_uds/private/uds/service_endpoint.h @@ -39,41 +39,40 @@ class Endpoint : public pdx::Endpoint { ~Endpoint() override = default; uint32_t GetIpcTag() const override { return kIpcTag; } - int SetService(Service* service) override; - int SetChannel(int channel_id, Channel* channel) override; - int CloseChannel(int channel_id) override; - int ModifyChannelEvents(int channel_id, int clear_mask, - int set_mask) override; + Status<void> SetService(Service* service) override; + Status<void> SetChannel(int channel_id, Channel* channel) override; + Status<void> CloseChannel(int channel_id) override; + Status<void> ModifyChannelEvents(int channel_id, int clear_mask, + int set_mask) override; Status<RemoteChannelHandle> PushChannel(Message* message, int flags, Channel* channel, int* channel_id) override; Status<int> CheckChannel(const Message* message, ChannelReference ref, Channel** channel) override; - int DefaultHandleMessage(const MessageInfo& info) override; - int MessageReceive(Message* message) override; - int MessageReply(Message* message, int return_code) override; - int MessageReplyFd(Message* message, unsigned int push_fd) override; - int MessageReplyChannelHandle(Message* message, - const LocalChannelHandle& handle) override; - int MessageReplyChannelHandle(Message* message, - const BorrowedChannelHandle& handle) override; - int MessageReplyChannelHandle(Message* message, - const RemoteChannelHandle& handle) override; - ssize_t ReadMessageData(Message* message, const iovec* vector, - size_t vector_length) override; - ssize_t WriteMessageData(Message* message, const iovec* vector, - size_t vector_length) override; - FileReference PushFileHandle(Message* message, - const LocalHandle& handle) override; - FileReference PushFileHandle(Message* message, - const BorrowedHandle& handle) override; - FileReference PushFileHandle(Message* message, - const RemoteHandle& handle) override; - ChannelReference PushChannelHandle(Message* message, - const LocalChannelHandle& handle) override; - ChannelReference PushChannelHandle( + Status<void> MessageReceive(Message* message) override; + Status<void> MessageReply(Message* message, int return_code) override; + Status<void> MessageReplyFd(Message* message, unsigned int push_fd) override; + Status<void> MessageReplyChannelHandle( + Message* message, const LocalChannelHandle& handle) override; + Status<void> MessageReplyChannelHandle( Message* message, const BorrowedChannelHandle& handle) override; - ChannelReference PushChannelHandle( + Status<void> MessageReplyChannelHandle( + Message* message, const RemoteChannelHandle& handle) override; + Status<size_t> ReadMessageData(Message* message, const iovec* vector, + size_t vector_length) override; + Status<size_t> WriteMessageData(Message* message, const iovec* vector, + size_t vector_length) override; + Status<FileReference> PushFileHandle(Message* message, + const LocalHandle& handle) override; + Status<FileReference> PushFileHandle(Message* message, + const BorrowedHandle& handle) override; + Status<FileReference> PushFileHandle(Message* message, + const RemoteHandle& handle) override; + Status<ChannelReference> PushChannelHandle( + Message* message, const LocalChannelHandle& handle) override; + Status<ChannelReference> PushChannelHandle( + Message* message, const BorrowedChannelHandle& handle) override; + Status<ChannelReference> PushChannelHandle( Message* message, const RemoteChannelHandle& handle) override; LocalHandle GetFileHandle(Message* message, FileReference ref) const override; LocalChannelHandle GetChannelHandle(Message* message, @@ -82,15 +81,22 @@ class Endpoint : public pdx::Endpoint { void* AllocateMessageState() override; void FreeMessageState(void* state) override; - int Cancel() override; + Status<void> Cancel() override; // Open an endpoint at the given path. // Second parameter is unused for UDS, but we have it here for compatibility // in signature with servicefs::Endpoint::Create(). + // This method uses |endpoint_path| as a relative path to endpoint socket + // created by init process. static std::unique_ptr<Endpoint> Create(const std::string& endpoint_path, mode_t /*unused_mode*/ = kDefaultMode, bool blocking = kDefaultBlocking); + // Helper method to create an endpoint at the given UDS socket path. This + // method physically creates and binds a socket at that path. + static std::unique_ptr<Endpoint> CreateAndBindSocket( + const std::string& endpoint_path, bool blocking = kDefaultBlocking); + int epoll_fd() const { return epoll_fd_.Get(); } private: @@ -101,7 +107,8 @@ class Endpoint : public pdx::Endpoint { }; // This class must be instantiated using Create() static methods above. - Endpoint(const std::string& endpoint_path, bool blocking); + Endpoint(const std::string& endpoint_path, bool blocking, + bool use_init_socket_fd = true); Endpoint(const Endpoint&) = delete; void operator=(const Endpoint&) = delete; @@ -117,7 +124,7 @@ class Endpoint : public pdx::Endpoint { Status<void> OnNewChannel(LocalHandle channel_fd); Status<ChannelData*> OnNewChannelLocked(LocalHandle channel_fd, Channel* channel_state); - int CloseChannelLocked(int channel_id); + Status<void> CloseChannelLocked(int channel_id); Status<void> ReenableEpollEvent(int fd); Channel* GetChannelState(int channel_id); int GetChannelSocketFd(int channel_id); diff --git a/libs/vr/libpdx_uds/remote_method_tests.cpp b/libs/vr/libpdx_uds/remote_method_tests.cpp index 905050092b..3109753dc2 100644 --- a/libs/vr/libpdx_uds/remote_method_tests.cpp +++ b/libs/vr/libpdx_uds/remote_method_tests.cpp @@ -342,87 +342,87 @@ class TestClient : public ClientBase<TestClient> { // Test service that encodes/decodes messages from clients. class TestService : public ServiceBase<TestService> { public: - int HandleMessage(Message& message) override { + Status<void> HandleMessage(Message& message) override { switch (message.GetOp()) { case TestInterface::Add::Opcode: DispatchRemoteMethod<TestInterface::Add>(*this, &TestService::OnAdd, message); - return 0; + return {}; case TestInterface::Foo::Opcode: DispatchRemoteMethod<TestInterface::Foo>(*this, &TestService::OnFoo, message); - return 0; + return {}; case TestInterface::Concatenate::Opcode: DispatchRemoteMethod<TestInterface::Concatenate>( *this, &TestService::OnConcatenate, message); - return 0; + return {}; case TestInterface::SumVector::Opcode: DispatchRemoteMethod<TestInterface::SumVector>( *this, &TestService::OnSumVector, message); - return 0; + return {}; case TestInterface::StringLength::Opcode: DispatchRemoteMethod<TestInterface::StringLength>( *this, &TestService::OnStringLength, message); - return 0; + return {}; case TestInterface::SendTestType::Opcode: DispatchRemoteMethod<TestInterface::SendTestType>( *this, &TestService::OnSendTestType, message); - return 0; + return {}; case TestInterface::SendVector::Opcode: DispatchRemoteMethod<TestInterface::SendVector>( *this, &TestService::OnSendVector, message); - return 0; + return {}; case TestInterface::Rot13::Opcode: DispatchRemoteMethod<TestInterface::Rot13>(*this, &TestService::OnRot13, message); - return 0; + return {}; case TestInterface::NoArgs::Opcode: DispatchRemoteMethod<TestInterface::NoArgs>( *this, &TestService::OnNoArgs, message); - return 0; + return {}; case TestInterface::SendFile::Opcode: DispatchRemoteMethod<TestInterface::SendFile>( *this, &TestService::OnSendFile, message); - return 0; + return {}; case TestInterface::GetFile::Opcode: DispatchRemoteMethod<TestInterface::GetFile>( *this, &TestService::OnGetFile, message); - return 0; + return {}; case TestInterface::GetTestFdType::Opcode: DispatchRemoteMethod<TestInterface::GetTestFdType>( *this, &TestService::OnGetTestFdType, message); - return 0; + return {}; case TestInterface::OpenFiles::Opcode: DispatchRemoteMethod<TestInterface::OpenFiles>( *this, &TestService::OnOpenFiles, message); - return 0; + return {}; case TestInterface::ReadFile::Opcode: DispatchRemoteMethod<TestInterface::ReadFile>( *this, &TestService::OnReadFile, message); - return 0; + return {}; case TestInterface::PushChannel::Opcode: DispatchRemoteMethod<TestInterface::PushChannel>( *this, &TestService::OnPushChannel, message); - return 0; + return {}; case TestInterface::Positive::Opcode: DispatchRemoteMethod<TestInterface::Positive>( *this, &TestService::OnPositive, message); - return 0; + return {}; default: return Service::DefaultHandleMessage(message); @@ -433,7 +433,8 @@ class TestService : public ServiceBase<TestService> { friend BASE; TestService() - : BASE("TestService", Endpoint::Create(TestInterface::kClientPath)) {} + : BASE("TestService", + Endpoint::CreateAndBindSocket(TestInterface::kClientPath)) {} int OnAdd(Message&, int a, int b) { return a + b; } diff --git a/libs/vr/libpdx_uds/service_dispatcher.cpp b/libs/vr/libpdx_uds/service_dispatcher.cpp index fa98f26826..2c52578d1c 100644 --- a/libs/vr/libpdx_uds/service_dispatcher.cpp +++ b/libs/vr/libpdx_uds/service_dispatcher.cpp @@ -30,7 +30,7 @@ ServiceDispatcher::ServiceDispatcher() { return; } - epoll_fd_.Reset(epoll_create(1)); // Size arg is ignored, but must be > 0. + epoll_fd_.Reset(epoll_create1(EPOLL_CLOEXEC)); if (!epoll_fd_) { ALOGE("Failed to create epoll fd because: %s\n", strerror(errno)); return; diff --git a/libs/vr/libpdx_uds/service_endpoint.cpp b/libs/vr/libpdx_uds/service_endpoint.cpp index 7bf753d921..6f32867dca 100644 --- a/libs/vr/libpdx_uds/service_endpoint.cpp +++ b/libs/vr/libpdx_uds/service_endpoint.cpp @@ -7,6 +7,9 @@ #include <sys/un.h> #include <algorithm> // std::min +#include <android-base/logging.h> +#include <android-base/strings.h> +#include <cutils/sockets.h> #include <pdx/service.h> #include <uds/channel_manager.h> #include <uds/client_channel_factory.h> @@ -19,6 +22,7 @@ constexpr int kMaxBackLogForSocketListen = 1; using android::pdx::BorrowedChannelHandle; using android::pdx::BorrowedHandle; using android::pdx::ChannelReference; +using android::pdx::ErrorStatus; using android::pdx::FileReference; using android::pdx::LocalChannelHandle; using android::pdx::LocalHandle; @@ -51,14 +55,14 @@ struct MessageState { return true; } - FileReference PushFileHandle(BorrowedHandle handle) { + Status<FileReference> PushFileHandle(BorrowedHandle handle) { if (!handle) return handle.Get(); response.file_descriptors.push_back(std::move(handle)); return response.file_descriptors.size() - 1; } - ChannelReference PushChannelHandle(BorrowedChannelHandle handle) { + Status<ChannelReference> PushChannelHandle(BorrowedChannelHandle handle) { if (!handle) return handle.value(); @@ -70,14 +74,14 @@ struct MessageState { response.channels.push_back(std::move(channel_info)); return response.channels.size() - 1; } else { - return -1; + return ErrorStatus{EINVAL}; } } - ChannelReference PushChannelHandle(BorrowedHandle data_fd, - BorrowedHandle event_fd) { + Status<ChannelReference> PushChannelHandle(BorrowedHandle data_fd, + BorrowedHandle event_fd) { if (!data_fd || !event_fd) - return -1; + return ErrorStatus{EINVAL}; ChannelInfo<BorrowedHandle> channel_info; channel_info.data_fd = std::move(data_fd); channel_info.event_fd = std::move(event_fd); @@ -85,8 +89,8 @@ struct MessageState { return response.channels.size() - 1; } - ssize_t WriteData(const iovec* vector, size_t vector_length) { - ssize_t size = 0; + Status<size_t> WriteData(const iovec* vector, size_t vector_length) { + size_t size = 0; for (size_t i = 0; i < vector_length; i++) { const auto* data = reinterpret_cast<const uint8_t*>(vector[i].iov_base); response_data.insert(response_data.end(), data, data + vector[i].iov_len); @@ -95,9 +99,9 @@ struct MessageState { return size; } - ssize_t ReadData(const iovec* vector, size_t vector_length) { + Status<size_t> ReadData(const iovec* vector, size_t vector_length) { size_t size_remaining = request_data.size() - request_data_read_pos; - ssize_t size = 0; + size_t size = 0; for (size_t i = 0; i < vector_length && size_remaining > 0; i++) { size_t size_to_copy = std::min(size_remaining, vector[i].iov_len); memcpy(vector[i].iov_base, request_data.data() + request_data_read_pos, @@ -123,43 +127,50 @@ namespace android { namespace pdx { namespace uds { -Endpoint::Endpoint(const std::string& endpoint_path, bool blocking) +Endpoint::Endpoint(const std::string& endpoint_path, bool blocking, + bool use_init_socket_fd) : endpoint_path_{ClientChannelFactory::GetEndpointPath(endpoint_path)}, is_blocking_{blocking} { - LocalHandle fd{socket(AF_UNIX, SOCK_STREAM, 0)}; - if (!fd) { - ALOGE("Endpoint::Endpoint: Failed to create socket: %s", strerror(errno)); - return; - } - - sockaddr_un local; - local.sun_family = AF_UNIX; - strncpy(local.sun_path, endpoint_path_.c_str(), sizeof(local.sun_path)); - local.sun_path[sizeof(local.sun_path) - 1] = '\0'; - - unlink(local.sun_path); - if (bind(fd.Get(), (struct sockaddr*)&local, sizeof(local)) == -1) { - ALOGE("Endpoint::Endpoint: bind error: %s", strerror(errno)); - return; - } - if (listen(fd.Get(), kMaxBackLogForSocketListen) == -1) { - ALOGE("Endpoint::Endpoint: listen error: %s", strerror(errno)); - return; + LocalHandle fd; + if (use_init_socket_fd) { + // Cut off the /dev/socket/ prefix from the full socket path and use the + // resulting "name" to retrieve the file descriptor for the socket created + // by the init process. + constexpr char prefix[] = "/dev/socket/"; + CHECK(android::base::StartsWith(endpoint_path_, prefix)) + << "Endpoint::Endpoint: Socket name '" << endpoint_path_ + << "' must begin with '" << prefix << "'"; + std::string socket_name = endpoint_path_.substr(sizeof(prefix) - 1); + fd.Reset(android_get_control_socket(socket_name.c_str())); + CHECK(fd.IsValid()) + << "Endpoint::Endpoint: Unable to obtain the control socket fd for '" + << socket_name << "'"; + fcntl(fd.Get(), F_SETFD, FD_CLOEXEC); + } else { + fd.Reset(socket(AF_UNIX, SOCK_STREAM | SOCK_CLOEXEC, 0)); + CHECK(fd.IsValid()) << "Endpoint::Endpoint: Failed to create socket: " + << strerror(errno); + + sockaddr_un local; + local.sun_family = AF_UNIX; + strncpy(local.sun_path, endpoint_path_.c_str(), sizeof(local.sun_path)); + local.sun_path[sizeof(local.sun_path) - 1] = '\0'; + + unlink(local.sun_path); + int ret = + bind(fd.Get(), reinterpret_cast<sockaddr*>(&local), sizeof(local)); + CHECK_EQ(ret, 0) << "Endpoint::Endpoint: bind error: " << strerror(errno); } + CHECK_EQ(listen(fd.Get(), kMaxBackLogForSocketListen), 0) + << "Endpoint::Endpoint: listen error: " << strerror(errno); cancel_event_fd_.Reset(eventfd(0, EFD_CLOEXEC | EFD_NONBLOCK)); - if (!cancel_event_fd_) { - ALOGE("Endpoint::Endpoint: Failed to create event fd: %s\n", - strerror(errno)); - return; - } + CHECK(cancel_event_fd_.IsValid()) + << "Endpoint::Endpoint: Failed to create event fd: " << strerror(errno); - epoll_fd_.Reset(epoll_create(1)); // Size arg is ignored, but must be > 0. - if (!epoll_fd_) { - ALOGE("Endpoint::Endpoint: Failed to create epoll fd: %s\n", - strerror(errno)); - return; - } + epoll_fd_.Reset(epoll_create1(EPOLL_CLOEXEC)); + CHECK(epoll_fd_.IsValid()) + << "Endpoint::Endpoint: Failed to create epoll fd: " << strerror(errno); epoll_event socket_event; socket_event.events = EPOLLIN | EPOLLRDHUP | EPOLLONESHOT; @@ -169,16 +180,16 @@ Endpoint::Endpoint(const std::string& endpoint_path, bool blocking) cancel_event.events = EPOLLIN; cancel_event.data.fd = cancel_event_fd_.Get(); - if (epoll_ctl(epoll_fd_.Get(), EPOLL_CTL_ADD, fd.Get(), &socket_event) < 0 || - epoll_ctl(epoll_fd_.Get(), EPOLL_CTL_ADD, cancel_event_fd_.Get(), - &cancel_event) < 0) { - ALOGE("Endpoint::Endpoint: Failed to add event fd to epoll fd: %s\n", - strerror(errno)); - cancel_event_fd_.Close(); - epoll_fd_.Close(); - } else { - socket_fd_ = std::move(fd); - } + int ret = epoll_ctl(epoll_fd_.Get(), EPOLL_CTL_ADD, fd.Get(), &socket_event); + CHECK_EQ(ret, 0) + << "Endpoint::Endpoint: Failed to add socket fd to epoll fd: " + << strerror(errno); + ret = epoll_ctl(epoll_fd_.Get(), EPOLL_CTL_ADD, cancel_event_fd_.Get(), + &cancel_event); + CHECK_EQ(ret, 0) + << "Endpoint::Endpoint: Failed to add cancel event fd to epoll fd: " + << strerror(errno); + socket_fd_ = std::move(fd); } void* Endpoint::AllocateMessageState() { return new MessageState; } @@ -190,8 +201,9 @@ void Endpoint::FreeMessageState(void* state) { Status<void> Endpoint::AcceptConnection(Message* message) { sockaddr_un remote; socklen_t addrlen = sizeof(remote); - LocalHandle channel_fd{ - accept(socket_fd_.Get(), reinterpret_cast<sockaddr*>(&remote), &addrlen)}; + LocalHandle channel_fd{accept4(socket_fd_.Get(), + reinterpret_cast<sockaddr*>(&remote), &addrlen, + SOCK_CLOEXEC)}; if (!channel_fd) { ALOGE("Endpoint::AcceptConnection: failed to accept connection: %s", strerror(errno)); @@ -214,18 +226,18 @@ Status<void> Endpoint::AcceptConnection(Message* message) { return status; } -int Endpoint::SetService(Service* service) { +Status<void> Endpoint::SetService(Service* service) { service_ = service; - return 0; + return {}; } -int Endpoint::SetChannel(int channel_id, Channel* channel) { +Status<void> Endpoint::SetChannel(int channel_id, Channel* channel) { std::lock_guard<std::mutex> autolock(channel_mutex_); auto channel_data = channels_.find(channel_id); if (channel_data == channels_.end()) - return -EINVAL; + return ErrorStatus{EINVAL}; channel_data->second.channel_state = channel; - return 0; + return {}; } Status<void> Endpoint::OnNewChannel(LocalHandle channel_fd) { @@ -269,44 +281,46 @@ Status<void> Endpoint::ReenableEpollEvent(int fd) { return {}; } -int Endpoint::CloseChannel(int channel_id) { +Status<void> Endpoint::CloseChannel(int channel_id) { std::lock_guard<std::mutex> autolock(channel_mutex_); return CloseChannelLocked(channel_id); } -int Endpoint::CloseChannelLocked(int channel_id) { +Status<void> Endpoint::CloseChannelLocked(int channel_id) { ALOGD_IF(TRACE, "Endpoint::CloseChannelLocked: channel_id=%d", channel_id); auto channel_data = channels_.find(channel_id); if (channel_data == channels_.end()) - return -EINVAL; + return ErrorStatus{EINVAL}; - int ret = 0; + Status<void> status; epoll_event dummy; // See BUGS in man 2 epoll_ctl. if (epoll_ctl(epoll_fd_.Get(), EPOLL_CTL_DEL, channel_id, &dummy) < 0) { - ret = -errno; + status.SetError(errno); ALOGE( "Endpoint::CloseChannelLocked: Failed to remove channel from endpoint: " "%s\n", strerror(errno)); + } else { + status.SetValue(); } channels_.erase(channel_data); - return ret; + return status; } -int Endpoint::ModifyChannelEvents(int channel_id, int clear_mask, - int set_mask) { +Status<void> Endpoint::ModifyChannelEvents(int channel_id, int clear_mask, + int set_mask) { std::lock_guard<std::mutex> autolock(channel_mutex_); auto search = channels_.find(channel_id); if (search != channels_.end()) { auto& channel_data = search->second; channel_data.event_set.ModifyEvents(clear_mask, set_mask); - return 0; + return {}; } - return -EINVAL; + return ErrorStatus{EINVAL}; } Status<RemoteChannelHandle> Endpoint::PushChannel(Message* message, @@ -314,7 +328,7 @@ Status<RemoteChannelHandle> Endpoint::PushChannel(Message* message, Channel* channel, int* channel_id) { int channel_pair[2] = {}; - if (socketpair(AF_UNIX, SOCK_STREAM, 0, channel_pair) == -1) { + if (socketpair(AF_UNIX, SOCK_STREAM | SOCK_CLOEXEC, 0, channel_pair) == -1) { ALOGE("Endpoint::PushChannel: Failed to create a socket pair: %s", strerror(errno)); return ErrorStatus(errno); @@ -337,17 +351,19 @@ Status<RemoteChannelHandle> Endpoint::PushChannel(Message* message, *channel_id = local_socket.Get(); auto channel_data = OnNewChannelLocked(std::move(local_socket), channel); if (!channel_data) - return ErrorStatus(channel_data.error()); + return channel_data.error_status(); // Flags are ignored for now. // TODO(xiaohuit): Implement those. auto* state = static_cast<MessageState*>(message->GetState()); - ChannelReference ref = state->PushChannelHandle( + Status<ChannelReference> ref = state->PushChannelHandle( remote_socket.Borrow(), channel_data.get()->event_set.event_fd().Borrow()); + if (!ref) + return ref.error_status(); state->sockets_to_close.push_back(std::move(remote_socket)); - return RemoteChannelHandle{ref}; + return RemoteChannelHandle{ref.get()}; } Status<int> Endpoint::CheckChannel(const Message* /*message*/, @@ -357,13 +373,6 @@ Status<int> Endpoint::CheckChannel(const Message* /*message*/, return ErrorStatus(EFAULT); } -int Endpoint::DefaultHandleMessage(const MessageInfo& /* info */) { - ALOGE( - "Endpoint::CheckChannel: Not implemented! Endpoint DefaultHandleMessage " - "does nothing!"); - return 0; -} - Channel* Endpoint::GetChannelState(int channel_id) { std::lock_guard<std::mutex> autolock(channel_mutex_); auto channel_data = channels_.find(channel_id); @@ -464,7 +473,7 @@ void Endpoint::BuildCloseMessage(int channel_id, Message* message) { *message = Message{info}; } -int Endpoint::MessageReceive(Message* message) { +Status<void> Endpoint::MessageReceive(Message* message) { // Receive at most one event from the epoll set. This should prevent multiple // dispatch threads from attempting to handle messages on the same socket at // the same time. @@ -474,40 +483,36 @@ int Endpoint::MessageReceive(Message* message) { if (count < 0) { ALOGE("Endpoint::MessageReceive: Failed to wait for epoll events: %s\n", strerror(errno)); - return -errno; + return ErrorStatus{errno}; } else if (count == 0) { - return -ETIMEDOUT; + return ErrorStatus{ETIMEDOUT}; } if (event.data.fd == cancel_event_fd_.Get()) { - return -ESHUTDOWN; + return ErrorStatus{ESHUTDOWN}; } if (event.data.fd == socket_fd_.Get()) { auto status = AcceptConnection(message); if (!status) - return -status.error(); - status = ReenableEpollEvent(socket_fd_.Get()); - return status ? 0 : -status.error(); + return status; + return ReenableEpollEvent(socket_fd_.Get()); } int channel_id = event.data.fd; if (event.events & (EPOLLRDHUP | EPOLLHUP)) { BuildCloseMessage(channel_id, message); - return 0; + return {}; } - auto status = ReceiveMessageForChannel(channel_id, message); - if (!status) - return -status.error(); - return 0; + return ReceiveMessageForChannel(channel_id, message); } -int Endpoint::MessageReply(Message* message, int return_code) { +Status<void> Endpoint::MessageReply(Message* message, int return_code) { const int channel_id = message->GetChannelId(); const int channel_socket = GetChannelSocketFd(channel_id); if (channel_socket < 0) - return -EBADF; + return ErrorStatus{EBADF}; auto* state = static_cast<MessageState*>(message->GetState()); switch (message->GetOp()) { @@ -515,12 +520,17 @@ int Endpoint::MessageReply(Message* message, int return_code) { return CloseChannel(channel_id); case opcodes::CHANNEL_OPEN: - if (return_code < 0) + if (return_code < 0) { return CloseChannel(channel_id); - // Reply with the event fd. - return_code = state->PushFileHandle( - BorrowedHandle{GetChannelEventFd(channel_socket)}); - state->response_data.clear(); // Just in case... + } else { + // Reply with the event fd. + auto push_status = state->PushFileHandle( + BorrowedHandle{GetChannelEventFd(channel_socket)}); + state->response_data.clear(); // Just in case... + if (!push_status) + return push_status.error_status(); + return_code = push_status.get(); + } break; } @@ -535,76 +545,82 @@ int Endpoint::MessageReply(Message* message, int return_code) { if (status) status = ReenableEpollEvent(channel_socket); - return status ? 0 : -status.error(); + return status; } -int Endpoint::MessageReplyFd(Message* message, unsigned int push_fd) { +Status<void> Endpoint::MessageReplyFd(Message* message, unsigned int push_fd) { auto* state = static_cast<MessageState*>(message->GetState()); auto ref = state->PushFileHandle(BorrowedHandle{static_cast<int>(push_fd)}); - return MessageReply(message, ref); + if (!ref) + return ref.error_status(); + return MessageReply(message, ref.get()); } -int Endpoint::MessageReplyChannelHandle(Message* message, - const LocalChannelHandle& handle) { +Status<void> Endpoint::MessageReplyChannelHandle( + Message* message, const LocalChannelHandle& handle) { auto* state = static_cast<MessageState*>(message->GetState()); auto ref = state->PushChannelHandle(handle.Borrow()); - return MessageReply(message, ref); + if (!ref) + return ref.error_status(); + return MessageReply(message, ref.get()); } -int Endpoint::MessageReplyChannelHandle(Message* message, - const BorrowedChannelHandle& handle) { +Status<void> Endpoint::MessageReplyChannelHandle( + Message* message, const BorrowedChannelHandle& handle) { auto* state = static_cast<MessageState*>(message->GetState()); auto ref = state->PushChannelHandle(handle.Duplicate()); - return MessageReply(message, ref); + if (!ref) + return ref.error_status(); + return MessageReply(message, ref.get()); } -int Endpoint::MessageReplyChannelHandle(Message* message, - const RemoteChannelHandle& handle) { +Status<void> Endpoint::MessageReplyChannelHandle( + Message* message, const RemoteChannelHandle& handle) { return MessageReply(message, handle.value()); } -ssize_t Endpoint::ReadMessageData(Message* message, const iovec* vector, - size_t vector_length) { +Status<size_t> Endpoint::ReadMessageData(Message* message, const iovec* vector, + size_t vector_length) { auto* state = static_cast<MessageState*>(message->GetState()); return state->ReadData(vector, vector_length); } -ssize_t Endpoint::WriteMessageData(Message* message, const iovec* vector, - size_t vector_length) { +Status<size_t> Endpoint::WriteMessageData(Message* message, const iovec* vector, + size_t vector_length) { auto* state = static_cast<MessageState*>(message->GetState()); return state->WriteData(vector, vector_length); } -FileReference Endpoint::PushFileHandle(Message* message, - const LocalHandle& handle) { +Status<FileReference> Endpoint::PushFileHandle(Message* message, + const LocalHandle& handle) { auto* state = static_cast<MessageState*>(message->GetState()); return state->PushFileHandle(handle.Borrow()); } -FileReference Endpoint::PushFileHandle(Message* message, - const BorrowedHandle& handle) { +Status<FileReference> Endpoint::PushFileHandle(Message* message, + const BorrowedHandle& handle) { auto* state = static_cast<MessageState*>(message->GetState()); return state->PushFileHandle(handle.Duplicate()); } -FileReference Endpoint::PushFileHandle(Message* /*message*/, - const RemoteHandle& handle) { +Status<FileReference> Endpoint::PushFileHandle(Message* /*message*/, + const RemoteHandle& handle) { return handle.Get(); } -ChannelReference Endpoint::PushChannelHandle(Message* message, - const LocalChannelHandle& handle) { +Status<ChannelReference> Endpoint::PushChannelHandle( + Message* message, const LocalChannelHandle& handle) { auto* state = static_cast<MessageState*>(message->GetState()); return state->PushChannelHandle(handle.Borrow()); } -ChannelReference Endpoint::PushChannelHandle( +Status<ChannelReference> Endpoint::PushChannelHandle( Message* message, const BorrowedChannelHandle& handle) { auto* state = static_cast<MessageState*>(message->GetState()); return state->PushChannelHandle(handle.Duplicate()); } -ChannelReference Endpoint::PushChannelHandle( +Status<ChannelReference> Endpoint::PushChannelHandle( Message* /*message*/, const RemoteChannelHandle& handle) { return handle.value(); } @@ -624,8 +640,10 @@ LocalChannelHandle Endpoint::GetChannelHandle(Message* message, return handle; } -int Endpoint::Cancel() { - return (eventfd_write(cancel_event_fd_.Get(), 1) < 0) ? -errno : 0; +Status<void> Endpoint::Cancel() { + if (eventfd_write(cancel_event_fd_.Get(), 1) < 0) + return ErrorStatus{errno}; + return {}; } std::unique_ptr<Endpoint> Endpoint::Create(const std::string& endpoint_path, @@ -634,6 +652,12 @@ std::unique_ptr<Endpoint> Endpoint::Create(const std::string& endpoint_path, return std::unique_ptr<Endpoint>(new Endpoint(endpoint_path, blocking)); } +std::unique_ptr<Endpoint> Endpoint::CreateAndBindSocket( + const std::string& endpoint_path, bool blocking) { + return std::unique_ptr<Endpoint>( + new Endpoint(endpoint_path, blocking, false)); +} + } // namespace uds } // namespace pdx } // namespace android diff --git a/libs/vr/libpdx_uds/service_framework_tests.cpp b/libs/vr/libpdx_uds/service_framework_tests.cpp index 9e31e82097..2943239495 100644 --- a/libs/vr/libpdx_uds/service_framework_tests.cpp +++ b/libs/vr/libpdx_uds/service_framework_tests.cpp @@ -119,106 +119,106 @@ class TestService : public ServiceBase<TestService> { } } - int HandleMessage(Message& message) override { + Status<void> HandleMessage(Message& message) override { switch (message.GetOp()) { case TEST_OP_GET_SERVICE_ID: - REPLY_MESSAGE_RETURN(message, service_id_, 0); + REPLY_MESSAGE_RETURN(message, service_id_, {}); // Set the test channel to the TestChannel for the current channel. Other // messages can use this to perform tests. case TEST_OP_SET_TEST_CHANNEL: test_channel_ = message.GetChannel<TestChannel>(); - REPLY_MESSAGE_RETURN(message, 0, 0); + REPLY_MESSAGE_RETURN(message, 0, {}); // Return the channel id for the current channel. case TEST_OP_GET_THIS_CHANNEL_ID: - REPLY_MESSAGE_RETURN(message, message.GetChannelId(), 0); + REPLY_MESSAGE_RETURN(message, message.GetChannelId(), {}); // Return the channel id for the test channel. case TEST_OP_GET_TEST_CHANNEL_ID: if (test_channel_) - REPLY_MESSAGE_RETURN(message, test_channel_->channel_id(), 0); + REPLY_MESSAGE_RETURN(message, test_channel_->channel_id(), {}); else - REPLY_ERROR_RETURN(message, ENOENT, 0); + REPLY_ERROR_RETURN(message, ENOENT, {}); // Test check channel feature. case TEST_OP_CHECK_CHANNEL_ID: { ChannelReference ref = 0; - if (message.Read(&ref, sizeof(ref)) < static_cast<ssize_t>(sizeof(ref))) - REPLY_ERROR_RETURN(message, EIO, 0); + if (!message.ReadAll(&ref, sizeof(ref))) + REPLY_ERROR_RETURN(message, EIO, {}); const Status<int> ret = message.CheckChannel<TestChannel>(ref, nullptr); - REPLY_MESSAGE_RETURN(message, ret, 0); + REPLY_MESSAGE_RETURN(message, ret, {}); } case TEST_OP_CHECK_CHANNEL_OBJECT: { std::shared_ptr<TestChannel> channel; ChannelReference ref = 0; - if (message.Read(&ref, sizeof(ref)) < static_cast<ssize_t>(sizeof(ref))) - REPLY_ERROR_RETURN(message, EIO, 0); + if (!message.ReadAll(&ref, sizeof(ref))) + REPLY_ERROR_RETURN(message, EIO, {}); const Status<int> ret = message.CheckChannel<TestChannel>(ref, &channel); if (!ret) - REPLY_MESSAGE_RETURN(message, ret, 0); + REPLY_MESSAGE_RETURN(message, ret, {}); if (channel != nullptr) - REPLY_MESSAGE_RETURN(message, channel->channel_id(), 0); + REPLY_MESSAGE_RETURN(message, channel->channel_id(), {}); else - REPLY_ERROR_RETURN(message, ENODATA, 0); + REPLY_ERROR_RETURN(message, ENODATA, {}); } case TEST_OP_CHECK_CHANNEL_FROM_OTHER_SERVICE: { ChannelReference ref = 0; - if (message.Read(&ref, sizeof(ref)) < static_cast<ssize_t>(sizeof(ref))) - REPLY_ERROR_RETURN(message, EIO, 0); + if (!message.ReadAll(&ref, sizeof(ref))) + REPLY_ERROR_RETURN(message, EIO, {}); const Status<int> ret = message.CheckChannel<TestChannel>( other_service_.get(), ref, nullptr); - REPLY_MESSAGE_RETURN(message, ret, 0); + REPLY_MESSAGE_RETURN(message, ret, {}); } case TEST_OP_GET_NEW_CHANNEL: { auto channel = std::make_shared<TestChannel>(-1); Status<RemoteChannelHandle> channel_handle = message.PushChannel(0, channel, &channel->channel_id_); - REPLY_MESSAGE_RETURN(message, channel_handle, 0); + REPLY_MESSAGE_RETURN(message, channel_handle, {}); } case TEST_OP_GET_NEW_CHANNEL_FROM_OTHER_SERVICE: { if (!other_service_) - REPLY_ERROR_RETURN(message, EINVAL, 0); + REPLY_ERROR_RETURN(message, EINVAL, {}); auto channel = std::make_shared<TestChannel>(-1); Status<RemoteChannelHandle> channel_handle = message.PushChannel( other_service_.get(), 0, channel, &channel->channel_id_); - REPLY_MESSAGE_RETURN(message, channel_handle, 0); + REPLY_MESSAGE_RETURN(message, channel_handle, {}); } case TEST_OP_GET_THIS_PROCESS_ID: - REPLY_MESSAGE_RETURN(message, message.GetProcessId(), 0); + REPLY_MESSAGE_RETURN(message, message.GetProcessId(), {}); case TEST_OP_GET_THIS_THREAD_ID: - REPLY_MESSAGE_RETURN(message, message.GetThreadId(), 0); + REPLY_MESSAGE_RETURN(message, message.GetThreadId(), {}); case TEST_OP_GET_THIS_EUID: - REPLY_MESSAGE_RETURN(message, message.GetEffectiveUserId(), 0); + REPLY_MESSAGE_RETURN(message, message.GetEffectiveUserId(), {}); case TEST_OP_GET_THIS_EGID: - REPLY_MESSAGE_RETURN(message, message.GetEffectiveGroupId(), 0); + REPLY_MESSAGE_RETURN(message, message.GetEffectiveGroupId(), {}); case TEST_OP_POLLIN_FROM_SERVICE: REPLY_MESSAGE_RETURN(message, message.ModifyChannelEvents(0, EPOLLIN), - 0); + {}); case TEST_OP_SEND_LARGE_DATA_RETURN_SUM: { std::array<int, kLargeDataSize> data_array; - ssize_t size_to_read = data_array.size() * sizeof(int); - ssize_t read = message.Read(data_array.data(), size_to_read); - if (read < size_to_read) - REPLY_ERROR_RETURN(message, EIO, 0); + size_t size_to_read = data_array.size() * sizeof(int); + if (!message.ReadAll(data_array.data(), size_to_read)) { + REPLY_ERROR_RETURN(message, EIO, {}); + } int sum = std::accumulate(data_array.begin(), data_array.end(), 0); - REPLY_MESSAGE_RETURN(message, sum, 0); + REPLY_MESSAGE_RETURN(message, sum, {}); } default: @@ -245,7 +245,7 @@ class TestService : public ServiceBase<TestService> { TestService(const std::string& name, const std::shared_ptr<TestService>& other_service, bool blocking) : BASE(std::string("TestService") + name, - Endpoint::Create(kTestServicePath + name, blocking)), + Endpoint::CreateAndBindSocket(kTestServicePath + name, blocking)), other_service_(other_service), service_id_(service_counter_++) {} @@ -300,7 +300,7 @@ class TestClient : public ClientBase<TestClient> { // Returns the channel id of the channel. int CheckChannelIdArgument(BorrowedChannelHandle channel) { Transaction trans{*this}; - ChannelReference ref = trans.PushChannelHandle(channel); + ChannelReference ref = trans.PushChannelHandle(channel).get(); return ReturnStatusOrError(trans.Send<int>(TEST_OP_CHECK_CHANNEL_ID, &ref, sizeof(ref), nullptr, 0)); } @@ -309,7 +309,7 @@ class TestClient : public ClientBase<TestClient> { // Returns the channel id of the channel exercising the context pointer. int CheckChannelObjectArgument(BorrowedChannelHandle channel) { Transaction trans{*this}; - ChannelReference ref = trans.PushChannelHandle(channel); + ChannelReference ref = trans.PushChannelHandle(channel).get(); return ReturnStatusOrError(trans.Send<int>(TEST_OP_CHECK_CHANNEL_OBJECT, &ref, sizeof(ref), nullptr, 0)); } @@ -318,7 +318,7 @@ class TestClient : public ClientBase<TestClient> { // Returns 0 on success. int CheckChannelFromOtherService(BorrowedChannelHandle channel) { Transaction trans{*this}; - ChannelReference ref = trans.PushChannelHandle(channel); + ChannelReference ref = trans.PushChannelHandle(channel).get(); return ReturnStatusOrError( trans.Send<int>(TEST_OP_CHECK_CHANNEL_FROM_OTHER_SERVICE, &ref, sizeof(ref), nullptr, 0)); diff --git a/libs/vr/libposepredictor/include/polynomial_predictor.h b/libs/vr/libposepredictor/include/polynomial_predictor.h index 762afd3b90..4b8d51bcb2 100644 --- a/libs/vr/libposepredictor/include/polynomial_predictor.h +++ b/libs/vr/libposepredictor/include/polynomial_predictor.h @@ -19,7 +19,7 @@ class PolynomialPosePredictor : public BufferedPredictor { public: PolynomialPosePredictor(real regularization = 1e-9) : BufferedPredictor(TrainingWindow), regularization_(regularization) { - static_assert(PolynomialDegree + 1 >= TrainingWindow, + static_assert(TrainingWindow >= PolynomialDegree + 1, "Underconstrained polynomial regressor"); } diff --git a/libs/vr/libposepredictor/predictor.cpp b/libs/vr/libposepredictor/predictor.cpp index 4d2eafdb2e..beba156378 100644 --- a/libs/vr/libposepredictor/predictor.cpp +++ b/libs/vr/libposepredictor/predictor.cpp @@ -5,7 +5,7 @@ namespace posepredictor { vec3 Predictor::AngularVelocity(const quat& a, const quat& b, real delta_time) { - const auto delta_q = b.inverse() * a; + const auto delta_q = a.inverse() * b; // Check that delta_q.w() == 1, Eigen doesn't respect this convention. If // delta_q.w() == -1, we'll get the opposite velocity. return 2.0 * (delta_q.w() < 0 ? static_cast<vec3>(-delta_q.vec()) : delta_q.vec()) / delta_time; diff --git a/libs/vr/libvrflinger/display_manager_service.cpp b/libs/vr/libvrflinger/display_manager_service.cpp index e07901d0e6..49b6f095b7 100644 --- a/libs/vr/libvrflinger/display_manager_service.cpp +++ b/libs/vr/libvrflinger/display_manager_service.cpp @@ -32,12 +32,12 @@ namespace android { namespace dvr { void DisplayManager::SetNotificationsPending(bool pending) { - int ret = service_->ModifyChannelEvents(channel_id_, pending ? 0 : POLLIN, - pending ? POLLIN : 0); - ALOGE_IF(ret < 0, + auto status = service_->ModifyChannelEvents(channel_id_, pending ? 0 : POLLIN, + pending ? POLLIN : 0); + ALOGE_IF(!status, "DisplayManager::SetNotificationPending: Failed to modify channel " "events: %s", - strerror(-ret)); + status.GetErrorMessage().c_str()); } DisplayManagerService::DisplayManagerService( @@ -68,24 +68,24 @@ void DisplayManagerService::OnChannelClose( display_manager_ = nullptr; } -int DisplayManagerService::HandleMessage(pdx::Message& message) { +pdx::Status<void> DisplayManagerService::HandleMessage(pdx::Message& message) { auto channel = std::static_pointer_cast<DisplayManager>(message.GetChannel()); switch (message.GetOp()) { case DisplayManagerRPC::GetSurfaceList::Opcode: DispatchRemoteMethod<DisplayManagerRPC::GetSurfaceList>( *this, &DisplayManagerService::OnGetSurfaceList, message); - return 0; + return {}; case DisplayManagerRPC::UpdateSurfaces::Opcode: DispatchRemoteMethod<DisplayManagerRPC::UpdateSurfaces>( *this, &DisplayManagerService::OnUpdateSurfaces, message); - return 0; + return {}; case DisplayManagerRPC::SetupPoseBuffer::Opcode: DispatchRemoteMethod<DisplayManagerRPC::SetupPoseBuffer>( *this, &DisplayManagerService::OnSetupPoseBuffer, message); - return 0; + return {}; default: return Service::DefaultHandleMessage(message); @@ -189,7 +189,7 @@ int DisplayManagerService::OnUpdateSurfaces( } pdx::BorrowedChannelHandle DisplayManagerService::OnSetupPoseBuffer( - pdx::Message& message, size_t extended_region_size, int usage) { + pdx::Message& /*message*/, size_t extended_region_size, int usage) { return display_service_->SetupPoseBuffer(extended_region_size, usage); } diff --git a/libs/vr/libvrflinger/display_manager_service.h b/libs/vr/libvrflinger/display_manager_service.h index 19098c27c2..80324fd6d4 100644 --- a/libs/vr/libvrflinger/display_manager_service.h +++ b/libs/vr/libvrflinger/display_manager_service.h @@ -42,7 +42,7 @@ class DisplayManagerService : public pdx::ServiceBase<DisplayManagerService> { std::shared_ptr<pdx::Channel> OnChannelOpen(pdx::Message& message) override; void OnChannelClose(pdx::Message& message, const std::shared_ptr<pdx::Channel>& channel) override; - int HandleMessage(pdx::Message& message) override; + pdx::Status<void> HandleMessage(pdx::Message& message) override; private: friend BASE; diff --git a/libs/vr/libvrflinger/display_service.cpp b/libs/vr/libvrflinger/display_service.cpp index c0791879a2..3750ea37a4 100644 --- a/libs/vr/libvrflinger/display_service.cpp +++ b/libs/vr/libvrflinger/display_service.cpp @@ -65,39 +65,39 @@ void DisplayService::OnChannelClose(pdx::Message& /*message*/, // First-level dispatch for display service messages. Directly handles messages // that are independent of the display surface (metrics, creation) and routes // surface-specific messages to the per-instance handlers. -int DisplayService::HandleMessage(pdx::Message& message) { +pdx::Status<void> DisplayService::HandleMessage(pdx::Message& message) { auto channel = message.GetChannel<SurfaceChannel>(); switch (message.GetOp()) { case DisplayRPC::GetMetrics::Opcode: DispatchRemoteMethod<DisplayRPC::GetMetrics>( *this, &DisplayService::OnGetMetrics, message); - return 0; + return {}; case DisplayRPC::GetEdsCapture::Opcode: DispatchRemoteMethod<DisplayRPC::GetEdsCapture>( *this, &DisplayService::OnGetEdsCapture, message); - return 0; + return {}; case DisplayRPC::CreateSurface::Opcode: DispatchRemoteMethod<DisplayRPC::CreateSurface>( *this, &DisplayService::OnCreateSurface, message); - return 0; + return {}; case DisplayRPC::SetViewerParams::Opcode: DispatchRemoteMethod<DisplayRPC::SetViewerParams>( *this, &DisplayService::OnSetViewerParams, message); - return 0; + return {}; case DisplayRPC::GetPoseBuffer::Opcode: DispatchRemoteMethod<DisplayRPC::GetPoseBuffer>( *this, &DisplayService::OnGetPoseBuffer, message); - return 0; + return {}; case DisplayRPC::IsVrAppRunning::Opcode: DispatchRemoteMethod<DisplayRPC::IsVrAppRunning>( *this, &DisplayService::IsVrAppRunning, message); - return 0; + return {}; // Direct the surface specific messages to the surface instance. case DisplayRPC::CreateBufferQueue::Opcode: @@ -265,7 +265,7 @@ pdx::LocalChannelHandle DisplayService::OnGetPoseBuffer(pdx::Message& message) { // Calls the message handler for the DisplaySurface associated with this // channel. -int DisplayService::HandleSurfaceMessage(pdx::Message& message) { +pdx::Status<void> DisplayService::HandleSurfaceMessage(pdx::Message& message) { auto surface = std::static_pointer_cast<SurfaceChannel>(message.GetChannel()); ALOGW_IF(!surface, "DisplayService::HandleSurfaceMessage: surface is nullptr!"); @@ -273,7 +273,7 @@ int DisplayService::HandleSurfaceMessage(pdx::Message& message) { if (surface) return surface->HandleMessage(message); else - REPLY_ERROR_RETURN(message, EINVAL, 0); + REPLY_ERROR_RETURN(message, EINVAL, {}); } std::shared_ptr<DisplaySurface> DisplayService::GetDisplaySurface( diff --git a/libs/vr/libvrflinger/display_service.h b/libs/vr/libvrflinger/display_service.h index 8e961725ee..da80a84510 100644 --- a/libs/vr/libvrflinger/display_service.h +++ b/libs/vr/libvrflinger/display_service.h @@ -27,7 +27,7 @@ class DisplayService : public pdx::ServiceBase<DisplayService> { void OnChannelClose(pdx::Message& message, const std::shared_ptr<pdx::Channel>& channel) override; - int HandleMessage(pdx::Message& message) override; + pdx::Status<void> HandleMessage(pdx::Message& message) override; std::shared_ptr<DisplaySurface> GetDisplaySurface(int surface_id) const; std::vector<std::shared_ptr<DisplaySurface>> GetDisplaySurfaces() const; @@ -94,7 +94,7 @@ class DisplayService : public pdx::ServiceBase<DisplayService> { // the display manager should be notified. void NotifyDisplayConfigurationUpdate(); - int HandleSurfaceMessage(pdx::Message& message); + pdx::Status<void> HandleSurfaceMessage(pdx::Message& message); DisplayService(const DisplayService&) = delete; void operator=(const DisplayService&) = delete; diff --git a/libs/vr/libvrflinger/display_surface.cpp b/libs/vr/libvrflinger/display_surface.cpp index 66e99255e1..a7220feedd 100644 --- a/libs/vr/libvrflinger/display_surface.cpp +++ b/libs/vr/libvrflinger/display_surface.cpp @@ -206,7 +206,7 @@ bool DisplaySurface::IsBufferPosted() { return !acquired_buffers_.IsEmpty(); } -int DisplaySurface::HandleMessage(pdx::Message& message) { +pdx::Status<void> DisplaySurface::HandleMessage(pdx::Message& message) { switch (message.GetOp()) { case DisplayRPC::SetAttributes::Opcode: DispatchRemoteMethod<DisplayRPC::SetAttributes>( @@ -227,7 +227,7 @@ int DisplaySurface::HandleMessage(pdx::Message& message) { return SurfaceChannel::HandleMessage(message); } - return 0; + return {}; } int DisplaySurface::OnClientSetAttributes( @@ -301,7 +301,7 @@ RemoteChannelHandle DisplaySurface::OnCreateVideoMeshSurface( pdx::Message& message) { if (flags_ & DVR_DISPLAY_SURFACE_FLAGS_DISABLE_SYSTEM_DISTORTION) { ALOGE( - "DisplaySurface::OnCreateVideoMeshSurface: system distorion is " + "DisplaySurface::OnCreateVideoMeshSurface: system distortion is " "disabled on this display surface, cannot create VideoMeshSurface on " "top of it."); REPLY_ERROR_RETURN(message, EINVAL, {}); @@ -309,22 +309,21 @@ RemoteChannelHandle DisplaySurface::OnCreateVideoMeshSurface( int channel_id; auto status = message.PushChannel(0, nullptr, &channel_id); - if (!status) { ALOGE( "DisplaySurface::OnCreateVideoMeshSurface: failed to push channel: %s", status.GetErrorMessage().c_str()); - REPLY_ERROR_RETURN(message, ENOMEM, {}); + REPLY_ERROR_RETURN(message, status.error(), {}); } auto surface = std::make_shared<VideoMeshSurface>(service(), channel_id); - const int ret = service()->SetChannel(channel_id, surface); - if (ret < 0) { + auto channel_status = service()->SetChannel(channel_id, surface); + if (!channel_status) { ALOGE( "DisplaySurface::OnCreateVideoMeshSurface: failed to set new video " "mesh surface channel: %s", - strerror(-ret)); - REPLY_ERROR_RETURN(message, ENOMEM, {}); + channel_status.GetErrorMessage().c_str()); + REPLY_ERROR_RETURN(message, channel_status.error(), {}); } { diff --git a/libs/vr/libvrflinger/display_surface.h b/libs/vr/libvrflinger/display_surface.h index d31a3a9288..2e4cf75d4d 100644 --- a/libs/vr/libvrflinger/display_surface.h +++ b/libs/vr/libvrflinger/display_surface.h @@ -106,7 +106,7 @@ class DisplaySurface : public SurfaceChannel { // Dispatches display surface messages to the appropriate handlers. This // handler runs on the displayd message dispatch thread. - int HandleMessage(pdx::Message& message) override; + pdx::Status<void> HandleMessage(pdx::Message& message) override; // Sets display surface's client-controlled attributes. int OnClientSetAttributes(pdx::Message& message, diff --git a/libs/vr/libvrflinger/screenshot_service.cpp b/libs/vr/libvrflinger/screenshot_service.cpp index fd1c5820e7..d14d58839a 100644 --- a/libs/vr/libvrflinger/screenshot_service.cpp +++ b/libs/vr/libvrflinger/screenshot_service.cpp @@ -19,17 +19,17 @@ namespace dvr { ScreenshotService::~ScreenshotService() { instance_ = nullptr; } -int ScreenshotService::HandleMessage(pdx::Message& message) { +pdx::Status<void> ScreenshotService::HandleMessage(pdx::Message& message) { switch (message.GetOp()) { case DisplayScreenshotRPC::GetFormat::Opcode: DispatchRemoteMethod<DisplayScreenshotRPC::GetFormat>( *this, &ScreenshotService::OnGetFormat, message); - return 0; + return {}; case DisplayScreenshotRPC::TakeScreenshot::Opcode: DispatchRemoteMethod<DisplayScreenshotRPC::TakeScreenshot>( *this, &ScreenshotService::OnTakeScreenshot, message); - return 0; + return {}; default: return Service::HandleMessage(message); diff --git a/libs/vr/libvrflinger/screenshot_service.h b/libs/vr/libvrflinger/screenshot_service.h index ec4c5270de..f59e87224f 100644 --- a/libs/vr/libvrflinger/screenshot_service.h +++ b/libs/vr/libvrflinger/screenshot_service.h @@ -38,7 +38,7 @@ class ScreenshotService : public pdx::ServiceBase<ScreenshotService> { public: ~ScreenshotService(); - int HandleMessage(pdx::Message& message) override; + pdx::Status<void> HandleMessage(pdx::Message& message) override; // Returns true if there is a pending screenshot request. bool IsScreenshotRequestPending() const { diff --git a/libs/vr/libvrflinger/surface_channel.cpp b/libs/vr/libvrflinger/surface_channel.cpp index 8aa220b989..263b382993 100644 --- a/libs/vr/libvrflinger/surface_channel.cpp +++ b/libs/vr/libvrflinger/surface_channel.cpp @@ -7,7 +7,7 @@ using android::pdx::rpc::DispatchRemoteMethod; namespace android { namespace dvr { -int SurfaceChannel::HandleMessage(Message& message) { +pdx::Status<void> SurfaceChannel::HandleMessage(Message& message) { switch (message.GetOp()) { case DisplayRPC::GetMetadataBuffer::Opcode: DispatchRemoteMethod<DisplayRPC::GetMetadataBuffer>( @@ -15,7 +15,7 @@ int SurfaceChannel::HandleMessage(Message& message) { break; } - return 0; + return {}; } BorrowedChannelHandle SurfaceChannel::OnGetMetadataBuffer(Message& message) { diff --git a/libs/vr/libvrflinger/surface_channel.h b/libs/vr/libvrflinger/surface_channel.h index 870e1a4f30..bb6b1c5e92 100644 --- a/libs/vr/libvrflinger/surface_channel.h +++ b/libs/vr/libvrflinger/surface_channel.h @@ -33,7 +33,7 @@ class SurfaceChannel : public pdx::Channel { // Dispatches surface channel messages to the appropriate handlers. This // handler runs on the displayd message dispatch thread. - virtual int HandleMessage(pdx::Message& message); + virtual pdx::Status<void> HandleMessage(pdx::Message& message); protected: // Contains the surface metadata. diff --git a/libs/vr/libvrflinger/video_mesh_surface.cpp b/libs/vr/libvrflinger/video_mesh_surface.cpp index a961a3db51..d915a4a382 100644 --- a/libs/vr/libvrflinger/video_mesh_surface.cpp +++ b/libs/vr/libvrflinger/video_mesh_surface.cpp @@ -14,7 +14,7 @@ VideoMeshSurface::VideoMeshSurface(DisplayService* service, int surface_id) VideoMeshSurface::~VideoMeshSurface() {} -int VideoMeshSurface::HandleMessage(Message& message) { +pdx::Status<void> VideoMeshSurface::HandleMessage(Message& message) { ATRACE_NAME("VideoMeshSurface::HandleMessage"); switch (message.GetOp()) { @@ -27,7 +27,7 @@ int VideoMeshSurface::HandleMessage(Message& message) { return SurfaceChannel::HandleMessage(message); } - return 0; + return {}; } std::shared_ptr<ConsumerQueue> VideoMeshSurface::GetConsumerQueue() { diff --git a/libs/vr/libvrflinger/video_mesh_surface.h b/libs/vr/libvrflinger/video_mesh_surface.h index 1370793acf..2c9f3e8767 100644 --- a/libs/vr/libvrflinger/video_mesh_surface.h +++ b/libs/vr/libvrflinger/video_mesh_surface.h @@ -12,7 +12,7 @@ class DisplayService; // VideoMeshSurface takes three inputs: 1) buffers filled by Android system // components (e.g. MediaCodec or camera stack) other than applications' GL -// context; 2) a 3D mesh choosen by application to define the shape of the +// context; 2) a 3D mesh chosen by application to define the shape of the // surface; 3) a transformation matrix from application to define the rotation, // position, and scaling of the video surface. class VideoMeshSurface : public SurfaceChannel { @@ -33,7 +33,7 @@ class VideoMeshSurface : public SurfaceChannel { } } - int HandleMessage(Message& message) override; + pdx::Status<void> HandleMessage(Message& message) override; std::shared_ptr<ConsumerQueue> GetConsumerQueue(); diff --git a/libs/vr/libvrflinger/vsync_service.cpp b/libs/vr/libvrflinger/vsync_service.cpp index 48fa2c27af..612b9b2ba1 100644 --- a/libs/vr/libvrflinger/vsync_service.cpp +++ b/libs/vr/libvrflinger/vsync_service.cpp @@ -107,26 +107,26 @@ void VSyncService::UpdateClients() { } } -int VSyncService::HandleMessage(pdx::Message& message) { +pdx::Status<void> VSyncService::HandleMessage(pdx::Message& message) { switch (message.GetOp()) { case DisplayVSyncRPC::Wait::Opcode: AddWaiter(message); - return 0; + return {}; case DisplayVSyncRPC::GetLastTimestamp::Opcode: DispatchRemoteMethod<DisplayVSyncRPC::GetLastTimestamp>( *this, &VSyncService::OnGetLastTimestamp, message); - return 0; + return {}; case DisplayVSyncRPC::GetSchedInfo::Opcode: DispatchRemoteMethod<DisplayVSyncRPC::GetSchedInfo>( *this, &VSyncService::OnGetSchedInfo, message); - return 0; + return {}; case DisplayVSyncRPC::Acknowledge::Opcode: DispatchRemoteMethod<DisplayVSyncRPC::Acknowledge>( *this, &VSyncService::OnAcknowledge, message); - return 0; + return {}; default: return Service::HandleMessage(message); diff --git a/libs/vr/libvrflinger/vsync_service.h b/libs/vr/libvrflinger/vsync_service.h index ba1d4df60b..1c86d4272d 100644 --- a/libs/vr/libvrflinger/vsync_service.h +++ b/libs/vr/libvrflinger/vsync_service.h @@ -56,7 +56,7 @@ class VSyncService : public pdx::ServiceBase<VSyncService> { public: ~VSyncService() override; - int HandleMessage(pdx::Message& message) override; + pdx::Status<void> HandleMessage(pdx::Message& message) override; std::shared_ptr<pdx::Channel> OnChannelOpen(pdx::Message& message) override; void OnChannelClose(pdx::Message& message, diff --git a/libs/vr/libvrsensor/Android.bp b/libs/vr/libvrsensor/Android.bp index 6d48f18385..d59182efe7 100644 --- a/libs/vr/libvrsensor/Android.bp +++ b/libs/vr/libvrsensor/Android.bp @@ -15,6 +15,7 @@ sourceFiles = [ "pose_client.cpp", "sensor_client.cpp", + "latency_model.cpp", ] includeFiles = [ diff --git a/libs/vr/libvrsensor/include/private/dvr/latency_model.h b/libs/vr/libvrsensor/include/private/dvr/latency_model.h new file mode 100644 index 0000000000..1bb3c4fdd8 --- /dev/null +++ b/libs/vr/libvrsensor/include/private/dvr/latency_model.h @@ -0,0 +1,31 @@ +#ifndef ANDROID_DVR_LATENCY_MODEL_H_ +#define ANDROID_DVR_LATENCY_MODEL_H_ + +#include <vector> + +namespace android { +namespace dvr { + +// This class holds a rolling average of the sensor latency. +class LatencyModel { + public: + LatencyModel(size_t window_size, double weight_mass_in_window); + ~LatencyModel() = default; + + void AddLatency(int64_t latency_ns); + int64_t CurrentLatencyEstimate() const { + return static_cast<int64_t>(rolling_average_); + } + + private: + // The rolling average of the latencies. + double rolling_average_ = 0; + + // The alpha parameter for an exponential moving average. + double alpha_; +}; + +} // namespace dvr +} // namespace android + +#endif // ANDROID_DVR_LATENCY_MODEL_H_ diff --git a/libs/vr/libvrsensor/latency_model.cpp b/libs/vr/libvrsensor/latency_model.cpp new file mode 100644 index 0000000000..8233889383 --- /dev/null +++ b/libs/vr/libvrsensor/latency_model.cpp @@ -0,0 +1,33 @@ +#include <private/dvr/latency_model.h> + +#include <cmath> + +namespace android { +namespace dvr { + +LatencyModel::LatencyModel(size_t window_size, double weight_mass_in_window) { + // Compute an alpha so the weight of the last window_size measurements is + // weight_mass_in_window of the total weights. + + // The weight in a series of k measurements: + // alpha + (1 + (1 - alpha) + (1 - alpha)^2 + ... (1 - alpha)^k-1) + // = alpha x (1 - (1 - alpha) ^ k) / alpha + // = 1 - (1 - alpha) ^ k + // weight_mass_in_window = 1 - (1 - alpha) ^ k / lim_k->inf (1 - alpha) ^ k + // weight_mass_in_window = 1 - (1 - alpha) ^ k / 1 + // 1 - weight_mass_in_window = (1 - alpha) ^ k + // log(1 - weight_mass_in_window) = k * log(1 - alpha) + // 10 ^ (log(1 - weight_mass_in_window) / k) = 1 - alpha + // alpha = 1 - 10 ^ (log(1 - weight_mass_in_window) / k) + // alpha = 1 - 10 ^ (log(1 - weight_mass_in_window) / window_size) + + alpha_ = 1 - std::pow(10.0, std::log10(1 - weight_mass_in_window) / + static_cast<double>(window_size)); +} + +void LatencyModel::AddLatency(int64_t latency_ns) { + rolling_average_ = latency_ns * alpha_ + rolling_average_ * (1 - alpha_); +} + +} // namespace dvr +} // namespace android diff --git a/opengl/libs/EGL/egl_object.cpp b/opengl/libs/EGL/egl_object.cpp index 7ed34be89a..623878062b 100644 --- a/opengl/libs/EGL/egl_object.cpp +++ b/opengl/libs/EGL/egl_object.cpp @@ -114,7 +114,7 @@ void egl_context_t::onMakeCurrent(EGLSurface draw, EGLSurface read) { // call the implementation's glGetString(GL_EXTENSIONS) const char* exts = (const char *)gEGLImpl.hooks[version]->gl.glGetString(GL_EXTENSIONS); gl_extensions = exts; - if (gl_extensions.find("GL_EXT_debug_marker") != std::string::npos) { + if (gl_extensions.find("GL_EXT_debug_marker") == std::string::npos) { gl_extensions.insert(0, "GL_EXT_debug_marker "); } diff --git a/services/sensorservice/hidl/Android.bp b/services/sensorservice/hidl/Android.bp index f00c297c72..748dafcf62 100644 --- a/services/sensorservice/hidl/Android.bp +++ b/services/sensorservice/hidl/Android.bp @@ -1,6 +1,7 @@ cc_library_shared { name: "libsensorservicehidl", srcs: [ + "EventQueue.cpp", "DirectReportChannel.cpp", "SensorManager.cpp", "utils.cpp", @@ -19,6 +20,9 @@ cc_library_shared { "android.hardware.sensors@1.0", "android.hidl.base@1.0", ], + static_libs: [ + "android.hardware.sensors@1.0-convert", + ], export_include_dirs: [ "include/" ], diff --git a/services/sensorservice/hidl/DirectReportChannel.cpp b/services/sensorservice/hidl/DirectReportChannel.cpp index 9caba47912..773ce8cd0a 100644 --- a/services/sensorservice/hidl/DirectReportChannel.cpp +++ b/services/sensorservice/hidl/DirectReportChannel.cpp @@ -32,8 +32,9 @@ DirectReportChannel::~DirectReportChannel() { // Methods from ::android::frameworks::sensorservice::V1_0::IDirectReportChannel follow. Return<Result> DirectReportChannel::configure(int32_t sensorHandle, RateLevel rate) { - return convertResult(mManager.configureDirectChannel(mId, - static_cast<int>(sensorHandle), static_cast<int>(rate))); + int token = mManager.configureDirectChannel(mId, + static_cast<int>(sensorHandle), static_cast<int>(rate)); + return token <= 0 ? convertResult(token) : Result::OK; } diff --git a/services/sensorservice/hidl/DirectReportChannel.h b/services/sensorservice/hidl/DirectReportChannel.h index f4cd4e77d3..913494427d 100644 --- a/services/sensorservice/hidl/DirectReportChannel.h +++ b/services/sensorservice/hidl/DirectReportChannel.h @@ -41,7 +41,7 @@ using ::android::hardware::Return; using ::android::hardware::Void; using ::android::sp; -struct DirectReportChannel : public IDirectReportChannel { +struct DirectReportChannel final : public IDirectReportChannel { DirectReportChannel(::android::SensorManager& manager, int channelId); ~DirectReportChannel(); diff --git a/services/sensorservice/hidl/EventQueue.cpp b/services/sensorservice/hidl/EventQueue.cpp new file mode 100644 index 0000000000..86d365c0c2 --- /dev/null +++ b/services/sensorservice/hidl/EventQueue.cpp @@ -0,0 +1,84 @@ +/* + * Copyright (C) 2017 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "EventQueue.h" +#include "utils.h" + +#include <utils/Looper.h> + +namespace android { +namespace frameworks { +namespace sensorservice { +namespace V1_0 { +namespace implementation { + +class EventQueueLooperCallback : public ::android::LooperCallback { +public: + EventQueueLooperCallback(sp<EventQueue> queue, sp<IEventQueueCallback> callback) + : mQueue(queue), mCallback(callback) { + } + + int handleEvent(__unused int fd, __unused int events, __unused void* data) { + + ASensorEvent event; + ssize_t actual; + const sp<::android::SensorEventQueue>& internalQueue = mQueue->mInternalQueue; + + while ((actual = internalQueue->read(&event, 1 /* count */)) > 0) { + internalQueue->sendAck(&event, actual); + mCallback->onEvent(convertEvent(event)); + } + + return 1; // continue to receive callbacks + } + +private: + sp<EventQueue> mQueue; + sp<IEventQueueCallback> mCallback; +}; + +EventQueue::EventQueue( + sp<IEventQueueCallback> callback, + sp<::android::Looper> looper, + sp<::android::SensorEventQueue> internalQueue) + : mLooper(looper), + mInternalQueue(internalQueue) { + + mLooper->addFd(mInternalQueue->getFd(), ALOOPER_POLL_CALLBACK, ALOOPER_EVENT_INPUT, + new EventQueueLooperCallback(this, callback), NULL /* data */); +} + +EventQueue::~EventQueue() { + mLooper->removeFd(mInternalQueue->getFd()); +} + +// Methods from ::android::frameworks::sensorservice::V1_0::IEventQueue follow. +Return<Result> EventQueue::enableSensor(int32_t sensorHandle, int32_t samplingPeriodUs, + int64_t maxBatchReportLatencyUs) { + // TODO implement + return convertResult(mInternalQueue->enableSensor(sensorHandle, samplingPeriodUs, + maxBatchReportLatencyUs, 0 /* reserved flags */)); +} + +Return<Result> EventQueue::disableSensor(int32_t sensorHandle) { + return convertResult(mInternalQueue->disableSensor(sensorHandle)); +} + +} // namespace implementation +} // namespace V1_0 +} // namespace sensorservice +} // namespace frameworks +} // namespace android diff --git a/services/sensorservice/hidl/EventQueue.h b/services/sensorservice/hidl/EventQueue.h new file mode 100644 index 0000000000..87c614b0dc --- /dev/null +++ b/services/sensorservice/hidl/EventQueue.h @@ -0,0 +1,63 @@ +/* + * Copyright (C) 2017 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#ifndef ANDROID_FRAMEWORKS_SENSORSERVICE_V1_0_EVENTQUEUE_H +#define ANDROID_FRAMEWORKS_SENSORSERVICE_V1_0_EVENTQUEUE_H + +#include "SensorManager.h" + +#include <android/frameworks/sensorservice/1.0/IEventQueue.h> +#include <android/frameworks/sensorservice/1.0/IEventQueueCallback.h> +#include <hidl/MQDescriptor.h> +#include <hidl/Status.h> +#include <sensor/SensorManager.h> + +namespace android { +namespace frameworks { +namespace sensorservice { +namespace V1_0 { +namespace implementation { + +using ::android::frameworks::sensorservice::V1_0::IEventQueue; +using ::android::frameworks::sensorservice::V1_0::IEventQueueCallback; +using ::android::frameworks::sensorservice::V1_0::Result; +using ::android::hardware::Return; +using ::android::sp; + +struct EventQueue final : public IEventQueue { + EventQueue( + sp<IEventQueueCallback> callback, + sp<::android::Looper> looper, + sp<::android::SensorEventQueue> internalQueue); + ~EventQueue(); + + // Methods from ::android::frameworks::sensorservice::V1_0::IEventQueue follow. + Return<Result> enableSensor(int32_t sensorHandle, int32_t samplingPeriodUs, int64_t maxBatchReportLatencyUs) override; + Return<Result> disableSensor(int32_t sensorHandle) override; + +private: + friend class EventQueueLooperCallback; + sp<::android::Looper> mLooper; + sp<::android::SensorEventQueue> mInternalQueue; +}; + +} // namespace implementation +} // namespace V1_0 +} // namespace sensorservice +} // namespace frameworks +} // namespace android + +#endif // ANDROID_FRAMEWORKS_SENSORSERVICE_V1_0_EVENTQUEUE_H diff --git a/services/sensorservice/hidl/SensorManager.cpp b/services/sensorservice/hidl/SensorManager.cpp index 37e53dc9fc..0743fc39d6 100644 --- a/services/sensorservice/hidl/SensorManager.cpp +++ b/services/sensorservice/hidl/SensorManager.cpp @@ -20,10 +20,14 @@ #endif #include <android-base/logging.h> -#include "DirectReportChannel.h" #include "SensorManager.h" + +#include "EventQueue.h" +#include "DirectReportChannel.h" #include "utils.h" +#include <thread> + namespace android { namespace frameworks { namespace sensorservice { @@ -31,19 +35,28 @@ namespace V1_0 { namespace implementation { using ::android::hardware::sensors::V1_0::SensorInfo; +using ::android::hardware::sensors::V1_0::SensorsEventFormatOffset; using ::android::hardware::hidl_vec; using ::android::hardware::Void; using ::android::sp; SensorManager::SensorManager() - : mManager{::android::SensorManager::getInstanceForPackage( + : mInternalManager{::android::SensorManager::getInstanceForPackage( String16(ISensorManager::descriptor))} { } +SensorManager::~SensorManager() { + // Stops pollAll inside the thread. + std::unique_lock<std::mutex> lock(mLooperMutex); + if (mLooper != nullptr) { + mLooper->wake(); + } +} + // Methods from ::android::frameworks::sensorservice::V1_0::ISensorManager follow. Return<void> SensorManager::getSensorList(getSensorList_cb _hidl_cb) { ::android::Sensor const* const* list; - ssize_t count = mManager.getSensorList(&list); + ssize_t count = mInternalManager.getSensorList(&list); if (count < 0 || !list) { LOG(ERROR) << "::android::SensorManager::getSensorList encounters " << count; _hidl_cb({}, Result::UNKNOWN_ERROR); @@ -59,7 +72,7 @@ Return<void> SensorManager::getSensorList(getSensorList_cb _hidl_cb) { } Return<void> SensorManager::getDefaultSensor(SensorType type, getDefaultSensor_cb _hidl_cb) { - ::android::Sensor const* sensor = mManager.getDefaultSensor(static_cast<int>(type)); + ::android::Sensor const* sensor = mInternalManager.getDefaultSensor(static_cast<int>(type)); if (!sensor) { _hidl_cb({}, Result::NOT_EXIST); return Void(); @@ -90,12 +103,12 @@ void createDirectChannel(::android::SensorManager& manager, size_t size, int typ Return<void> SensorManager::createAshmemDirectChannel( const hidl_memory& mem, uint64_t size, createAshmemDirectChannel_cb _hidl_cb) { - if (size > mem.size()) { + if (size > mem.size() || size < (uint64_t)SensorsEventFormatOffset::TOTAL_LENGTH) { _hidl_cb(nullptr, Result::BAD_VALUE); return Void(); } - createDirectChannel(mManager, size, SENSOR_DIRECT_MEM_TYPE_ASHMEM, + createDirectChannel(mInternalManager, size, SENSOR_DIRECT_MEM_TYPE_ASHMEM, mem.handle(), _hidl_cb); return Void(); @@ -105,16 +118,53 @@ Return<void> SensorManager::createGrallocDirectChannel( const hidl_handle& buffer, uint64_t size, createGrallocDirectChannel_cb _hidl_cb) { - createDirectChannel(mManager, size, SENSOR_DIRECT_MEM_TYPE_GRALLOC, + createDirectChannel(mInternalManager, size, SENSOR_DIRECT_MEM_TYPE_GRALLOC, buffer.getNativeHandle(), _hidl_cb); return Void(); } +/* One global looper for all event queues created from this SensorManager. */ +sp<::android::Looper> SensorManager::getLooper() { + std::unique_lock<std::mutex> lock(mLooperMutex); + if (mLooper == nullptr) { + std::condition_variable looperSet; + + std::thread{[&mutex = mLooperMutex, &looper = mLooper, &looperSet] { + std::unique_lock<std::mutex> lock(mutex); + looper = Looper::prepare(ALOOPER_PREPARE_ALLOW_NON_CALLBACKS /* opts */); + lock.unlock(); + + looperSet.notify_one(); + int pollResult = looper->pollAll(-1 /* timeout */); + if (pollResult != ALOOPER_POLL_WAKE) { + LOG(ERROR) << "Looper::pollAll returns unexpected " << pollResult; + } + LOG(INFO) << "Looper thread is terminated."; + }}.detach(); + looperSet.wait(lock, [this]{ return this->mLooper != nullptr; }); + } + return mLooper; +} + Return<void> SensorManager::createEventQueue( - __unused const sp<IEventQueueCallback> &callback, createEventQueue_cb _hidl_cb) { - // TODO(b/35219747) Implement this - _hidl_cb(nullptr, Result::UNKNOWN_ERROR); + const sp<IEventQueueCallback> &callback, createEventQueue_cb _hidl_cb) { + if (callback == nullptr) { + _hidl_cb(nullptr, Result::BAD_VALUE); + return Void(); + } + + sp<::android::Looper> looper = getLooper(); + sp<::android::SensorEventQueue> internalQueue = mInternalManager.createEventQueue(); + if (internalQueue == nullptr) { + LOG(WARNING) << "::android::SensorManager::createEventQueue returns nullptr."; + _hidl_cb(nullptr, Result::UNKNOWN_ERROR); + return Void(); + } + + sp<IEventQueue> queue = new EventQueue(callback, looper, internalQueue); + _hidl_cb(queue, Result::OK); + return Void(); } diff --git a/services/sensorservice/hidl/include/sensorservicehidl/SensorManager.h b/services/sensorservice/hidl/include/sensorservicehidl/SensorManager.h index 0b026c9dcd..a2372df3d1 100644 --- a/services/sensorservice/hidl/include/sensorservicehidl/SensorManager.h +++ b/services/sensorservice/hidl/include/sensorservicehidl/SensorManager.h @@ -17,11 +17,14 @@ #ifndef ANDROID_FRAMEWORKS_SENSORSERVICE_V1_0_SENSORMANAGER_H #define ANDROID_FRAMEWORKS_SENSORSERVICE_V1_0_SENSORMANAGER_H +#include <mutex> + #include <android/frameworks/sensorservice/1.0/ISensorManager.h> #include <android/frameworks/sensorservice/1.0/types.h> #include <hidl/MQDescriptor.h> #include <hidl/Status.h> #include <sensor/SensorManager.h> +#include <utils/Looper.h> namespace android { namespace frameworks { @@ -34,9 +37,10 @@ using ::android::hardware::hidl_handle; using ::android::hardware::hidl_memory; using ::android::hardware::Return; -struct SensorManager : public ISensorManager { +struct SensorManager final : public ISensorManager { SensorManager(); + ~SensorManager(); // Methods from ::android::frameworks::sensorservice::V1_0::ISensorManager follow. Return<void> getSensorList(getSensorList_cb _hidl_cb) override; @@ -44,9 +48,13 @@ struct SensorManager : public ISensorManager { Return<void> createAshmemDirectChannel(const hidl_memory& mem, uint64_t size, createAshmemDirectChannel_cb _hidl_cb) override; Return<void> createGrallocDirectChannel(const hidl_handle& buffer, uint64_t size, createGrallocDirectChannel_cb _hidl_cb) override; Return<void> createEventQueue(const sp<IEventQueueCallback> &callback, createEventQueue_cb _hidl_cb); + private: - ::android::SensorManager& mManager; + sp<::android::Looper> getLooper(); + ::android::SensorManager& mInternalManager; + std::mutex mLooperMutex; + sp<::android::Looper> mLooper; }; } // namespace implementation diff --git a/services/sensorservice/hidl/utils.cpp b/services/sensorservice/hidl/utils.cpp index 4e027412a7..b5405254d9 100644 --- a/services/sensorservice/hidl/utils.cpp +++ b/services/sensorservice/hidl/utils.cpp @@ -16,6 +16,8 @@ #include "utils.h" +#include <sensors/convert.h> + namespace android { namespace frameworks { namespace sensorservice { @@ -26,7 +28,7 @@ using ::android::Sensor; using ::android::hardware::hidl_string; using ::android::hardware::sensors::V1_0::SensorInfo; -SensorInfo convertSensor(const Sensor &src) { +SensorInfo convertSensor(const Sensor& src) { SensorInfo dst; const String8& name = src.getName(); const String8& vendor = src.getVendor(); @@ -36,7 +38,7 @@ SensorInfo convertSensor(const Sensor &src) { dst.sensorHandle = src.getHandle(); dst.type = static_cast<::android::hardware::sensors::V1_0::SensorType>( src.getType()); - // FIXME maxRange uses maxValue because ::android::Sensor wraps the + // maxRange uses maxValue because ::android::Sensor wraps the // internal sensor_t in this way. dst.maxRange = src.getMaxValue(); dst.resolution = src.getResolution(); @@ -70,6 +72,13 @@ Result convertResult(status_t status) { } } +::android::hardware::sensors::V1_0::Event convertEvent(const ::ASensorEvent& src) { + ::android::hardware::sensors::V1_0::Event dst; + ::android::hardware::sensors::V1_0::implementation::convertFromSensorEvent( + reinterpret_cast<const sensors_event_t&>(src), &dst); + return dst; +} + } // namespace implementation } // namespace V1_0 } // namespace sensorservice diff --git a/services/sensorservice/hidl/utils.h b/services/sensorservice/hidl/utils.h index 0606e697b0..b350928187 100644 --- a/services/sensorservice/hidl/utils.h +++ b/services/sensorservice/hidl/utils.h @@ -30,6 +30,8 @@ namespace implementation { ::android::hardware::sensors::V1_0::SensorInfo convertSensor(const ::android::Sensor &src); Result convertResult(status_t status); +::android::hardware::sensors::V1_0::Event convertEvent(const ::ASensorEvent &event); + } // namespace implementation } // namespace V1_0 } // namespace sensorservice diff --git a/services/surfaceflinger/Android.mk b/services/surfaceflinger/Android.mk index 647a4c0286..ebf72bcc87 100644 --- a/services/surfaceflinger/Android.mk +++ b/services/surfaceflinger/Android.mk @@ -66,9 +66,6 @@ endif LOCAL_CFLAGS += -fvisibility=hidden -Werror=format -LOCAL_HEADER_LIBRARIES := \ - android.hardware.configstore-utils - LOCAL_STATIC_LIBRARIES := \ libhwcomposer-command-buffer \ libtrace_proto \ @@ -81,6 +78,7 @@ LOCAL_SHARED_LIBRARIES := \ android.hardware.graphics.allocator@2.0 \ android.hardware.graphics.composer@2.1 \ android.hardware.configstore@1.0 \ + android.hardware.configstore-utils \ libcutils \ liblog \ libdl \ diff --git a/services/surfaceflinger/surfaceflinger.rc b/services/surfaceflinger/surfaceflinger.rc index 435aa0cce7..41b6225302 100644 --- a/services/surfaceflinger/surfaceflinger.rc +++ b/services/surfaceflinger/surfaceflinger.rc @@ -1,6 +1,10 @@ service surfaceflinger /system/bin/surfaceflinger - class core + class core animation user system group graphics drmrpc readproc onrestart restart zygote writepid /dev/stune/foreground/tasks + socket pdx/system/vr/display/client stream 0666 system graphics + socket pdx/system/vr/display/manager stream 0660 system graphics + socket pdx/system/vr/display/screenshot stream 0660 system graphics + socket pdx/system/vr/display/vsync stream 0666 system graphics diff --git a/services/vr/bufferhubd/buffer_hub.cpp b/services/vr/bufferhubd/buffer_hub.cpp index 80efcf8452..de4950ea81 100644 --- a/services/vr/bufferhubd/buffer_hub.cpp +++ b/services/vr/bufferhubd/buffer_hub.cpp @@ -189,7 +189,7 @@ void BufferHubService::HandleImpulse(Message& message) { channel->HandleImpulse(message); } -int BufferHubService::HandleMessage(Message& message) { +pdx::Status<void> BufferHubService::HandleMessage(Message& message) { ATRACE_NAME("BufferHubService::HandleMessage"); auto channel = message.GetChannel<BufferHubChannel>(); @@ -207,22 +207,22 @@ int BufferHubService::HandleMessage(Message& message) { case BufferHubRPC::CreateBuffer::Opcode: DispatchRemoteMethod<BufferHubRPC::CreateBuffer>( *this, &BufferHubService::OnCreateBuffer, message); - return 0; + return {}; case BufferHubRPC::CreatePersistentBuffer::Opcode: DispatchRemoteMethod<BufferHubRPC::CreatePersistentBuffer>( *this, &BufferHubService::OnCreatePersistentBuffer, message); - return 0; + return {}; case BufferHubRPC::GetPersistentBuffer::Opcode: DispatchRemoteMethod<BufferHubRPC::GetPersistentBuffer>( *this, &BufferHubService::OnGetPersistentBuffer, message); - return 0; + return {}; case BufferHubRPC::CreateProducerQueue::Opcode: DispatchRemoteMethod<BufferHubRPC::CreateProducerQueue>( *this, &BufferHubService::OnCreateProducerQueue, message); - return 0; + return {}; default: return DefaultHandleMessage(message); @@ -438,11 +438,11 @@ void BufferHubChannel::SignalAvailable() { "BufferHubChannel::SignalAvailable: channel_id=%d buffer_id=%d", channel_id(), buffer_id()); if (!IsDetached()) { - const int ret = service_->ModifyChannelEvents(channel_id_, 0, POLLIN); - ALOGE_IF(ret < 0, + const auto status = service_->ModifyChannelEvents(channel_id_, 0, POLLIN); + ALOGE_IF(!status, "BufferHubChannel::SignalAvailable: failed to signal availability " "channel_id=%d: %s", - channel_id_, strerror(-ret)); + channel_id_, status.GetErrorMessage().c_str()); } else { ALOGD_IF(TRACE, "BufferHubChannel::SignalAvailable: detached buffer."); } @@ -454,11 +454,11 @@ void BufferHubChannel::ClearAvailable() { "BufferHubChannel::ClearAvailable: channel_id=%d buffer_id=%d", channel_id(), buffer_id()); if (!IsDetached()) { - const int ret = service_->ModifyChannelEvents(channel_id_, POLLIN, 0); - ALOGE_IF(ret < 0, + const auto status = service_->ModifyChannelEvents(channel_id_, POLLIN, 0); + ALOGE_IF(!status, "BufferHubChannel::ClearAvailable: failed to clear availability " "channel_id=%d: %s", - channel_id_, strerror(-ret)); + channel_id_, status.GetErrorMessage().c_str()); } else { ALOGD_IF(TRACE, "BufferHubChannel::ClearAvailable: detached buffer."); } @@ -469,11 +469,11 @@ void BufferHubChannel::Hangup() { ALOGD_IF(TRACE, "BufferHubChannel::Hangup: channel_id=%d buffer_id=%d", channel_id(), buffer_id()); if (!IsDetached()) { - const int ret = service_->ModifyChannelEvents(channel_id_, 0, POLLHUP); + const auto status = service_->ModifyChannelEvents(channel_id_, 0, POLLHUP); ALOGE_IF( - ret < 0, + !status, "BufferHubChannel::Hangup: failed to signal hangup channel_id=%d: %s", - channel_id_, strerror(-ret)); + channel_id_, status.GetErrorMessage().c_str()); } else { ALOGD_IF(TRACE, "BufferHubChannel::Hangup: detached buffer."); } diff --git a/services/vr/bufferhubd/buffer_hub.h b/services/vr/bufferhubd/buffer_hub.h index 28cb468239..8a7dca843d 100644 --- a/services/vr/bufferhubd/buffer_hub.h +++ b/services/vr/bufferhubd/buffer_hub.h @@ -141,7 +141,7 @@ class BufferHubService : public pdx::ServiceBase<BufferHubService> { BufferHubService(); ~BufferHubService() override; - int HandleMessage(pdx::Message& message) override; + pdx::Status<void> HandleMessage(pdx::Message& message) override; void HandleImpulse(pdx::Message& message) override; void OnChannelClose(pdx::Message& message, diff --git a/services/vr/bufferhubd/bufferhubd.rc b/services/vr/bufferhubd/bufferhubd.rc index 65b7293160..8d57723994 100644 --- a/services/vr/bufferhubd/bufferhubd.rc +++ b/services/vr/bufferhubd/bufferhubd.rc @@ -3,4 +3,4 @@ service bufferhubd /system/bin/bufferhubd user system group system writepid /dev/cpuset/tasks - + socket pdx/system/buffer_hub/client stream 0660 system system diff --git a/services/vr/bufferhubd/producer_channel.cpp b/services/vr/bufferhubd/producer_channel.cpp index 43010b0f79..903d17464a 100644 --- a/services/vr/bufferhubd/producer_channel.cpp +++ b/services/vr/bufferhubd/producer_channel.cpp @@ -161,12 +161,12 @@ RemoteChannelHandle ProducerChannel::CreateConsumer(Message& message) { auto consumer = std::make_shared<ConsumerChannel>( service(), buffer_id(), channel_id, shared_from_this()); - const int ret = service()->SetChannel(channel_id, consumer); - if (ret < 0) { + const auto channel_status = service()->SetChannel(channel_id, consumer); + if (!channel_status) { ALOGE( "ProducerChannel::CreateConsumer: failed to set new consumer channel: " "%s", - strerror(-ret)); + channel_status.GetErrorMessage().c_str()); return RemoteChannelHandle(); } diff --git a/services/vr/bufferhubd/producer_queue_channel.cpp b/services/vr/bufferhubd/producer_queue_channel.cpp index 08f1e9d119..7952642456 100644 --- a/services/vr/bufferhubd/producer_queue_channel.cpp +++ b/services/vr/bufferhubd/producer_queue_channel.cpp @@ -97,18 +97,18 @@ ProducerQueueChannel::OnCreateConsumerQueue(Message& message) { "ProducerQueueChannel::OnCreateConsumerQueue: failed to push consumer " "channel: %s", status.GetErrorMessage().c_str()); - REPLY_ERROR_RETURN(message, ENOMEM, {}); + REPLY_ERROR_RETURN(message, status.error(), {}); } - const int ret = service()->SetChannel( + const auto channel_status = service()->SetChannel( channel_id, std::make_shared<ConsumerQueueChannel>( service(), buffer_id(), channel_id, shared_from_this())); - if (ret < 0) { + if (!channel_status) { ALOGE( "ProducerQueueChannel::OnCreateConsumerQueue: failed to set new " "consumer channel: %s", - strerror(-ret)); - REPLY_ERROR_RETURN(message, ENOMEM, {}); + channel_status.GetErrorMessage().c_str()); + REPLY_ERROR_RETURN(message, channel_status.error(), {}); } return std::make_pair(status.take(), meta_size_bytes_); @@ -214,12 +214,13 @@ std::pair<RemoteChannelHandle, size_t> ProducerQueueChannel::AllocateBuffer( "ProducerQueueChannel::AllocateBuffer: buffer_id=%d, buffer_handle=%d", buffer_id, buffer_handle.value()); - const int ret = service()->SetChannel(buffer_id, producer_channel); - if (ret < 0) { + const auto channel_status = + service()->SetChannel(buffer_id, producer_channel); + if (!channel_status) { ALOGE( - "ProducerQueueChannel::AllocateBuffer: failed to set prodcuer channel " + "ProducerQueueChannel::AllocateBuffer: failed to set producer channel " "for new BufferHubBuffer: %s", - strerror(-ret)); + channel_status.GetErrorMessage().c_str()); return {}; } @@ -252,7 +253,7 @@ std::pair<RemoteChannelHandle, size_t> ProducerQueueChannel::AllocateBuffer( return {std::move(buffer_handle), slot}; } -int ProducerQueueChannel::OnProducerQueueDetachBuffer(Message& message, +int ProducerQueueChannel::OnProducerQueueDetachBuffer(Message& /*message*/, size_t slot) { if (buffers_[slot].expired()) { ALOGE( diff --git a/services/vr/hardware_composer/Android.bp b/services/vr/hardware_composer/Android.bp index 1601c7f6e0..629d65bb5a 100644 --- a/services/vr/hardware_composer/Android.bp +++ b/services/vr/hardware_composer/Android.bp @@ -75,31 +75,6 @@ cc_binary { ], } -cc_library_static { - name: "libdvr_hwc", - srcs: [ - "dvr_hardware_composer_client.cpp", - ], - static_libs: [ - "libvr_hwc-impl", - // NOTE: This needs to be included after the *-impl lib otherwise the - // symbols in the *-binder library get optimized out. - "libvr_hwc-binder", - ], - shared_libs: [ - "libbase", - "libbinder", - "liblog", - "libnativewindow", - "libui", - "libutils", - ], - export_include_dirs: ["private"], - export_shared_lib_headers: [ - "libnativewindow", - ], -} - cc_test { name: "vr_hwc_test", gtest: true, diff --git a/services/vr/hardware_composer/aidl/android/dvr/parcelable_composer_layer.cpp b/services/vr/hardware_composer/aidl/android/dvr/parcelable_composer_layer.cpp index 34e2b7ec36..999d71efb3 100644 --- a/services/vr/hardware_composer/aidl/android/dvr/parcelable_composer_layer.cpp +++ b/services/vr/hardware_composer/aidl/android/dvr/parcelable_composer_layer.cpp @@ -34,9 +34,9 @@ sp<GraphicBuffer> GetBufferFromHandle(native_handle_t* handle) { // capability. Otherwise assume a count of 1. mapper.getLayerCount(handle, &layer_count); - sp<GraphicBuffer> buffer = new GraphicBuffer( - width, height, format, layer_count, producer_usage, consumer_usage, - stride, handle, true); + sp<GraphicBuffer> buffer = new GraphicBuffer(handle, + GraphicBuffer::TAKE_HANDLE, width, height, format, layer_count, + producer_usage, consumer_usage, stride); return buffer; } diff --git a/services/vr/hardware_composer/vr_hwc.rc b/services/vr/hardware_composer/vr_hwc.rc index 5d3c4f74f8..52d4da8d57 100644 --- a/services/vr/hardware_composer/vr_hwc.rc +++ b/services/vr/hardware_composer/vr_hwc.rc @@ -3,4 +3,3 @@ service vr_hwc /system/bin/vr_hwc user system group system graphics onrestart restart surfaceflinger - disabled diff --git a/services/vr/performanced/performance_service.cpp b/services/vr/performanced/performance_service.cpp index c99c8d4801..955c6610cc 100644 --- a/services/vr/performanced/performance_service.cpp +++ b/services/vr/performanced/performance_service.cpp @@ -170,22 +170,22 @@ std::string PerformanceService::OnGetCpuPartition(Message& message, return task.GetCpuSetPath(); } -int PerformanceService::HandleMessage(Message& message) { +pdx::Status<void> PerformanceService::HandleMessage(Message& message) { switch (message.GetOp()) { case PerformanceRPC::SetCpuPartition::Opcode: DispatchRemoteMethod<PerformanceRPC::SetSchedulerClass>( *this, &PerformanceService::OnSetCpuPartition, message); - return 0; + return {}; case PerformanceRPC::SetSchedulerClass::Opcode: DispatchRemoteMethod<PerformanceRPC::SetSchedulerClass>( *this, &PerformanceService::OnSetSchedulerClass, message); - return 0; + return {}; case PerformanceRPC::GetCpuPartition::Opcode: DispatchRemoteMethod<PerformanceRPC::GetCpuPartition>( *this, &PerformanceService::OnGetCpuPartition, message); - return 0; + return {}; default: return Service::HandleMessage(message); diff --git a/services/vr/performanced/performance_service.h b/services/vr/performanced/performance_service.h index e32d83441b..34abba7bd9 100644 --- a/services/vr/performanced/performance_service.h +++ b/services/vr/performanced/performance_service.h @@ -17,7 +17,7 @@ namespace dvr { // achieve system performance goals. class PerformanceService : public pdx::ServiceBase<PerformanceService> { public: - int HandleMessage(pdx::Message& message) override; + pdx::Status<void> HandleMessage(pdx::Message& message) override; bool IsInitialized() const override; std::string DumpState(size_t max_length) override; diff --git a/services/vr/performanced/performanced.rc b/services/vr/performanced/performanced.rc index 5042982d80..6283f37178 100644 --- a/services/vr/performanced/performanced.rc +++ b/services/vr/performanced/performanced.rc @@ -3,3 +3,4 @@ service performanced /system/bin/performanced user root group system readproc writepid /dev/cpuset/tasks + socket pdx/system/performance/client stream 0666 system system diff --git a/services/vr/sensord/pose_service.cpp b/services/vr/sensord/pose_service.cpp index 2c4fc30bd1..7534732ec2 100644 --- a/services/vr/sensord/pose_service.cpp +++ b/services/vr/sensord/pose_service.cpp @@ -65,6 +65,9 @@ static constexpr char kPoseRingBufferName[] = "PoseService:RingBuffer"; static constexpr int kDatasetIdLength = 36; static constexpr char kDatasetIdChars[] = "0123456789abcdef-"; +static constexpr int kLatencyWindowSize = 100; +static constexpr double kLatencyWindowMass = 0.5; + // These are the flags used by BufferProducer::CreatePersistentUncachedBlob, // plus PRIVATE_ADSP_HEAP to allow access from the DSP. static constexpr int kPoseRingBufferFlags = @@ -111,7 +114,8 @@ PoseService::PoseService(SensorThread* sensor_thread) vsync_count_(0), photon_timestamp_(0), // Will be updated by external service, but start with a non-zero value: - display_period_ns_(16000000) { + display_period_ns_(16000000), + sensor_latency_(kLatencyWindowSize, kLatencyWindowMass) { last_known_pose_ = { .orientation = {1.0f, 0.0f, 0.0f, 0.0f}, .translation = {0.0f, 0.0f, 0.0f, 0.0f}, @@ -463,10 +467,13 @@ void PoseService::UpdatePoseMode() { start_from_head_rotation * Vector3d(0.0, kDefaultNeckVerticalOffset, -kDefaultNeckHorizontalOffset); - // IMU driver gives timestamps on its own clock, but we need monotonic - // clock. Subtract 5ms to account for estimated IMU sample latency. - WriteAsyncPoses(position, start_from_head_rotation, - pose_state.timestamp_ns + 5000000); + // Update the current latency model. + sensor_latency_.AddLatency(GetSystemClockNs() - pose_state.timestamp_ns); + + // Update the timestamp with the expected latency. + WriteAsyncPoses( + position, start_from_head_rotation, + pose_state.timestamp_ns + sensor_latency_.CurrentLatencyEstimate()); break; } default: @@ -476,8 +483,8 @@ void PoseService::UpdatePoseMode() { } } -int PoseService::HandleMessage(pdx::Message& msg) { - int ret = 0; +pdx::Status<void> PoseService::HandleMessage(pdx::Message& msg) { + pdx::Status<void> ret; const pdx::MessageInfo& info = msg.GetInfo(); switch (info.op) { case DVR_POSE_NOTIFY_VSYNC: { @@ -495,21 +502,13 @@ int PoseService::HandleMessage(pdx::Message& msg) { {.iov_base = &right_eye_photon_offset_ns_, .iov_len = sizeof(right_eye_photon_offset_ns_)}, }; - constexpr int expected_size = - sizeof(vsync_count_) + sizeof(photon_timestamp_) + - sizeof(display_period_ns_) + sizeof(right_eye_photon_offset_ns_); - ret = msg.ReadVector(data, sizeof(data) / sizeof(data[0])); - if (ret < expected_size) { - ALOGI("error: msg.Read read too little (%d < %d)", ret, expected_size); - REPLY_ERROR(msg, EIO, error); - } - - if (!enable_external_pose_) { + ret = msg.ReadVectorAll(data); + if (ret && !enable_external_pose_) { mapped_pose_buffer_->vsync_count = vsync_count_; } // TODO(jbates, eieio): make this async, no need to reply. - REPLY_SUCCESS(msg, 0, error); + REPLY_MESSAGE(msg, ret, error); } case DVR_POSE_POLL: { ATRACE_NAME("pose_poll"); @@ -535,61 +534,43 @@ int PoseService::HandleMessage(pdx::Message& msg) { Btrace("Pose polled"); - ret = msg.Write(&client_state, sizeof(client_state)); - const int expected_size = sizeof(client_state); - if (ret < expected_size) { - ALOGI("error: msg.Write wrote too little (%d < %d)", ret, - expected_size); - REPLY_ERROR(msg, EIO, error); - } - REPLY_SUCCESS(msg, 0, error); + ret = msg.WriteAll(&client_state, sizeof(client_state)); + REPLY_MESSAGE(msg, ret, error); } case DVR_POSE_FREEZE: { { std::lock_guard<std::mutex> guard(mutex_); DvrPoseState frozen_state; - const int expected_size = sizeof(frozen_state); - ret = msg.Read(&frozen_state, expected_size); - if (ret < expected_size) { - ALOGI("error: msg.Read read too little (%d < %d)", ret, - expected_size); - REPLY_ERROR(msg, EIO, error); + ret = msg.ReadAll(&frozen_state, sizeof(frozen_state)); + if (!ret) { + REPLY_ERROR(msg, ret.error(), error); } frozen_state_ = frozen_state; } SetPoseMode(DVR_POSE_MODE_MOCK_FROZEN); - REPLY_SUCCESS(msg, 0, error); + REPLY_MESSAGE(msg, ret, error); } case DVR_POSE_SET_MODE: { int mode; { std::lock_guard<std::mutex> guard(mutex_); - const int expected_size = sizeof(mode); - ret = msg.Read(&mode, expected_size); - if (ret < expected_size) { - ALOGI("error: msg.Read read too little (%d < %d)", ret, - expected_size); - REPLY_ERROR(msg, EIO, error); + ret = msg.ReadAll(&mode, sizeof(mode)); + if (!ret) { + REPLY_ERROR(msg, ret.error(), error); } if (mode < 0 || mode >= DVR_POSE_MODE_COUNT) { REPLY_ERROR(msg, EINVAL, error); } } SetPoseMode(DvrPoseMode(mode)); - REPLY_SUCCESS(msg, 0, error); + REPLY_MESSAGE(msg, ret, error); } case DVR_POSE_GET_MODE: { std::lock_guard<std::mutex> guard(mutex_); int mode = pose_mode_; - ret = msg.Write(&mode, sizeof(mode)); - const int expected_size = sizeof(mode); - if (ret < expected_size) { - ALOGI("error: msg.Write wrote too little (%d < %d)", ret, - expected_size); - REPLY_ERROR(msg, EIO, error); - } - REPLY_SUCCESS(msg, 0, error); + ret = msg.WriteAll(&mode, sizeof(mode)); + REPLY_MESSAGE(msg, ret, error); } case DVR_POSE_GET_RING_BUFFER: { std::lock_guard<std::mutex> guard(mutex_); diff --git a/services/vr/sensord/pose_service.h b/services/vr/sensord/pose_service.h index 4df503672b..7b7adecb83 100644 --- a/services/vr/sensord/pose_service.h +++ b/services/vr/sensord/pose_service.h @@ -11,8 +11,9 @@ #include <dvr/pose_client.h> #include <pdx/service.h> #include <private/dvr/buffer_hub_client.h> -#include <private/dvr/pose_client_internal.h> #include <private/dvr/dvr_pose_predictor.h> +#include <private/dvr/latency_model.h> +#include <private/dvr/pose_client_internal.h> #include <private/dvr/ring_buffer.h> #include "sensor_fusion.h" @@ -27,7 +28,7 @@ class PoseService : public pdx::ServiceBase<PoseService> { ~PoseService() override; bool IsInitialized() const override; - int HandleMessage(pdx::Message& msg) override; + pdx::Status<void> HandleMessage(pdx::Message& msg) override; std::string DumpState(size_t max_length) override; // Handle events from the sensor HAL. @@ -132,6 +133,9 @@ class PoseService : public pdx::ServiceBase<PoseService> { int64_t display_period_ns_; int64_t right_eye_photon_offset_ns_ = 0; + // To model the measurement - arrival latency. + LatencyModel sensor_latency_; + // Type for controlling pose orientation calculation. OrientationType device_orientation_type_; diff --git a/services/vr/sensord/sensor_service.cpp b/services/vr/sensord/sensor_service.cpp index 1b809b04a0..a182a262ab 100644 --- a/services/vr/sensord/sensor_service.cpp +++ b/services/vr/sensord/sensor_service.cpp @@ -69,8 +69,8 @@ void SensorService::RemoveSensorClient(SensorClient* client) { client->unset_sensor(); } -int SensorService::HandleMessage(pdx::Message& msg) { - int ret = 0; +pdx::Status<void> SensorService::HandleMessage(pdx::Message& msg) { + pdx::Status<void> ret; const pdx::MessageInfo& info = msg.GetInfo(); switch (info.op) { case DVR_SENSOR_START: { @@ -82,8 +82,7 @@ int SensorService::HandleMessage(pdx::Message& msg) { if (client->has_sensor()) REPLY_ERROR(msg, EINVAL, error); int sensor_type; - if (msg.Read(&sensor_type, sizeof(sensor_type)) < - (ssize_t)sizeof(sensor_type)) + if (!msg.ReadAll(&sensor_type, sizeof(sensor_type))) REPLY_ERROR(msg, EIO, error); // Find the sensor of the requested type. @@ -120,10 +119,8 @@ int SensorService::HandleMessage(pdx::Message& msg) { {.iov_base = out_buffer, .iov_len = num_events * sizeof(sensors_event_t)}, }; - ret = msg.WriteVector(svec, 2); - int expected_size = sizeof(int) + num_events * sizeof(sensors_event_t); - if (ret < expected_size) { - ALOGI("error: msg.WriteVector wrote too little."); + ret = msg.WriteVectorAll(svec, 2); + if (!ret) { REPLY_ERROR(msg, EIO, error); } REPLY_SUCCESS(msg, 0, error); diff --git a/services/vr/sensord/sensor_service.h b/services/vr/sensord/sensor_service.h index c35fadaea9..6ea470b06e 100644 --- a/services/vr/sensord/sensor_service.h +++ b/services/vr/sensord/sensor_service.h @@ -22,7 +22,7 @@ class SensorClient; */ class SensorService : public pdx::ServiceBase<SensorService> { public: - int HandleMessage(pdx::Message& msg) override; + pdx::Status<void> HandleMessage(pdx::Message& msg) override; std::shared_ptr<pdx::Channel> OnChannelOpen(pdx::Message& msg) override; void OnChannelClose(pdx::Message& msg, const std::shared_ptr<pdx::Channel>& chan) override; diff --git a/services/vr/sensord/sensord.rc b/services/vr/sensord/sensord.rc index f8d28fd448..36cd377369 100644 --- a/services/vr/sensord/sensord.rc +++ b/services/vr/sensord/sensord.rc @@ -7,3 +7,5 @@ service sensord /system/bin/sensord user system group system camera sdcard_rw writepid /dev/cpuset/system/tasks + socket pdx/system/vr/sensors/client stream 0666 system system + socket pdx/system/vr/pose/client stream 0666 system system diff --git a/services/vr/vr_window_manager/Android.bp b/services/vr/vr_window_manager/Android.bp index a7a341ca49..0406331a4d 100644 --- a/services/vr/vr_window_manager/Android.bp +++ b/services/vr/vr_window_manager/Android.bp @@ -41,6 +41,7 @@ static_libs = [ "libperformance", "libpdx_default_transport", "libcutils", + "libvr_hwc-binder", "libvr_manager", "libvirtualtouchpadclient", ] diff --git a/services/vr/vr_window_manager/composer/impl/vr_hwc.cpp b/services/vr/vr_window_manager/composer/impl/vr_hwc.cpp index 3393ade01d..d142729d23 100644 --- a/services/vr/vr_window_manager/composer/impl/vr_hwc.cpp +++ b/services/vr/vr_window_manager/composer/impl/vr_hwc.cpp @@ -69,11 +69,10 @@ sp<GraphicBuffer> GetBufferFromHandle(const native_handle_t* handle) { mapper.getLayerCount(handle, &layer_count); // NOTE: Can't re-use |handle| since we don't own it. - sp<GraphicBuffer> buffer = new GraphicBuffer( - width, height, format, layer_count, producer_usage, consumer_usage, - stride, native_handle_clone(handle), true); - // Need to register the cloned buffer otherwise it can't be used later on. - if (mapper.registerBuffer(buffer.get()) != OK) { + sp<GraphicBuffer> buffer = new GraphicBuffer(handle, + GraphicBuffer::CLONE_HANDLE, width, height, format, layer_count, + producer_usage, consumer_usage, stride); + if (buffer->initCheck() != OK) { ALOGE("Failed to register cloned buffer"); return nullptr; } diff --git a/services/vr/vr_window_manager/hwc_callback.cpp b/services/vr/vr_window_manager/hwc_callback.cpp index 19b220bf6c..43f504276a 100644 --- a/services/vr/vr_window_manager/hwc_callback.cpp +++ b/services/vr/vr_window_manager/hwc_callback.cpp @@ -38,26 +38,29 @@ HwcCallback::HwcCallback(Client* client) : client_(client) { HwcCallback::~HwcCallback() { } -base::unique_fd HwcCallback::OnNewFrame(const ComposerView::Frame& display_frame) { - auto& frame = display_frame.layers; - std::vector<HwcLayer> hwc_frame(frame.size()); - - for (size_t i = 0; i < frame.size(); ++i) { +binder::Status HwcCallback::onNewFrame( + const ParcelableComposerFrame& parcelable_frame, + ParcelableUniqueFd* fence) { + ComposerView::Frame frame = parcelable_frame.frame(); + std::vector<HwcLayer> hwc_frame(frame.layers.size()); + for (size_t i = 0; i < frame.layers.size(); ++i) { + const ComposerView::ComposerLayer& layer = frame.layers[i]; hwc_frame[i] = HwcLayer{ - .fence = frame[i].fence, - .buffer = frame[i].buffer, - .crop = frame[i].crop, - .display_frame = frame[i].display_frame, - .blending = static_cast<int32_t>(frame[i].blend_mode), - .appid = frame[i].app_id, - .type = static_cast<HwcLayer::LayerType>(frame[i].type), - .alpha = frame[i].alpha, + .fence = layer.fence, + .buffer = layer.buffer, + .crop = layer.crop, + .display_frame = layer.display_frame, + .blending = static_cast<int32_t>(layer.blend_mode), + .appid = layer.app_id, + .type = static_cast<HwcLayer::LayerType>(layer.type), + .alpha = layer.alpha, }; } - return client_->OnFrame(std::make_unique<Frame>( - std::move(hwc_frame), display_frame.display_id, display_frame.removed, - display_frame.display_width, display_frame.display_height)); + fence->set_fence(client_->OnFrame(std::make_unique<Frame>( + std::move(hwc_frame), frame.display_id, frame.removed, + frame.display_width, frame.display_height))); + return binder::Status::ok(); } HwcCallback::Frame::Frame(std::vector<HwcLayer>&& layers, uint32_t display_id, diff --git a/services/vr/vr_window_manager/hwc_callback.h b/services/vr/vr_window_manager/hwc_callback.h index c0d965a6ae..f1f91a1381 100644 --- a/services/vr/vr_window_manager/hwc_callback.h +++ b/services/vr/vr_window_manager/hwc_callback.h @@ -1,14 +1,16 @@ #ifndef VR_WINDOW_MANAGER_HWC_CALLBACK_H_ #define VR_WINDOW_MANAGER_HWC_CALLBACK_H_ +#include <android/dvr/BnVrComposerCallback.h> +#include <android-base/unique_fd.h> + #include <deque> #include <functional> #include <mutex> #include <vector> -#include <android-base/unique_fd.h> -#include <impl/vr_composer_view.h> -#include <impl/vr_hwc.h> +#include "impl/vr_composer_view.h" +#include "impl/vr_hwc.h" namespace android { @@ -20,7 +22,7 @@ namespace dvr { using Recti = ComposerView::ComposerLayer::Recti; using Rectf = ComposerView::ComposerLayer::Rectf; -class HwcCallback : public VrComposerView::Callback { +class HwcCallback : public BnVrComposerCallback { public: struct HwcLayer { enum LayerType : uint32_t { @@ -110,7 +112,8 @@ class HwcCallback : public VrComposerView::Callback { ~HwcCallback() override; private: - base::unique_fd OnNewFrame(const ComposerView::Frame& frame) override; + binder::Status onNewFrame(const ParcelableComposerFrame& frame, + ParcelableUniqueFd* fence) override; Client *client_; diff --git a/services/vr/vr_window_manager/surface_flinger_view.cpp b/services/vr/vr_window_manager/surface_flinger_view.cpp index c0ee1fc261..aef23a1d7b 100644 --- a/services/vr/vr_window_manager/surface_flinger_view.cpp +++ b/services/vr/vr_window_manager/surface_flinger_view.cpp @@ -1,5 +1,7 @@ #include "surface_flinger_view.h" +#include <android/dvr/IVrComposer.h> +#include <binder/IServiceManager.h> #include <impl/vr_composer_view.h> #include <private/dvr/native_buffer.h> @@ -14,22 +16,20 @@ SurfaceFlingerView::SurfaceFlingerView() {} SurfaceFlingerView::~SurfaceFlingerView() {} bool SurfaceFlingerView::Initialize(HwcCallback::Client *client) { - const char vr_hwcomposer_name[] = "vr"; - vr_hwcomposer_ = HIDL_FETCH_IComposer(vr_hwcomposer_name); - if (!vr_hwcomposer_.get()) { - ALOGE("Failed to get vr_hwcomposer"); - return false; - } + sp<IServiceManager> sm(defaultServiceManager()); + vr_composer_ = interface_cast<IVrComposer>( + sm->getService(IVrComposer::SERVICE_NAME())); - if (vr_hwcomposer_->isRemote()) { - ALOGE("vr_hwcomposer service is remote"); + String8 service_name(IVrComposer::SERVICE_NAME().string()); + if (!vr_composer_.get()) { + ALOGE("Faild to connect to %s", service_name.c_str()); return false; } - const android::status_t vr_hwcomposer_status = - vr_hwcomposer_->registerAsService(vr_hwcomposer_name); - if (vr_hwcomposer_status != OK) { - ALOGE("Failed to register vr_hwcomposer service"); + composer_callback_ = new HwcCallback(client); + binder::Status status = vr_composer_->registerObserver(composer_callback_); + if (!status.isOk()) { + ALOGE("Failed to register observer with %s", service_name.c_str()); return false; } diff --git a/services/vr/vr_window_manager/surface_flinger_view.h b/services/vr/vr_window_manager/surface_flinger_view.h index 3ea2b219af..1bea38d9d2 100644 --- a/services/vr/vr_window_manager/surface_flinger_view.h +++ b/services/vr/vr_window_manager/surface_flinger_view.h @@ -3,14 +3,13 @@ #include <memory> -#include <impl/vr_composer_view.h> - #include "hwc_callback.h" namespace android { namespace dvr { class IDisplay; +class IVrComposer; class Texture; struct TextureLayer { @@ -34,8 +33,8 @@ class SurfaceFlingerView { bool skip_first_layer) const; private: - sp<IComposer> vr_hwcomposer_; - std::unique_ptr<VrComposerView> vr_composer_view_; + sp<IVrComposer> vr_composer_; + sp<HwcCallback> composer_callback_; SurfaceFlingerView(const SurfaceFlingerView&) = delete; void operator=(const SurfaceFlingerView&) = delete; diff --git a/vulkan/api/vulkan.api b/vulkan/api/vulkan.api index 86dd0016ff..a19fcf1c56 100644 --- a/vulkan/api/vulkan.api +++ b/vulkan/api/vulkan.api @@ -28,7 +28,7 @@ import platform "platform.api" // API version (major.minor.patch) define VERSION_MAJOR 1 define VERSION_MINOR 0 -define VERSION_PATCH 43 +define VERSION_PATCH 46 // API limits define VK_MAX_PHYSICAL_DEVICE_NAME_SIZE 256 @@ -93,7 +93,7 @@ define NULL_HANDLE 0 @extension("VK_ANDROID_native_buffer") define VK_ANDROID_NATIVE_BUFFER_NAME "VK_ANDROID_native_buffer" // 12 -@extension("VK_EXT_debug_report") define VK_EXT_DEBUG_REPORT_SPEC_VERSION 5 +@extension("VK_EXT_debug_report") define VK_EXT_DEBUG_REPORT_SPEC_VERSION 6 @extension("VK_EXT_debug_report") define VK_EXT_DEBUG_REPORT_NAME "VK_EXT_debug_report" // 13 @@ -250,7 +250,7 @@ define NULL_HANDLE 0 // 85 @extension("VK_KHR_incremental_present") define VK_KHR_INCREMENTAL_PRESENT_SPEC_VERSION 1 -@extension("VK_KHR_incremental_present") define VK_KHR_INCREMENTAL_PRESENT_NAME "VK_KHR_incremental_present" +@extension("VK_KHR_incremental_present") define VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME "VK_KHR_incremental_present" // 86 @extension("VK_KHR_descriptor_update_template") define VK_KHR_DESCRIPTOR_UPDATE_TEMPLATE_SPEC_VERSION 1 @@ -309,8 +309,8 @@ define NULL_HANDLE 0 @extension("VK_EXT_discard_rectangles") define VK_EXT_DISCARD_RECTANGLES_EXTENSION_NAME "VK_EXT_discard_rectangles" // 105 -@extension("VK_EXT_swapchain_colorspace") define VK_EXT_SWAPCHAIN_COLORSPACE_SPEC_VERSION 1 -@extension("VK_EXT_swapchain_colorspace") define VK_EXT_SWAPCHAIN_COLORSPACE_COUNTER_EXTENSION_NAME "VK_EXT_swapchain_colorspace" +@extension("VK_EXT_swapchain_colorspace") define VK_EXT_SWAPCHAIN_COLORSPACE_SPEC_VERSION 2 +@extension("VK_EXT_swapchain_colorspace") define VK_EXT_SWAPCHAIN_COLORSPACE_EXTENSION_NAME "VK_EXT_swapchain_colorspace" // 106 @extension("VK_EXT_hdr_metadata") define VK_EXT_HDR_METADATA_SPEC_VERSION 1 @@ -1195,19 +1195,20 @@ enum VkPresentModeKHR { enum VkColorSpaceKHR { VK_COLORSPACE_SRGB_NONLINEAR_KHR = 0x00000000, - //@extension("VK_EXT_swapchain_colorspace") - VK_COLOR_SPACE_DISPLAY_P3_LINEAR_EXT = 1000104001, - VK_COLOR_SPACE_DISPLAY_P3_NONLINEAR_EXT = 1000104002, - VK_COLOR_SPACE_SCRGB_LINEAR_EXT = 1000104003, - VK_COLOR_SPACE_SCRGB_NONLINEAR_EXT = 1000104004, - VK_COLOR_SPACE_DCI_P3_LINEAR_EXT = 1000104005, - VK_COLOR_SPACE_DCI_P3_NONLINEAR_EXT = 1000104006, - VK_COLOR_SPACE_BT709_LINEAR_EXT = 1000104007, - VK_COLOR_SPACE_BT709_NONLINEAR_EXT = 1000104008, - VK_COLOR_SPACE_BT2020_LINEAR_EXT = 1000104009, - VK_COLOR_SPACE_BT2020_NONLINEAR_EXT = 1000104010, + //@extension("VK_EXT_swapchain_colorspace") // 105 + VK_COLOR_SPACE_DISPLAY_P3_NONLINEAR_EXT = 1000104001, + VK_COLOR_SPACE_EXTENDED_SRGB_LINEAR_EXT = 1000104002, + VK_COLOR_SPACE_DCI_P3_LINEAR_EXT = 1000104003, + VK_COLOR_SPACE_DCI_P3_NONLINEAR_EXT = 1000104004, + VK_COLOR_SPACE_BT709_LINEAR_EXT = 1000104005, + VK_COLOR_SPACE_BT709_NONLINEAR_EXT = 1000104006, + VK_COLOR_SPACE_BT2020_LINEAR_EXT = 1000104007, + VK_COLOR_SPACE_HDR10_ST2084_EXT = 1000104008, + VK_COLOR_SPACE_DOLBYVISION_EXT = 1000104009, + VK_COLOR_SPACE_HDR10_HLG_EXT = 1000104010, VK_COLOR_SPACE_ADOBERGB_LINEAR_EXT = 1000104011, VK_COLOR_SPACE_ADOBERGB_NONLINEAR_EXT = 1000104012, + VK_COLOR_SPACE_PASS_THROUGH_EXT = 1000104013, } @extension("VK_EXT_debug_report") // 12 @@ -1245,6 +1246,9 @@ enum VkDebugReportObjectTypeEXT { VK_DEBUG_REPORT_OBJECT_TYPE_DISPLAY_MODE_KHR_EXT = 30, VK_DEBUG_REPORT_OBJECT_TYPE_OBJECT_TABLE_NVX_EXT = 31, VK_DEBUG_REPORT_OBJECT_TYPE_INDIRECT_COMMANDS_LAYOUT_NVX_EXT = 32, + + //extension("VK_KHR_descriptor_update_template") // 86 + VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_UPDATE_TEMPLATE_KHR_EXT = 1000085000, } @extension("VK_EXT_debug_report") // 12 @@ -3735,7 +3739,7 @@ class VkViSurfaceCreateInfoNN { @extension("VK_KHX_device_group_creation") // 71 class VkPhysicalDeviceGroupPropertiesKHX { VkStructureType sType - const void* pNext + void* pNext u32 physicalDeviceCount VkPhysicalDevice[VK_MAX_DEVICE_GROUP_SIZE_KHX] physicalDevices VkBool32 subsetAllocation @@ -4223,7 +4227,7 @@ class VkPipelineViewportSwizzleStateCreateInfoNV { @extension("VK_EXT_discard_rectangles") // 100 class VkPhysicalDeviceDiscardRectanglePropertiesEXT { VkStructureType sType - const void* pNext + void* pNext u32 maxDiscardRectangles } diff --git a/vulkan/include/vulkan/vulkan.h b/vulkan/include/vulkan/vulkan.h index 4b3b8bf984..67eba86646 100644 --- a/vulkan/include/vulkan/vulkan.h +++ b/vulkan/include/vulkan/vulkan.h @@ -43,7 +43,7 @@ extern "C" { #define VK_VERSION_MINOR(version) (((uint32_t)(version) >> 12) & 0x3ff) #define VK_VERSION_PATCH(version) ((uint32_t)(version) & 0xfff) // Version of this file -#define VK_HEADER_VERSION 43 +#define VK_HEADER_VERSION 46 #define VK_NULL_HANDLE 0 @@ -4011,6 +4011,30 @@ VKAPI_ATTR void VKAPI_CALL vkCmdPushDescriptorSetKHR( const VkWriteDescriptorSet* pDescriptorWrites); #endif +#define VK_KHR_incremental_present 1 +#define VK_KHR_INCREMENTAL_PRESENT_SPEC_VERSION 1 +#define VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME "VK_KHR_incremental_present" + +typedef struct VkRectLayerKHR { + VkOffset2D offset; + VkExtent2D extent; + uint32_t layer; +} VkRectLayerKHR; + +typedef struct VkPresentRegionKHR { + uint32_t rectangleCount; + const VkRectLayerKHR* pRectangles; +} VkPresentRegionKHR; + +typedef struct VkPresentRegionsKHR { + VkStructureType sType; + const void* pNext; + uint32_t swapchainCount; + const VkPresentRegionKHR* pRegions; +} VkPresentRegionsKHR; + + + #define VK_KHR_descriptor_update_template 1 VK_DEFINE_NON_DISPATCHABLE_HANDLE(VkDescriptorUpdateTemplateKHR) @@ -4086,7 +4110,7 @@ VKAPI_ATTR void VKAPI_CALL vkCmdPushDescriptorSetWithTemplateKHR( #define VK_EXT_debug_report 1 VK_DEFINE_NON_DISPATCHABLE_HANDLE(VkDebugReportCallbackEXT) -#define VK_EXT_DEBUG_REPORT_SPEC_VERSION 5 +#define VK_EXT_DEBUG_REPORT_SPEC_VERSION 6 #define VK_EXT_DEBUG_REPORT_EXTENSION_NAME "VK_EXT_debug_report" #define VK_STRUCTURE_TYPE_DEBUG_REPORT_CREATE_INFO_EXT VK_STRUCTURE_TYPE_DEBUG_REPORT_CALLBACK_CREATE_INFO_EXT @@ -4125,6 +4149,7 @@ typedef enum VkDebugReportObjectTypeEXT { VK_DEBUG_REPORT_OBJECT_TYPE_DISPLAY_MODE_KHR_EXT = 30, VK_DEBUG_REPORT_OBJECT_TYPE_OBJECT_TABLE_NVX_EXT = 31, VK_DEBUG_REPORT_OBJECT_TYPE_INDIRECT_COMMANDS_LAYOUT_NVX_EXT = 32, + VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_UPDATE_TEMPLATE_KHR_EXT = 1000085000, VK_DEBUG_REPORT_OBJECT_TYPE_BEGIN_RANGE_EXT = VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_END_RANGE_EXT = VK_DEBUG_REPORT_OBJECT_TYPE_INDIRECT_COMMANDS_LAYOUT_NVX_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RANGE_SIZE_EXT = (VK_DEBUG_REPORT_OBJECT_TYPE_INDIRECT_COMMANDS_LAYOUT_NVX_EXT - VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT + 1), @@ -4781,7 +4806,7 @@ VKAPI_ATTR VkResult VKAPI_CALL vkCreateViSurfaceNN( typedef struct VkPhysicalDeviceGroupPropertiesKHX { VkStructureType sType; - const void* pNext; + void* pNext; uint32_t physicalDeviceCount; VkPhysicalDevice physicalDevices[VK_MAX_DEVICE_GROUP_SIZE_KHX]; VkBool32 subsetAllocation; @@ -4906,7 +4931,7 @@ typedef struct VkExportMemoryAllocateInfoKHX { -#ifdef VK_USE_PLATFORM_WIN32_KHR +#ifdef VK_USE_PLATFORM_WIN32_KHX #define VK_KHX_external_memory_win32 1 #define VK_KHX_EXTERNAL_MEMORY_WIN32_SPEC_VERSION 1 #define VK_KHX_EXTERNAL_MEMORY_WIN32_EXTENSION_NAME "VK_KHX_external_memory_win32" @@ -4949,7 +4974,7 @@ VKAPI_ATTR VkResult VKAPI_CALL vkGetMemoryWin32HandlePropertiesKHX( HANDLE handle, VkMemoryWin32HandlePropertiesKHX* pMemoryWin32HandleProperties); #endif -#endif /* VK_USE_PLATFORM_WIN32_KHR */ +#endif /* VK_USE_PLATFORM_WIN32_KHX */ #define VK_KHX_external_memory_fd 1 #define VK_KHX_EXTERNAL_MEMORY_FD_SPEC_VERSION 1 @@ -5139,28 +5164,6 @@ VKAPI_ATTR VkResult VKAPI_CALL vkGetSemaphoreFdKHX( int* pFd); #endif -#define VK_KHR_incremental_present 1 -#define VK_KHR_INCREMENTAL_PRESENT_SPEC_VERSION 1 -#define VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME "VK_KHR_incremental_present" - -typedef struct VkRectLayerKHR { - VkOffset2D offset; - VkExtent2D extent; - uint32_t layer; -} VkRectLayerKHR; - -typedef struct VkPresentRegionKHR { - uint32_t rectangleCount; - const VkRectLayerKHR* pRectangles; -} VkPresentRegionKHR; - -typedef struct VkPresentRegionsKHR { - VkStructureType sType; - const void* pNext; - uint32_t swapchainCount; - const VkPresentRegionKHR* pRegions; -} VkPresentRegionsKHR; - #define VK_NVX_device_generated_commands 1 VK_DEFINE_NON_DISPATCHABLE_HANDLE(VkObjectTableNVX) VK_DEFINE_NON_DISPATCHABLE_HANDLE(VkIndirectCommandsLayoutNVX) @@ -5705,7 +5708,7 @@ typedef VkFlags VkPipelineDiscardRectangleStateCreateFlagsEXT; typedef struct VkPhysicalDeviceDiscardRectanglePropertiesEXT { VkStructureType sType; - const void* pNext; + void* pNext; uint32_t maxDiscardRectangles; } VkPhysicalDeviceDiscardRectanglePropertiesEXT; @@ -5730,9 +5733,10 @@ VKAPI_ATTR void VKAPI_CALL vkCmdSetDiscardRectangleEXT( #endif #define VK_EXT_swapchain_colorspace 1 -#define VK_EXT_SWAPCHAIN_COLOR_SPACE_SPEC_VERSION 1 +#define VK_EXT_SWAPCHAIN_COLOR_SPACE_SPEC_VERSION 2 #define VK_EXT_SWAPCHAIN_COLOR_SPACE_EXTENSION_NAME "VK_EXT_swapchain_colorspace" + #define VK_EXT_hdr_metadata 1 #define VK_EXT_HDR_METADATA_SPEC_VERSION 1 #define VK_EXT_HDR_METADATA_EXTENSION_NAME "VK_EXT_hdr_metadata" diff --git a/vulkan/libvulkan/swapchain.cpp b/vulkan/libvulkan/swapchain.cpp index 2fee8a5fbf..3b785e671d 100644 --- a/vulkan/libvulkan/swapchain.cpp +++ b/vulkan/libvulkan/swapchain.cpp @@ -981,25 +981,9 @@ VkResult CreateSwapchainKHR(VkDevice device, int gralloc_usage = 0; if (dispatch.GetSwapchainGrallocUsage2ANDROID) { uint64_t consumer_usage, producer_usage; - if (GetData(device).driver_version == 256587285) { - // HACK workaround for loader/driver mismatch during transition to - // vkGetSwapchainGrallocUsage2ANDROID. - typedef VkResult(VKAPI_PTR * - PFN_vkGetSwapchainGrallocUsage2ANDROID_HACK)( - VkDevice device, VkFormat format, VkImageUsageFlags imageUsage, - uint64_t * grallocConsumerUsage, - uint64_t * grallocProducerUsage); - auto get_swapchain_gralloc_usage = - reinterpret_cast<PFN_vkGetSwapchainGrallocUsage2ANDROID_HACK>( - dispatch.GetSwapchainGrallocUsage2ANDROID); - result = get_swapchain_gralloc_usage( - device, create_info->imageFormat, create_info->imageUsage, - &consumer_usage, &producer_usage); - } else { - result = dispatch.GetSwapchainGrallocUsage2ANDROID( - device, create_info->imageFormat, create_info->imageUsage, - swapchain_image_usage, &consumer_usage, &producer_usage); - } + result = dispatch.GetSwapchainGrallocUsage2ANDROID( + device, create_info->imageFormat, create_info->imageUsage, + swapchain_image_usage, &consumer_usage, &producer_usage); if (result != VK_SUCCESS) { ALOGE("vkGetSwapchainGrallocUsage2ANDROID failed: %d", result); return VK_ERROR_SURFACE_LOST_KHR; |