diff options
| -rw-r--r-- | libs/binder/include/binder/Parcel.h | 10 | ||||
| -rw-r--r-- | libs/binder/include/binder/SafeInterface.h | 7 |
2 files changed, 17 insertions, 0 deletions
diff --git a/libs/binder/include/binder/Parcel.h b/libs/binder/include/binder/Parcel.h index 698de0180e..5209140138 100644 --- a/libs/binder/include/binder/Parcel.h +++ b/libs/binder/include/binder/Parcel.h @@ -388,6 +388,11 @@ public: LIBBINDER_EXPORTED status_t writeUniqueFileDescriptorVector(const std::vector<binder::unique_fd>& val); + // WARNING: deprecated and incompatible with AIDL. You should use Parcelable + // definitions outside of Parcel to represent shared memory, such as + // IMemory or with ParcelFileDescriptor. We should remove this, or move it to be + // external to Parcel, it's not a very encapsulated API. + // // Writes a blob to the parcel. // If the blob is small, then it is stored in-place, otherwise it is // transferred by way of an anonymous shared memory region. Prefer sending @@ -629,6 +634,11 @@ public: LIBBINDER_EXPORTED status_t readUniqueFileDescriptorVector(std::vector<binder::unique_fd>* val) const; + // WARNING: deprecated and incompatible with AIDL. You should use Parcelable + // definitions outside of Parcel to represent shared memory, such as + // IMemory or with ParcelFileDescriptor. We should remove this, or move it to be + // external to Parcel, it's not a very encapsulated API. + // // Reads a blob from the parcel. // The caller should call release() on the blob after reading its contents. LIBBINDER_EXPORTED status_t readBlob(size_t len, ReadableBlob* outBlob) const; diff --git a/libs/binder/include/binder/SafeInterface.h b/libs/binder/include/binder/SafeInterface.h index 0b4f196b8f..bcbd14f9d4 100644 --- a/libs/binder/include/binder/SafeInterface.h +++ b/libs/binder/include/binder/SafeInterface.h @@ -34,6 +34,13 @@ namespace android { namespace SafeInterface { +/** + * WARNING: Prefer to use AIDL-generated interfaces. Using SafeInterface to generate interfaces + * does not support tracing, and many other AIDL features out of the box. The general direction + * we should go is to migrate safe interface users to AIDL and then remove this so that there + * is only one thing to learn/use/test/integrate, not this as well. + */ + // ParcelHandler is responsible for writing/reading various types to/from a Parcel in a generic way class LIBBINDER_EXPORTED ParcelHandler { public: |