diff options
| -rw-r--r-- | libs/gui/FrameTimestamps.cpp | 2 | ||||
| -rw-r--r-- | libs/gui/IGraphicBufferProducer.cpp | 2 | ||||
| -rw-r--r-- | libs/gui/include/gui/BufferQueueConsumer.h | 2 | ||||
| -rw-r--r-- | libs/gui/include/gui/BufferQueueProducer.h | 3 | ||||
| -rw-r--r-- | libs/gui/include/gui/DisplayEventReceiver.h | 2 | ||||
| -rw-r--r-- | libs/gui/include/gui/GLConsumer.h | 2 | ||||
| -rw-r--r-- | libs/gui/include/gui/StreamSplitter.h | 4 | ||||
| -rw-r--r-- | libs/gui/include/gui/bufferqueue/1.0/B2HProducerListener.h | 2 | ||||
| -rw-r--r-- | libs/gui/include/gui/bufferqueue/1.0/H2BGraphicBufferProducer.h | 2 | ||||
| -rw-r--r-- | libs/gui/tests/Malicious.cpp | 4 | ||||
| -rw-r--r-- | libs/gui/tests/Surface_test.cpp | 3 |
11 files changed, 14 insertions, 14 deletions
diff --git a/libs/gui/FrameTimestamps.cpp b/libs/gui/FrameTimestamps.cpp index 85ae433e42..8a14359cd5 100644 --- a/libs/gui/FrameTimestamps.cpp +++ b/libs/gui/FrameTimestamps.cpp @@ -158,7 +158,7 @@ void FrameEvents::dump(String8& outString) const namespace { struct FrameNumberEqual { - FrameNumberEqual(uint64_t frameNumber) : mFrameNumber(frameNumber) {} + explicit FrameNumberEqual(uint64_t frameNumber) : mFrameNumber(frameNumber) {} bool operator()(const FrameEvents& frame) { return frame.valid && mFrameNumber == frame.frameNumber; } diff --git a/libs/gui/IGraphicBufferProducer.cpp b/libs/gui/IGraphicBufferProducer.cpp index 0b3796056d..74ab5ac1c8 100644 --- a/libs/gui/IGraphicBufferProducer.cpp +++ b/libs/gui/IGraphicBufferProducer.cpp @@ -536,7 +536,7 @@ BpGraphicBufferProducer::~BpGraphicBufferProducer() {} class HpGraphicBufferProducer : public HpInterface< BpGraphicBufferProducer, H2BGraphicBufferProducer> { public: - HpGraphicBufferProducer(const sp<IBinder>& base) : PBase(base) {} + explicit HpGraphicBufferProducer(const sp<IBinder>& base) : PBase(base) {} status_t requestBuffer(int slot, sp<GraphicBuffer>* buf) override { return mBase->requestBuffer(slot, buf); diff --git a/libs/gui/include/gui/BufferQueueConsumer.h b/libs/gui/include/gui/BufferQueueConsumer.h index d108120777..aa13c0cf13 100644 --- a/libs/gui/include/gui/BufferQueueConsumer.h +++ b/libs/gui/include/gui/BufferQueueConsumer.h @@ -31,7 +31,7 @@ class BufferQueueCore; class BufferQueueConsumer : public BnGraphicBufferConsumer { public: - BufferQueueConsumer(const sp<BufferQueueCore>& core); + explicit BufferQueueConsumer(const sp<BufferQueueCore>& core); ~BufferQueueConsumer() override; // acquireBuffer attempts to acquire ownership of the next pending buffer in diff --git a/libs/gui/include/gui/BufferQueueProducer.h b/libs/gui/include/gui/BufferQueueProducer.h index 5c7ffb416d..73bc5dd318 100644 --- a/libs/gui/include/gui/BufferQueueProducer.h +++ b/libs/gui/include/gui/BufferQueueProducer.h @@ -29,7 +29,8 @@ class BufferQueueProducer : public BnGraphicBufferProducer, public: friend class BufferQueue; // Needed to access binderDied - BufferQueueProducer(const sp<BufferQueueCore>& core, bool consumerIsSurfaceFlinger = false); + explicit BufferQueueProducer(const sp<BufferQueueCore>& core, + bool consumerIsSurfaceFlinger = false); ~BufferQueueProducer() override; // requestBuffer returns the GraphicBuffer for slot N. diff --git a/libs/gui/include/gui/DisplayEventReceiver.h b/libs/gui/include/gui/DisplayEventReceiver.h index 32ce59a765..a4102dfe03 100644 --- a/libs/gui/include/gui/DisplayEventReceiver.h +++ b/libs/gui/include/gui/DisplayEventReceiver.h @@ -84,7 +84,7 @@ public: * or requestNextVsync to receive them. * Other events start being delivered immediately. */ - DisplayEventReceiver( + explicit DisplayEventReceiver( ISurfaceComposer::VsyncSource vsyncSource = ISurfaceComposer::eVsyncSourceApp); /* diff --git a/libs/gui/include/gui/GLConsumer.h b/libs/gui/include/gui/GLConsumer.h index 71ed3bf239..8bc7cbffb9 100644 --- a/libs/gui/include/gui/GLConsumer.h +++ b/libs/gui/include/gui/GLConsumer.h @@ -300,7 +300,7 @@ private: // also only creating new EGLImages from buffers when required. class EglImage : public LightRefBase<EglImage> { public: - EglImage(sp<GraphicBuffer> graphicBuffer); + explicit EglImage(sp<GraphicBuffer> graphicBuffer); // createIfNeeded creates an EGLImage if required (we haven't created // one yet, or the EGLDisplay or crop-rect has changed). diff --git a/libs/gui/include/gui/StreamSplitter.h b/libs/gui/include/gui/StreamSplitter.h index 8f47eb47ac..b4eef292c1 100644 --- a/libs/gui/include/gui/StreamSplitter.h +++ b/libs/gui/include/gui/StreamSplitter.h @@ -128,7 +128,7 @@ private: class BufferTracker : public LightRefBase<BufferTracker> { public: - BufferTracker(const sp<GraphicBuffer>& buffer); + explicit BufferTracker(const sp<GraphicBuffer>& buffer); const sp<GraphicBuffer>& getBuffer() const { return mBuffer; } const sp<Fence>& getMergedFence() const { return mMergedFence; } @@ -154,7 +154,7 @@ private: }; // Only called from createSplitter - StreamSplitter(const sp<IGraphicBufferConsumer>& inputQueue); + explicit StreamSplitter(const sp<IGraphicBufferConsumer>& inputQueue); // Must be accessed through RefBase virtual ~StreamSplitter(); diff --git a/libs/gui/include/gui/bufferqueue/1.0/B2HProducerListener.h b/libs/gui/include/gui/bufferqueue/1.0/B2HProducerListener.h index fa6c2d9f7f..0f6fb45512 100644 --- a/libs/gui/include/gui/bufferqueue/1.0/B2HProducerListener.h +++ b/libs/gui/include/gui/bufferqueue/1.0/B2HProducerListener.h @@ -50,7 +50,7 @@ typedef ::android::IProducerListener struct B2HProducerListener : public HProducerListener { sp<BProducerListener> mBase; - B2HProducerListener(sp<BProducerListener> const& base); + explicit B2HProducerListener(sp<BProducerListener> const& base); Return<void> onBufferReleased() override; Return<bool> needsReleaseNotify() override; }; diff --git a/libs/gui/include/gui/bufferqueue/1.0/H2BGraphicBufferProducer.h b/libs/gui/include/gui/bufferqueue/1.0/H2BGraphicBufferProducer.h index 74850b4879..c92fa9d0e5 100644 --- a/libs/gui/include/gui/bufferqueue/1.0/H2BGraphicBufferProducer.h +++ b/libs/gui/include/gui/bufferqueue/1.0/H2BGraphicBufferProducer.h @@ -59,7 +59,7 @@ struct H2BGraphicBufferProducer : public ::android::H2BConverter< HGraphicBufferProducer, BGraphicBufferProducer, BnGraphicBufferProducer> { - H2BGraphicBufferProducer(sp<HGraphicBufferProducer> const& base) : CBase(base) {} + explicit H2BGraphicBufferProducer(sp<HGraphicBufferProducer> const& base) : CBase(base) {} status_t requestBuffer(int slot, sp<GraphicBuffer>* buf) override; status_t setMaxDequeuedBufferCount(int maxDequeuedBuffers) override; diff --git a/libs/gui/tests/Malicious.cpp b/libs/gui/tests/Malicious.cpp index bb6b8a59fe..acd42979c2 100644 --- a/libs/gui/tests/Malicious.cpp +++ b/libs/gui/tests/Malicious.cpp @@ -27,7 +27,7 @@ namespace test { class ProxyBQP : public BnGraphicBufferProducer { public: - ProxyBQP(const sp<IGraphicBufferProducer>& producer) : mProducer(producer) {} + explicit ProxyBQP(const sp<IGraphicBufferProducer>& producer) : mProducer(producer) {} // Pass through calls to mProducer status_t requestBuffer(int slot, sp<GraphicBuffer>* buf) override { @@ -102,7 +102,7 @@ protected: class MaliciousBQP : public ProxyBQP { public: - MaliciousBQP(const sp<IGraphicBufferProducer>& producer) : ProxyBQP(producer) {} + explicit MaliciousBQP(const sp<IGraphicBufferProducer>& producer) : ProxyBQP(producer) {} void beMalicious(int32_t value) { mMaliciousValue = value; } diff --git a/libs/gui/tests/Surface_test.cpp b/libs/gui/tests/Surface_test.cpp index 6e196bfac8..959aafc503 100644 --- a/libs/gui/tests/Surface_test.cpp +++ b/libs/gui/tests/Surface_test.cpp @@ -635,8 +635,7 @@ private: class FakeProducerFrameEventHistory : public ProducerFrameEventHistory { public: - FakeProducerFrameEventHistory(FenceToFenceTimeMap* fenceMap) - : mFenceMap(fenceMap) {} + explicit FakeProducerFrameEventHistory(FenceToFenceTimeMap* fenceMap) : mFenceMap(fenceMap) {} ~FakeProducerFrameEventHistory() {} |