diff options
-rw-r--r-- | include/gui/IGraphicBufferProducer.h | 21 | ||||
-rw-r--r-- | include/private/gui/LayerState.h | 8 | ||||
-rw-r--r-- | include/ui/DisplayInfo.h | 22 | ||||
-rw-r--r-- | include/ui/DisplayStatInfo.h | 4 | ||||
-rw-r--r-- | libs/gui/BufferItem.cpp | 9 | ||||
-rw-r--r-- | libs/gui/BufferQueueCore.cpp | 1 | ||||
-rw-r--r-- | libs/gui/BufferQueueProducer.cpp | 1 | ||||
-rw-r--r-- | libs/gui/IGraphicBufferAlloc.cpp | 2 | ||||
-rw-r--r-- | services/surfaceflinger/DisplayHardware/HWC2On1Adapter.cpp | 1 | ||||
-rw-r--r-- | services/surfaceflinger/DisplayHardware/HWC2On1Adapter.h | 1 |
10 files changed, 41 insertions, 29 deletions
diff --git a/include/gui/IGraphicBufferProducer.h b/include/gui/IGraphicBufferProducer.h index c62bc5899c..9353042e1e 100644 --- a/include/gui/IGraphicBufferProducer.h +++ b/include/gui/IGraphicBufferProducer.h @@ -339,20 +339,19 @@ public: void setSurfaceDamage(const Region& damage) { surfaceDamage = damage; } private: - int64_t timestamp; - int isAutoTimestamp; - android_dataspace dataSpace; + int64_t timestamp{0}; + int isAutoTimestamp{0}; + android_dataspace dataSpace{HAL_DATASPACE_UNKNOWN}; Rect crop; - int scalingMode; - uint32_t transform; - uint32_t stickyTransform; + int scalingMode{0}; + uint32_t transform{0}; + uint32_t stickyTransform{0}; sp<Fence> fence; Region surfaceDamage; }; // QueueBufferOutput must be a POD structure struct __attribute__ ((__packed__)) QueueBufferOutput { - inline QueueBufferOutput() { } // outWidth - filled with default width applied to the buffer // outHeight - filled with default height applied to the buffer // outTransformHint - filled with default transform applied to the buffer @@ -379,10 +378,10 @@ public: nextFrameNumber = inNextFrameNumber; } private: - uint32_t width; - uint32_t height; - uint32_t transformHint; - uint32_t numPendingBuffers; + uint32_t width{0}; + uint32_t height{0}; + uint32_t transformHint{0}; + uint32_t numPendingBuffers{0}; uint64_t nextFrameNumber{0}; }; diff --git a/include/private/gui/LayerState.h b/include/private/gui/LayerState.h index 4b3fcc6e2b..292dd3b8df 100644 --- a/include/private/gui/LayerState.h +++ b/include/private/gui/LayerState.h @@ -74,10 +74,10 @@ struct layer_state_t { status_t read(const Parcel& input); struct matrix22_t { - float dsdx; - float dtdx; - float dsdy; - float dtdy; + float dsdx{0}; + float dtdx{0}; + float dsdy{0}; + float dtdy{0}; }; sp<IBinder> surface; uint32_t what; diff --git a/include/ui/DisplayInfo.h b/include/ui/DisplayInfo.h index ad73ee72f9..1f5a9914b7 100644 --- a/include/ui/DisplayInfo.h +++ b/include/ui/DisplayInfo.h @@ -26,17 +26,17 @@ namespace android { struct DisplayInfo { - uint32_t w; - uint32_t h; - float xdpi; - float ydpi; - float fps; - float density; - uint8_t orientation; - bool secure; - nsecs_t appVsyncOffset; - nsecs_t presentationDeadline; - int colorTransform; + uint32_t w{0}; + uint32_t h{0}; + float xdpi{0}; + float ydpi{0}; + float fps{0}; + float density{0}; + uint8_t orientation{0}; + bool secure{false}; + nsecs_t appVsyncOffset{0}; + nsecs_t presentationDeadline{0}; + int colorTransform{0}; }; /* Display orientations as defined in Surface.java and ISurfaceComposer.h. */ diff --git a/include/ui/DisplayStatInfo.h b/include/ui/DisplayStatInfo.h index 0549a832b5..09543ec13a 100644 --- a/include/ui/DisplayStatInfo.h +++ b/include/ui/DisplayStatInfo.h @@ -22,8 +22,8 @@ namespace android { struct DisplayStatInfo { - nsecs_t vsyncTime; - nsecs_t vsyncPeriod; + nsecs_t vsyncTime{0}; + nsecs_t vsyncPeriod{0}; }; }; // namespace android diff --git a/libs/gui/BufferItem.cpp b/libs/gui/BufferItem.cpp index 5e3924a7ee..2ffeb0d333 100644 --- a/libs/gui/BufferItem.cpp +++ b/libs/gui/BufferItem.cpp @@ -66,6 +66,9 @@ size_t BufferItem::getPodSize() const { addAligned(size, mIsDroppable); addAligned(size, mAcquireCalled); addAligned(size, mTransformToDisplayInverse); + addAligned(size, mAutoRefresh); + addAligned(size, mQueuedBuffer); + addAligned(size, mIsStale); return size; } @@ -151,6 +154,9 @@ status_t BufferItem::flatten( writeAligned(buffer, size, mIsDroppable); writeAligned(buffer, size, mAcquireCalled); writeAligned(buffer, size, mTransformToDisplayInverse); + writeAligned(buffer, size, mAutoRefresh); + writeAligned(buffer, size, mQueuedBuffer); + writeAligned(buffer, size, mIsStale); return NO_ERROR; } @@ -207,6 +213,9 @@ status_t BufferItem::unflatten( readAligned(buffer, size, mIsDroppable); readAligned(buffer, size, mAcquireCalled); readAligned(buffer, size, mTransformToDisplayInverse); + readAligned(buffer, size, mAutoRefresh); + readAligned(buffer, size, mQueuedBuffer); + readAligned(buffer, size, mIsStale); return NO_ERROR; } diff --git a/libs/gui/BufferQueueCore.cpp b/libs/gui/BufferQueueCore.cpp index b574f9d754..a9eac90e01 100644 --- a/libs/gui/BufferQueueCore.cpp +++ b/libs/gui/BufferQueueCore.cpp @@ -92,6 +92,7 @@ BufferQueueCore::BufferQueueCore(const sp<IGraphicBufferAlloc>& allocator) : mSharedBufferSlot(INVALID_BUFFER_SLOT), mSharedBufferCache(Rect::INVALID_RECT, 0, NATIVE_WINDOW_SCALING_MODE_FREEZE, HAL_DATASPACE_UNKNOWN), + mLastQueuedSlot(INVALID_BUFFER_SLOT), mUniqueId(getUniqueId()) { if (allocator == NULL) { diff --git a/libs/gui/BufferQueueProducer.cpp b/libs/gui/BufferQueueProducer.cpp index b7b56f03f2..fc9d29f624 100644 --- a/libs/gui/BufferQueueProducer.cpp +++ b/libs/gui/BufferQueueProducer.cpp @@ -47,6 +47,7 @@ BufferQueueProducer::BufferQueueProducer(const sp<BufferQueueCore>& core) : mConsumerName(), mStickyTransform(0), mLastQueueBufferFence(Fence::NO_FENCE), + mLastQueuedTransform(0), mCallbackMutex(), mNextCallbackTicket(0), mCurrentCallbackTicket(0), diff --git a/libs/gui/IGraphicBufferAlloc.cpp b/libs/gui/IGraphicBufferAlloc.cpp index d4d470281e..ac6ace692c 100644 --- a/libs/gui/IGraphicBufferAlloc.cpp +++ b/libs/gui/IGraphicBufferAlloc.cpp @@ -101,7 +101,7 @@ status_t BnGraphicBufferAlloc::onTransact( uint32_t height = data.readUint32(); PixelFormat format = static_cast<PixelFormat>(data.readInt32()); uint32_t usage = data.readUint32(); - status_t error; + status_t error = NO_ERROR; sp<GraphicBuffer> result = createGraphicBuffer(width, height, format, usage, &error); reply->writeInt32(error); diff --git a/services/surfaceflinger/DisplayHardware/HWC2On1Adapter.cpp b/services/surfaceflinger/DisplayHardware/HWC2On1Adapter.cpp index 0528d7b27a..cbe32e6d37 100644 --- a/services/surfaceflinger/DisplayHardware/HWC2On1Adapter.cpp +++ b/services/surfaceflinger/DisplayHardware/HWC2On1Adapter.cpp @@ -562,6 +562,7 @@ HWC2On1Adapter::Display::Display(HWC2On1Adapter& device, HWC2::DisplayType type) mHwc1Id(-1), mConfigs(), mActiveConfig(nullptr), + mActiveColorMode(-1), mName(), mType(type), mPowerMode(PowerMode::Off), diff --git a/services/surfaceflinger/DisplayHardware/HWC2On1Adapter.h b/services/surfaceflinger/DisplayHardware/HWC2On1Adapter.h index dc7c355617..b46556d43d 100644 --- a/services/surfaceflinger/DisplayHardware/HWC2On1Adapter.h +++ b/services/surfaceflinger/DisplayHardware/HWC2On1Adapter.h @@ -247,6 +247,7 @@ private: public: Config(Display& display) : mDisplay(display), + mId(0), mAttributes() {} bool isOnDisplay(const Display& display) const { |