diff options
| -rw-r--r-- | libs/binder/Parcel.cpp | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/libs/binder/Parcel.cpp b/libs/binder/Parcel.cpp index c7e8ff2e71..e88ae29518 100644 --- a/libs/binder/Parcel.cpp +++ b/libs/binder/Parcel.cpp @@ -1795,15 +1795,16 @@ status_t Parcel::readUtf8FromUtf16(std::string* str) const { return NO_ERROR; } - ssize_t utf8Size = utf16_to_utf8_length(src, utf16Size); - if (utf8Size < 0) { + // Allow for closing '\0' + ssize_t utf8Size = utf16_to_utf8_length(src, utf16Size) + 1; + if (utf8Size < 1) { return BAD_VALUE; } // Note that while it is probably safe to assume string::resize keeps a - // spare byte around for the trailing null, we're going to be explicit. - str->resize(utf8Size + 1); - utf16_to_utf8(src, utf16Size, &((*str)[0])); + // spare byte around for the trailing null, we still pass the size including the trailing null str->resize(utf8Size); + utf16_to_utf8(src, utf16Size, &((*str)[0]), utf8Size); + str->resize(utf8Size - 1); return NO_ERROR; } |