diff options
| -rw-r--r-- | cmds/atrace/atrace.rc | 6 | ||||
| -rw-r--r-- | libs/sensor/include/sensor/Sensor.h | 6 | ||||
| -rw-r--r-- | libs/sensor/include/sensor/SensorEventQueue.h | 2 | ||||
| -rw-r--r-- | libs/sensor/include/sensor/SensorManager.h | 2 | ||||
| -rw-r--r-- | services/sensorservice/SensorRecord.h | 2 | ||||
| -rw-r--r-- | services/sensorservice/hidl/include/sensorservicehidl/SensorManager.h | 2 | ||||
| -rw-r--r-- | services/sensorservice/mat.h | 4 | ||||
| -rw-r--r-- | services/sensorservice/vec.h | 4 |
8 files changed, 17 insertions, 11 deletions
diff --git a/cmds/atrace/atrace.rc b/cmds/atrace/atrace.rc index 4459cef655..07b12f9753 100644 --- a/cmds/atrace/atrace.rc +++ b/cmds/atrace/atrace.rc @@ -138,6 +138,12 @@ on late-init chmod 0666 /sys/kernel/tracing/events/block/block_rq_complete/enable chmod 0666 /sys/kernel/debug/tracing/events/block/block_rq_complete/enable + # filemap events for iorapd + chmod 0666 /sys/kernel/tracing/events/filemap/mm_filemap_add_to_page_cache/enable + chmod 0666 /sys/kernel/debug/tracing/events/filemap/mm_filemap_add_to_page_cache/enable + chmod 0666 /sys/kernel/tracing/events/filemap/mm_filemap_delete_from_page_cache/enable + chmod 0666 /sys/kernel/debug/tracing/events/filemap/mm_filemap_delete_from_page_cache/enable + # Tracing disabled by default write /sys/kernel/debug/tracing/tracing_on 0 write /sys/kernel/tracing/tracing_on 0 diff --git a/libs/sensor/include/sensor/Sensor.h b/libs/sensor/include/sensor/Sensor.h index 6926f7f341..324d443106 100644 --- a/libs/sensor/include/sensor/Sensor.h +++ b/libs/sensor/include/sensor/Sensor.h @@ -57,15 +57,15 @@ public: uint8_t b[16]; int64_t i64[2]; }; - uuid_t(const uint8_t (&uuid)[16]) { memcpy(b, uuid, sizeof(b));} + explicit uuid_t(const uint8_t (&uuid)[16]) { memcpy(b, uuid, sizeof(b));} uuid_t() : b{0} {} }; Sensor(const Sensor&) = default; Sensor& operator=(const Sensor&) = default; - Sensor(const char * name = ""); - Sensor(struct sensor_t const* hwSensor, int halVersion = 0); + explicit Sensor(const char * name = ""); + explicit Sensor(struct sensor_t const* hwSensor, int halVersion = 0); Sensor(struct sensor_t const& hwSensor, const uuid_t& uuid, int halVersion = 0); ~Sensor(); diff --git a/libs/sensor/include/sensor/SensorEventQueue.h b/libs/sensor/include/sensor/SensorEventQueue.h index baed2ee20d..8176578526 100644 --- a/libs/sensor/include/sensor/SensorEventQueue.h +++ b/libs/sensor/include/sensor/SensorEventQueue.h @@ -64,7 +64,7 @@ public: // Default sensor sample period static constexpr int32_t SENSOR_DELAY_NORMAL = 200000; - SensorEventQueue(const sp<ISensorEventConnection>& connection); + explicit SensorEventQueue(const sp<ISensorEventConnection>& connection); virtual ~SensorEventQueue(); virtual void onFirstRef(); diff --git a/libs/sensor/include/sensor/SensorManager.h b/libs/sensor/include/sensor/SensorManager.h index 23f7a918bb..f09c9c67b4 100644 --- a/libs/sensor/include/sensor/SensorManager.h +++ b/libs/sensor/include/sensor/SensorManager.h @@ -71,7 +71,7 @@ private: void sensorManagerDied(); static status_t waitForSensorService(sp<ISensorServer> *server); - SensorManager(const String16& opPackageName); + explicit SensorManager(const String16& opPackageName); status_t assertStateLocked(); private: diff --git a/services/sensorservice/SensorRecord.h b/services/sensorservice/SensorRecord.h index 5a35410572..031744a668 100644 --- a/services/sensorservice/SensorRecord.h +++ b/services/sensorservice/SensorRecord.h @@ -25,7 +25,7 @@ class SensorService; class SensorService::SensorRecord { public: - SensorRecord(const sp<const SensorEventConnection>& connection); + explicit SensorRecord(const sp<const SensorEventConnection>& connection); bool addConnection(const sp<const SensorEventConnection>& connection); bool removeConnection(const wp<const SensorEventConnection>& connection); size_t getNumConnections() const { return mConnections.size(); } diff --git a/services/sensorservice/hidl/include/sensorservicehidl/SensorManager.h b/services/sensorservice/hidl/include/sensorservicehidl/SensorManager.h index ddcee288e1..8d7a05b5e2 100644 --- a/services/sensorservice/hidl/include/sensorservicehidl/SensorManager.h +++ b/services/sensorservice/hidl/include/sensorservicehidl/SensorManager.h @@ -43,7 +43,7 @@ using ::android::sp; struct SensorManager final : public ISensorManager { - SensorManager(JavaVM* vm); + explicit SensorManager(JavaVM* vm); ~SensorManager(); // Methods from ::android::frameworks::sensorservice::V1_0::ISensorManager follow. diff --git a/services/sensorservice/mat.h b/services/sensorservice/mat.h index 495c14e67e..934ae58ade 100644 --- a/services/sensorservice/mat.h +++ b/services/sensorservice/mat.h @@ -139,13 +139,13 @@ public: mat() { } mat(const mat& rhs) : base(rhs) { } - mat(const base& rhs) : base(rhs) { } // NOLINT(implicit) + mat(const base& rhs) : base(rhs) { } // NOLINT(google-explicit-constructor) // ----------------------------------------------------------------------- // conversion constructors // sets the diagonal to the value, off-diagonal to zero - mat(pTYPE rhs) { // NOLINT(implicit) + mat(pTYPE rhs) { // NOLINT(google-explicit-constructor) helpers::doAssign(*this, rhs); } diff --git a/services/sensorservice/vec.h b/services/sensorservice/vec.h index 9e5d2809c3..c195434966 100644 --- a/services/sensorservice/vec.h +++ b/services/sensorservice/vec.h @@ -322,12 +322,12 @@ public: vec() { } vec(const vec& rhs) : base(rhs) { } - vec(const base& rhs) : base(rhs) { } // NOLINT(implicit) + vec(const base& rhs) : base(rhs) { } // NOLINT(google-explicit-constructor) // ----------------------------------------------------------------------- // conversion constructors - vec(pTYPE rhs) { // NOLINT(implicit) + vec(pTYPE rhs) { // NOLINT(google-explicit-constructor) for (size_t i=0 ; i<SIZE ; i++) base::operator[](i) = rhs; } |