summaryrefslogtreecommitdiff
path: root/vulkan/libvulkan/api.cpp
diff options
context:
space:
mode:
author Ytai Ben-Tsvi <ytai@google.com> 2019-09-05 15:14:30 -0700
committer Ytai Ben-Tsvi <ytai@google.com> 2019-09-16 12:18:38 -0700
commitacb7299dfc8e9270923141183bbde04b135e8492 (patch)
treeef4070691d5fa690273d22d61ab41e81183fd0c4 /vulkan/libvulkan/api.cpp
parent56de7c0e47d3097720b67c5e3a3addcb78569ac1 (diff)
Improve visibility of IMemory security risks
This change renames the IMemory raw pointer accessors to unsecure*() to make it apparent to coders and code reviewers that the returned buffer may potentially be shared with untrusted processes, who may, after the fact, attempt to read and/or modify the contents. This may lead to hard to find security bugs and hopefully the rename makes it harder to forget. The change also attempts to fix all the callsites to make everything build correctly, but in the processes, wherever the callsite code was not obviously secure, I added a TODO requesting the owners to either document why it's secure or to change the code. Apologies in advance to the owners if there are some false positives here - I don't have enough context to reason about all the different callsites. Test: Completely syntactic change. Made sure code still builds. Change-Id: If8474d0c6a2f0a23cb0514eac1a86c71e334fcc9
Diffstat (limited to 'vulkan/libvulkan/api.cpp')
0 files changed, 0 insertions, 0 deletions