summaryrefslogtreecommitdiff
path: root/services/surfaceflinger/MessageQueue.cpp
diff options
context:
space:
mode:
author Shuo Gao <shuo.gao@intel.com> 2013-10-17 11:36:11 +0800
committer Jian Luo <jian.luo@intel.com> 2013-10-22 22:36:46 -0700
commit0a885309aa7be823b4ad1852d0a08f84c301578c (patch)
tree9654bd521c2713f0642b0ef7cc3b900fa0979539 /services/surfaceflinger/MessageQueue.cpp
parentd9be16f920f7c2581fda3ca495c1e6fc88857a6c (diff)
fix corruption in Vector<> when malloc falied
1. When alloc or realloc failed in the function SharedBuffer::editResize, it would return a NULL pointer, then mStorage would update to be 1 by SharedBuffer::data() if no pointer check here, which is an obviously wrong address, and would cause corruption when used it e.g. in capacity(). So add the pointer check here for the return value of SharedBuffer::editResize, if it's NULL do not use it to update mStorage, to avoid the value of mStorage polluted. 2. when alloc or realloc falied in _grow & _shrink function, mStorage keep the original value, so mCount should not be updated here. Otherwise, mStorage might be 0 but mCount>0, so a corruption would happend when it try to delete items from the Vector since mCount>0. Change-Id: I7c3814e843c459834ca5eed392e8d63d1cb7d2d8 Signed-off-by: Shuo Gao <shuo.gao@intel.com> Signed-off-by: Jian Luo <jian.luo@intel.com> Signed-off-by: Bruce Beare <bruce.j.beare@intel.com> Signed-off-by: Jack Ren <jack.ren@intel.com> Author-tracking-BZ: 139626
Diffstat (limited to 'services/surfaceflinger/MessageQueue.cpp')
0 files changed, 0 insertions, 0 deletions