diff options
| author | 2023-05-05 15:02:20 -0700 | |
|---|---|---|
| committer | 2023-06-10 00:20:43 +0000 | |
| commit | 580fb3af1743d2a6e12bd8c3f933641644e5eb4a (patch) | |
| tree | 9f499dea1f01de680ba87e732c0cb44094e116df /services/inputflinger/InputManager.cpp | |
| parent | e632c7cbd2ee0483b48bd4924aff2ff1375a7b10 (diff) | |
Prevent targeted injection into non-owned windows
Before this CL, it was possible to send ACTION_OUTSIDE events to
non-owned windows even during targeted injection.
However:
1) It's not clear why we actually need this behaviour, and it requires
extra work to support this
2) The block of code that we used to "support" this didn't actually do
anything.
3) During targeted injection, you should only be allowed to affect owned
windows. If you want to affect the entire system, you:
a) Should use global rather than targeted injection
b) Must be very careful to clean up any remaining state that you
cause
In this CL, we remove the block of code that did nothing, and also add
an explicit target pass to remove any non-owned windows.
This should allow further future refactors.
Bug: 211379801
Fixes: 281091008
Test: m inputflinger_tests && $ANDROID_HOST_OUT/nativetest64/inputflinger_tests/inputflinger_tests
Change-Id: Ib065d39ab162188bf2f6e73601e2bb7e2c5d0409
Diffstat (limited to 'services/inputflinger/InputManager.cpp')
0 files changed, 0 insertions, 0 deletions