summaryrefslogtreecommitdiff
path: root/libs/ui/FramebufferNativeWindow.cpp
diff options
context:
space:
mode:
author bdeng3X <bingx.deng@intel.com> 2014-03-20 09:15:34 +0800
committer Guobin Zhang <guobin.zhang@intel.com> 2014-03-27 09:09:19 +0800
commitc2633ce19bdbca4cbf8d6a225ede68a0afd693b9 (patch)
tree086c187dbfa47f5789d5d3a09d39e6bd6157b2af /libs/ui/FramebufferNativeWindow.cpp
parentb1a8c016371282a3cd3b113e6b2c0310372babf2 (diff)
GraphicProducerWrapper may return false transact status
GraphicProducerWrapper(GPW) changed how the methods of BpGraphicBufferProducer(BpGBP) are executed. First, "fake" BpGBP is created. Its remote is GPW. The GPW has wrapped the real BpGBP. All the method calls to the fake BpGPB will be intercepted by the GPW inside it when the methods run into remote()->transact(). Then the GPW will invoke the transact() of the real BpGBP. And Everything runs well except that the GPW forgets to store the transact status and always return NO_ERROR to the fake BpGBP. It would be disastrous if the binder call of the IGBP failed and the out parameter "reply" of transact() was in unkown state. E.g. the queueBuffer() in the fake BpGBP will try to operate on the "reply". This will crash the SurfaceFlinger. Change-Id: I01b31f64e1fc92804da3f16c1fb1420dcfb3b855 Signed-off-by: bdeng3X <bingx.deng@intel.com> Signed-off-by: Guobin Zhang <guobin.zhang@intel.com>
Diffstat (limited to 'libs/ui/FramebufferNativeWindow.cpp')
0 files changed, 0 insertions, 0 deletions