summaryrefslogtreecommitdiff
path: root/libs/renderengine/RenderEngine.cpp
diff options
context:
space:
mode:
author Ana Krulec <akrulec@google.com> 2020-06-01 14:07:57 -0700
committer Ana Krulec <akrulec@google.com> 2020-06-01 14:56:49 -0700
commitd0156d931db2810ee76524916dd2c7ae16932b13 (patch)
tree1e33013804f67fb05a1af6068ec9b06b2ee692f5 /libs/renderengine/RenderEngine.cpp
parentd84efff48de3877e0524700926b5d7c4f4ece97f (diff)
Copy arguments into RenderEngineThreaded
RenderEngineThreaded currently crashes when trying to create framebuffer in function: createFramebufferImageIfNeeded. Looks like passing the copy of arguments fixes the problem. Bug: 157932582 Test: Print mFramebufferImageCacheSize, when threaded is off: 2 Test: Print mFramebufferImageCacheSize, when threaded is on: 2 Test: Open Chrome to trigger RE composition. Test: Pull down status bar to trigger RE composition. Change-Id: I3b21e0d159d63ea4454e46d10ffe698c4c1c3c4e
Diffstat (limited to 'libs/renderengine/RenderEngine.cpp')
-rw-r--r--libs/renderengine/RenderEngine.cpp5
1 files changed, 2 insertions, 3 deletions
diff --git a/libs/renderengine/RenderEngine.cpp b/libs/renderengine/RenderEngine.cpp
index 596f15cff2..c3fbb60af2 100644
--- a/libs/renderengine/RenderEngine.cpp
+++ b/libs/renderengine/RenderEngine.cpp
@@ -41,9 +41,8 @@ std::unique_ptr<RenderEngine> RenderEngine::create(const RenderEngineCreationArg
switch (renderEngineType) {
case RenderEngineType::THREADED:
ALOGD("Threaded RenderEngine with GLES Backend");
- return renderengine::threaded::RenderEngineThreaded::create([&args]() {
- return android::renderengine::gl::GLESRenderEngine::create(args);
- });
+ return renderengine::threaded::RenderEngineThreaded::create(
+ [args]() { return android::renderengine::gl::GLESRenderEngine::create(args); });
case RenderEngineType::GLES:
default:
ALOGD("RenderEngine with GLES Backend");