summaryrefslogtreecommitdiff
path: root/libs/renderengine/RenderEngine.cpp
diff options
context:
space:
mode:
author Ian Elliott <ianelliott@google.com> 2023-01-04 08:31:37 -0700
committer Ian Elliott <ianelliott@google.com> 2023-01-18 01:18:37 +0000
commitbe70507beea2aeb22fbc35a3dffaf0cd45039303 (patch)
tree2b0bf36f42f6d5e4e7999f9438ceff261bd39496 /libs/renderengine/RenderEngine.cpp
parent6b65c0c7abd78b10583a27b80734fb672dea66aa (diff)
Remove RE_SKIAVK ifdefs (always Compile SkiaVkRenderEngine)
This reverts 2 previous commits: - "Allow SkiaVkRenderEngine to not be compiled" (commit 646ebf21377ff28f9604846351a1230f9cd5c1a9) - "Compile SkiaVkRenderEngine so that it can be enabled" ( commit 32f9e69927c2efefe6f7a138bfd291f130ccc486) that allowed SkiaVkRenderEngine to be conditionally compiled and then set the define so that it would always be compiled. We have decided for now to have both SkiaGL and SkiaVk in RenderEngine, and so removing the ifdef's makes the code simpler. Note: the total increase in pinned memory that was observed in testing was between 360-362 KB (see b/263443538) Test: `git revert` and visual inspection with gitk Bug: 236390072 Change-Id: Ia49a2971c544db1d6b9a8996220e2b3e2d0ab437
Diffstat (limited to 'libs/renderengine/RenderEngine.cpp')
-rw-r--r--libs/renderengine/RenderEngine.cpp8
1 files changed, 0 insertions, 8 deletions
diff --git a/libs/renderengine/RenderEngine.cpp b/libs/renderengine/RenderEngine.cpp
index 341c011dc9..d08c2213ad 100644
--- a/libs/renderengine/RenderEngine.cpp
+++ b/libs/renderengine/RenderEngine.cpp
@@ -39,12 +39,8 @@ std::unique_ptr<RenderEngine> RenderEngine::create(const RenderEngineCreationArg
ALOGD("RenderEngine with SkiaGL Backend");
return renderengine::skia::SkiaGLRenderEngine::create(args);
case RenderEngineType::SKIA_VK:
-#ifdef RE_SKIAVK
ALOGD("RenderEngine with SkiaVK Backend");
return renderengine::skia::SkiaVkRenderEngine::create(args);
-#else
- LOG_ALWAYS_FATAL("Requested VK backend, but RE_SKIAVK is not defined!");
-#endif
case RenderEngineType::SKIA_GL_THREADED: {
ALOGD("Threaded RenderEngine with SkiaGL Backend");
return renderengine::threaded::RenderEngineThreaded::create(
@@ -54,16 +50,12 @@ std::unique_ptr<RenderEngine> RenderEngine::create(const RenderEngineCreationArg
args.renderEngineType);
}
case RenderEngineType::SKIA_VK_THREADED:
-#ifdef RE_SKIAVK
ALOGD("Threaded RenderEngine with SkiaVK Backend");
return renderengine::threaded::RenderEngineThreaded::create(
[args]() {
return android::renderengine::skia::SkiaVkRenderEngine::create(args);
},
args.renderEngineType);
-#else
- LOG_ALWAYS_FATAL("Requested VK backend, but RE_SKIAVK is not defined!");
-#endif
case RenderEngineType::GLES:
default:
ALOGD("RenderEngine with GLES Backend");