summaryrefslogtreecommitdiff
path: root/libs/input/InputApplication.cpp
diff options
context:
space:
mode:
author Arthur Hung <arthurhung@google.com> 2019-03-20 16:52:24 +0800
committer Arthur Hung <arthurhung@google.com> 2019-03-22 18:14:29 +0800
commit7a0c39a5b46bbb8f2e7b869c642078e892d4804c (patch)
tree0dbccb8e489d3977be760d85e206b86baac08047 /libs/input/InputApplication.cpp
parentebb52c5ac8b95637f5048b993aad88253cd85205 (diff)
Make InputApplicationInfo as a part of InputApplicationHandle (1/2)
InputWindowHandle::updateInfo would also call InputApplicationHandle::updateInfo that may access the null pointer if the focus application changed in same time. - To replace allocated mInfo in updateInfo(), make it as an object   member variable of InputApplicationHandle. Bug: 128930899 Test: atest inputflinger_tests Change-Id: Id19d2d8cd1be181ea994d0efa7afbb2567c4d734
Diffstat (limited to 'libs/input/InputApplication.cpp')
-rw-r--r--libs/input/InputApplication.cpp11
1 files changed, 1 insertions, 10 deletions
diff --git a/libs/input/InputApplication.cpp b/libs/input/InputApplication.cpp
index 7936f50d54..1d9f8a7091 100644
--- a/libs/input/InputApplication.cpp
+++ b/libs/input/InputApplication.cpp
@@ -24,19 +24,10 @@ namespace android {
// --- InputApplicationHandle ---
-InputApplicationHandle::InputApplicationHandle() :
- mInfo(nullptr) {
+InputApplicationHandle::InputApplicationHandle() {
}
InputApplicationHandle::~InputApplicationHandle() {
- delete mInfo;
-}
-
-void InputApplicationHandle::releaseInfo() {
- if (mInfo) {
- delete mInfo;
- mInfo = nullptr;
- }
}
InputApplicationInfo InputApplicationInfo::read(const Parcel& from) {