summaryrefslogtreecommitdiff
path: root/libs/gui/LayerState.cpp
diff options
context:
space:
mode:
author Rob Carr <racarr@google.com> 2020-03-06 14:46:07 -0800
committer Rob Carr <racarr@google.com> 2020-03-09 11:47:58 -0700
commita79435bd6f7de397ac7f65f68c8db0f7173eabe5 (patch)
treee8101c24f3821ab1be33d3b935152f8b6baac873 /libs/gui/LayerState.cpp
parent34560b6d0950b54497d70a319d5496ccc0ffec10 (diff)
SurfaceFlinger: Avoid destroying Layer on Binder thread
BufferQueueLayer::onFrameAvailable passes 'this' as an sp<Layer> to SurfaceInterceptor. This constructs a temporary sp<Layer>. We are on a binder thread and not holding any locks, so at this point the main thread could drop it's last references. Then when we destroy our temporary sp<Layer> it is the last reference and we end up invoking ~Layer from the Binder thread, an invalid operation which in this case leads to dead-lock (as we attempt to reacquire the already acquired BufferQueue mutex from the BufferQueueLayer d'tor) Bug: 149473038 Test: Existing tests pass Change-Id: I77a20bedf2db3b974ac03d804f70993514478fb2
Diffstat (limited to 'libs/gui/LayerState.cpp')
0 files changed, 0 insertions, 0 deletions