diff options
| author | 2019-01-15 18:19:36 -0800 | |
|---|---|---|
| committer | 2019-01-15 18:24:23 -0800 | |
| commit | 9a83965a6def131fdae7712e3ec517fc6f6a1da5 (patch) | |
| tree | b01af94e80f37227e6d2ed0bd00849290e555a3b /libs/gui/LayerDebugInfo.cpp | |
| parent | 4ffbaac8e82d4e27c10486d235c2fce100546a57 (diff) | |
NFC: Switch ATRACE_BUFFER_INDEX to be a more friendly macro statement.
In the process of upgrading to clang r349610, a new diagnostic,
-Wextra-semi-stmt, enabled by -Weverything catches redundant semicolons
in code. ATRACE_BUFFER_INDEX is a macro statement (currently using an if
with a code block that ends in a '}'). Since most callers are treating
this as a pseudo-function call, they terminate the macro with a
semicolon. This triggers the diagnostic, as we now have "if (...) { ...
};", where the semicolon is unnecessary.
To remedy these kinds of situations, it is better to construct macro
statements that require a semicolon to terminate them. This patch uses a
do/while wrapped around the existing statement, which is a pretty common
pattern for macro statements.
Bug: http://b/122481018
Test: m checkbuild
Change-Id: Ib1271e8634b0a6bd05b27d78ae17f63feb0e5f65
Diffstat (limited to 'libs/gui/LayerDebugInfo.cpp')
0 files changed, 0 insertions, 0 deletions