diff options
| author | 2016-11-08 15:35:02 -0800 | |
|---|---|---|
| committer | 2016-11-09 17:25:44 +0000 | |
| commit | d073eb7a3f28fd74bfa24c8b7599465cb7de5436 (patch) | |
| tree | 313ea3bcbab084f3a60fd1690b552f49c0629624 /libs/gui/BufferQueueProducer.cpp | |
| parent | 2c39ea10255c4cddf3e97fd00c2aa1548bc54c4f (diff) | |
Fix SF security vulnerability: 32706020
Because of lack of mutex lock when get mConsumerName, if one thread
getConsumerName, another thread setConsumerName frequently, an UAF will
be triggered.
Change-Id: Id1bbf0d15de6d16def2f54ecade385058cda3b65
Test: Marling with poc provided in bug report.
Bug: 32706020
Diffstat (limited to 'libs/gui/BufferQueueProducer.cpp')
| -rw-r--r-- | libs/gui/BufferQueueProducer.cpp | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/libs/gui/BufferQueueProducer.cpp b/libs/gui/BufferQueueProducer.cpp index 87e5b4d279..c6851c872d 100644 --- a/libs/gui/BufferQueueProducer.cpp +++ b/libs/gui/BufferQueueProducer.cpp @@ -1091,6 +1091,7 @@ status_t BufferQueueProducer::setGenerationNumber(uint32_t generationNumber) { String8 BufferQueueProducer::getConsumerName() const { ATRACE_CALL(); + Mutex::Autolock lock(mCore->mMutex); BQ_LOGV("getConsumerName: %s", mConsumerName.string()); return mConsumerName; } |