diff options
author | 2021-12-11 10:16:59 +0900 | |
---|---|---|
committer | 2021-12-11 11:40:55 +0900 | |
commit | 889451ed46c40eb11ac5942197c551bee2bf3ef9 (patch) | |
tree | 749c4cf5932eb60dcd58eef2ae57d3786e0e12fa /libs/binder/RpcState.cpp | |
parent | 305af2eb093c09b4bc8efd7f24ab47f66be199ab (diff) |
libbinder_ndk: do not rely on copyability of parcelables
AParcel_readNullableParcelable accidentally relies on T's copyability
(introduced by 3b31ccac97b070fd9e20a9d1860382af5a15fd10.)
This prevents non-copyable parcelables from being used in a nullable
arrays. For example, ScopedFileDescriptor.
The following example should be valid.
parcelable Foo {
parcelable Bar { ParcelFileDescriptor pfd; }
@nullable Bar[] bars;
}
This fixes it by using std::optional<T>::emplace().
Bug: 203483658
Test: m; build NDK with the example above.
Change-Id: If95b28869feca2114922c117b7eb618af434a535
Diffstat (limited to 'libs/binder/RpcState.cpp')
0 files changed, 0 insertions, 0 deletions