summaryrefslogtreecommitdiff
path: root/libs/binder/RpcState.cpp
diff options
context:
space:
mode:
author Shubang Lu <shubang@google.com> 2021-05-14 23:02:07 +0000
committer Shubang Lu <shubang@google.com> 2021-05-14 23:02:07 +0000
commit15e2835588ce3a8e318c01230bda2c113a16f761 (patch)
tree018527b00e6312efad649ec16cd2948b8619124b /libs/binder/RpcState.cpp
parenteb258ff0ce3fde7db201c0c9063a057c9d5e06ae (diff)
Revert "libbinder: binder RPC - using getCalling* aborts"
Revert submission 1707789 Reason for revert: potential cause of b/188228705 Reverted Changes: Id8fc889f4:libbinder: binder RPC - using getCalling* aborts I2145ad0e7:libbinder: introduce guards for getCalling* Change-Id: I4cba7ab9a2a525c6f8158e32c8411ce081e0a8a2
Diffstat (limited to 'libs/binder/RpcState.cpp')
-rw-r--r--libs/binder/RpcState.cpp16
1 files changed, 0 insertions, 16 deletions
diff --git a/libs/binder/RpcState.cpp b/libs/binder/RpcState.cpp
index e5a6026f3b..2ba9fa2bd5 100644
--- a/libs/binder/RpcState.cpp
+++ b/libs/binder/RpcState.cpp
@@ -18,9 +18,7 @@
#include "RpcState.h"
-#include <android-base/scopeguard.h>
#include <binder/BpBinder.h>
-#include <binder/IPCThreadState.h>
#include <binder/RpcServer.h>
#include "Debug.h"
@@ -30,8 +28,6 @@
namespace android {
-using base::ScopeGuard;
-
RpcState::RpcState() {}
RpcState::~RpcState() {}
@@ -474,18 +470,6 @@ status_t RpcState::getAndExecuteCommand(const base::unique_fd& fd, const sp<RpcS
status_t RpcState::processServerCommand(const base::unique_fd& fd, const sp<RpcSession>& session,
const RpcWireHeader& command) {
- IPCThreadState* kernelBinderState = IPCThreadState::selfOrNull();
- IPCThreadState::SpGuard spGuard{"processing binder RPC command"};
- IPCThreadState::SpGuard* origGuard;
- if (kernelBinderState != nullptr) {
- origGuard = kernelBinderState->pushGetCallingSpGuard(&spGuard);
- }
- ScopeGuard guardUnguard = [&]() {
- if (kernelBinderState != nullptr) {
- kernelBinderState->restoreGetCallingSpGuard(origGuard);
- }
- };
-
switch (command.command) {
case RPC_COMMAND_TRANSACT:
return processTransact(fd, session, command);