diff options
author | 2021-10-01 03:19:35 +0000 | |
---|---|---|
committer | 2021-10-01 03:19:35 +0000 | |
commit | 0204dcc52e85012435271c2bcad001b83761f25f (patch) | |
tree | f7f3581754c6340d919b0a436461d284d9c3809e /libs/binder/RpcState.cpp | |
parent | 33891720aaa7e97c7ec50d31ebb69cea2eb28565 (diff) | |
parent | 6709cf43d19717f76b2cfbfad7dd2a64df357c08 (diff) |
Merge "libbinder: RPC simplify flush commands"
Diffstat (limited to 'libs/binder/RpcState.cpp')
-rw-r--r-- | libs/binder/RpcState.cpp | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/libs/binder/RpcState.cpp b/libs/binder/RpcState.cpp index b5c6cb091c..ef62f20d9a 100644 --- a/libs/binder/RpcState.cpp +++ b/libs/binder/RpcState.cpp @@ -885,12 +885,6 @@ processTransactInternalTailCall: } } - // Binder refs are flushed for oneway calls only after all calls which are - // built up are executed. Otherwise, they fill up the binder buffer. - if (addr != 0 && replyStatus == OK && !oneway) { - replyStatus = flushExcessBinderRefs(session, addr, target); - } - if (oneway) { if (replyStatus != OK) { ALOGW("Oneway call failed with error: %d", replyStatus); @@ -950,6 +944,12 @@ processTransactInternalTailCall: return OK; } + // Binder refs are flushed for oneway calls only after all calls which are + // built up are executed. Otherwise, they fill up the binder buffer. + if (addr != 0 && replyStatus == OK) { + replyStatus = flushExcessBinderRefs(session, addr, target); + } + LOG_ALWAYS_FATAL_IF(std::numeric_limits<int32_t>::max() - sizeof(RpcWireHeader) - sizeof(RpcWireReply) < reply.dataSize(), |