summaryrefslogtreecommitdiff
path: root/libs/binder/RpcServer.cpp
diff options
context:
space:
mode:
author Steven Moreland <smoreland@google.com> 2021-05-11 16:51:38 +0000
committer Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> 2021-05-11 16:51:38 +0000
commitf9df1ab9f27d3206361943899a41531d4b5b8b2f (patch)
tree37238286eb20409f9d537aac666025a1b121b75c /libs/binder/RpcServer.cpp
parentfc87fc210a1cc37d77cce8ec8f4284ddb017b0b8 (diff)
parenta416e7b190b0275234221e8074ca30c914ce0533 (diff)
Merge "libbinder: RPC - add DOS TODO" am: a416e7b190
Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/1702013 Change-Id: I80277ca460985002b0edf91a2284d0b31f581206
Diffstat (limited to 'libs/binder/RpcServer.cpp')
-rw-r--r--libs/binder/RpcServer.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/libs/binder/RpcServer.cpp b/libs/binder/RpcServer.cpp
index a6850ff6aa..51c770e85d 100644
--- a/libs/binder/RpcServer.cpp
+++ b/libs/binder/RpcServer.cpp
@@ -134,7 +134,8 @@ void RpcServer::join() {
}
LOG_RPC_DETAIL("accept4 on fd %d yields fd %d", mServer.get(), clientFd.get());
- // TODO(b/183988761): cannot trust this simple ID
+ // TODO(b/183988761): cannot trust this simple ID, should not block this
+ // thread
LOG_ALWAYS_FATAL_IF(!mAgreedExperimental, "no!");
int32_t id;
if (sizeof(id) != read(clientFd.get(), &id, sizeof(id))) {