diff options
| author | 2022-01-05 01:32:58 +0000 | |
|---|---|---|
| committer | 2022-01-05 01:32:58 +0000 | |
| commit | 2c25d94025fde6cf7ad80f7a799c7ff7f81b46b6 (patch) | |
| tree | eacdd4bbef7d0f7df0fdd3dcf2c7df85c2e3c57b /libs/binder/RpcServer.cpp | |
| parent | 2692efa2371af720c7d92fddcdb39e8031eea960 (diff) | |
| parent | e627a40c7e4bed19850ee556cb5c4c7300e5b099 (diff) | |
Merge "binder: Eliminate a data copy in RPC transport operations" am: 7dc506f27f am: 8e5a9c89be am: e627a40c7e
Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/1917958
Change-Id: Idd582e849674945da732d57b004989fade91cddb
Diffstat (limited to 'libs/binder/RpcServer.cpp')
| -rw-r--r-- | libs/binder/RpcServer.cpp | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/libs/binder/RpcServer.cpp b/libs/binder/RpcServer.cpp index 93ed50e986..ace5cd5052 100644 --- a/libs/binder/RpcServer.cpp +++ b/libs/binder/RpcServer.cpp @@ -287,8 +287,8 @@ void RpcServer::establishConnection(sp<RpcServer>&& server, base::unique_fd clie RpcConnectionHeader header; if (status == OK) { - status = client->interruptableReadFully(server->mShutdownTrigger.get(), &header, - sizeof(header), {}); + iovec iov{&header, sizeof(header)}; + status = client->interruptableReadFully(server->mShutdownTrigger.get(), &iov, 1, {}); if (status != OK) { ALOGE("Failed to read ID for client connecting to RPC server: %s", statusToString(status).c_str()); @@ -301,8 +301,9 @@ void RpcServer::establishConnection(sp<RpcServer>&& server, base::unique_fd clie if (header.sessionIdSize > 0) { if (header.sessionIdSize == kSessionIdBytes) { sessionId.resize(header.sessionIdSize); - status = client->interruptableReadFully(server->mShutdownTrigger.get(), - sessionId.data(), sessionId.size(), {}); + iovec iov{sessionId.data(), sessionId.size()}; + status = + client->interruptableReadFully(server->mShutdownTrigger.get(), &iov, 1, {}); if (status != OK) { ALOGE("Failed to read session ID for client connecting to RPC server: %s", statusToString(status).c_str()); @@ -331,8 +332,8 @@ void RpcServer::establishConnection(sp<RpcServer>&& server, base::unique_fd clie .version = protocolVersion, }; - status = client->interruptableWriteFully(server->mShutdownTrigger.get(), &response, - sizeof(response), {}); + iovec iov{&response, sizeof(response)}; + status = client->interruptableWriteFully(server->mShutdownTrigger.get(), &iov, 1, {}); if (status != OK) { ALOGE("Failed to send new session response: %s", statusToString(status).c_str()); // still need to cleanup before we can return |