diff options
author | 2024-07-22 18:38:27 +0000 | |
---|---|---|
committer | 2024-07-24 19:14:40 +0000 | |
commit | 81da2ab941bd929c2891fe710e6ce96ac750578d (patch) | |
tree | 7f1f668e8611ac68f63314ab87107c69f21aa8ea /libs/binder/BackendUnifiedServiceManager.cpp | |
parent | a42f727dbc156bad1982d616b36b4502e6e1d31a (diff) |
Error fix from enabling Clang thread-safety checks.
Parent bug: b/353324127. Enabling `thread-safety-reference-return`
to allow developers to utilize Clang thread safety guardrails
(GUARDED_BY, REQUIRES, EXCLUDES).
Error:
frameworks/native/services/surfaceflinger/Scheduler/RefreshRateSelector.h:307:55:
error: returning variable 'mDisplayModes' by reference requires holding
mutex 'mLock' [-Werror,-Wthread-safety-reference-return]
Fix: return by value, hold mutex from parent, or remove GUARDED_BY
attribute.
This fix removes the GUARDED_BY attribute in order to avoid changing
functionality. If this is not desired, please respond with concerns
or preferred fix.
Change-Id: Ia3444fd193294e1478a9f830651eb8dabf2c73cd
Bug: 354740314
Test: make
Diffstat (limited to 'libs/binder/BackendUnifiedServiceManager.cpp')
0 files changed, 0 insertions, 0 deletions