summaryrefslogtreecommitdiff
path: root/cmds/dumpstate/main.cpp
diff options
context:
space:
mode:
author Nandana Dutt <nandana@google.com> 2019-01-22 12:10:16 +0000
committer Nandana Dutt <nandana@google.com> 2019-01-22 21:03:25 +0000
commit235864b47896d308f56a012b1d509588a5069daf (patch)
tree40796f37cd810135864670741b1ffaabd7b49c97 /cmds/dumpstate/main.cpp
parent9a76d20e4fa6d4a3c29bb1aba662f0d839077782 (diff)
Add a flag that makes dumpstate wait for options
There are 2 ways of running bugreports. Running dumpstate binary directly with command line options (existing flow), or running the binary to start the binder service, which waits for a caller to supply arguments like file descriptors to write output to (new flow to support the bugreport triggering API). Support the second flow with a new commandline flag. Also add a new service that uses the flag, to be used in the API. BUG:111441001 Test: adb shell setprop "ctl.start" "bugreportd" -> starts service & waits. Test: interactive bugreport still works Change-Id: I64cd03d15f45a896692d7462998d4faa6e413ef1
Diffstat (limited to 'cmds/dumpstate/main.cpp')
-rw-r--r--cmds/dumpstate/main.cpp49
1 files changed, 48 insertions, 1 deletions
diff --git a/cmds/dumpstate/main.cpp b/cmds/dumpstate/main.cpp
index 78aad1137b..68d373377c 100644
--- a/cmds/dumpstate/main.cpp
+++ b/cmds/dumpstate/main.cpp
@@ -14,8 +14,55 @@
* limitations under the License.
*/
+#define LOG_TAG "dumpstate"
+
+#include <binder/IPCThreadState.h>
+
+#include "DumpstateInternal.h"
+#include "DumpstateService.h"
#include "dumpstate.h"
+namespace {
+
+// Returns true if we should start the service and wait for a listener
+// to bind with bugreport options.
+bool ShouldStartServiceAndWait(int argc, char* argv[]) {
+ bool do_wait = false;
+ int c;
+ // Keep flags in sync with Dumpstate::DumpOptions::Initialize.
+ while ((c = getopt(argc, argv, "wdho:svqzpPBRSV:")) != -1 && !do_wait) {
+ switch (c) {
+ case 'w':
+ do_wait = true;
+ break;
+ default:
+ // Ignore all other options
+ break;
+ }
+ }
+
+ // Reset next index used by getopt so getopt can be called called again in Dumpstate::Run to
+ // parse bugreport options.
+ optind = 1;
+ return do_wait;
+}
+
+} // namespace
+
int main(int argc, char* argv[]) {
- return run_main(argc, argv);
+ if (ShouldStartServiceAndWait(argc, argv)) {
+ int ret;
+ if ((ret = android::os::DumpstateService::Start()) != android::OK) {
+ MYLOGE("Unable to start 'dumpstate' service: %d", ret);
+ exit(1);
+ }
+ MYLOGI("'dumpstate' service started and will wait for a call to startBugreport()");
+
+ // Waits forever for an incoming connection.
+ // TODO(b/111441001): should this time out?
+ android::IPCThreadState::self()->joinThreadPool();
+ return 0;
+ } else {
+ return run_main(argc, argv);
+ }
}