summaryrefslogtreecommitdiff
path: root/cmds/dumpstate/dumpstate.cpp
diff options
context:
space:
mode:
author Steven Moreland <smoreland@google.com> 2021-07-20 20:45:43 +0000
committer Steven Moreland <smoreland@google.com> 2021-07-21 18:14:12 +0000
commitcbd69fcb6011fc6b0b054727634a9eb460c661ca (patch)
treebf7135f3873c191619709c1e645df34b762b4dc4 /cmds/dumpstate/dumpstate.cpp
parentb08c2cb666abb46551d84ed01341c0d96c245a00 (diff)
dumpsys: dump multiple types of info in one run
I was looking at which processes were using too many threads, since almost all services in dumpsys report 0/16 threads out of use, and this looks like a lot of (potentially wasted threads). However, almost all of these come from system_server, so they are actually shared among all of the services. Though, from the existing output of dumpsys, it was a bit hard to actually understand this without comparing two outputs. This still isn't quite like lshal (which has columns), but at least now I can run `dumpsys --thread --pid` and I can see all the services and see their processes to make this analysis easier. Bug: N/A Test: dumpsys_test Change-Id: I88a6c80f4c9aed82b3f5a050b29c13ba86284562
Diffstat (limited to 'cmds/dumpstate/dumpstate.cpp')
-rw-r--r--cmds/dumpstate/dumpstate.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/cmds/dumpstate/dumpstate.cpp b/cmds/dumpstate/dumpstate.cpp
index 8f466ca57e..1db2867bf2 100644
--- a/cmds/dumpstate/dumpstate.cpp
+++ b/cmds/dumpstate/dumpstate.cpp
@@ -1236,7 +1236,7 @@ static Dumpstate::RunStatus RunDumpsysTextByPriority(const std::string& title, i
std::string path(title);
path.append(" - ").append(String8(service).c_str());
size_t bytes_written = 0;
- status_t status = dumpsys.startDumpThread(Dumpsys::Type::DUMP, service, args);
+ status_t status = dumpsys.startDumpThread(Dumpsys::TYPE_DUMP, service, args);
if (status == OK) {
dumpsys.writeDumpHeader(STDOUT_FILENO, service, priority);
std::chrono::duration<double> elapsed_seconds;
@@ -1315,7 +1315,7 @@ static Dumpstate::RunStatus RunDumpsysProto(const std::string& title, int priori
path.append("_HIGH");
}
path.append(kProtoExt);
- status_t status = dumpsys.startDumpThread(Dumpsys::Type::DUMP, service, args);
+ status_t status = dumpsys.startDumpThread(Dumpsys::TYPE_DUMP, service, args);
if (status == OK) {
status = ds.AddZipEntryFromFd(path, dumpsys.getDumpFd(), service_timeout);
bool dumpTerminated = (status == OK);