diff options
author | 2018-08-07 14:22:37 -0700 | |
---|---|---|
committer | 2018-08-09 15:10:42 -0700 | |
commit | fefcb58f5789f6ac441ae0a342d4d0878236bf94 (patch) | |
tree | 26fc077898389ec48eaf246844f30e235a84a946 | |
parent | 32fd9f9bf710dd157c7a0e2b7951f24176587689 (diff) |
SF: Move relevant scheduler files into one directory.
Scheduler (see go/surface-flinger-scheduler) is going to live in its own
directory. This CL just moves the relevant files into that directory. No
changes to business logic.
Test: all SF tests pass.
Change-Id: Iff0717f9867316b28e68fd8311bd9fdc4e029951
20 files changed, 31 insertions, 43 deletions
diff --git a/services/surfaceflinger/Android.bp b/services/surfaceflinger/Android.bp index 3fa1311ce9..d0aa742fef 100644 --- a/services/surfaceflinger/Android.bp +++ b/services/surfaceflinger/Android.bp @@ -105,11 +105,8 @@ filegroup { "DisplayHardware/HWComposerBufferCache.cpp", "DisplayHardware/PowerAdvisor.cpp", "DisplayHardware/VirtualDisplaySurface.cpp", - "DispSync.cpp", "Effects/Daltonizer.cpp", - "EventControlThread.cpp", "EventLog/EventLog.cpp", - "EventThread.cpp", "FrameTracker.cpp", "GpuService.cpp", "Layer.cpp", @@ -118,7 +115,6 @@ filegroup { "LayerRejecter.cpp", "LayerStats.cpp", "LayerVector.cpp", - "MessageQueue.cpp", "MonitoredProducer.cpp", "RenderArea.cpp", "RenderEngine/Description.cpp", @@ -131,6 +127,10 @@ filegroup { "RenderEngine/RenderEngine.cpp", "RenderEngine/Surface.cpp", "RenderEngine/Texture.cpp", + "Scheduler/DispSync.cpp", + "Scheduler/EventControlThread.cpp", + "Scheduler/EventThread.cpp", + "Scheduler/MessageQueue.cpp", "StartPropertySetThread.cpp", "SurfaceFlinger.cpp", "SurfaceInterceptor.cpp", diff --git a/services/surfaceflinger/BufferLayerConsumer.cpp b/services/surfaceflinger/BufferLayerConsumer.cpp index 8788d47451..9096d4c719 100644 --- a/services/surfaceflinger/BufferLayerConsumer.cpp +++ b/services/surfaceflinger/BufferLayerConsumer.cpp @@ -21,10 +21,10 @@ #include "BufferLayerConsumer.h" -#include "DispSync.h" #include "Layer.h" #include "RenderEngine/Image.h" #include "RenderEngine/RenderEngine.h" +#include "Scheduler/DispSync.h" #include <inttypes.h> diff --git a/services/surfaceflinger/MonitoredProducer.cpp b/services/surfaceflinger/MonitoredProducer.cpp index 389fbd23e3..06e3d9c154 100644 --- a/services/surfaceflinger/MonitoredProducer.cpp +++ b/services/surfaceflinger/MonitoredProducer.cpp @@ -14,10 +14,11 @@ * limitations under the License. */ -#include "MessageQueue.h" #include "MonitoredProducer.h" -#include "SurfaceFlinger.h" #include "Layer.h" +#include "SurfaceFlinger.h" + +#include "Scheduler/MessageQueue.h" namespace android { diff --git a/services/surfaceflinger/DispSync.cpp b/services/surfaceflinger/Scheduler/DispSync.cpp index b789d04ce9..9d9acd3116 100644 --- a/services/surfaceflinger/DispSync.cpp +++ b/services/surfaceflinger/Scheduler/DispSync.cpp @@ -528,8 +528,7 @@ void DispSync::scalePeriod(uint32_t multiplier, uint32_t divisor) { // point "attempting" to set the scale to 1 when it is already // 1. Check that special case so that we don't do a useless // update of the model. - if ((multiplier == 1) && (divisor == 1) && (mPeriod == mPeriodBase)) - return; + if ((multiplier == 1) && (divisor == 1) && (mPeriod == mPeriodBase)) return; mPeriod = mPeriodBase * multiplier / divisor; mThread->updateModel(mPeriod, mPhase, mReferenceTime); diff --git a/services/surfaceflinger/DispSync.h b/services/surfaceflinger/Scheduler/DispSync.h index 183966feba..183966feba 100644 --- a/services/surfaceflinger/DispSync.h +++ b/services/surfaceflinger/Scheduler/DispSync.h diff --git a/services/surfaceflinger/EventControlThread.cpp b/services/surfaceflinger/Scheduler/EventControlThread.cpp index fb6cff5705..fb6cff5705 100644 --- a/services/surfaceflinger/EventControlThread.cpp +++ b/services/surfaceflinger/Scheduler/EventControlThread.cpp diff --git a/services/surfaceflinger/EventControlThread.h b/services/surfaceflinger/Scheduler/EventControlThread.h index cafae53400..cafae53400 100644 --- a/services/surfaceflinger/EventControlThread.h +++ b/services/surfaceflinger/Scheduler/EventControlThread.h diff --git a/services/surfaceflinger/EventThread.cpp b/services/surfaceflinger/Scheduler/EventThread.cpp index 5a8fd25270..b84177c1da 100644 --- a/services/surfaceflinger/EventThread.cpp +++ b/services/surfaceflinger/Scheduler/EventThread.cpp @@ -100,7 +100,8 @@ status_t EventThread::registerDisplayEventConnection( return NO_ERROR; } -void EventThread::removeDisplayEventConnectionLocked(const wp<EventThread::Connection>& connection) { +void EventThread::removeDisplayEventConnectionLocked( + const wp<EventThread::Connection>& connection) { mDisplayEventConnections.remove(connection); } diff --git a/services/surfaceflinger/EventThread.h b/services/surfaceflinger/Scheduler/EventThread.h index a0262b2ad9..a0262b2ad9 100644 --- a/services/surfaceflinger/EventThread.h +++ b/services/surfaceflinger/Scheduler/EventThread.h diff --git a/services/surfaceflinger/MessageQueue.cpp b/services/surfaceflinger/Scheduler/MessageQueue.cpp index 056d381eb9..056d381eb9 100644 --- a/services/surfaceflinger/MessageQueue.cpp +++ b/services/surfaceflinger/Scheduler/MessageQueue.cpp diff --git a/services/surfaceflinger/MessageQueue.h b/services/surfaceflinger/Scheduler/MessageQueue.h index 90d1c72450..90d1c72450 100644 --- a/services/surfaceflinger/MessageQueue.h +++ b/services/surfaceflinger/Scheduler/MessageQueue.h diff --git a/services/surfaceflinger/VSyncModulator.h b/services/surfaceflinger/Scheduler/VSyncModulator.h index e071a599c9..7dfad43f70 100644 --- a/services/surfaceflinger/VSyncModulator.h +++ b/services/surfaceflinger/Scheduler/VSyncModulator.h @@ -29,22 +29,17 @@ namespace android { */ class VSyncModulator { private: - // Number of frames we'll keep the early phase offsets once they are activated. This acts as a // low-pass filter in case the client isn't quick enough in sending new transactions. const int MIN_EARLY_FRAME_COUNT = 2; public: - struct Offsets { nsecs_t sf; nsecs_t app; }; - enum TransactionStart { - EARLY, - NORMAL - }; + enum TransactionStart { EARLY, NORMAL }; // Sets the phase offsets // @@ -63,13 +58,9 @@ public: mOffsets = late; } - Offsets getEarlyOffsets() const { - return mEarlyOffsets; - } + Offsets getEarlyOffsets() const { return mEarlyOffsets; } - Offsets getEarlyGlOffsets() const { - return mEarlyGlOffsets; - } + Offsets getEarlyGlOffsets() const { return mEarlyGlOffsets; } void setEventThreads(EventThread* sfEventThread, EventThread* appEventThread) { mSfEventThread = sfEventThread; @@ -77,7 +68,6 @@ public: } void setTransactionStart(TransactionStart transactionStart) { - if (transactionStart == TransactionStart::EARLY) { mRemainingEarlyFrameCount = MIN_EARLY_FRAME_COUNT; } @@ -112,7 +102,6 @@ public: } private: - void updateOffsets() { const Offsets desired = getOffsets(); const Offsets current = mOffsets; diff --git a/services/surfaceflinger/SurfaceFlinger.cpp b/services/surfaceflinger/SurfaceFlinger.cpp index 8310455ac5..d87df59dfa 100644 --- a/services/surfaceflinger/SurfaceFlinger.cpp +++ b/services/surfaceflinger/SurfaceFlinger.cpp @@ -70,10 +70,7 @@ #include "Colorizer.h" #include "ContainerLayer.h" #include "DdmConnection.h" -#include "DispSync.h" #include "DisplayDevice.h" -#include "EventControlThread.h" -#include "EventThread.h" #include "Layer.h" #include "LayerVector.h" #include "MonitoredProducer.h" @@ -85,10 +82,12 @@ #include "DisplayHardware/FramebufferSurface.h" #include "DisplayHardware/HWComposer.h" #include "DisplayHardware/VirtualDisplaySurface.h" - #include "Effects/Daltonizer.h" - #include "RenderEngine/RenderEngine.h" +#include "Scheduler/DispSync.h" +#include "Scheduler/EventControlThread.h" +#include "Scheduler/EventThread.h" + #include <cutils/compiler.h> #include <android/hardware/configstore/1.0/ISurfaceFlingerConfigs.h> diff --git a/services/surfaceflinger/SurfaceFlinger.h b/services/surfaceflinger/SurfaceFlinger.h index 12f4185e80..5ceea3a0e2 100644 --- a/services/surfaceflinger/SurfaceFlinger.h +++ b/services/surfaceflinger/SurfaceFlinger.h @@ -55,23 +55,22 @@ #include "Barrier.h" #include "DisplayDevice.h" -#include "DispSync.h" -#include "EventThread.h" #include "FrameTracker.h" +#include "LayerBE.h" #include "LayerStats.h" #include "LayerVector.h" -#include "MessageQueue.h" +#include "StartPropertySetThread.h" #include "SurfaceInterceptor.h" #include "SurfaceTracing.h" -#include "StartPropertySetThread.h" -#include "TimeStats/TimeStats.h" -#include "LayerBE.h" -#include "VSyncModulator.h" #include "DisplayHardware/HWC2.h" #include "DisplayHardware/HWComposer.h" - #include "Effects/Daltonizer.h" +#include "Scheduler/DispSync.h" +#include "Scheduler/EventThread.h" +#include "Scheduler/MessageQueue.h" +#include "Scheduler/VSyncModulator.h" +#include "TimeStats/TimeStats.h" #include <map> #include <mutex> diff --git a/services/surfaceflinger/tests/unittests/EventControlThreadTest.cpp b/services/surfaceflinger/tests/unittests/EventControlThreadTest.cpp index b34645463f..9dc4193ecc 100644 --- a/services/surfaceflinger/tests/unittests/EventControlThreadTest.cpp +++ b/services/surfaceflinger/tests/unittests/EventControlThreadTest.cpp @@ -23,7 +23,7 @@ #include <log/log.h> #include "AsyncCallRecorder.h" -#include "EventControlThread.h" +#include "Scheduler/EventControlThread.h" namespace android { namespace { diff --git a/services/surfaceflinger/tests/unittests/EventThreadTest.cpp b/services/surfaceflinger/tests/unittests/EventThreadTest.cpp index 19747bd442..fb3b7a2951 100644 --- a/services/surfaceflinger/tests/unittests/EventThreadTest.cpp +++ b/services/surfaceflinger/tests/unittests/EventThreadTest.cpp @@ -25,7 +25,7 @@ #include <utils/Errors.h> #include "AsyncCallRecorder.h" -#include "EventThread.h" +#include "Scheduler/EventThread.h" using namespace std::chrono_literals; using namespace std::placeholders; diff --git a/services/surfaceflinger/tests/unittests/mock/MockDispSync.h b/services/surfaceflinger/tests/unittests/mock/MockDispSync.h index cd8d943dff..06a6b690c3 100644 --- a/services/surfaceflinger/tests/unittests/mock/MockDispSync.h +++ b/services/surfaceflinger/tests/unittests/mock/MockDispSync.h @@ -19,7 +19,7 @@ #include <gmock/gmock.h> #include <utils/String8.h> -#include "DispSync.h" +#include "Scheduler/DispSync.h" namespace android { namespace mock { diff --git a/services/surfaceflinger/tests/unittests/mock/MockEventControlThread.h b/services/surfaceflinger/tests/unittests/mock/MockEventControlThread.h index 8ac09a962d..6ef352a548 100644 --- a/services/surfaceflinger/tests/unittests/mock/MockEventControlThread.h +++ b/services/surfaceflinger/tests/unittests/mock/MockEventControlThread.h @@ -18,7 +18,7 @@ #include <gmock/gmock.h> -#include "EventControlThread.h" +#include "Scheduler/EventControlThread.h" namespace android { namespace mock { diff --git a/services/surfaceflinger/tests/unittests/mock/MockEventThread.h b/services/surfaceflinger/tests/unittests/mock/MockEventThread.h index df9bfc6d96..ad2463dac2 100644 --- a/services/surfaceflinger/tests/unittests/mock/MockEventThread.h +++ b/services/surfaceflinger/tests/unittests/mock/MockEventThread.h @@ -18,7 +18,7 @@ #include <gmock/gmock.h> -#include "EventThread.h" +#include "Scheduler/EventThread.h" namespace android { namespace mock { diff --git a/services/surfaceflinger/tests/unittests/mock/MockMessageQueue.h b/services/surfaceflinger/tests/unittests/mock/MockMessageQueue.h index cf07cf7ba9..8d503f4070 100644 --- a/services/surfaceflinger/tests/unittests/mock/MockMessageQueue.h +++ b/services/surfaceflinger/tests/unittests/mock/MockMessageQueue.h @@ -18,7 +18,7 @@ #include <gmock/gmock.h> -#include "MessageQueue.h" +#include "Scheduler/MessageQueue.h" namespace android { namespace mock { |