diff options
author | 2021-02-02 23:02:38 +0000 | |
---|---|---|
committer | 2021-02-02 23:25:39 +0000 | |
commit | dbbbc654445405e3d6734c46cc5d46cf1ec8d93b (patch) | |
tree | 54b491ac8076ead99e8c8122e0c2bdc57f3552b3 | |
parent | c282248fd7c6d1e8a4fa2f4a91e52186aee52082 (diff) |
lshal: emphasize HIDL in docs/output
Some IMs floating about this recently. For now, lshal is still HIDL
specific and binder-facing tools work with AIDL HALs.
It remains to be seen if lshal will be re-adapted for AIDL in the
future, or if some of the ideas here will be transfered to dumpsys and
this binary ultimately deprecated.
Bug: N/A
Test: lshal/lshal --help
Change-Id: I39be9533b44c085a0688eb39171a0a40f88067b2
-rw-r--r-- | cmds/lshal/DebugCommand.cpp | 4 | ||||
-rw-r--r-- | cmds/lshal/ListCommand.cpp | 22 | ||||
-rw-r--r-- | cmds/lshal/Lshal.cpp | 3 | ||||
-rw-r--r-- | cmds/lshal/WaitCommand.cpp | 2 |
4 files changed, 16 insertions, 15 deletions
diff --git a/cmds/lshal/DebugCommand.cpp b/cmds/lshal/DebugCommand.cpp index 72958bd2a9..ccf1ab1e8a 100644 --- a/cmds/lshal/DebugCommand.cpp +++ b/cmds/lshal/DebugCommand.cpp @@ -28,7 +28,7 @@ std::string DebugCommand::getName() const { } std::string DebugCommand::getSimpleDescription() const { - return "Debug a specified HAL."; + return "Debug a specified HIDL HAL."; } Status DebugCommand::parseArgs(const Arg &arg) { @@ -78,7 +78,7 @@ void DebugCommand::usage() const { "debug:\n" " lshal debug [-E] <interface> [options [options [...]]] \n" " Print debug information of a specified interface.\n" - " -E: excludes debug output if HAL is actually a subclass.\n" + " -E: excludes debug output if HIDL HAL is actually a subclass.\n" " <interface>: Format is `android.hardware.foo@1.0::IFoo/default`.\n" " If instance name is missing `default` is used.\n" " options: space separated options to IBase::debug.\n"; diff --git a/cmds/lshal/ListCommand.cpp b/cmds/lshal/ListCommand.cpp index 22268aceea..d5110f6203 100644 --- a/cmds/lshal/ListCommand.cpp +++ b/cmds/lshal/ListCommand.cpp @@ -81,7 +81,7 @@ std::string ListCommand::GetName() { return "list"; } std::string ListCommand::getSimpleDescription() const { - return "List HALs."; + return "List HIDL HALs."; } std::string ListCommand::parseCmdline(pid_t pid) const { @@ -295,21 +295,21 @@ void ListCommand::postprocess() { } mServicesTable.setDescription( - "| All binderized services (registered with hwservicemanager)"); + "| All HIDL binderized services (registered with hwservicemanager)"); mPassthroughRefTable.setDescription( - "| All interfaces that getService() has ever returned as a passthrough interface;\n" + "| All HIDL interfaces getService() has ever returned as a passthrough interface;\n" "| PIDs / processes shown below might be inaccurate because the process\n" "| might have relinquished the interface or might have died.\n" "| The Server / Server CMD column can be ignored.\n" "| The Clients / Clients CMD column shows all process that have ever dlopen'ed \n" "| the library and successfully fetched the passthrough implementation."); mImplementationsTable.setDescription( - "| All available passthrough implementations (all -impl.so files).\n" + "| All available HIDL passthrough implementations (all -impl.so files).\n" "| These may return subclasses through their respective HIDL_FETCH_I* functions."); mManifestHalsTable.setDescription( - "| All HALs that are in VINTF manifest."); + "| All HIDL HALs that are in VINTF manifest."); mLazyHalsTable.setDescription( - "| All HALs that are declared in VINTF manifest:\n" + "| All HIDL HALs that are declared in VINTF manifest:\n" "| - as hwbinder HALs but are not registered to hwservicemanager, and\n" "| - as hwbinder/passthrough HALs with no implementation."); } @@ -903,11 +903,11 @@ void ListCommand::registerAllOptions() { thiz->mSelectedColumns.push_back(TableColumnType::VINTF); return OK; }, "print VINTF info. This column contains a comma-separated list of:\n" - " - DM: if the HAL is in the device manifest\n" - " - DC: if the HAL is in the device compatibility matrix\n" - " - FM: if the HAL is in the framework manifest\n" - " - FC: if the HAL is in the framework compatibility matrix\n" - " - X: if the HAL is in none of the above lists"}); + " - DM: if the HIDL HAL is in the device manifest\n" + " - DC: if the HIDL HAL is in the device compatibility matrix\n" + " - FM: if the HIDL HAL is in the framework manifest\n" + " - FC: if the HIDL HAL is in the framework compatibility matrix\n" + " - X: if the HIDL HAL is in none of the above lists"}); mOptions.push_back({'S', "service-status", no_argument, v++, [](ListCommand* thiz, const char*) { thiz->mSelectedColumns.push_back(TableColumnType::SERVICE_STATUS); return OK; diff --git a/cmds/lshal/Lshal.cpp b/cmds/lshal/Lshal.cpp index 99cb93afe2..bc99f4d473 100644 --- a/cmds/lshal/Lshal.cpp +++ b/cmds/lshal/Lshal.cpp @@ -59,7 +59,8 @@ void Lshal::forEachCommand(const std::function<void(const Command* c)>& f) const } void Lshal::usage() { - err() << "lshal: List and debug HALs." << std::endl << std::endl + err() << "lshal: List and debug HIDL HALs." << std::endl + << " (for AIDL HALs, see `dumpsys`)" << std::endl << std::endl << "commands:" << std::endl; size_t nameMaxLength = 0; diff --git a/cmds/lshal/WaitCommand.cpp b/cmds/lshal/WaitCommand.cpp index 65b41b95d2..437a66ae2f 100644 --- a/cmds/lshal/WaitCommand.cpp +++ b/cmds/lshal/WaitCommand.cpp @@ -29,7 +29,7 @@ std::string WaitCommand::getName() const { } std::string WaitCommand::getSimpleDescription() const { - return "Wait for HAL to start if it is not already started."; + return "Wait for HIDL HAL to start if it is not already started."; } Status WaitCommand::parseArgs(const Arg &arg) { |