summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Parth Sane <parthsane@google.com> 2024-09-30 17:47:28 +0000
committer Parth Sane <parthsane@google.com> 2024-09-30 17:50:04 +0000
commitd73a5101d06977cf1466dc0d8d78f951cec7448a (patch)
treebea26aa966001e5a1a53ff09667566278f09a66c
parentb36f04300000053d16b9d9b4b689bb0f351207c1 (diff)
Fix binderCacheUnitTest: Add 50ms wait with retry
The test is flaky and sometimes the cache invalidation doesn't happen fast enough. Bug: 333854840 Test: atest binderCacheUnitTest Change-Id: I38779fa55327fac0123dadb61bed5281931de5ea
-rw-r--r--libs/binder/tests/binderCacheUnitTest.cpp11
1 files changed, 10 insertions, 1 deletions
diff --git a/libs/binder/tests/binderCacheUnitTest.cpp b/libs/binder/tests/binderCacheUnitTest.cpp
index 482d197688..be5d559d8e 100644
--- a/libs/binder/tests/binderCacheUnitTest.cpp
+++ b/libs/binder/tests/binderCacheUnitTest.cpp
@@ -149,7 +149,16 @@ TEST_F(LibbinderCacheTest, RemoveFromCacheOnServerDeath) {
EXPECT_EQ(OK, mServiceManager->addService(kCachedServiceName, binder2));
// Confirm that new service is returned instead of old.
- sp<IBinder> result2 = mServiceManager->checkService(kCachedServiceName);
+ int retry_count = 5;
+ sp<IBinder> result2;
+ do {
+ std::this_thread::sleep_for(std::chrono::milliseconds(50));
+ if (retry_count-- == 0) {
+ break;
+ }
+ result2 = mServiceManager->checkService(kCachedServiceName);
+ } while (result2 != binder2);
+
ASSERT_EQ(binder2, result2);
}