summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Steven Moreland <smoreland@google.com> 2021-04-13 01:01:32 +0000
committer Steven Moreland <smoreland@google.com> 2021-04-19 23:39:58 +0000
commitd40497186cff7cbb891d67ea4bde818e0dde4a4d (patch)
tree0a8c226f3d58fb1211622d7a11167d2eafd41ac8
parente4d7d43dd2a079e6ac89264c417fa58ce6ae8d7b (diff)
libbinder->libpermission: appops
Since libbinder is used in many places, lightening it up (vtables in these classes contribute to private dirty memory). Bug: 183654927 Test: boot Change-Id: I79aa34c023074862c6c568be1f8e3503cd4a24eb
-rw-r--r--libs/binder/Android.bp4
-rw-r--r--libs/permission/Android.bp13
-rw-r--r--libs/permission/AppOpsManager.cpp (renamed from libs/binder/AppOpsManager.cpp)0
-rw-r--r--libs/permission/IAppOpsCallback.cpp (renamed from libs/binder/IAppOpsCallback.cpp)0
-rw-r--r--libs/permission/IAppOpsService.cpp (renamed from libs/binder/IAppOpsService.cpp)0
-rw-r--r--libs/permission/include/binder/AppOpsManager.h (renamed from libs/binder/include/binder/AppOpsManager.h)0
-rw-r--r--libs/permission/include/binder/IAppOpsCallback.h (renamed from libs/binder/include/binder/IAppOpsCallback.h)0
-rw-r--r--libs/permission/include/binder/IAppOpsService.h (renamed from libs/binder/include/binder/IAppOpsService.h)0
-rw-r--r--libs/sensor/Android.bp5
-rw-r--r--services/sensorservice/Android.bp2
10 files changed, 15 insertions, 9 deletions
diff --git a/libs/binder/Android.bp b/libs/binder/Android.bp
index 6da4e9eff9..1800481343 100644
--- a/libs/binder/Android.bp
+++ b/libs/binder/Android.bp
@@ -60,10 +60,6 @@ cc_library_headers {
// Currently, these are only on system android (not vendor, not host)
// TODO(b/183654927) - move these into separate libraries
libbinder_device_interface_sources = [
- "AppOpsManager.cpp",
- "IAppOpsCallback.cpp",
- "IAppOpsService.cpp",
-
"IPermissionController.cpp",
"PermissionCache.cpp",
"PermissionController.cpp",
diff --git a/libs/permission/Android.bp b/libs/permission/Android.bp
index 9492bda8a1..dd38224a60 100644
--- a/libs/permission/Android.bp
+++ b/libs/permission/Android.bp
@@ -1,5 +1,14 @@
-// TODO(b/183654927): empty place holder to start moving permission related things out of libbinder
-// (appops, permission controller, etc..)
cc_library_shared {
name: "libpermission",
+ srcs: [
+ "AppOpsManager.cpp",
+ "IAppOpsCallback.cpp",
+ "IAppOpsService.cpp",
+ ],
+ export_include_dirs: ["include"],
+ shared_libs: [
+ "libbinder",
+ "liblog",
+ "libutils",
+ ],
}
diff --git a/libs/binder/AppOpsManager.cpp b/libs/permission/AppOpsManager.cpp
index baa9d75116..baa9d75116 100644
--- a/libs/binder/AppOpsManager.cpp
+++ b/libs/permission/AppOpsManager.cpp
diff --git a/libs/binder/IAppOpsCallback.cpp b/libs/permission/IAppOpsCallback.cpp
index 2b3f462ab8..2b3f462ab8 100644
--- a/libs/binder/IAppOpsCallback.cpp
+++ b/libs/permission/IAppOpsCallback.cpp
diff --git a/libs/binder/IAppOpsService.cpp b/libs/permission/IAppOpsService.cpp
index d59f44562e..d59f44562e 100644
--- a/libs/binder/IAppOpsService.cpp
+++ b/libs/permission/IAppOpsService.cpp
diff --git a/libs/binder/include/binder/AppOpsManager.h b/libs/permission/include/binder/AppOpsManager.h
index c048cbed37..c048cbed37 100644
--- a/libs/binder/include/binder/AppOpsManager.h
+++ b/libs/permission/include/binder/AppOpsManager.h
diff --git a/libs/binder/include/binder/IAppOpsCallback.h b/libs/permission/include/binder/IAppOpsCallback.h
index eb76f57bf8..eb76f57bf8 100644
--- a/libs/binder/include/binder/IAppOpsCallback.h
+++ b/libs/permission/include/binder/IAppOpsCallback.h
diff --git a/libs/binder/include/binder/IAppOpsService.h b/libs/permission/include/binder/IAppOpsService.h
index 22f056b235..22f056b235 100644
--- a/libs/binder/include/binder/IAppOpsService.h
+++ b/libs/permission/include/binder/IAppOpsService.h
diff --git a/libs/sensor/Android.bp b/libs/sensor/Android.bp
index 497c33c386..edd453a936 100644
--- a/libs/sensor/Android.bp
+++ b/libs/sensor/Android.bp
@@ -48,11 +48,10 @@ cc_library_shared {
"libutils",
"liblog",
"libhardware",
+ "libpermission",
],
export_include_dirs: ["include"],
- export_shared_lib_headers: ["libbinder", "libhardware"],
+ export_shared_lib_headers: ["libbinder", "libpermission", "libhardware"],
}
-
-subdirs = ["tests"]
diff --git a/services/sensorservice/Android.bp b/services/sensorservice/Android.bp
index 9aecaff409..4151b4512f 100644
--- a/services/sensorservice/Android.bp
+++ b/services/sensorservice/Android.bp
@@ -54,6 +54,7 @@ cc_library_shared {
"libbinder",
"libsensor",
"libsensorprivacy",
+ "libpermission",
"libprotoutil",
"libcrypto",
"libbase",
@@ -74,6 +75,7 @@ cc_library_shared {
"libactivitymanager_aidl",
"libsensor",
"libsensorprivacy",
+ "libpermission",
],
}