diff options
author | 2024-08-19 18:58:49 +0000 | |
---|---|---|
committer | 2024-08-19 23:50:14 +0000 | |
commit | bee6be16111f8437bcebe9348b4e502eef9f4343 (patch) | |
tree | 840b06ecf838cf2f8fd301679d53b1baa8a5f838 | |
parent | 382fc4d2e8a4cd4f0f6976b11f3847fd803856c6 (diff) |
Remove onAsBinder() override for BackendUnifiedServiceManager
The implementation of onAsBinder was bypassing the
BackendUnifiedServiceManager when called in Java.
Test: N/A
Bug: 333854840
Flag: exempt. Bugfix
Change-Id: I0c364c3cb3c7ccbd59a3da041ec801357433479e
-rw-r--r-- | libs/binder/BackendUnifiedServiceManager.h | 2 | ||||
-rw-r--r-- | libs/binder/tests/binderRpcUniversalTests.cpp | 3 |
2 files changed, 2 insertions, 3 deletions
diff --git a/libs/binder/BackendUnifiedServiceManager.h b/libs/binder/BackendUnifiedServiceManager.h index f5d7e66568..8f3839fcb2 100644 --- a/libs/binder/BackendUnifiedServiceManager.h +++ b/libs/binder/BackendUnifiedServiceManager.h @@ -57,8 +57,6 @@ public: return mTheRealServiceManager->getInterfaceDescriptor(); } - IBinder* onAsBinder() override { return IInterface::asBinder(mTheRealServiceManager).get(); } - private: sp<os::IServiceManager> mTheRealServiceManager; void toBinderService(const os::Service& in, os::Service* _out); diff --git a/libs/binder/tests/binderRpcUniversalTests.cpp b/libs/binder/tests/binderRpcUniversalTests.cpp index 2cec243c38..c6fd4870a0 100644 --- a/libs/binder/tests/binderRpcUniversalTests.cpp +++ b/libs/binder/tests/binderRpcUniversalTests.cpp @@ -301,7 +301,8 @@ TEST_P(BinderRpc, CannotSendRegularBinderOverSocketBinder) { auto proc = createRpcTestSocketServerProcess({}); - sp<IBinder> someRealBinder = IInterface::asBinder(defaultServiceManager()); + sp<IBinder> someRealBinder = defaultServiceManager()->getService(String16("activity")); + ASSERT_NE(someRealBinder, nullptr); sp<IBinder> outBinder; EXPECT_EQ(INVALID_OPERATION, proc.rootIface->repeatBinder(someRealBinder, &outBinder).transactionError()); |